From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 02 08:10:07 2020 Received: (at submit) by debbugs.gnu.org; 2 Apr 2020 12:10:07 +0000 Received: from localhost ([127.0.0.1]:39334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJyfY-0006Fy-Fl for submit@debbugs.gnu.org; Thu, 02 Apr 2020 08:10:06 -0400 Received: from lists.gnu.org ([209.51.188.17]:36989) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJyfX-0006Fm-4M for submit@debbugs.gnu.org; Thu, 02 Apr 2020 08:09:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56315) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJyfV-0000EI-Ji for bug-guix@gnu.org; Thu, 02 Apr 2020 08:09:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_40,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJyfU-0004r4-D4 for bug-guix@gnu.org; Thu, 02 Apr 2020 08:09:57 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:47353) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jJyfT-0004p1-Sz for bug-guix@gnu.org; Thu, 02 Apr 2020 08:09:56 -0400 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 2A2116B5 for ; Thu, 2 Apr 2020 08:09:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 02 Apr 2020 08:09:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inv.alid.pw; h= from:to:subject:date:message-id:mime-version:content-type; s= fm3; bh=6Js7BGbN16fvgV42hQRUgU/ug8Ptb5tBmmnxl0Nx7HA=; b=fvwjsmKk sAEY5Uf/aQGmxoUgmpLDAiItAd6tHQtJxoSZn9i+okU/c5eKZH2yJN1pT+tkMVNB by/M6iqIryxHWoUmMe8WkAznNquAImY+dIc0JTi+pS/8xu51h3tc6prN5r06NN3+ ADUcpIwKpxncasJTWstl9myN5k75fFSBF+HeYws1ht+0tMNGxChpG7HMyR6vQ289 pfWFdBWSz9GkkKVFDbVcE3O6uwSEV4JtyqXzzBzHCi3XmPEbf7M+yqLABVeVPE9z RfN4TLe5nh/v4nxpb8lweirW1bNIaQlIjER0Lpt7e6D2vw8O4Q8fPCHpi+50KL6o Y6tlz0i9x0DIXw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=6Js7BGbN16fvgV42hQRUgU/ug8Ptb 5tBmmnxl0Nx7HA=; b=Zrc/Z3DYOQSqj5rGg4/tSn+1v7xXYeYM0uxt5gijdRMXL gJDS5Te9U761rsYPk8UXSvYUIU5OZ6UARq/PP8WlwMVTJVD0FMuBanOKUT7NzUwc 4MPgp9dCVafs71xvjwutT4gZlRlGteUgunCe6kTWa8URX/PQXiNVZrJ6L2NqnxW7 W3jm8B8Uk37AuWShh4PLQ2sBqjjx3OzrWPoPmX7GURQAWKY4XAZkkA9d3CSd2Icn nsRk44WC26MdnH3ioTKmZ+USyPF4/PbO6kP/X/BO1XTmnVNoQmUttCZnIOafn0iv 5c7DQwoA1bHzMR9Hibtxsi7JXmi33U1v2Risysv/A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrtdeggdegfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdduhedmnecujfgurhepfgfhvffufffkgggtsehttdertddtredtnecu hfhrohhmpeflohhshhcujfholhhlrghnugcuoehjohhshhesihhnvhdrrghlihgurdhpfi eqnecuffhomhgrihhnpehgnhhurdhorhhgnecukfhppeekhedrudduledrkeefrddvieen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjohhshh esihhnvhdrrghlihgurdhpfi X-ME-Proxy: Received: from spica (procyon.chrys.alid.pw [85.119.83.26]) by mail.messagingengine.com (Postfix) with ESMTPA id 3FD243280067 for ; Thu, 2 Apr 2020 08:09:52 -0400 (EDT) User-agent: mu4e 1.2.0; emacs 26.3 From: Josh Holland To: "bug-guix\\\@gnu.org" Subject: Calibre test suite fails Date: Thu, 02 Apr 2020 13:09:50 +0100 Message-ID: <87wo6yf5rl.fsf@inv.alid.pw> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 64.147.123.25 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Both on my local machine and on the CI[0], the Calibre test suite has been failing with the following error: ====================================================================== ERROR: test_msgpack (calibre.test_build.BuildTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/tmp/guix-build-calibre-3.42.0.drv-0/calibre-3.42.0/src/calibre/test_build.py", line 124, in test_msgpack self.assertEqual(obj, msgpack_loads(s)) File "/tmp/guix-build-calibre-3.42.0.drv-0/calibre-3.42.0/src/calibre/utils/serialize.py", line 113, in msgpack_loads return msgpack.unpackb(dump, ext_hook=msgpack_decoder, raw=False, use_list=use_list) File "/gnu/store/z7dz4iiaivmadhk0x50qs5zv3rwykrmd-python2-msgpack-1.0.0/lib/python2.7/site-packages/msgpack/fallback.py", line 129, in unpackb ret = unpacker._unpack() File "/gnu/store/z7dz4iiaivmadhk0x50qs5zv3rwykrmd-python2-msgpack-1.0.0/lib/python2.7/site-packages/msgpack/fallback.py", line 666, in _unpack "%s is not allowed for map key" % str(type(key)) ValueError: is not allowed for map key ---------------------------------------------------------------------- This is happening on both staging and master. There have been no changes to the calibre package itself since January. I have run a git bisect and the offending change appears to be in commit 66ab2f5e3a0df665f6e39203aedd2bf4812e6a71, when python-msgpack was updated to version 1.0.0. [0]: e.g. http://ci.guix.gnu.org/build/2485977/details -- Josh Holland From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 03 09:05:39 2020 Received: (at 40388) by debbugs.gnu.org; 3 Apr 2020 13:05:39 +0000 Received: from localhost ([127.0.0.1]:41377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jKM0x-0007KC-Bs for submit@debbugs.gnu.org; Fri, 03 Apr 2020 09:05:39 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:51763) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jKM0u-0007Jg-Vf for 40388@debbugs.gnu.org; Fri, 03 Apr 2020 09:05:37 -0400 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 38E585F1 for <40388@debbugs.gnu.org>; Fri, 3 Apr 2020 09:05:31 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Fri, 03 Apr 2020 09:05:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inv.alid.pw; h= from:to:subject:date:message-id:mime-version:content-type; s= fm3; bh=A/abQqMqLSicqKiOUBDo2aKoW3AMtPFzYvuNRgMg310=; b=PC5wC03X qTP8MR8Hj+EExCswpyaJpFWgpeatzygz4i/vFuk2mCrIbFs8IcVIDjtMw2V/dwPk 5Yxrh1vnSkbelScB/XckagtiIZDHoYmDrHLHwfzsH82a4P74ayWH/G+o/gskiGbn Wx0EJlI4pljkdQvoxkK5AnLRPoF0p3BXrdrI/XeDGx5GS3Bo+y8xHD/v0FFVm1Ys Jh+FUXjAq790JSWVcBV4MNjKqSqMxb9uXQrpdKuD5mcO4ZW89mAEuklZG4tgGqhq uXuIujvs5GvZh2gFhhTCI7u4BBjurD3Ugly/a9Yb+3RttAt2j57hA3RAUW1zyrgM 5VTJGUe9rW+vTw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=A/abQqMqLSicqKiOUBDo2aKoW3AMt PFzYvuNRgMg310=; b=14y5W/pDy0XCqvqGx19N+Cg65REyuz89P4Fs7zqK+7EZ+ f6VCPxpaNZe08OX4AM5lvvvX2DwbZQFdscIFa5sl81WrJA/fh4BtaP1yIeRGuvfA wqMcCP8HJS2bFmfqOtVRxOM5vC2MiAUfjFTU/wN4s7wofQo2PvF7WcPw6nJCh6E4 sTReHOvUtgDvA2TPpkBfYw49MQlx9PQef3l23mnV4gJqtJHe6VHTMPaMeEcO+fZS EZJ+Nxf76wKuwyag1lRkWpa5bz6N0hUqY5Zd3D/QJPaO6nETzw4cCG6KLTihanUf bJKiEOq5rnbOsTFpawVer1l1M2Hcc0mNSq9u+ZNbQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrtdeigdeiudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecufghrlhcuvffnffculddutddmnecujfgurhepfgfhvf fufffkgggtsehttdertddtredtnecuhfhrohhmpeflohhshhcujfholhhlrghnugcuoehj ohhshhesihhnvhdrrghlihgurdhpfieqnecuffhomhgrihhnpehlrghunhgthhhprggurd hnvghtpdhphihpihdrohhrghenucfkphepkeehrdduudelrdekfedrvdeinecuvehluhhs thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepjhhoshhhsehinhhvrd grlhhiugdrphif X-ME-Proxy: Received: from spica (procyon.chrys.alid.pw [85.119.83.26]) by mail.messagingengine.com (Postfix) with ESMTPA id 5C65A306CF67 for <40388@debbugs.gnu.org>; Fri, 3 Apr 2020 09:05:30 -0400 (EDT) User-agent: mu4e 1.2.0; emacs 26.3 From: Josh Holland To: 40388@debbugs.gnu.org Subject: Reported upstream to Calibre Date: Fri, 03 Apr 2020 14:05:29 +0100 Message-ID: <87a73sbtye.fsf@inv.alid.pw> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40388 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) I've reported this bug as https://bugs.launchpad.net/calibre/+bug/1870541. I also found the backwards-incompatible change in msgpack which is the culprit of this: * Default value of strict_map_key is changed to True to avoid hashdos. You need to pass strict_map_key=False if you have data which contain map keys which type is not bytes or str. (from ) I can prepare a patch (both within the Guix build system and to send upstream) which fixes this, though I'm not sure what hashdos are or whether they are actually important to avoid in this case. -- Josh Holland From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 03 09:32:06 2020 Received: (at 40388-done) by debbugs.gnu.org; 3 Apr 2020 13:32:06 +0000 Received: from localhost ([127.0.0.1]:41399 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jKMQX-0000Jt-03 for submit@debbugs.gnu.org; Fri, 03 Apr 2020 09:32:05 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:53423) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jKMQQ-0000Ig-4j for 40388-done@debbugs.gnu.org; Fri, 03 Apr 2020 09:31:58 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id B66A55C00CD; Fri, 3 Apr 2020 09:31:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 03 Apr 2020 09:31:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=x8UtB6BkLntSABYUZU1EqQ1cQY 4TYjYON6DR/x5kAY4=; b=G6nYDAC/2TNJG8yTai5wFvWNYmcvDOkFCP3o7icQa2 VLFeti0cTUY4keSS7ZHhTvOFXb9HzOFgb/cc89447gpTu+6yOEIGnhY/dnH+o8ml +pq3GgatPHMOf0rQRgrENbGV0nvSNVLQNCbn+IZfqMckjPhBTjFrdZiNoxVdfWz5 X1FwL8KRT0bwsTnNoh3RYUfQHaMtTs075NNHjWX+UtmhXPe8AzlXD7K3TH33ns9V bqSTBzgxq0fjkWRBuobpW2sJYNTS+vyAha4aua65GhXKMjJ5JVD7oXsLkkvC48tb FRQKSa0yN91TXybv8CMRoBaNIlTkBgsUKXxdU4OfG83w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=x8UtB6 BkLntSABYUZU1EqQ1cQY4TYjYON6DR/x5kAY4=; b=XkR/a24WjzvKXbPI1zr9Zf NnfJdA9/jJGjhXmzxpQ04ZRfgs2GHJ1YyeN7WoeQGqYSK0/xVcyb/t6qMZ7YXjGU ysZ7i5crcWjZcgQS0YFfsM6cXwj0qxy22c9MDIEvOhTzV/pnAfuoKBXoa6RPUqDj tuSmkag2lP8eJ/ySo4hwB2cHf+1b3jfiIPk/dMoMrh9VVFEoNJVKSg4ttZYpXluq f9OCEeAVI3y41SKg8CRIQOX9XiLAdpEyUioYExn+Q8lmSurM7D0sm9RFaWjqlvmN zSL1WuKtIJpV4W5wA8OqRrV2To7MrxbTRAYh817f3B+fRMUt4S+QeMJQSzzTgfWA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrtdeigdeihecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdeimdenucfjughrpefhvffujghffgffkfggtgesghdtreertdertden ucfhrhhomhepofgrrhhiuhhsuceurghkkhgvuceomhgsrghkkhgvsehfrghsthhmrghilh drtghomheqnecuffhomhgrihhnpehlrghunhgthhhprggurdhnvghtpdhphihpihdrohhr ghdpghhithhhuhgsrdgtohhmnecukfhppeekgedrvddtvddrieekrdejheenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmsggrkhhkvgesfhgr shhtmhgrihhlrdgtohhm X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id 82C1B306CFC8; Fri, 3 Apr 2020 09:31:51 -0400 (EDT) From: Marius Bakke To: Josh Holland , 40388-done@debbugs.gnu.org Subject: Re: bug#40388: Reported upstream to Calibre In-Reply-To: <87a73sbtye.fsf@inv.alid.pw> References: <87wo6yf5rl.fsf@inv.alid.pw> <87a73sbtye.fsf@inv.alid.pw> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Fri, 03 Apr 2020 15:31:49 +0200 Message-ID: <87wo6wpuey.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40388-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Josh Holland writes: > I've reported this bug as > https://bugs.launchpad.net/calibre/+bug/1870541. I also found the > backwards-incompatible change in msgpack which is the culprit of this: > > * Default value of strict_map_key is changed to True to avoid > hashdos. You need to pass strict_map_key=False if you have data which > contain map keys which type is not bytes or str. > > (from ) Thanks for reporting it! I was just looking into the issue and found that it was fixed upstream 3 days ago: https://github.com/kovidgoyal/calibre/commit/0ff41ac64994ec11b7859fc004c94d08769e3af3 I adopted the patch to Guix in 3e4ce1cc3eb7b35405c4d2c4f837e53ec9952c99. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl6HOsUACgkQoqBt8qM6 VPpsbQf+PXW98e2Nv0aOby3q0i3FYfSifDn+jG9c3ilhn4SUjKOYGp7oWIHuzfbq HfT7WkdXa7OD1kvUP8iLk3C2MiJv/jUTfkdZw0BbX/WkdAAebHN55xlo5sd57BCC FTtzyRRV+h7gzs5oE7yFLgpkuxpYS5z8OqzbM0bL5ReCN9cw+hY0atxzjPJa53+a dWEinsw+hHi3sB9xc1S7pNEJrmxEiHpqJ2gY8tTzkzgpL89CpzjTh7B7FBgKqyjM YL68XjLofCPWrqdNLH9eNDb/IgTMZb1SEBOYO8+fsZJecJVgx0yFu6WP7+aTWXWD aiL39twD1x2BalRh/Lk157TGoqRc6Q== =Lg6z -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Jun 14 03:57:35 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 02 May 2020 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator