Subject: Re: [bug#40362] [PATCH] gnu: cross-base: Add mingw-w64 specific binutils patches.

From: Mathieu Othacehe <[email-masked]>
Date: Wed, 01 Apr 2020 16:14:14 +0200

Hello Carl!

> * gnu/packages/patches/binutils-mingw-w64-reproducible-import-libraries.patch:
> New file.
> * gnu/packages/patches/binutils-mingw-w64-specify-timestamp.patch:
> New file.

You also need to add those patches to gnu/local.mk.

> +(define (package-with-extra-patches original patches)
> +  "Return package ORIGINAL with all PATCHES appended to its list of patches."
> +  (package-with-patch original
> +                      `(,@(origin-patches (package-source original))
> +                        ,@patches))

Nitpick, maybe we could just name it package-with-patches?

> +                  (package-with-extra-patches binutils
> +                                              (search-patches
> +                                               "binutils-mingw-w64-specify-timestamp.patch"
> +                                               "binutils-mingw-w64-reproducible-import-libraries.patch")))

This is over the 78 column limit.

Otherwise, seems fine!

Thanks,

Mathieu