GNU bug report logs - #40358
Add beancount

Previous Next

Full log

Message #13 received at 40358-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Lemmer Webber <cwebber <at> dustycloud.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 40358-done <at> debbugs.gnu.org
Subject: Re: [bug#40358] Add beancount
Date: Thu, 02 Apr 2020 11:20:20 -0400

Ludovic Courtès writes:

> Hello!
>
> Christopher Lemmer Webber <cwebber <at> dustycloud.org> skribis:
>
>> From 27274e0075f7215693cc4a51482c68ce00167d37 Mon Sep 17 00:00:00 2001
>> From: Christopher Lemmer Webber <cwebber <at> dustycloud.org>
>> Date: Tue, 31 Mar 2020 16:57:15 -0400
>> Subject: [PATCH] gnu: Add beancount.
>>
>> * gnu/packages/finance.scm (beancount): New variable.
>> * gnu/packages/patches/beancount-disable-googleapis-fonts.patch: New file.
>
> Could you add the patch to gnu/local.mk?

Good call.  Done.

>> +    (home-page "http://furius.ca/beancount")
>> +    (synopsis "Command-line Double-Entry Accounting")
>
> Nitpick: please remote capitals except for the first one, and…

Done.

>> +    (description
>> +     "A double-entry bookkeeping computer language that lets you define
>> +financial transaction records in a text file, read them in memory, generate
>> +a variety of reports from them, and provides a web interface.")
>
> … make it a full sentence.

Okay, done.

>> +++ b/gnu/packages/patches/beancount-disable-googleapis-fonts.patch
>> @@ -0,0 +1,23 @@
>> +From: Nicolas Dandrimont <nicolas <at> dandrimont.eu>
>> +Date: Tue, 1 May 2018 04:49:55 +0200
>> +Subject: Remove fonts.googleapis.com links for the bean-web template
>
> Could you add the URL of the upstream patch or discussion, if any?
>
> OK with these changes!
>
> Thanks,
> Ludo’.

Pushed!  Thanks for your review!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.