GNU bug report logs - #40350
[PATCH] ui: Mention that changes to package definitions can cause "upgrades".

Previous Next

Package: guix-patches;

Reported by: Leo Famulari <leo <at> famulari.name>

Date: Tue, 31 Mar 2020 15:17:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: guix-patches <at> gnu.org
Subject: [PATCH] ui: Mention that changes to package definitions can cause
 "upgrades".
Date: Tue, 31 Mar 2020 11:15:32 -0400
* guix/ui.scm (show-manifest-transaction)[upgrade-string]: Use the
package name in UI message.
---
 guix/ui.scm | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/guix/ui.scm b/guix/ui.scm
index 1e24fe5dca..20b1e79ca9 100644
--- a/guix/ui.scm
+++ b/guix/ui.scm
@@ -14,6 +14,7 @@
 ;;; Copyright © 2019 Chris Marusich <cmmarusich <at> gmail.com>
 ;;; Copyright © 2019 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2019 Simon Tournier <zimon.toutoune <at> gmail.com>
+;;; Copyright © 2020 Leo Famulari <leo <at> famulari.name>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1162,11 +1163,13 @@ separator between subsequent columns."
                               name
                               (string-append name ":" output)))
                         names outputs)
-                   (map (lambda (old new)
+                   (map (lambda (old new name)
                           (if (string=? old new)
-                              (G_ "(dependencies changed)")
+                              (format
+                                (G_ "(dependencies or ~a package recipe changed)")
+                                name)
                               (string-append old " " → " " new)))
-                        old-version new-version))
+                        old-version new-version names))
               #:initial-indent 3))
 
   (let-values (((remove install upgrade downgrade)
-- 
2.26.0





This bug report was last modified 5 years and 55 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.