GNU bug report logs - #40350
[PATCH] ui: Mention that changes to package definitions can cause "upgrades".

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#40350: closed ([PATCH] ui: Mention that changes to package
 definitions can cause "upgrades".)
Date: Thu, 02 Apr 2020 08:06:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 02 Apr 2020 10:05:05 +0200
with message-id <87v9miqpn2.fsf <at> gnu.org>
and subject line Re: [bug#40350] [PATCH] ui: Mention that changes to package definitions can cause "upgrades".
has caused the debbugs.gnu.org bug report #40350,
regarding [PATCH] ui: Mention that changes to package definitions can cause "upgrades".
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
40350: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40350
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Leo Famulari <leo <at> famulari.name>
To: guix-patches <at> gnu.org
Subject: [PATCH] ui: Mention that changes to package definitions can cause
 "upgrades".
Date: Tue, 31 Mar 2020 11:15:32 -0400

* guix/ui.scm (show-manifest-transaction)[upgrade-string]: Use the
package name in UI message.
---
 guix/ui.scm | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/guix/ui.scm b/guix/ui.scm
index 1e24fe5dca..20b1e79ca9 100644
--- a/guix/ui.scm
+++ b/guix/ui.scm
@@ -14,6 +14,7 @@
 ;;; Copyright © 2019 Chris Marusich <cmmarusich <at> gmail.com>
 ;;; Copyright © 2019 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2019 Simon Tournier <zimon.toutoune <at> gmail.com>
+;;; Copyright © 2020 Leo Famulari <leo <at> famulari.name>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1162,11 +1163,13 @@ separator between subsequent columns."
                               name
                               (string-append name ":" output)))
                         names outputs)
-                   (map (lambda (old new)
+                   (map (lambda (old new name)
                           (if (string=? old new)
-                              (G_ "(dependencies changed)")
+                              (format
+                                (G_ "(dependencies or ~a package recipe changed)")
+                                name)
                               (string-append old " " → " " new)))
-                        old-version new-version))
+                        old-version new-version names))
               #:initial-indent 3))
 
   (let-values (((remove install upgrade downgrade)
-- 
2.26.0

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 40350-done <at> debbugs.gnu.org
Subject: Re: [bug#40350] [PATCH] ui: Mention that changes to package
 definitions can cause "upgrades".
Date: Thu, 02 Apr 2020 10:05:05 +0200

Hi,

Leo Famulari <leo <at> famulari.name> skribis:

> On Wed, Apr 01, 2020 at 11:03:22PM +0200, Ludovic Courtès wrote:
>> Is that not implied in a way?
>
> It is, but I think we will still get some confused users asking about
> it.
>
>> If it is, how about something shorter like:
>> 
>>   (dependencies or package changed)
>
> Yeah, I think that's okay.

OK, done!

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.