Subject: bug#40350: closed (Re: [bug#40350] [PATCH] ui: Mention that changes to package definitions can cause "upgrades".)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 02 Apr 2020 08:06:02 +0000

Your bug report

#40350: [PATCH] ui: Mention that changes to package definitions can cause "upgrades".

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
40350: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40350
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#40350] [PATCH] ui: Mention that changes to package definitions can cause "upgrades".
From: Ludovic Courtès <[email-masked]>
To: Leo Famulari <[email-masked]>
Cc: [email-masked]
Date: Thu, 02 Apr 2020 10:05:05 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Leo Famulari <[email-masked]> skribis:

> On Wed, Apr 01, 2020 at 11:03:22PM +0200, Ludovic Courtès wrote:
>> Is that not implied in a way?
>
> It is, but I think we will still get some confused users asking about
> it.
>
>> If it is, how about something shorter like:
>> 
>>   (dependencies or package changed)
>
> Yeah, I think that's okay.

OK, done!

Thanks,
Ludo’.

Subject: [PATCH] ui: Mention that changes to package definitions can cause "upgrades".
From: Leo Famulari <[email-masked]>
To: [email-masked]
Date: Tue, 31 Mar 2020 11:15:32 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

* guix/ui.scm (show-manifest-transaction)[upgrade-string]: Use the
package name in UI message.
---
 guix/ui.scm | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/guix/ui.scm b/guix/ui.scm
index 1e24fe5dca..20b1e79ca9 100644
--- a/guix/ui.scm
+++ b/guix/ui.scm
@@ -14,6 +14,7 @@
 ;;; Copyright © 2019 Chris Marusich <[email-masked]>
 ;;; Copyright © 2019 Tobias Geerinckx-Rice <[email-masked]>
 ;;; Copyright © 2019 Simon Tournier <[email-masked]>
+;;; Copyright © 2020 Leo Famulari <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1162,11 +1163,13 @@ separator between subsequent columns."
                               name
                               (string-append name ":" output)))
                         names outputs)
-                   (map (lambda (old new)
+                   (map (lambda (old new name)
                           (if (string=? old new)
-                              (G_ "(dependencies changed)")
+                              (format
+                                (G_ "(dependencies or ~a package recipe changed)")
+                                name)
                               (string-append old " " → " " new)))
-                        old-version new-version))
+                        old-version new-version names))
               #:initial-indent 3))
 
   (let-values (((remove install upgrade downgrade)
-- 
2.26.0