GNU bug report logs - #40340
[PATCH] etc: indent-code.el: Use the --quick option.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#40340: closed ([PATCH] etc: indent-code.el: Use the --quick
 option.)
Date: Fri, 15 May 2020 03:10:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 14 May 2020 23:09:11 -0400
with message-id <87eerldhd4.fsf <at> gmail.com>
and subject line Re: [bug#40340] [PATCH] etc: indent-code.el: Use the --quick option.
has caused the debbugs.gnu.org bug report #40340,
regarding [PATCH] etc: indent-code.el: Use the --quick option.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
40340: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40340
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] etc: indent-code.el: Use the --quick option.
Date: Tue, 31 Mar 2020 00:41:25 -0400

[Message part 3 (text/plain, inline)]

Hello!

I noticed two small annoyances with the indent-code.el script, which are
explained and fixed in the attached patch.

[0001-etc-indent-code.el-Use-the-quick-option.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

[Message part 6 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 40340-done <at> debbugs.gnu.org
Subject: Re: [bug#40340] [PATCH] etc: indent-code.el: Use the --quick option.
Date: Thu, 14 May 2020 23:09:11 -0400

Hello Simon,

zimoun <zimon.toutoune <at> gmail.com> writes:

> Hi Maxim,
>
> On Tue, 31 Mar 2020 at 06:42, Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:
>
>> * configure.ac: Remove the warning about Emacs.  Emacs can now be installed
>> any time by the user if they want to use the script.
>
> The point of this warning was to inform (teach) the user if they does
> not know how to use 'etc/indent-code.el'; basically newcomers which do
> not use Emacs and do not read manual cover to cover.
> Well, maybe it is not useful since the manual already explains [1] and
> this message is meaningful by itself:
>
> ./etc/indent-code.el gnu/packages/maths.scm
> ./etc/indent-code.el: line 1: exec: emacs: not found
>
> [1] https://guix.gnu.org/manual/devel/en/guix.html#Formatting-Code
>
>
> Thank you for the improvement.

The warning was indeed useful before this change, as the script was not
generated in the event Emacs was not found at configuration time.  Now
that the script is always available, it can be removed.

I went ahead and merged this as commit cb21ae7671.

Thank you for taking a look :-).

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.