From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 31 00:41:40 2020 Received: (at submit) by debbugs.gnu.org; 31 Mar 2020 04:41:40 +0000 Received: from localhost ([127.0.0.1]:35372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJ8iW-0001eJ-Qw for submit@debbugs.gnu.org; Tue, 31 Mar 2020 00:41:40 -0400 Received: from lists.gnu.org ([209.51.188.17]:34184) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJ8iV-0001e9-8S for submit@debbugs.gnu.org; Tue, 31 Mar 2020 00:41:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35801) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJ8iT-0006e2-HW for guix-patches@gnu.org; Tue, 31 Mar 2020 00:41:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJ8iP-0002ih-Se for guix-patches@gnu.org; Tue, 31 Mar 2020 00:41:33 -0400 Received: from mail-qt1-x830.google.com ([2607:f8b0:4864:20::830]:36230) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jJ8iP-0002iJ-Mx for guix-patches@gnu.org; Tue, 31 Mar 2020 00:41:29 -0400 Received: by mail-qt1-x830.google.com with SMTP id m33so17281852qtb.3 for ; Mon, 30 Mar 2020 21:41:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=80Ac3zmWE3ZTfo3WrnpiDIimcY2DRzuMmlBFkW9z0M8=; b=tiSyINpvW66JuhPfLOYiV2mtFaVRKO+nJFuKN6hBpCFoq5OW0MwBS97TV9OJjiMDRL JK1XBb0s2f6iSjJe8WoyqrKPxMS54yTFqYbQfyPCMglFNV5PhmiKIouf6tLjfAPru0v4 pgC9eGbKb7AEI0uVxjCmSPGR72byBOt6xsyu2gm2Mlzr0vsfROLtwP0q9PCGCX+hLinI pmDJR0O5ciyO7BYb2PNpPKWcFZdX3uakccCHDsOUbO/OmqyzQ07CxO247T21qfkRke3J VYwZGDdhRukp5CmqzmVo5XsPVILuB9Qrj7DszWuTRe5jpxW5Rp2dH1pMvEh9OIMM6Gwu /kKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=80Ac3zmWE3ZTfo3WrnpiDIimcY2DRzuMmlBFkW9z0M8=; b=M1PUFxw3G6bDelfH034PPMjqkXFQFgqe6Xkbt3RjsFnvXuWifW32CxnkMxLPnj2TQr g1c5qUwFLT8DZa+nPzfvuwrACrYrLWFFKzsxRLvqWsr18Foq8ozlLB4ehffd4QiiShPK CO+USCaRCEh7MGwO2xG1d6X3SYhEgVrFEj3HXNidGcHbZ0W5lMokyd02feGyQBkbDSab WavusybmKThutuGR+0zOmZ7U+hpI2NmxyyFw5NwfmRZoQcahbcKfSvYJVcgTf69Qpx+S LpBYYQLRCRD2YvIVnUEvxL4x3xBtJIEVfKyd0dntumaHCkpDWw/GbloStXkmyoVVKSKH rYZA== X-Gm-Message-State: ANhLgQ3P1puURCSmGhTQfOYpoXdR4hvAIvt23bhOvlKjxBQsJXWpqIwU 9C4TEGSChTwstbFfXUVFxPh3GO4Fkac= X-Google-Smtp-Source: ADFU+vug6918xa++XxeCMgqmTwBPzRSCBF0m7g85ieJqR8llyvzvOM9kI3vNilnrMtzUjq0XmHREVQ== X-Received: by 2002:ac8:4e94:: with SMTP id 20mr3271922qtp.314.1585629688741; Mon, 30 Mar 2020 21:41:28 -0700 (PDT) Received: from hurd (dsl-159-222.b2b2c.ca. [66.158.159.222]) by smtp.gmail.com with ESMTPSA id k124sm12140660qke.108.2020.03.30.21.41.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 21:41:27 -0700 (PDT) From: Maxim Cournoyer To: guix-patches Subject: [PATCH] etc: indent-code.el: Use the --quick option. Date: Tue, 31 Mar 2020 00:41:25 -0400 Message-ID: <87lfnhxhje.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::830 X-Spam-Score: 2.3 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello! I noticed two small annoyances with the indent-code.el script, which are explained and fixed in the attached patch. From ce30a6ceb76595ce0ba87eeb54f0b6624485354f Mon Sep 17 00:00:00 2001 From: Maxim Cournoyer Date: Tue, 31 Mar 2020 00:12:01 -0400 Subject: [PATCH] etc: indent-code.el: Use the --quick option. Content analysis details: (2.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: configure.ac] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [209.51.188.17 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (maxim.cournoyer[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 2.0 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Hello! I noticed two small annoyances with the indent-code.el script, which are explained and fixed in the attached patch. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-etc-indent-code.el-Use-the-quick-option.patch Content-Transfer-Encoding: quoted-printable From=20ce30a6ceb76595ce0ba87eeb54f0b6624485354f Mon Sep 17 00:00:00 2001 From: Maxim Cournoyer Date: Tue, 31 Mar 2020 00:12:01 -0400 Subject: [PATCH] etc: indent-code.el: Use the --quick option. This prevents Emacs from loading the autoload definitions found in its profile, which needlessly clutters the output. It also prevents Geiser (if installed) from blocking the script and asking the user to input the Scheme implementation to use. The trick for passing multiple arguments to Emacs is to use what is called a "sesquicolon" (see https://www.emacswiki.org/emacs/EmacsScripts). * etc/indent-code.el.in: Rename to... * etc/indent-code.el: ...this. Adapt the shebang to use a sesquicolon, and pass the --quick option to Emacs. Since this line is interpreted by the shell, simply use Emacs from the PATH instead of from a hard coded location. (main): New procedure, used as the entry point. * configure.ac: Remove the warning about Emacs. Emacs can now be installed any time by the user if they want to use the script. * .gitignore: No longer ignore changes to etc/indent-code.el. =2D-- .gitignore | 1 - configure.ac | 9 ---- etc/{indent-code.el.in =3D> indent-code.el} | 52 ++++++++++++----------- 3 files changed, 27 insertions(+), 35 deletions(-) rename etc/{indent-code.el.in =3D> indent-code.el} (71%) diff --git a/.gitignore b/.gitignore index fd2cf56098..cc5ceb5e10 100644 =2D-- a/.gitignore +++ b/.gitignore @@ -149,7 +149,6 @@ stamp-h[0-9] tmp /doc/os-config-lightweight-desktop.texi /nix/scripts/download =2D/etc/indent-code.el /.version /doc/stamp-[0-9] /gnu/packages/bootstrap diff --git a/configure.ac b/configure.ac index 6a6a020585..5ed2cf7aa0 100644 =2D-- a/configure.ac +++ b/configure.ac @@ -284,15 +284,6 @@ dnl Documentation translation. AM_MISSING_PROG([PO4A_TRANSLATE], [po4a-translate]) AM_MISSING_PROG([PO4A_UPDATEPO], [po4a-updatepo]) =20 =2Ddnl Emacs (optional), for 'etc/indent-code.el'. =2DAC_PATH_PROG([EMACS], [emacs]) =2Dif test "x$EMACS" =3D x; then =2D AC_MSG_WARN([Please install GNU Emacs to use etc/indent-code.el.]) =2Delse =2D AC_SUBST([EMACS]) =2D AC_CONFIG_FILES([etc/indent-code.el], [chmod +x etc/indent-code.el]) =2Dfi =2D case "$storedir" in /gnu/store) ;; diff --git a/etc/indent-code.el.in b/etc/indent-code.el similarity index 71% rename from etc/indent-code.el.in rename to etc/indent-code.el index 6102b5d1ab..255ffb126b 100755 =2D-- a/etc/indent-code.el.in +++ b/etc/indent-code.el @@ -1,8 +1,9 @@ =2D#!@EMACS@ --script +:;exec emacs --batch --quick --load=3D"$0" --funcall=3Dmain "$@" ;;; indent-code.el --- Run Emacs to indent a package definition. =20 ;; Copyright =C2=A9 2017 Alex Kost ;; Copyright =C2=A9 2017 Ludovic Court=C3=A8s +;; Copyright =C2=A9 2020 Maxim Cournoyer =20 ;; This file is part of GNU Guix. =20 @@ -86,29 +87,30 @@ (with-syntax 1)) =20 =2D(pcase command-line-args-left =2D (`(,file-name ,package-name) =2D ;; Indent the definition of PACKAGE-NAME in FILE-NAME. =2D (find-file file-name) =2D (goto-char (point-min)) =2D (if (re-search-forward (concat "^(define\\(-public\\) +" =2D package-name) =2D nil t) =2D (let ((indent-tabs-mode nil)) =2D (beginning-of-defun) =2D (indent-sexp) =2D (save-buffer) =2D (message "Done!")) =2D (error "Package '%s' not found in '%s'" =2D package-name file-name))) =2D (`(,file-name) =2D ;; Indent all of FILE-NAME. =2D (find-file file-name) =2D (let ((indent-tabs-mode nil)) =2D (indent-region (point-min) (point-max)) =2D (save-buffer) =2D (message "Done!"))) =2D (x =2D (error "Usage: indent-code.el FILE [PACKAGE]"))) +(defun main () + (pcase command-line-args-left + (`(,file-name ,package-name) + ;; Indent the definition of PACKAGE-NAME in FILE-NAME. + (find-file file-name) + (goto-char (point-min)) + (if (re-search-forward (concat "^(define\\(-public\\) +" + package-name) + nil t) + (let ((indent-tabs-mode nil)) + (beginning-of-defun) + (indent-sexp) + (save-buffer) + (message "Done!")) + (error "Package '%s' not found in '%s'" + package-name file-name))) + (`(,file-name) + ;; Indent all of FILE-NAME. + (find-file file-name) + (let ((indent-tabs-mode nil)) + (indent-region (point-min) (point-max)) + (save-buffer) + (message "Done!"))) + (x + (error "Usage: indent-code.el FILE [PACKAGE]")))) =20 ;;; indent-code.el ends here =2D-=20 2.25.2 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEJ9WGpPiQCFQyn/CfEmDkZILmNWIFAl6CyfUACgkQEmDkZILm NWJeDA//W1oD7Pz8hd59dh1HZqSG2M2FlgY6I8d8iwOPDTr7bZ0TrP4qodCjlUEH utQ54+YlaYHB7JqD0DOckTqJlcArnqap9j0QiQOE1S+b6Lz+8L72YS04ia7gx1Nd hqO2tc9HceZvSNRkBem8CvMNOp9Ivki+Faa3GknCA2g9JXhU0A93zKgyo03V91s9 GhBKaBOqJACuBRQ1jxKsO4dOuiNuYR9VoSaeTO1Q76I7tRqIo12sE+9ew/DKRLQD TN8vy+RgJ9mXYdzPKzAsfEZovTalfMQ+ORQ5ohmBj01B41lMvPM7m52ltUIvJqEH L9uEGQjWATf0DGLebA7uvpp5WtP67iBIZICE+ITNo8iW1k4Gr2UWy5oQmc/FniIi rXBGFC5cBsl0pdI7fu1aumgqbG8wWk5Ea3QsYWKQ4pAhrmumnXjWWL55IoVDvlqW TaOLr7HEkmAYEDIDS49pjyG6PELObK8H8xvQBdmAfTWKqePB7pMrtV5ZhunCcHO2 0TCNBZ0dSjO79KW5U/5o080ecY+IudtxE0wgXU0tDIG+uu3RrAiG8FCIFC4CtYyJ +KsI8yoSs680r2QoTfW/7qwbQTlc8kum6KVw1nLoyrlr5pWs5ThjAT182c6+YH/F 1tWQZcFjXl8vJqW0yiIuPRbJQXGnSxhxs8DekaAnlK3mxPYuAaU= =fVXt -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 12 20:45:28 2020 Received: (at 40340) by debbugs.gnu.org; 13 May 2020 00:45:28 +0000 Received: from localhost ([127.0.0.1]:56933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYfWa-0007T9-Ml for submit@debbugs.gnu.org; Tue, 12 May 2020 20:45:28 -0400 Received: from mail-qt1-f173.google.com ([209.85.160.173]:40147) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYfWZ-0007Su-QJ for 40340@debbugs.gnu.org; Tue, 12 May 2020 20:45:28 -0400 Received: by mail-qt1-f173.google.com with SMTP id c24so6406597qtw.7 for <40340@debbugs.gnu.org>; Tue, 12 May 2020 17:45:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ataC+pb2Lqlf3ypeO1d8Sc5Z+GJEO+MENbtMwG1oTkE=; b=GT6KNBcWKMgmWeDsvlC8a+TXvRKTcVHBDRaNbMgMkllFgjP5YABFSkDCY1hABCT5Gc 4fu79ipa71duJMXF3ZlY2Ugf5tBBirOyrKtnsG997fhCTZisJZoWymPg5A9z7UGzxsyb DUfD3/TKMecZeh7Aa/I83mrDR7+J2elvOENfCKJxe/8uchKz3B5sGvLKm0L/mfhfvU/A YZsulH2gJfXvVvd4xtpOHD2UUKNWvtD2Mx5TD+FHowRIu/TsTFqE+VZgp8ZpiX7sfST/ zSx0FundYbrFtBtuG5GaV0sMHryg2fgNmJ7y3QmuvsINn18pGKMXiDhkbE3/5YRdJi8H ghyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ataC+pb2Lqlf3ypeO1d8Sc5Z+GJEO+MENbtMwG1oTkE=; b=E0laP3mDPztZhKWpMsDnDnkyLdPPKkgXnurCx4XCfNpM5nI7cenkWggdh03OwH5oPc St8SK46/Mt2mG+R3effRtc9NLtryLo+jiSFq+YUBxAFGkJ7BELmpLhVNGblQLImqt4Wl 8gw2OLI8DC+RGr7eA8TqpIrhOBQ5DXRgAo/Z5HvIU0DtSZNV2/Hzt/iwavEds2VwOYtN cSMou0trHQ1sMS6XLzxDvrULmEa2LcJybHA72DaHpeER66xJv910x8bye5ET3SOTllx4 63sP6eWH82hFOL7Gh3syH+A/aq93j8qw8/3FRLtw8JGjCLGsLud9YFKLwdF46TFlfmkh pn6Q== X-Gm-Message-State: AGi0Pubjp3Y3dhMfdwf47tzlxLLwUq0Y/T3GjZzWrPyFf58F5BTgRwbA T4NheKCnjNZBBXZgB+mm2K4nngR83T+RHhvC5IQ= X-Google-Smtp-Source: APiQypKGd98a4kiDOxS9CJV2EGuSVfRfVQ2pPl99TbhauuMSrZybsudWGvuMLi+1g4gfBjFtiXC9jZcGB3XUBDoVHSM= X-Received: by 2002:ac8:4e0f:: with SMTP id c15mr23516674qtw.211.1589330722245; Tue, 12 May 2020 17:45:22 -0700 (PDT) MIME-Version: 1.0 References: <87lfnhxhje.fsf@gmail.com> In-Reply-To: <87lfnhxhje.fsf@gmail.com> From: zimoun Date: Wed, 13 May 2020 02:45:11 +0200 Message-ID: Subject: Re: [bug#40340] [PATCH] etc: indent-code.el: Use the --quick option. To: Maxim Cournoyer Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40340 Cc: 40340@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxim, On Tue, 31 Mar 2020 at 06:42, Maxim Cournoyer wrote: > * configure.ac: Remove the warning about Emacs. Emacs can now be installed > any time by the user if they want to use the script. The point of this warning was to inform (teach) the user if they does not know how to use 'etc/indent-code.el'; basically newcomers which do not use Emacs and do not read manual cover to cover. Well, maybe it is not useful since the manual already explains [1] and this message is meaningful by itself: --8<---------------cut here---------------start------------->8--- ./etc/indent-code.el gnu/packages/maths.scm ./etc/indent-code.el: line 1: exec: emacs: not found --8<---------------cut here---------------end--------------->8--- [1] https://guix.gnu.org/manual/devel/en/guix.html#Formatting-Code Thank you for the improvement. All the best, simon From debbugs-submit-bounces@debbugs.gnu.org Thu May 14 23:09:20 2020 Received: (at 40340-done) by debbugs.gnu.org; 15 May 2020 03:09:20 +0000 Received: from localhost ([127.0.0.1]:35563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZQiu-0000he-3L for submit@debbugs.gnu.org; Thu, 14 May 2020 23:09:20 -0400 Received: from mail-qv1-f65.google.com ([209.85.219.65]:44061) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZQis-0000hN-Vm for 40340-done@debbugs.gnu.org; Thu, 14 May 2020 23:09:19 -0400 Received: by mail-qv1-f65.google.com with SMTP id ee19so397592qvb.11 for <40340-done@debbugs.gnu.org>; Thu, 14 May 2020 20:09:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=G2Vq3pDJ7zdvHc+mF3CYJ7zzohHQ3HYki+t5RxO+Bu0=; b=gP6Usd9GKsd5fTzs4LtHvyfAp2rw/CeTGrEbcSHAupX0482zXbvH5+2rjz4+waizVB sns72wRnF2gUacawmSCCGAUnOne0XFavATXPWguUChVOszq3Mua4gBBGGw45HFvSUR3W QTdlJUyJ5CsKI03Oxr4W+TARc8PM0CiC7QqzTk3J9xRfo2xd6k9zzwdhvZqT2KJEt78e uyxdxQgykUFjzB59lubmYVZ9aYs9qs2Ah4GKTbJzwRZlNNtb7N9ssYsPcfPgkTsH3+De YA1J8at5na1E047neT5a9terPhiIHs0OQNkG7FAYUAByxb03RwxStAuscoaUF3EGN4i3 MG7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=G2Vq3pDJ7zdvHc+mF3CYJ7zzohHQ3HYki+t5RxO+Bu0=; b=SvwQUg/NciXDR8WIlCNODlk/Lap0sIqIxpaz93U0PJPg5JSWlFgGckb/5xIDUop0Qt fUoceHipiVleTTN73sn2ErD3qvMB0VeoLgCuPVehwvnQ7Q4mmtk7OpD5O2ETt1U6CzZF q6sUJyjCuxMMfE3oOabvHebEFJo+0Xqn9kuT6UMasydlV5NxIW06ZGI+S6Txs/nf7J+B TJd3WWDFWv69Rhxqe0CAF+v78QXT7lum9GZWfLXxSxbiI+HAoWtwx9YOpSa9U4+etXs4 AblWal4HxkUGupWEKMMfVIjnMsXF0CnqGAbhORguN9LeutGadk2qSK5pUk8Op75skEtA Sw0Q== X-Gm-Message-State: AOAM531E1xkIMy1s1esF71Sr7jJh38OInKeDC/KmpR/o/71tFoUkBz6T eYk4WNHR/N/tYMgBIUngaIQqC4Nt X-Google-Smtp-Source: ABdhPJynJKrYE9uggy8sEpIK5y6Fgm46Nm5NrGDmSlC6sCf6Zhv47KI/HSerEbbhnEW7tvqLy4c5ig== X-Received: by 2002:ad4:462d:: with SMTP id x13mr1544283qvv.238.1589512152904; Thu, 14 May 2020 20:09:12 -0700 (PDT) Received: from hurd (dsl-151-246.b2b2c.ca. [66.158.151.246]) by smtp.gmail.com with ESMTPSA id l22sm635826qki.45.2020.05.14.20.09.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2020 20:09:12 -0700 (PDT) From: Maxim Cournoyer To: zimoun Subject: Re: [bug#40340] [PATCH] etc: indent-code.el: Use the --quick option. References: <87lfnhxhje.fsf@gmail.com> Date: Thu, 14 May 2020 23:09:11 -0400 In-Reply-To: (zimoun's message of "Wed, 13 May 2020 02:45:11 +0200") Message-ID: <87eerldhd4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40340-done Cc: 40340-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Simon, zimoun writes: > Hi Maxim, > > On Tue, 31 Mar 2020 at 06:42, Maxim Cournoyer wrote: > >> * configure.ac: Remove the warning about Emacs. Emacs can now be installed >> any time by the user if they want to use the script. > > The point of this warning was to inform (teach) the user if they does > not know how to use 'etc/indent-code.el'; basically newcomers which do > not use Emacs and do not read manual cover to cover. > Well, maybe it is not useful since the manual already explains [1] and > this message is meaningful by itself: > > ./etc/indent-code.el gnu/packages/maths.scm > ./etc/indent-code.el: line 1: exec: emacs: not found > > [1] https://guix.gnu.org/manual/devel/en/guix.html#Formatting-Code > > > Thank you for the improvement. The warning was indeed useful before this change, as the script was not generated in the event Emacs was not found at configuration time. Now that the script is always available, it can be removed. I went ahead and merged this as commit cb21ae7671. Thank you for taking a look :-). Maxim From unknown Sat Aug 09 13:16:54 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 12 Jun 2020 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator