GNU bug report logs - #40336
default face spec doesn't get overriden

Previous Next

Full log

Message #17 received at control <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Frank Terbeck <ft <at> bewatermyfriend.org>, 18074 <at> debbugs.gnu.org
Subject: Re: bug#18074: 24.3.50; `default' clause in face specs with
 custom-theme-set-faces doesn't work as advertised
Date: Wed, 26 Aug 2020 10:51:09 -0300

[Message part 1 (text/plain, inline)]

unarchive 40336
forcemerge 40336 18074
quit

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Mauro Aranda <maurooaranda <at> gmail.com>
>> Date: Wed, 26 Aug 2020 09:50:34 -0300
>> Cc: 18074 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
>>
>> > (deftheme foobar "Foobar theme")
>> > (custom-theme-set-faces 'foobar
>> >   '(default ((default :slant normal
>> >                       :weight bold
>> >                       :foreground "white"
>> >                       :background "black")
>> >              (t :foreground "blue"))))
>> >
>> > What I would expect is the `blue' foreground definition from the `t'
>> > clause to override the `white' foreground definition from the `default'
>> > clause. But alas, it doesn't work, the foreground remains white.
>>
>> I can reproduce this in Emacs 27, but not with current master.
>>
>> It looks like this was fixed in:
>> commit 05d365d3105371ec956f31f109a2de14c5cf67df
>> Author: Eli Zaretskii <eliz <at> gnu.org>
>> Date:   Sat Apr 4 09:59:16 2020 +0300
>>
>>     Fix face spec handling for 'default' "terminal class"
>>
>>     * lisp/faces.el (face-spec-choose): Reverse order of 'defaults'
>>     and 'result' when generating attribute list, so that the spec for
>>     'default' "terminal class" is indeed overridden by the actual
>>     class's spec, per the documentation.  (Bug#40336)
>>
>> CCing Eli, hoping he can confirm.
>
> Confirmed, thanks.

Thanks.  Merging this bug with Bug#40336.

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.