GNU bug report logs - #40332
28.0.50; dired-readin binds inhibit-modification-hooks

Previous Next

Package: emacs;

Reported by: Štěpán Němec <stepnem <at> gmail.com>

Date: Mon, 30 Mar 2020 19:20:01 UTC

Severity: normal

Found in version 28.0.50

Fixed in version 28.1

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: casouri <at> gmail.com, stepnem <at> gmail.com, 40332 <at> debbugs.gnu.org
Subject: bug#40332: 28.0.50; dired-readin binds inhibit-modification-hooks
Date: Tue, 31 Mar 2020 11:13:27 -0400
>> +      ;; We used to bind `inhibit-modification-hooks' to try and speed up
>> +      ;; execution, in particular, to prevent the font-lock hook from running
>> +      ;; until the directory is all read in.
>> +      ;; I strongly suspect that this was only useful in Emacs<21, because
>> +      ;; jit-lock made it a non-issue.
>> +      ;; Nevertheless, I used `combine-change-calls' which provides the
>> +      ;; same performance advantages, just in case.
>
> FWIW, according to "git log", the change which introduced
> inhibit-modification-hooks was made by RMS in Dec 2008, so it's
> unlikely that had anything to do with Emacs before v21.  Maybe we
> should augment that part of the comment?

Sounds right, yes,


        Stefan





This bug report was last modified 5 years and 48 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.