GNU bug report logs - #40332
28.0.50; dired-readin binds inhibit-modification-hooks

Previous Next

Full log

Message #16 received at 40332 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: casouri <at> gmail.com, stepnem <at> gmail.com, 40332 <at> debbugs.gnu.org
Subject: Re: bug#40332: 28.0.50; dired-readin binds inhibit-modification-hooks
Date: Tue, 31 Mar 2020 17:40:31 +0300

> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Date: Mon, 30 Mar 2020 15:47:17 -0400
> Cc: 40332-done <at> debbugs.gnu.org, Yuan Fu <casouri <at> gmail.com>
> 
> +      ;; We used to bind `inhibit-modification-hooks' to try and speed up
> +      ;; execution, in particular, to prevent the font-lock hook from running
> +      ;; until the directory is all read in.
> +      ;; I strongly suspect that this was only useful in Emacs<21, because
> +      ;; jit-lock made it a non-issue.
> +      ;; Nevertheless, I used `combine-change-calls' which provides the
> +      ;; same performance advantages, just in case.

FWIW, according to "git log", the change which introduced
inhibit-modification-hooks was made by RMS in Dec 2008, so it's
unlikely that had anything to do with Emacs before v21.  Maybe we
should augment that part of the comment?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.