From unknown Sun Jun 15 01:05:18 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#40332 <40332@debbugs.gnu.org> To: bug#40332 <40332@debbugs.gnu.org> Subject: Status: 28.0.50; dired-readin binds inhibit-modification-hooks Reply-To: bug#40332 <40332@debbugs.gnu.org> Date: Sun, 15 Jun 2025 08:05:18 +0000 retitle 40332 28.0.50; dired-readin binds inhibit-modification-hooks reassign 40332 emacs submitter 40332 =C5=A0t=C4=9Bp=C3=A1n N=C4=9Bmec severity 40332 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 30 15:19:45 2020 Received: (at submit) by debbugs.gnu.org; 30 Mar 2020 19:19:46 +0000 Received: from localhost ([127.0.0.1]:35079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jIzwn-00017Q-GW for submit@debbugs.gnu.org; Mon, 30 Mar 2020 15:19:45 -0400 Received: from lists.gnu.org ([209.51.188.17]:52804) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jIzwk-00017H-Ax for submit@debbugs.gnu.org; Mon, 30 Mar 2020 15:19:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53921) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIzwj-0007RT-3G for bug-gnu-emacs@gnu.org; Mon, 30 Mar 2020 15:19:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jIzwg-0007Li-Us for bug-gnu-emacs@gnu.org; Mon, 30 Mar 2020 15:19:39 -0400 Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]:41948) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jIzwg-0007L3-Nm for bug-gnu-emacs@gnu.org; Mon, 30 Mar 2020 15:19:38 -0400 Received: by mail-lj1-x233.google.com with SMTP id n17so19388223lji.8 for ; Mon, 30 Mar 2020 12:19:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:user-agent:date:message-id:mime-version :content-transfer-encoding; bh=JdVlatu8Ennv5YzQMdzK4yJhON6APdam7p1zouJbTCU=; b=bfx7SpZbPXXjxeLsFPOYNo1wzThEqgTAm9awlkGwblA3vy/u8SX/T3BhePBLRCvMAV u1nDt+EFApXz1Jh6HfXuDyUhurns1sELLGg9w5uFdOYWcgHGtx+jWNkqNkm/VIuqJPAD JcTrQuH4R/1j/zapoLRGR6NFh+OHLq1qfPe/xw6q/eT4Kpy1MJa7SugjiBlilP6uaWBl p6t87iXmX2yGF3w6X54QYNHUSEo3mAd0QfNOoD77AyTYy58s2hVa/mgrkFPmjk4FHnxU S71GXqf6D16lA2t7XMLPUZXs2ZHbUY5orq65VgNj98ztyy1aK5jNWtymdjuBa0Ns3evW /bgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:user-agent:date:message-id :mime-version:content-transfer-encoding; bh=JdVlatu8Ennv5YzQMdzK4yJhON6APdam7p1zouJbTCU=; b=Fk1FizfSEz1/Uar1Y7SPAxy7HTRNTqIrpRl7VYMkty+2h4SrKk4Nyfp5tpwNu1z+XY FDFZ7/Vx93ndgnWyJrdq1WsFWWlaiWmJsA0Bv5lQwuSJGR9+neAr7j5jVZzENxoYRn2N YE27lynK7A+AnIKL7rFI+4wig4lgjWQ6KAf4npdfY9gp3exYpO5K7tPDfHn+bv2SfA9r UXYjhF1sR82D1eaA3RbcA1WizCTCTGD7Bl3i+GO02jRUBNAPsWd7UWSMW2D8DVnVjZRO 8gye2VsqaMdlY2Bi2glIKDv28z6yX8Y2TzA84kDn0pKacYQbutmzYEbkzWCUVfVTUCcq dlxg== X-Gm-Message-State: AGi0Pub3bJTT7BIogj+IrRzlTVRx31sY5kA+s5Vn1LswIXNx3KtiE0gO Jcobgk2QSfjAwFnVuVCrOrUcy6xl X-Google-Smtp-Source: APiQypLeFw38xmtd5TDCA4tEKMQuN+LcH0JPY3sS2mYjMsEwP24g5FMg/jWBxyi7ijNcCwb6W1snAg== X-Received: by 2002:a2e:878a:: with SMTP id n10mr7891086lji.130.1585595976984; Mon, 30 Mar 2020 12:19:36 -0700 (PDT) Received: from localhost ([185.112.167.47]) by smtp.gmail.com with ESMTPSA id v79sm8162672lfa.21.2020.03.30.12.19.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 12:19:36 -0700 (PDT) From: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= To: bug-gnu-emacs@gnu.org Subject: 28.0.50; dired-readin binds inhibit-modification-hooks User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/28.0.50 (x86_64-pc-linux-gnu) Date: Mon, 30 Mar 2020 21:20:04 +0200 Message-ID: <87k131myzf.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::233 X-Spam-Score: 2.3 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: `dired-readin' binds `inhibit-modification-hooks' to t, so the buffer changes caused by populating dired buffers are not noticeable in `after-change-functions'. A practical example of the problem: https://gitlab.com/stepnem/stripes-el/-/issues/1#note_309176403 Content analysis details: (2.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: gnu.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stepnem[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [209.51.188.17 listed in list.dnswl.org] 2.0 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) `dired-readin' binds `inhibit-modification-hooks' to t, so the buffer changes caused by populating dired buffers are not noticeable in `after-change-functions'. A practical example of the problem: https://gitlab.com/stepnem/stripes-el/-/issues/1#note_309176403 Related discussion: https://lists.gnu.org/archive/html/emacs-devel/2020-03/msg00921.html In GNU Emacs 28.0.50 (build 16, x86_64-pc-linux-gnu, GTK+ Version 3.24.14, = cairo version 1.17.3) of 2020-03-28 built on lenora Repository revision: e27b8882e3969412876561af8fd30144820ec81a Repository branch: master --=20 =C5=A0t=C4=9Bp=C3=A1n From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 30 15:47:28 2020 Received: (at 40332-done) by debbugs.gnu.org; 30 Mar 2020 19:47:28 +0000 Received: from localhost ([127.0.0.1]:35103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJ0Nc-0001rA-43 for submit@debbugs.gnu.org; Mon, 30 Mar 2020 15:47:28 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:12119) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJ0Na-0001qw-6j for 40332-done@debbugs.gnu.org; Mon, 30 Mar 2020 15:47:26 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id C189F100660; Mon, 30 Mar 2020 15:47:20 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 2AE41100473; Mon, 30 Mar 2020 15:47:19 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1585597639; bh=1q4mkntThh3DVFrpKrmjK3NPXjCuqvJQeDH3pcJZ/JI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Qm/gMvBRX4qfMOWfvJIwlpgNSu/1HQ6W9eByFp/iruaeSfpdCGyPIFYC3UXdlQm3k qsvTcXd6pvs/FT8LpQkIKt1Y0kqZvRZXSN4vZzo0hT/30bC2BW/TkN0UYw90dcxUqy iaYkZe+eTXJDryhY3m98+/YGDbbU2jbev6+oCnU5zA1o85E/2cUzCB887dshwQWyfS zP0DXaP/6LeSLKXZV09D7D8+mmKLPGNimuai+zvUrrnLZoxBVji5g3naihYdFWT+US 3aOaeJRXMuW63X23pvR+6EpGjsNr7wQhjlOoyJOEKE4vpTLNx8MT5XQ/+PifU9YHI0 Vjom7QNPeJkNg== Received: from alfajor (unknown [104.247.241.114]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9B8EF1208C1; Mon, 30 Mar 2020 15:47:18 -0400 (EDT) From: Stefan Monnier To: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= Subject: Re: bug#40332: 28.0.50; dired-readin binds inhibit-modification-hooks Message-ID: References: <87k131myzf.fsf@gmail.com> Date: Mon, 30 Mar 2020 15:47:17 -0400 In-Reply-To: <87k131myzf.fsf@gmail.com> (=?utf-8?B?IsWgdMSbcMOhbiBOxJtt?= =?utf-8?B?ZWMiJ3M=?= message of "Mon, 30 Mar 2020 21:20:04 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.110 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 40332-done Cc: 40332-done@debbugs.gnu.org, Yuan Fu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Version: 28.1 > `dired-readin' binds `inhibit-modification-hooks' to t, so the buffer > changes caused by populating dired buffers are not noticeable in > `after-change-functions'. Indeed, thanks. I just installed into `master` the patch below which should fix this problem. Can you confirm it works for you? Stefan diff --git a/lisp/dired.el b/lisp/dired.el index b66bb03471..d58c37be2f 100644 --- a/lisp/dired.el +++ b/lisp/dired.el @@ -1208,15 +1208,11 @@ dired-readin ;; default-directory and dired-actual-switches must be buffer-local ;; and initialized by now. - (let (dirname - ;; This makes read-in much faster. - ;; In particular, it prevents the font lock hook from running - ;; until the directory is all read in. - (inhibit-modification-hooks t)) - (if (consp dired-directory) - (setq dirname (car dired-directory)) - (setq dirname dired-directory)) - (setq dirname (expand-file-name dirname)) + (let ((dirname + (expand-file-name + (if (consp dired-directory) + (car dired-directory) + dired-directory)))) (save-excursion ;; This hook which may want to modify dired-actual-switches ;; based on dired-directory, e.g. with ange-ftp to a SysV host @@ -1226,17 +1222,25 @@ dired-readin (setq buffer-undo-list nil)) (setq-local file-name-coding-system (or coding-system-for-read file-name-coding-system)) - (let ((inhibit-read-only t) - ;; Don't make undo entries for readin. - (buffer-undo-list t)) - (widen) - (erase-buffer) - (dired-readin-insert)) - (goto-char (point-min)) - ;; Must first make alist buffer local and set it to nil because - ;; dired-build-subdir-alist will call dired-clear-alist first - (setq-local dired-subdir-alist nil) - (dired-build-subdir-alist) + (widen) + ;; We used to bind `inhibit-modification-hooks' to try and speed up + ;; execution, in particular, to prevent the font-lock hook from running + ;; until the directory is all read in. + ;; I strongly suspect that this was only useful in Emacs<21, because + ;; jit-lock made it a non-issue. + ;; Nevertheless, I used `combine-change-calls' which provides the + ;; same performance advantages, just in case. + (combine-change-calls (point-min) (point-max) + (let ((inhibit-read-only t) + ;; Don't make undo entries for readin. + (buffer-undo-list t)) + (erase-buffer) + (dired-readin-insert)) + (goto-char (point-min)) + ;; Must first make alist buffer local and set it to nil because + ;; dired-build-subdir-alist will call dired-clear-alist first + (setq-local dired-subdir-alist nil) + (dired-build-subdir-alist)) (let ((attributes (file-attributes dirname))) (if (eq (car attributes) t) (set-visited-file-modtime (file-attribute-modification-time From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 30 16:03:11 2020 Received: (at 40332) by debbugs.gnu.org; 30 Mar 2020 20:03:12 +0000 Received: from localhost ([127.0.0.1]:35130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJ0cp-0002IZ-LC for submit@debbugs.gnu.org; Mon, 30 Mar 2020 16:03:11 -0400 Received: from mail-lj1-f182.google.com ([209.85.208.182]:37781) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJ0cm-0002IE-Td for 40332@debbugs.gnu.org; Mon, 30 Mar 2020 16:03:10 -0400 Received: by mail-lj1-f182.google.com with SMTP id r24so19552913ljd.4 for <40332@debbugs.gnu.org>; Mon, 30 Mar 2020 13:03:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-transfer-encoding; bh=Vm8ar1PJMUVFtIx9T/JINMn2BmItskT3wDAnoxkkn/U=; b=Laerm7QlDnA1fPIVaqFlvD77/90Plv4OY88yN6+s3l+MeF5nxYdIB++G3NgjhGnkRE YbP35OEa6d2IiwIKGKR4p96jqci5hNnUi7xsYJxbjZxdjnrjijclUNf/Fzh/Kqa1Qyyc m9fZrYl9iViRmSgjTW68ysrqqFTNy123eODarE4BRyOpPrdi6V88R6Nu6wyOXa+YQgZU xGomK0RsMsNdYeQ5DjqCP8Rlh+SpNoXWwAn5phi7fqxbDn0MRn4az99POQfgagmBDc1e FdChqJ14XhdOsuZQv65Wwnj3EDxTT81Q4yGkWZxZi27zNJX3VF5AHCnQtfmBNsOhAYtB b3yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-transfer-encoding; bh=Vm8ar1PJMUVFtIx9T/JINMn2BmItskT3wDAnoxkkn/U=; b=n06zTQDpHRNXYBrPm6DAgbPxOhsMcOrHNSk6nueFX2xdbuWcEplFKUNacStB6MIY4m 2AJScjjokUdyHjgdNs7fljJANm3sdT/FLNrURutMXp93Ji4qDVcbTtQUgNcqh6Na85cr CrhN9amPfD0c55OsMQhw+D+pbuHN8BtwaCjfgywC/tA79V87srk5ZjXg9vNmPMVzg+Y7 gsOaOurT3JKnc4Q6gzImwwvuWMZeZKbnb6sUdfCQEYvRgoGSBK9H7bouwiodaEShePcx mCb0zrOnAoL3VtVMS0lRAl4Sw5rgi3wRgxuyvpbS0GbYBi8oPPnTw2mJ6HusKzzP9O8L MJoQ== X-Gm-Message-State: AGi0PuY/wQwWB8iojNpldpxaXR3hrdlcLb25QuyIPXvVLYJHg0hy5n14 lRiZVYunkvbMXS2zmLkvwRc= X-Google-Smtp-Source: APiQypJ4Ua3rv81GJKGY2/Vq4BrPJhMinc3nzbtQcA00vzEXv7/MlXiXDn3nqde1bBGIuijCJGG7Cg== X-Received: by 2002:a2e:3203:: with SMTP id y3mr5772212ljy.54.1585598582839; Mon, 30 Mar 2020 13:03:02 -0700 (PDT) Received: from localhost ([185.112.167.47]) by smtp.gmail.com with ESMTPSA id b21sm7234103ljj.46.2020.03.30.13.03.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 13:03:02 -0700 (PDT) From: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= To: monnier@iro.umontreal.ca Subject: Re: bug#40332: 28.0.50; dired-readin binds inhibit-modification-hooks In-Reply-To: (Stefan Monnier's message of "Mon, 30 Mar 2020 15:47:17 -0400") References: <87k131myzf.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Mon, 30 Mar 2020 22:03:30 +0200 Message-ID: <87369pmwz1.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40332 Cc: Yuan Fu , 40332@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, 30 Mar 2020 15:47:17 -0400 Stefan Monnier wrote: > I just installed into `master` the patch below which should fix this > problem. > > Can you confirm it works for you? Confirmed, thank you! --=20 =C5=A0t=C4=9Bp=C3=A1n From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 31 10:40:26 2020 Received: (at 40332) by debbugs.gnu.org; 31 Mar 2020 14:40:26 +0000 Received: from localhost ([127.0.0.1]:36770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJI42-00066H-Df for submit@debbugs.gnu.org; Tue, 31 Mar 2020 10:40:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJI41-000662-9Z for 40332@debbugs.gnu.org; Tue, 31 Mar 2020 10:40:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39476) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jJI3v-0002Cd-Rx; Tue, 31 Mar 2020 10:40:19 -0400 Received: from [176.228.60.248] (port=2438 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jJI3v-0001Dj-6C; Tue, 31 Mar 2020 10:40:19 -0400 Date: Tue, 31 Mar 2020 17:40:31 +0300 Message-Id: <83lfng1tb4.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Mon, 30 Mar 2020 15:47:17 -0400) Subject: Re: bug#40332: 28.0.50; dired-readin binds inhibit-modification-hooks References: <87k131myzf.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40332 Cc: casouri@gmail.com, stepnem@gmail.com, 40332@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Stefan Monnier > Date: Mon, 30 Mar 2020 15:47:17 -0400 > Cc: 40332-done@debbugs.gnu.org, Yuan Fu > > + ;; We used to bind `inhibit-modification-hooks' to try and speed up > + ;; execution, in particular, to prevent the font-lock hook from running > + ;; until the directory is all read in. > + ;; I strongly suspect that this was only useful in Emacs<21, because > + ;; jit-lock made it a non-issue. > + ;; Nevertheless, I used `combine-change-calls' which provides the > + ;; same performance advantages, just in case. FWIW, according to "git log", the change which introduced inhibit-modification-hooks was made by RMS in Dec 2008, so it's unlikely that had anything to do with Emacs before v21. Maybe we should augment that part of the comment? From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 31 11:13:42 2020 Received: (at 40332) by debbugs.gnu.org; 31 Mar 2020 15:13:42 +0000 Received: from localhost ([127.0.0.1]:36806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJIaE-00073W-Gf for submit@debbugs.gnu.org; Tue, 31 Mar 2020 11:13:42 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:9895) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJIaC-00073E-D9 for 40332@debbugs.gnu.org; Tue, 31 Mar 2020 11:13:40 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 2B67F81234; Tue, 31 Mar 2020 11:13:35 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B881181367; Tue, 31 Mar 2020 11:13:29 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1585667609; bh=ELoehrrPTXSA3yjRTvzxZgdGQLtoV82SdfMa6P5isGU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=QENJ94wg4Hr8juORk3Wf3rJr7NGStOws9g2vNyqpWjdJ77G4SxzMdaZzc3uC8OUHR zG1EjzqlJgzboWHpQzBIjJjD6cCce4CkYSLulvmOrZ2sIoFmJGvFx2X2+JKOsN+F9g Xayz8pZly6lmpIZggou012RSqT8xr4IPkKbhqIPhh2RtR6FEladh4BT3ZX61pG4DhT 0VP+CE8wqxjKOTtBmzeNZsRLEbwEKzSFbeH23YTlVNCC/ALqL6/sMy/2+w1NQpRFBE XgAvPksKHFfdCqGjNm241TSks+EjKNC2XArCswwfzjkKgGFiC+5xUaz3FRn0Bt3hhL qc+M7wWTlKIlg== Received: from alfajor (unknown [104.247.241.114]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7C7D71202AC; Tue, 31 Mar 2020 11:13:29 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#40332: 28.0.50; dired-readin binds inhibit-modification-hooks Message-ID: References: <87k131myzf.fsf@gmail.com> <83lfng1tb4.fsf@gnu.org> Date: Tue, 31 Mar 2020 11:13:27 -0400 In-Reply-To: <83lfng1tb4.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 31 Mar 2020 17:40:31 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.143 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 40332 Cc: casouri@gmail.com, stepnem@gmail.com, 40332@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> + ;; We used to bind `inhibit-modification-hooks' to try and speed up >> + ;; execution, in particular, to prevent the font-lock hook from running >> + ;; until the directory is all read in. >> + ;; I strongly suspect that this was only useful in Emacs<21, because >> + ;; jit-lock made it a non-issue. >> + ;; Nevertheless, I used `combine-change-calls' which provides the >> + ;; same performance advantages, just in case. > > FWIW, according to "git log", the change which introduced > inhibit-modification-hooks was made by RMS in Dec 2008, so it's > unlikely that had anything to do with Emacs before v21. Maybe we > should augment that part of the comment? Sounds right, yes, Stefan From unknown Sun Jun 15 01:05:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 29 Apr 2020 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator