GNU bug report logs - #40320
[PATCH 1/2] gnu: Add libqalculate

Previous Next

Full log

Message #14 received at 40320 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: R Veera Kumar <vkor <at> vkten.in>
Cc: 40320 <at> debbugs.gnu.org
Subject: Re: [bug#40320] [PATCH 2/2] gnu: Add qalculate-gtk
Date: Mon, 30 Mar 2020 12:50:13 +0200

[Message part 1 (text/plain, inline)]

> +  (let ((commit "87f78ab3d7ed0dedf56edc38242d559ac07b1330")
> +        (revision "1"))
> +    (package
> +      (name "qalculate-gtk")
> +      (version (git-version "3.8.0" revision commit))

Same as in libqalculate, please use the git tag "v3.8.0" instead.

> +         ("automake" ,automake)
> +         ("autoconf" ,autoconf)

Why?

> +           (add-before 'check 'update-po-files ;; to pass po check

Please use just one semicolon for this kind of comment.
Maybe also include the error message one would get otherwise, as a comment.

> +             (lambda _
> +               (with-output-to-file "po/POTFILES.skip"
> +                 (lambda _ (format #t "data/shortcuts.ui~%"))))))))

Please end the phase in #t.

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.