Subject: bug#40318: closed (Re: [bug#40318] [PATCH] gnu: Add tuir.)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 05 Apr 2020 06:46:02 +0000

Your bug report

#40318: [PATCH] gnu: Add tuir.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
40318: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40318
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#40318] [PATCH] gnu: Add tuir.
From: Efraim Flashner <[email-masked]>
To: Marius Bakke <[email-masked]>
Cc: [email-masked]
Date: Sun, 5 Apr 2020 09:44:49 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

On Thu, Apr 02, 2020 at 07:14:25PM +0200, Marius Bakke wrote:
> Efraim Flashner <[email-masked]> writes:
> 
> > * gnu/packages/syndication.scm (tuir): New variable.
> 
> [...]
> 
> > +    (build-system python-build-system)
> > +    (arguments
> > +     `(#:phases
> > +       (modify-phases %standard-phases
> > +         (replace 'check
> > +           (lambda* (#:key inputs outputs #:allow-other-keys)
> > +             (add-installed-pythonpath inputs outputs)
> > +             (invoke "py.test" "-v"))))))
> > +    (propagated-inputs
> > +     `(("python-beautifulsoup4" ,python-beautifulsoup4)
> > +       ("python-decorator" ,python-decorator)
> > +       ("python-kitchen" ,python-kitchen)
> > +       ("python-requests" ,python-requests)
> > +       ("python-six" ,python-six)))
> 
> As this is a terminal application, I guess these inputs can be regular
> inputs instead of propagated?  The 'wrap' phase should take care of
> things automatically.
> 

Good call, I forgot about that one.

> Also note that "py.test" is deprecated and one is supposed to use just
> "pytest" nowadays IIRC.

TIL. I was working from their test suite command.

Patch pushed.

-- 
Efraim Flashner   <[email-masked]>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Subject: [PATCH] gnu: Add tuir.
From: Efraim Flashner <[email-masked]>
To: [email-masked]
Cc: Efraim Flashner <[email-masked]>
Date: Sun, 29 Mar 2020 17:23:00 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/syndication.scm (tuir): New variable.
---
 gnu/packages/syndication.scm | 41 +++++++++++++++++++++++++++++++++++-
 1 file changed, 40 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/syndication.scm b/gnu/packages/syndication.scm
index a84281364f..7e62636835 100644
--- a/gnu/packages/syndication.scm
+++ b/gnu/packages/syndication.scm
@@ -1,5 +1,5 @@
 ;;; GNU Guix --- Functional package management for GNU
-;;; Copyright © 2016, 2017, 2019 Efraim Flashner <[email-masked]>
+;;; Copyright © 2016, 2017, 2019, 2020 Efraim Flashner <[email-masked]>
 ;;; Copyright © 2018, 2019 Tobias Geerinckx-Rice <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
@@ -136,3 +136,42 @@ It started life as a fork of the currently unmaintained Newsbeuter.")
      "RTV provides a text-based interface to view and interact with Reddit.")
     (license (list license:expat
                    license:gpl3+)))) ; rtv/packages/praw
+
+(define-public tuir
+  (package
+    (name "tuir")
+    (version "1.28.3")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "tuir" version))
+        (sha256
+         (base32
+          "1gpyjrl7jdfjq30m32nzh59ajv91gq19l93jjri2wsv5yrf90hdr"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (add-installed-pythonpath inputs outputs)
+             (invoke "py.test" "-v"))))))
+    (propagated-inputs
+     `(("python-beautifulsoup4" ,python-beautifulsoup4)
+       ("python-decorator" ,python-decorator)
+       ("python-kitchen" ,python-kitchen)
+       ("python-requests" ,python-requests)
+       ("python-six" ,python-six)))
+    (native-inputs
+     `(("python-coverage" ,python-coverage)
+       ("python-coveralls" ,python-coveralls)
+       ("python-mock" ,python-mock)
+       ("python-pylint" ,python-pylint)
+       ("python-pytest" ,python-pytest)
+       ("python-vcrpy" ,python-vcrpy)))
+    (home-page "https://gitlab.com/ajak/tuir")
+    (synopsis "Terminal viewer for Reddit (Terminal UI for Reddit)")
+    (description
+     "Tuir provides a simple terminal viewer for Reddit (Terminal UI for Reddit).")
+    (license (list license:expat
+                   license:gpl3+))))    ; tuir/packages/praw
-- 
2.26.0