GNU bug report logs - #40301
[PATCH] gnu: Add emacs-psc-ide.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#40301: closed ([PATCH] gnu: Add emacs-psc-ide.)
Date: Sun, 12 Apr 2020 09:05:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 12 Apr 2020 11:04:08 +0200
with message-id <87sgh913ef.fsf <at> nicolasgoaziou.fr>
and subject line Re: [bug#40301] [PATCH] Fixed some issues with the patches.
has caused the debbugs.gnu.org bug report #40301,
regarding [PATCH] gnu: Add emacs-psc-ide.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
40301: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40301
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: John Soo <jsoo1 <at> asu.edu>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-psc-ide.
Date: Sat, 28 Mar 2020 18:11:01 -0700

[Message part 3 (text/plain, inline)]

Hi Guix,

psd-ide is an indispensable part of my PureScript workflow.

Thanks!

John

[0001-gnu-Add-emacs-psc-ide.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 40301-done <at> debbugs.gnu.org
Subject: Re: [bug#40301] [PATCH] Fixed some issues with the patches.
Date: Sun, 12 Apr 2020 11:04:08 +0200

Hello,

John Soo <jsoo1 <at> asu.edu> writes:

> Ok I added the revision and the commit and used git-version and
> git-file-name. As an aside, what does the revision mean? Maybe if I
> really understand it I can submit better patches in the future.

If there is no proper versioning for the package (e.g., no releases, or
version strings hidden in a source file), we have to rely on commit
hashes. But commit hashes are not monotonic. So, if you package, e.g.,
"emacs-psc-ide" with commit "bbbb", and later, update it to include
latest commit "aaaa", you have, from Guix's point of view, downgraded
the package, even though "aaaa" is more advanced than "bbbb".

The revision number solves that. Each time you update the commit
message, you increase the revision number, so you releases are
monotonic. E.g., your first package will be "emacs-psc-ide-1-bbbb", and
the other "emacs-psc-ide-2-aaaa".

> Subject: [PATCH] gnu: Add emacs-psc-ide.
>
> * gnu/packages/emacs-xyz.scm (emacs-psc-ide): New variable.

Thank you. Applied as 8a00a2202ef2a0a0173e17479359370f5656ecd0.

Regards,

-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.