GNU bug report logs -
#40301
[PATCH] gnu: Add emacs-psc-ide.
Previous Next
Reported by: John Soo <jsoo1 <at> asu.edu>
Date: Mon, 30 Mar 2020 02:36:11 UTC
Severity: normal
Tags: patch
Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Bug is archived. No further changes may be made.
Full log
View this message in rfc822 format
Hello,
John Soo <jsoo1 <at> asu.edu> writes:
> I rebased these commits on master, moved the build-system field up, and
> put the sha string on the same line as base32. I also moved the
> definition further up in the file to avoid conflicts.
Thank you!
> +(define-public emacs-psc-ide
> + (package
> + (name "emacs-psc-ide")
> + (version "0.0.0")
According to "Version:" keyword in "psc-ide.el", it is "0.1.0". Also,
you need to add a revision number, "0", or "1" at this point.
> + (source
> + (origin
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://github.com/purescript-emacs/psc-ide-emacs")
> + (commit "7fc2b841be25f5bc5e1eb7d0634436181c38b3fe")))
The commit should be moved in a top-level `let' at the beginning of the
package definition.
> + (file-name (git-file-name name "0.0.0"))
This should use version, along with the revision number.
> + (synopsis "Emacs integration for PureScript's psc-ide tool")
> + (description
> + "Emacs integration for PureScript's psc-ide tool. Featuring:
Description should be made of full sentences. Also, it might be useful
to explain what "psc-ide" tool is.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
This bug report was last modified 5 years and 119 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.