From jsoo1@asu.edu Sat Mar 28 21:11:07 2020 Received: (at submit) by debbugs.gnu.org; 30 Mar 2020 02:35:34 +0000 Received: from lists.gnu.org ([209.51.188.17]:45264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jIMTj-0005js-E8 for submit@debbugs.gnu.org; Sat, 28 Mar 2020 21:11:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52822) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIMTi-0007X7-7A for guix-patches@gnu.org; Sat, 28 Mar 2020 21:11:07 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jIMTg-0005qp-G9 for guix-patches@gnu.org; Sat, 28 Mar 2020 21:11:05 -0400 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]:35722) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jIMTg-0005qb-9M for guix-patches@gnu.org; Sat, 28 Mar 2020 21:11:04 -0400 Received: by mail-pl1-x630.google.com with SMTP id c12so2321343plz.2 for ; Sat, 28 Mar 2020 18:11:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=asu-edu.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:mime-version; bh=jN9Q8MyBrCTCCVsKn2/AlMjXrBwAtRstaPDF+PIeJw4=; b=H8Q0xV23dGjt6gYvkkR5WO5ycHYVBpzUDnF8MSASPUe5e3MjyJIRgxZHeiebPYwR4/ N4OWeg6vRsWv1DeaEUKJjT1T3YW9EoQBGJGa2t/mACnuZskId+IN+fXrN0T3RlTyGCmT RAXUqlGQcFizyNDkIov1+FY6r6oyK5Kr9cPIbO2KBF5pIt8m1bbLhVgCnYe2p6LgM43e xugdO/o0QbWfsU+o0KhyfbXP1wXPxpI/fbQUEYzReUAfletIJZNsN6V3iBdfP2aLByvI CbZHe6z7fSbswK57sWG8IslYL0Ou3unyIvxaBdoSK4JJnkdp5r0Vx9LT9TkxacfEuvQt +95A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=jN9Q8MyBrCTCCVsKn2/AlMjXrBwAtRstaPDF+PIeJw4=; b=GDg1T8YaKpjJL6ekcGIiB1eL9RbY0sBWMyE05CRvDNkbleDF+5o1V9npe12XDwEkTS VxMDlxekeb2A1S7rQJxZCZEzKwKk1QrrXqD8L/3DK0ENysQjRwlyauEC3zzeAeacaQc+ CJpZWg+k/dMhfi/Tq1iRyXOLeD2EGYhytmjq/len9jsez5zwdye8IBywRzV7IrPM/rVW L7DUJMcMfrYGUQEBNg8/YZIDFfvO9kOyovLL4GQURvUCoQOpAuFeAbfP5WudgZCvwopd ovz7/lWr+lt2TOEWTl2SD5DzLxBpFtTfEwrb1yI3/xH/MwNLB4JI9vxwQ85rP0G3DDJT Qqfw== X-Gm-Message-State: ANhLgQ2Prd7HBCXORCi2OZlierL4wNaysJ93zyIjAnPTno1mSoQXYh7D TKRAYw1jYhQv2yTclKLIFrAmnIropbg= X-Google-Smtp-Source: ADFU+vtS9Qq+/5OF9i5YtfJ5PUi0FI2dBkyZdCUdgNjPXqd4aKGsgp2C94LiTN7y89glqWK4hRfvmQ== X-Received: by 2002:a17:90a:c482:: with SMTP id j2mr7857225pjt.71.1585444262860; Sat, 28 Mar 2020 18:11:02 -0700 (PDT) Received: from ecenter ([2600:1700:83b0:8bd0::6c3]) by smtp.gmail.com with ESMTPSA id d7sm7027089pfo.86.2020.03.28.18.11.02 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 28 Mar 2020 18:11:02 -0700 (PDT) From: John Soo To: guix-patches@gnu.org Subject: [PATCH] gnu: Add emacs-psc-ide. Date: Sat, 28 Mar 2020 18:11:01 -0700 Message-ID: <87h7y82cey.fsf@asu.edu> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::630 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Mar 2020 01:11:08 -0000 --=-=-= Content-Type: text/plain Hi Guix, psd-ide is an indispensable part of my PureScript workflow. Thanks! John --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-gnu-Add-emacs-psc-ide.patch Content-Transfer-Encoding: quoted-printable Content-Description: add emacs-psc-ide >>From c2001d000ffa61a4d2ae18e1f7db9b0c57923197 Mon Sep 17 00:00:00 2001 From: John Soo Date: Tue, 24 Mar 2020 07:36:28 -0700 Subject: [PATCH] gnu: Add emacs-psc-ide. * gnu/packages/emacs-xyz.scm (emacs-psc-ide): New variable. --- gnu/packages/emacs-xyz.scm | 39 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 9d40b8019e..0fa43fa4d1 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -65,6 +65,7 @@ ;;; Copyright =C2=A9 2020 Michael Rohleder ;;; Copyright =C2=A9 2020 Brice Waegeneire ;;; Copyright =C2=A9 2020 6033fe7de85d <6033fe7de85d@airmail.cc> +;;; Copyright =C2=A9 2020 John Soo ;;; ;;; This file is part of GNU Guix. ;;; @@ -21776,3 +21777,41 @@ enables modal editing and composition of commands,= too. It combines ideas of other Editors like Vim or Kakoune and tries to align them with regular Ema= cs conventions.") (license license:gpl3+))) + +(define-public emacs-psc-ide + (package + (name "emacs-psc-ide") + (version "0.0.0") + (source + (origin + (method git-fetch) + (uri + (git-reference + (url "https://github.com/purescript-emacs/psc-ide-emacs") + (commit "7fc2b841be25f5bc5e1eb7d0634436181c38b3fe"))) + (file-name (git-file-name name "0.0.0")) + (sha256 + (base32 + "0r0fymyai30jimm34z1cmav4wgij8ci6s1d9y7qigygfbbfrdsmj")))) + (inputs + `(("emacs-company" ,emacs-company) + ("emacs-dash" ,emacs-dash) + ("emacs-flycheck" ,emacs-flycheck) + ("emacs-let-alist" ,emacs-let-alist) + ("emacs-s" ,emacs-s) + ("emacs-seq" ,emacs-seq))) + (build-system emacs-build-system) + (home-page "https://github.com/purescript-emacs/psc-ide-emacs") + (synopsis "Emacs integration for PureScript's psc-ide tool") + (description + "Emacs integration for PureScript's psc-ide tool. Featuring: +@itemize +@item Completions +@item Type at point +@item Go to definition +@item Automatic imports +@item Case split +@item Build system integration +@item Flycheck support +@end itemize") + (license license:gpl3+))) --=20 2.26.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 11 12:21:39 2020 Received: (at 40301) by debbugs.gnu.org; 11 Apr 2020 16:21:39 +0000 Received: from localhost ([127.0.0.1]:57028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNIt0-0007SN-Ex for submit@debbugs.gnu.org; Sat, 11 Apr 2020 12:21:39 -0400 Received: from mail-ot1-f49.google.com ([209.85.210.49]:44710) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNIsx-0007S9-Dj for 40301@debbugs.gnu.org; Sat, 11 Apr 2020 12:21:36 -0400 Received: by mail-ot1-f49.google.com with SMTP id a49so4763850otc.11 for <40301@debbugs.gnu.org>; Sat, 11 Apr 2020 09:21:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=asu-edu.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:mime-version; bh=B/j2aKaJJjHhRrcwnA1NtbfElMnIS8ye50EP4r93qEw=; b=esDgCO7PVSAXaDBLY5ofpXm7Ct2kSi+i8GGPpv5pjQU7TO0PeD8NdGvYaXRBSVHGCb am3oCw2I+VK0kXRPYh7VnbM6WzZ0NBy8Z8t9qeXzr5g8IRF5tIyNL5VqZLfuQNNsyeRR wIk1t9AlfhaWd5gJ1CyFWntBxygjeMnQyVFJ93oINQzH2TCuOKM0Ah0b0AcziHNIMZxf Y7jDZIc6UBS8tNQSICgvLzn6cqgJ4YJNOPw63xEXhmeQ51IQ1uvKOK5GFcPTXewHxWJs exLfyUVnZu491Dd3zqLUzbvPmsbPDgTu89noO7obaoy93xvBGVbmhJiGUAitlUTXvIRk sHFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=B/j2aKaJJjHhRrcwnA1NtbfElMnIS8ye50EP4r93qEw=; b=XLpkB7X0J0W/F7Ffov6ot2wl+3+LfbNBKd/kO+9ewZs8PSb32Bt7LcbuMFLKBjy2VE mNLmMbN2Whnkp4kz2lAM8c1nVbrnTS87gBuv2sX9qOXRLExPkBqxuCczYDsscnGq2h6V h1dRs2ZCgR9MhtChIE1Fi6i7CtluASBHkrun6S+P3VfIDj0Ai97g4qxmnd80aipeHtbT 9TI/w5s9OrpR88f/tHYoaM0U5/kODlX1ZfCoIRODGyeKIhhoOmGfJEgGiqiuSXggC/go UK2lI5if8x6MmvW6jCBenN3U9crR5n9kSqa5E1BLsc1FpCZk5/n3bIDJW7f+rAi9MuVt rMqw== X-Gm-Message-State: AGi0PubvXUyE3y1HZckDZTCdZSK9uUs0bvWnKRmBaDERVNGiePBwd1YC YeWYffMmebOeRpgPSC10sH3uuS263hrUVQ== X-Google-Smtp-Source: APiQypKbMs556QfdhhA3SXZizXj7q+NqMwrteKd4PgeaIA6s8/adYOedR0fr5JyS5/FjKaXTpu+FCg== X-Received: by 2002:a9d:1c8e:: with SMTP id l14mr7057296ota.0.1586622089458; Sat, 11 Apr 2020 09:21:29 -0700 (PDT) Received: from ecenter ([2600:1700:83b0:8bd0::479]) by smtp.gmail.com with ESMTPSA id s23sm3434091ook.4.2020.04.11.09.21.28 for <40301@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 11 Apr 2020 09:21:28 -0700 (PDT) From: John Soo To: 40301@debbugs.gnu.org Subject: [PATCH] Fixed some issues with the patches. Date: Sat, 11 Apr 2020 09:21:27 -0700 Message-ID: <87o8ryq9h4.fsf@asu.edu> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40301 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hi Guix, I rebased these commits on master, moved the build-system field up, and put the sha string on the same line as base32. I also moved the definition further up in the file to avoid conflicts. Thanks! John --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-Add-emacs-psc-ide.patch >From ce0c61cbf65fbda29f5fa8ebd5c22558d71eec62 Mon Sep 17 00:00:00 2001 From: John Soo Date: Tue, 24 Mar 2020 07:36:28 -0700 Subject: [PATCH] gnu: Add emacs-psc-ide. * gnu/packages/emacs-xyz.scm (emacs-psc-ide): New variable. --- gnu/packages/emacs-xyz.scm | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index e700920266..25a854cf5a 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -12334,6 +12334,43 @@ keychains. The keychain entries are displayed in a directory-like structure and can be consulted and modified.") (license license:gpl3+))) +(define-public emacs-psc-ide + (package + (name "emacs-psc-ide") + (version "0.0.0") + (source + (origin + (method git-fetch) + (uri + (git-reference + (url "https://github.com/purescript-emacs/psc-ide-emacs") + (commit "7fc2b841be25f5bc5e1eb7d0634436181c38b3fe"))) + (file-name (git-file-name name "0.0.0")) + (sha256 + (base32 "0r0fymyai30jimm34z1cmav4wgij8ci6s1d9y7qigygfbbfrdsmj")))) + (build-system emacs-build-system) + (inputs + `(("emacs-company" ,emacs-company) + ("emacs-dash" ,emacs-dash) + ("emacs-flycheck" ,emacs-flycheck) + ("emacs-let-alist" ,emacs-let-alist) + ("emacs-s" ,emacs-s) + ("emacs-seq" ,emacs-seq))) + (home-page "https://github.com/purescript-emacs/psc-ide-emacs") + (synopsis "Emacs integration for PureScript's psc-ide tool") + (description + "Emacs integration for PureScript's psc-ide tool. Featuring: +@itemize +@item Completions +@item Type at point +@item Go to definition +@item Automatic imports +@item Case split +@item Build system integration +@item Flycheck support +@end itemize") + (license license:gpl3+))) + (define-public emacs-evil-anzu (package (name "emacs-evil-anzu") -- 2.26.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 11 15:55:46 2020 Received: (at 40301) by debbugs.gnu.org; 11 Apr 2020 19:55:46 +0000 Received: from localhost ([127.0.0.1]:57120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNMEE-00040k-Ge for submit@debbugs.gnu.org; Sat, 11 Apr 2020 15:55:46 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:4167) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNMEC-00040W-Pe for 40301@debbugs.gnu.org; Sat, 11 Apr 2020 15:55:45 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id B5738240008; Sat, 11 Apr 2020 19:55:37 +0000 (UTC) From: Nicolas Goaziou To: John Soo Subject: Re: [bug#40301] [PATCH] Fixed some issues with the patches. References: <87h7y82cey.fsf@asu.edu> <87o8ryq9h4.fsf@asu.edu> Date: Sat, 11 Apr 2020 21:55:36 +0200 In-Reply-To: <87o8ryq9h4.fsf@asu.edu> (John Soo's message of "Sat, 11 Apr 2020 09:21:27 -0700") Message-ID: <87a73h3ih3.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40301 Cc: 40301@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, John Soo writes: > I rebased these commits on master, moved the build-system field up, and > put the sha string on the same line as base32. I also moved the > definition further up in the file to avoid conflicts. Thank you! > +(define-public emacs-psc-ide > + (package > + (name "emacs-psc-ide") > + (version "0.0.0") According to "Version:" keyword in "psc-ide.el", it is "0.1.0". Also, you need to add a revision number, "0", or "1" at this point. > + (source > + (origin > + (method git-fetch) > + (uri > + (git-reference > + (url "https://github.com/purescript-emacs/psc-ide-emacs") > + (commit "7fc2b841be25f5bc5e1eb7d0634436181c38b3fe"))) The commit should be moved in a top-level `let' at the beginning of the package definition. > + (file-name (git-file-name name "0.0.0")) This should use version, along with the revision number. > + (synopsis "Emacs integration for PureScript's psc-ide tool") > + (description > + "Emacs integration for PureScript's psc-ide tool. Featuring: Description should be made of full sentences. Also, it might be useful to explain what "psc-ide" tool is. Could you send an updated patch? Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 11 20:45:59 2020 Received: (at 40301) by debbugs.gnu.org; 12 Apr 2020 00:45:59 +0000 Received: from localhost ([127.0.0.1]:57213 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNQl4-0004G0-M1 for submit@debbugs.gnu.org; Sat, 11 Apr 2020 20:45:58 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:34096) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNQl2-0004Fm-6d for 40301@debbugs.gnu.org; Sat, 11 Apr 2020 20:45:57 -0400 Received: by mail-pg1-f195.google.com with SMTP id l19so844073pgk.1 for <40301@debbugs.gnu.org>; Sat, 11 Apr 2020 17:45:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=asu-edu.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=TKzL5ifS3eSwSLyJTHm4bYObPRRHC9QK+THe0rM8ZLw=; b=ljgJbJMq1eEQo8rwDZCRCukj8EAqAaOuspkZkgmDITTeWI2+WU0eZYWFaCA2959R+/ 0v5X4DTDCxRXMXzjvXwjYxGhBYV1hCdy3C16SIMUn2+jc2YrJ8xOYzvDKQFExo3umx1F LIWLaWznKojR8wjGgEkhYddQHjeVEu4ZF4Aoa6OBiq4ahCOwIPQO+zjSaRmKLqgSXU6L OjgjxznXAAC6OocmnjpAXrpq1CHwibCl2A3Z7KmsDf+quFJ0a4fLEYErzRtb6BEDhu88 eypVX89Hanvw01wGnwq9UZcLmYp4bWuOzus0vMZvU5EqrenohgTK8PJV6arwQDsWM8R0 qp4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=TKzL5ifS3eSwSLyJTHm4bYObPRRHC9QK+THe0rM8ZLw=; b=YV0hi/JBJb/f3H0yhgI0BfnRpqkUkYl2fY/z7fysdrDb5F/tH1+7KGgCj9rv6LteYJ BbDYAr4nSG1c8EYWRSgWemLqo5keq4DIyspY6xmO+PMV09H6cO71KeT5CarE5RPPw83a SM/Xn/mU7T3Z7V/HgrNS6EQI7arw0yyESjLdds9avr3Yaq5PwXOGdkCIe1le+yf86Y1V GqQbntp5qXZtA33LkEwJ4HC6NoWLkIn8HBLDF6io9nGBHRWAQ2zTmTay0hcvWxL4mdnF 2e9vem1zpWVJB7FwgbFj/DnxYE0xRI12TY00eGeOOPI3nBpNN8w4+GP1nz2go/XLv+F/ b75A== X-Gm-Message-State: AGi0PuZ4XQjQgEeVxgZDuUqRLldAAsGgQSkdMoAuX3yFMyHqZ78dIFZ5 bH2mS3H2bI7DrUBsGNl4Dl9jVre3r1fmUQ== X-Google-Smtp-Source: APiQypJnWsfkUD5EkH9T8lS3ZK18ANPJ+xFcs40EtGT6WxQhJaH+ZH69ITifDklJgN0SQyJLX0lv3g== X-Received: by 2002:a62:e113:: with SMTP id q19mr257946pfh.107.1586652349863; Sat, 11 Apr 2020 17:45:49 -0700 (PDT) Received: from ecenter ([2600:1700:83b0:8bd0::429]) by smtp.gmail.com with ESMTPSA id k63sm1955575pjb.6.2020.04.11.17.45.47 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 11 Apr 2020 17:45:48 -0700 (PDT) From: John Soo To: Nicolas Goaziou Subject: Re: [bug#40301] [PATCH] Fixed some issues with the patches. References: <87h7y82cey.fsf@asu.edu> <87o8ryq9h4.fsf@asu.edu> <87a73h3ih3.fsf@nicolasgoaziou.fr> Date: Sat, 11 Apr 2020 17:45:47 -0700 In-Reply-To: <87a73h3ih3.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Sat, 11 Apr 2020 21:55:36 +0200") Message-ID: <87ftd9r0p0.fsf@asu.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40301 Cc: 40301@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hi Nicolas, Nicolas Goaziou writes: >> +(define-public emacs-psc-ide >> + (package >> + (name "emacs-psc-ide") >> + (version "0.0.0") > > According to "Version:" keyword in "psc-ide.el", it is "0.1.0". Also, > you need to add a revision number, "0", or "1" at this point. > ... >> + (source >> + (origin >> + (method git-fetch) >> + (uri >> + (git-reference >> + (url "https://github.com/purescript-emacs/psc-ide-emacs") >> + (commit "7fc2b841be25f5bc5e1eb7d0634436181c38b3fe"))) > > The commit should be moved in a top-level `let' at the beginning of the > package definition. > >> + (file-name (git-file-name name "0.0.0")) > > This should use version, along with the revision number. >> + (synopsis "Emacs integration for PureScript's psc-ide tool") >> + (description >> + "Emacs integration for PureScript's psc-ide tool. Featuring: Ok I added the revision and the commit and used git-version and git-file-name. As an aside, what does the revision mean? Maybe if I really understand it I can submit better patches in the future. > Description should be made of full sentences. Also, it might be useful > to explain what "psc-ide" tool is. I think I clarified the description a little. This was an excellent detailed review, thank you so much. Also, I changed inputs->propagated-inputs. Kindly, John --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-Add-emacs-psc-ide.patch Content-Description: psc-ide >From 20e7f672bb002e8e0e784300789c3e11aeabd41f Mon Sep 17 00:00:00 2001 From: John Soo Date: Tue, 24 Mar 2020 07:36:28 -0700 Subject: [PATCH] gnu: Add emacs-psc-ide. * gnu/packages/emacs-xyz.scm (emacs-psc-ide): New variable. --- gnu/packages/emacs-xyz.scm | 41 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index e700920266..530eee7eb7 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -12334,6 +12334,47 @@ keychains. The keychain entries are displayed in a directory-like structure and can be consulted and modified.") (license license:gpl3+))) +(define-public emacs-psc-ide + (let ((revision "1") + (commit "7fc2b841be25f5bc5e1eb7d0634436181c38b3fe")) + (package + (name "emacs-psc-ide") + (version (git-version "0.1.0" revision commit)) + (source + (origin + (method git-fetch) + (uri + (git-reference + (url "https://github.com/purescript-emacs/psc-ide-emacs") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0r0fymyai30jimm34z1cmav4wgij8ci6s1d9y7qigygfbbfrdsmj")))) + (build-system emacs-build-system) + (propagated-inputs + `(("emacs-company" ,emacs-company) + ("emacs-dash" ,emacs-dash) + ("emacs-flycheck" ,emacs-flycheck) + ("emacs-let-alist" ,emacs-let-alist) + ("emacs-s" ,emacs-s) + ("emacs-seq" ,emacs-seq))) + (home-page "https://github.com/purescript-emacs/psc-ide-emacs") + (synopsis "Emacs integration for PureScript's psc-ide tool") + (description + "PureScript implements an ide protocol in its compiler called psc-ide. +This package provices Emacs integration for psc-ide. It features: + +@itemize +@item Completions +@item Type at point +@item Go to definition +@item Automatic imports +@item Case split +@item Build system integration, and +@item Flycheck support +@end itemize") + (license license:gpl3+)))) + (define-public emacs-evil-anzu (package (name "emacs-evil-anzu") -- 2.26.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 12 05:04:19 2020 Received: (at 40301-done) by debbugs.gnu.org; 12 Apr 2020 09:04:19 +0000 Received: from localhost ([127.0.0.1]:57352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNYXK-0008IN-V4 for submit@debbugs.gnu.org; Sun, 12 Apr 2020 05:04:19 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:50653) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNYXI-0008I7-Tj for 40301-done@debbugs.gnu.org; Sun, 12 Apr 2020 05:04:17 -0400 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay10.mail.gandi.net (Postfix) with ESMTPSA id A888B240004; Sun, 12 Apr 2020 09:04:09 +0000 (UTC) From: Nicolas Goaziou To: John Soo Subject: Re: [bug#40301] [PATCH] Fixed some issues with the patches. References: <87h7y82cey.fsf@asu.edu> <87o8ryq9h4.fsf@asu.edu> <87a73h3ih3.fsf@nicolasgoaziou.fr> <87ftd9r0p0.fsf@asu.edu> Date: Sun, 12 Apr 2020 11:04:08 +0200 In-Reply-To: <87ftd9r0p0.fsf@asu.edu> (John Soo's message of "Sat, 11 Apr 2020 17:45:47 -0700") Message-ID: <87sgh913ef.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40301-done Cc: 40301-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, John Soo writes: > Ok I added the revision and the commit and used git-version and > git-file-name. As an aside, what does the revision mean? Maybe if I > really understand it I can submit better patches in the future. If there is no proper versioning for the package (e.g., no releases, or version strings hidden in a source file), we have to rely on commit hashes. But commit hashes are not monotonic. So, if you package, e.g., "emacs-psc-ide" with commit "bbbb", and later, update it to include latest commit "aaaa", you have, from Guix's point of view, downgraded the package, even though "aaaa" is more advanced than "bbbb". The revision number solves that. Each time you update the commit message, you increase the revision number, so you releases are monotonic. E.g., your first package will be "emacs-psc-ide-1-bbbb", and the other "emacs-psc-ide-2-aaaa". > Subject: [PATCH] gnu: Add emacs-psc-ide. > > * gnu/packages/emacs-xyz.scm (emacs-psc-ide): New variable. Thank you. Applied as 8a00a2202ef2a0a0173e17479359370f5656ecd0. Regards, -- Nicolas Goaziou From unknown Mon Aug 18 15:41:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 10 May 2020 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator