GNU bug report logs - #40300
[PATCH] gnu: Add emacs-haskell-snippets.

Previous Next

Full log

Message #17 received at 40300 <at> debbugs.gnu.org (full text, mbox):

From: John Soo <jsoo1 <at> asu.edu>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 40300 <at> debbugs.gnu.org
Subject: Re: [bug#40300] [PATCH] gnu: Add emacs-haskell-snippets.
Date: Mon, 30 Mar 2020 12:03:23 -0700

[Message part 1 (text/plain, inline)]

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> Hello,
>
> John Soo <jsoo1 <at> asu.edu> writes:
>
>> +(define-public emacs-haskell-snippets
>> +  (package
>> +    (name "emacs-haskell-snippets")
>> +    (version "0.1.0")
>
> Would it make sense to package HEAD instead. I'm looking in particular
> at upstream's commit 9e41a53f8388f2a2cf2a1bb3163bc6de764099d5.

I think so. Done.

>> +    (source
>> +     (origin
>> +       (method git-fetch)
>> +       (uri
>> +        (git-reference
>> +         (url "https://github.com/haskell/haskell-snippets")
>> +         (commit version)))
>> +       (file-name (git-file-name name version))
>> +       (sha256
>> +        (base32
>> +         "0b3d7rvqvvcsp51aqfhl0zg9zg8j0p6vlfvga6jp9xc7626vh6f6"))))
>
> Usual nitpick: please put string on the same line as `base32'.

Done.

>> +    (inputs
>> +     `(("emacs-yasnippet" ,emacs-yasnippet)))
>> +    (arguments
>> +     `(#:phases
>> +       (modify-phases %standard-phases
>> +         (add-after 'install 'install-snippets
>> +           (lambda* (#:key outputs #:allow-other-keys)
>> +             (let* ((out (assoc-ref outputs "out"))
>> +                    (snippets
>> +                     (string-append
>> +                      out "/share/emacs/site-lisp/snippets/haskell-mode")))
>> +               (mkdir-p snippets)
>> +               (copy-recursively "snippets/haskell-mode" snippets)
>> +               #t))))))
>> +    (build-system emacs-build-system)
>
> Nitpick: could you move parts in this order: build-system ->
> arguments -> inputs.

Yes I can. Done.

I also changed inputs -> propagated-inputs.

Thanks again,

John

[0001-gnu-Add-emacs-haskell-snippets.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.