From unknown Thu Aug 21 23:00:42 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#40284 <40284@debbugs.gnu.org> To: bug#40284 <40284@debbugs.gnu.org> Subject: Status: [PATCH] gnu: emacs-arduino-mode: Change to a maintained fork. Reply-To: bug#40284 <40284@debbugs.gnu.org> Date: Fri, 22 Aug 2025 06:00:42 +0000 retitle 40284 [PATCH] gnu: emacs-arduino-mode: Change to a maintained fork. reassign 40284 guix-patches submitter 40284 Evan Straw severity 40284 normal tag 40284 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 29 19:34:20 2020 Received: (at submit) by debbugs.gnu.org; 29 Mar 2020 23:34:20 +0000 Received: from localhost ([127.0.0.1]:60069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jIhRc-00083v-0N for submit@debbugs.gnu.org; Sun, 29 Mar 2020 19:34:20 -0400 Received: from lists.gnu.org ([209.51.188.17]:52115) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jIhRa-00083n-53 for submit@debbugs.gnu.org; Sun, 29 Mar 2020 19:34:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36491) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIhRY-00018e-Qs for guix-patches@gnu.org; Sun, 29 Mar 2020 19:34:17 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jIhRX-00055F-Kb for guix-patches@gnu.org; Sun, 29 Mar 2020 19:34:16 -0400 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]:43029) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jIhRX-00053X-Cs for guix-patches@gnu.org; Sun, 29 Mar 2020 19:34:15 -0400 Received: by mail-pf1-x443.google.com with SMTP id f206so7690699pfa.10 for ; Sun, 29 Mar 2020 16:34:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=JovTEyFp1P76K5vEuUou48PHYz2y9C/RjTg0cidUxFs=; b=WKxkitTAtgMGDSZI5hFQ9NwrBv5Zv833l+6euRJLrb2LAQepLG2MIE2hTK+8/ptjK8 1f8mOg/GjSSS60+Kcc64Pc9NQb9XJ+FK0Jh9yfbiWZvLQNtcdAYWodohMEK+NOVbiczZ e1BAzOFBprpRixAG5ip16rJZWD46kkT1aUUzh1JxoV792SKL5pb77V8YP/s5lyTqGftc zhwYF/+xv/H9UxP53j/2+l4QjOoQUjlsN0gXkIrxPdWMekwlA7Mps+PX4pkUZKigQR38 T2J1Zu8RsYEMwJ0tby9rScLbLddJKzCEONPVISFn6ZZQTa9rm3/FRc4zOwy0VUPN/cBP NQUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=JovTEyFp1P76K5vEuUou48PHYz2y9C/RjTg0cidUxFs=; b=Xzsemk+4W/4S2u8iHjS6J3uZJEc1x/MwbgEgdR3Q4K0+OodB6OUoOH2nBPxGB00RKX H70gJ8vjHRizY+5mniPeTWoG9oUMoKKVJOwXr6IFnVCaUcEynrgb+JosqUWq6ThfP3s3 p8BNvIOFNhGSrMUiMPCzdQiJKUmt4ILAh5KrGUEnkXKJRA19pnbFJxoCCpQyds6iw6WA TYz9pncLy9ITAmuEd/410eet2rltn3+qw47DRz2Qizw2AMiT0Y2Z3YezwyLAkCDamYMB tKaRPjFTtfA8EePMlPKl1WU7B/YJmvXe0ymddoI/P0JUGjJ51sPBlJ3W6XRtM/sGILmc 7khQ== X-Gm-Message-State: ANhLgQ1GhMciV0dpIsdnq8rjvXHOFr4hCgas5/CsVdobaCcCWTCDV+8m G7a6jhZ94x2mxnUdisymMqPVtmNU X-Google-Smtp-Source: ADFU+vtatgExvu9O0GBul+i81vf3q2yWYxbUTQWDt3L9M3YRHm4A890pp3JoO0afAyu+PYy7HO4T4w== X-Received: by 2002:aa7:988f:: with SMTP id r15mr10577525pfl.252.1585524853503; Sun, 29 Mar 2020 16:34:13 -0700 (PDT) Received: from virtualplaza ([2600:6c50:677f:fd7e:3ae1:7063:7a8d:5d31]) by smtp.gmail.com with ESMTPSA id mq6sm9065153pjb.38.2020.03.29.16.34.12 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 29 Mar 2020 16:34:12 -0700 (PDT) From: Evan Straw To: guix-patches@gnu.org Subject: [PATCH] gnu: emacs-arduino-mode: Change to a maintained fork. Date: Sun, 29 Mar 2020 16:34:10 -0700 Message-ID: <87k13220st.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::443 X-Spam-Score: 2.5 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From 603fe12010817b41a4d1e93fab6b8356cbf2f50f Mon Sep 17 00:00:00 2001 From: Evan Straw Date: Sun, 29 Mar 2020 16:27:34 -0700 Subject: [PATCH] gnu: emacs-arduino-mode: Change to a maintained fork. * gnu/packages/emacs-xyz.scm (emacs-arduino-mode): Change to a maintained fork. --- gnu/packages/emacs-xyz.scm | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) Content analysis details: (2.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (evan.straw99[at]gmail.com) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (evan.straw99[at]gmail.com) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [209.51.188.17 listed in list.dnswl.org] 2.0 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-emacs-arduino-mode-Change-to-a-maintained-fork.patch Content-Transfer-Encoding: quoted-printable Content-Description: [PATCH] gnu: emacs-arduino-mode: Change to a maintained fork. From=20603fe12010817b41a4d1e93fab6b8356cbf2f50f Mon Sep 17 00:00:00 2001 From: Evan Straw Date: Sun, 29 Mar 2020 16:27:34 -0700 Subject: [PATCH] gnu: emacs-arduino-mode: Change to a maintained fork. * gnu/packages/emacs-xyz.scm (emacs-arduino-mode): Change to a maintained fork. =2D-- gnu/packages/emacs-xyz.scm | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 782d8650dd..d23905075f 100644 =2D-- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -17092,23 +17092,34 @@ other frame parameters.") (license license:gpl3+))) =20 (define-public emacs-arduino-mode =2D (let ((commit "3e2bad4569ad26e929e6db2cbcff0d6d36812698")) ;no release= yet + (let ((commit "23ae47c9f28f559e70b790b471f20310e163a39b")) ;no release y= et (package (name "emacs-arduino-mode") (version (git-version "0" "0" commit)) (source (origin (method git-fetch) (uri (git-reference =2D (url "https://github.com/bookest/arduino-mode.git") + (url "https://github.com/stardiviner/arduino-mode.gi= t") (commit commit))) (sha256 (base32 =2D "1yvaqjc9hadbnnay5fprnh890xsp53kidad1zpb4a5z4a5z61n3c"= )) + "08vnbz9gpah1l93fzfd87aawrhcnh2v1kyfxgsn88pdwg8awz8rx")) (file-name (git-file-name name version)))) (build-system emacs-build-system) + (inputs + `(("spinner" ,emacs-spinner) + ("flycheck" ,emacs-flycheck))) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'fix-obsolete + (lambda _ + (substitute* "ede-arduino.el" + (("defmethod") "cl-defmethod") + (("defgeneric") "cl-defgeneric"))))))) (synopsis "Emacs major mode for editing Arduino sketches") (description "Emacs major mode for editing Arduino sketches.") =2D (home-page "https://github.com/bookest/arduino-mode") + (home-page "https://github.com/stardiviner/arduino-mode") (license license:gpl3+)))) =20 (define-public emacs-annalist =2D-=20 2.20.1 --=-=-= Content-Type: text/plain Hello! The Emacs Arduino mode that is currently packaged in Guix is an old, unmaintained version, and there is a newer fork of the project by the same name that has much more functionality. The patch attached to this email replaces the package emacs-arduino-mode with this newer version, which basically just amounts to changing the Git repository, hash, and commit. There's also a substitution done that stops Emacs from complaining about obsolete macros. I have no idea if this is the correct way of going about this, or if I should instead make another package with a different name to refer to the new fork of arduino-mode. Please let me know if I should change or revise anything. Thanks, -- Evan --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6f/SZXb4DLdwy+VR9TDDtKKp8G0FAl6BMHIACgkQ9TDDtKKp 8G2jZQ/+MQK6BbeSGP1yr3yfuAg6saD5cPEWQpSF3sD2je47Rh6hX6CQlE9cVEyu S/YqArlYbQwaMH6+kgm1vgzxdRNlUaDfKLsFdNeY/Z1T/EU795saIUT+6s3P52lp uQg6X86CTiq638E5WxHHdJ+/JqlFc7931AIVlU8tR+jZHJBRMAchaP3TxfgwVBD8 gjYHmlZIsnIkm3eVnw0KDvXExrhio/mPau5vvXFxc7ENtMiam2VGIb4zJkC7SHuP xP+OmOxODKl8qtqyUlRnCr0szGfFOjJ7JjsNYYbUaNwflKkylfpBFajtKQpMMxK2 RS9V894lUSsRSM/Pa7DiJ5ny+WyWVZWgSV8ccI01ZI3U8aIZ0vgUrEzdK64fzUk2 A6wKtBH3Re/O3i9gh+HU6C4lmNMnaCetpE/ZvSEXTCBcG+HWCsnoOKbKKC8blED+ fu+QOm+Ljc38MHxCeLoCSW9kqCgjUPdYbsD6BZSEtsfe+azZszs57TxYo6gHAIkb 2MOmhouB4VHK6Jm+fBG4hzx22b6pPpI9sWGmsjp5HmXKDz+24LYHQnhTjG4X4ZTF iWc1NnvSdKifBgnl/xc87SfjZeBXO6+5RXq9ZHJveOvY6FNFXP8cfE7GoD7KUcAL +dGRngDFntiu+xq3zWBhDOKKMQdIrW2kGsD1rLG9OxhbfCfsWzQ= =LMBy -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 29 19:59:18 2020 Received: (at 40284) by debbugs.gnu.org; 29 Mar 2020 23:59:18 +0000 Received: from localhost ([127.0.0.1]:60074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jIhpm-0000Eu-2a for submit@debbugs.gnu.org; Sun, 29 Mar 2020 19:59:18 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:56185) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jIhpj-0000Eg-O1 for 40284@debbugs.gnu.org; Sun, 29 Mar 2020 19:59:16 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 7642D60005; Sun, 29 Mar 2020 23:59:08 +0000 (UTC) From: Nicolas Goaziou To: Evan Straw Subject: Re: [bug#40284] [PATCH] gnu: emacs-arduino-mode: Change to a maintained fork. References: <87k13220st.fsf@gmail.com> Date: Mon, 30 Mar 2020 01:59:07 +0200 In-Reply-To: <87k13220st.fsf@gmail.com> (Evan Straw's message of "Sun, 29 Mar 2020 16:34:10 -0700") Message-ID: <87sghqaf1w.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40284 Cc: 40284@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Evan Straw writes: > Subject: [PATCH] gnu: emacs-arduino-mode: Change to a maintained fork. > > * gnu/packages/emacs-xyz.scm (emacs-arduino-mode): Change to a maintained > fork. Thank you. > - (let ((commit "3e2bad4569ad26e929e6db2cbcff0d6d36812698")) ;no release yet > + (let ((commit "23ae47c9f28f559e70b790b471f20310e163a39b")) ;no release yet > (package > (name "emacs-arduino-mode") > (version (git-version "0" "0" commit)) We want to increment version, too, so the above should be: (git-version "0" "1" commit) For clarity, you may want to bind `revision' to "1" right after `commit' and use that in the `git-version' call. > + (add-after 'unpack 'fix-obsolete > + (lambda _ > + (substitute* "ede-arduino.el" > + (("defmethod") "cl-defmethod") > + (("defgeneric") "cl-defgeneric"))))))) The phase must end with a #f Could you send an updated patch? Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 29 20:42:11 2020 Received: (at 40284) by debbugs.gnu.org; 30 Mar 2020 00:42:11 +0000 Received: from localhost ([127.0.0.1]:60089 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jIiVH-0001Md-DB for submit@debbugs.gnu.org; Sun, 29 Mar 2020 20:42:11 -0400 Received: from tobias.gr ([80.241.217.52]:33066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jIiVE-0001MS-Pd for 40284@debbugs.gnu.org; Sun, 29 Mar 2020 20:42:09 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id 23ad2dfb; Mon, 30 Mar 2020 00:42:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to :subject:references:in-reply-to:date:message-id:mime-version :content-type; s=2018; i=me@tobias.gr; bh=BXwXri0fwu8ehXmPyJ1G86 ME8OCjQUEy2lVLaleF6vs=; b=MqBd8tfF58p9TvGxGzlJCtiPxvIlVXF1Bm8jQe qijYQYRVWSKFtcKrcgtITsXrHCHrgI7GYF/mVKLw+D/flsD+9ARZckEsd6+e/42E af/kiMzappJEahYWednFDut0VpvaI10TFYG4Tj3UTBfm/iACdOnL5AkoRPQl4/zh kNRuGlpalHfkYYkODz7QrLiNwXI3zuNuVnlrHIB8ioMaI5rT8k5xutNVYYEKmuVu tMIyn6FZBx7uTpK3AA90DdxLppZMHmnafm120HSIwrgqwzd1iR+aoXwekA48ldDo SuCg9QVNiAr8FuYlN4heCmGPzOgrGxldxsIEpfzrNt2xDkyg== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id d90270ed (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Mon, 30 Mar 2020 00:42:06 +0000 (UTC) From: Tobias Geerinckx-Rice To: Evan Straw , 40284@debbugs.gnu.org Subject: Re: [bug#40284] [PATCH] gnu: emacs-arduino-mode: Change to a maintained fork. References: <87k13220st.fsf@gmail.com> <87sghqaf1w.fsf@nicolasgoaziou.fr> In-reply-to: <87sghqaf1w.fsf@nicolasgoaziou.fr> Date: Mon, 30 Mar 2020 02:42:20 +0200 Message-ID: <874ku6lllf.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 40284 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Nicolas Goaziou =E5=86=99=E9=81=93=EF=BC=9A > The phase must end with a #f Typo of course, but: #t! :-) Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfo+u0AlEeO9y5k0W2Imw8BjFSTwFAl6BQGwACgkQ2Imw8BjF STzXEw//ez+qMvSQ5Vv3euioBbnFlcxkzdD9ANTrCgU6VpVhaADSGxsE0iMvfqDp vtPt4ziEuCdBIPFC4b1eqboI8WExiLAV/+D5TM5iitVfBL0vjKiJxqa7Tsx0fRFI JLK3WY/MtEvvvfhR24cxA/+wKZyrpviy+UPtLyyRcFiW/y9RCBK9LR9TK17mzHx9 al7ha+yseCCciAVNJ0LAzjXwdQ6gMI4mYxqpYj65Lm/bqLvHNZ6KB+qBdM8ngxuc 1dstT95NmEUYJKLsQEAbnsDbkX7tkZwwL6oSKsY3AQsEeg8cEbjmnSOksQ8vxpIK vU1l+ijB18ZUfobr7DrTMfmfS6XiGniJ6rd5Odl0FjIPJxJNqgcq8nYmpvAE1wxf X8hchHY+x5x/8gDjkIc+v9cT3EQzJOu61QByAEGx1XV9BPjNkEismwVlY8Uam2z5 AFGIW3Bv3IdD6G1vHfFr9n+zEIm795UQXdNGzH+/mNelROtZQUKDmgQa4x7PvgZk uQ1k8HQK+HBW8UAfm4JSYU8ee9g+ovZjCR3l0BUYz9c8Kv9EViVvHvUI7nM7YKMu dfCMUlRVYyb+n3bLdFCsVlHyndMURTY4uMJk7Y8nKukakEcRVhvgf5PD3aS6qVDd jyEmzaa5b7kNqYDvt2pREPOSZ6XdVbRYHidl4FNfASXCrHpJJx0= =SwKU -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 29 20:56:21 2020 Received: (at 40284) by debbugs.gnu.org; 30 Mar 2020 00:56:21 +0000 Received: from localhost ([127.0.0.1]:60097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jIiiz-0001io-BW for submit@debbugs.gnu.org; Sun, 29 Mar 2020 20:56:21 -0400 Received: from mail-pg1-f174.google.com ([209.85.215.174]:35500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jIiix-0001ib-Jf for 40284@debbugs.gnu.org; Sun, 29 Mar 2020 20:56:20 -0400 Received: by mail-pg1-f174.google.com with SMTP id k5so5676129pga.2 for <40284@debbugs.gnu.org>; Sun, 29 Mar 2020 17:56:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=OxPXVQ2oh63I9XI6QyYearkS3lQcYUHCRt9gKET8oK0=; b=Ol00BmlL8SYwCJM0mXkWJ6zamXJqihNyPP5CF2iMYOotqxM3FO3gtIsU4DOeBf46ay vjsJsHbCJODo5BaFjQrapCjegya7nhRNuh4vOCsImG9A6EZOQU5kMC1L+giilF9yQf2v GCjCAaO+YR31g2L2rcnrnS6+mGAQdtD2buO3Es65ZAjxVscb4Z0HqOiC3g1qF8nXP3sa utKWZNZ0BVqbWXLrKqYkt3iA6rKyZQAvCA4j+T53P4qfL9bYOFLaP6MGHnH1HwSuXJV5 BQV4C/e06/1H3USjS2U2k26EP5NCZHXwJ+lzQxbotKIUBPAnkhOv1rOMhkb6a3AS5bLI HpjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=OxPXVQ2oh63I9XI6QyYearkS3lQcYUHCRt9gKET8oK0=; b=SwnExwiFR1ubH9PJWZPP2966fl5dKH6WVdvdJRvYDyFxLWh9WE6+lm4lUg+mdi4xQ1 N+L87Zgqj4iMZ9O6PDyrX4mAr05cMqDHfl5ODGzem+ubPWMPhU/KcoOo7yXYcyUOnovt p/kyjm6y3JJWs1WR+QR+FAA4xLovq7qV3e6LNzz6Ob1JA0fhxqFAaUN7GA3FsTYji+yk MVBKtK6YLunVv/pqitjpyt8TvnqsZBuTm7wJNX2+dL1vwh5TaYRxc9L/nCSJwbiyj/9K G6QCmwJ/kdnhiZEYqUeASbM87Hg91/J8am6IHXpqDb/4/tUjEkCxLy1wkLIBPuAKfg2O XiaQ== X-Gm-Message-State: ANhLgQ3JUQZL1HRLtPO1lI2yJAeqIyhJk0Poj8nJoKRhsAuUcd+/eNaH +A42S34nxs1lSIonWjZc/rBRN+AHh0c= X-Google-Smtp-Source: ADFU+vusP85yICJWLrjtnkh/5/GggcCY9d0HQvH4wurCkmNKgEsasNpU94J4RP1cliWrUpOYelKrfw== X-Received: by 2002:aa7:9e42:: with SMTP id z2mr10333729pfq.109.1585529773483; Sun, 29 Mar 2020 17:56:13 -0700 (PDT) Received: from virtualplaza ([2600:6c50:677f:fd7e:3ae1:7063:7a8d:5d31]) by smtp.gmail.com with ESMTPSA id 66sm8985811pfb.150.2020.03.29.17.56.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 29 Mar 2020 17:56:12 -0700 (PDT) From: Evan Straw To: Nicolas Goaziou Subject: [bug#40284] [PATCH v2] gnu: emacs-arduino-mode: Change to a maintained fork. References: <87k13220st.fsf@gmail.com> <87sghqaf1w.fsf@nicolasgoaziou.fr> Date: Sun, 29 Mar 2020 17:56:10 -0700 In-Reply-To: <87sghqaf1w.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Mon, 30 Mar 2020 01:59:07 +0200") Message-ID: <877dz21x05.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 40284 Cc: Tobias Geerinckx-Rice , 40284@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Nicolas Goaziou writes: > Hello, > > Evan Straw writes: > >> Subject: [PATCH] gnu: emacs-arduino-mode: Change to a maintained fork. >> >> * gnu/packages/emacs-xyz.scm (emacs-arduino-mode): Change to a maintained >> fork. > > Thank you. > >> - (let ((commit "3e2bad4569ad26e929e6db2cbcff0d6d36812698")) ;no release yet >> + (let ((commit "23ae47c9f28f559e70b790b471f20310e163a39b")) ;no release yet >> (package >> (name "emacs-arduino-mode") >> (version (git-version "0" "0" commit)) > > We want to increment version, too, so the above should be: > > (git-version "0" "1" commit) > > For clarity, you may want to bind `revision' to "1" right after `commit' > and use that in the `git-version' call. > >> + (add-after 'unpack 'fix-obsolete >> + (lambda _ >> + (substitute* "ede-arduino.el" >> + (("defmethod") "cl-defmethod") >> + (("defgeneric") "cl-defgeneric"))))))) > > The phase must end with a #f > > Could you send an updated patch? > > Regards, Thanks for the feedback. Attached to this email should be an updated patch. Please let me know if there's anything else I should change. Thanks, -- Evan --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-emacs-arduino-mode-Change-to-a-maintained-fork.patch Content-Transfer-Encoding: quoted-printable Content-Description: Patch From=209488d348f12631aa76b13f259434a996e3370aa9 Mon Sep 17 00:00:00 2001 From: Evan Straw Date: Sun, 29 Mar 2020 16:27:34 -0700 Subject: [PATCH] gnu: emacs-arduino-mode: Change to a maintained fork. * gnu/packages/emacs-xyz.scm (emacs-arduino-mode): Change to a maintained fork. =2D-- gnu/packages/emacs-xyz.scm | 26 +++++++++++++++++++++----- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 782d8650dd..4fe61fafaf 100644 =2D-- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -17092,23 +17092,39 @@ other frame parameters.") (license license:gpl3+))) =20 (define-public emacs-arduino-mode =2D (let ((commit "3e2bad4569ad26e929e6db2cbcff0d6d36812698")) ;no release= yet + (let ((commit "23ae47c9f28f559e70b790b471f20310e163a39b") + (revision "1")) ;no release yet (package (name "emacs-arduino-mode") =2D (version (git-version "0" "0" commit)) + (version (git-version "0" revision commit)) (source (origin (method git-fetch) (uri (git-reference =2D (url "https://github.com/bookest/arduino-mode.git") + (url "https://github.com/stardiviner/arduino-mode.gi= t") (commit commit))) (sha256 (base32 =2D "1yvaqjc9hadbnnay5fprnh890xsp53kidad1zpb4a5z4a5z61n3c"= )) + "08vnbz9gpah1l93fzfd87aawrhcnh2v1kyfxgsn88pdwg8awz8rx")) (file-name (git-file-name name version)))) (build-system emacs-build-system) + (inputs + `(("spinner" ,emacs-spinner) + ("flycheck" ,emacs-flycheck))) + (arguments + `(#:phases + (modify-phases %standard-phases + ;; Emacs complains that "defmethod" and "defgeneric" are obsole= te + ;; macros when compiling. Substitute them with the recommended + ;; macros "cl-defmethod" and "cl-defgeneric", respectively. + (add-after 'unpack 'fix-obsolete + (lambda _ + (substitute* "ede-arduino.el" + (("defmethod") "cl-defmethod") + (("defgeneric") "cl-defgeneric")) + #t))))) (synopsis "Emacs major mode for editing Arduino sketches") (description "Emacs major mode for editing Arduino sketches.") =2D (home-page "https://github.com/bookest/arduino-mode") + (home-page "https://github.com/stardiviner/arduino-mode") (license license:gpl3+)))) =20 (define-public emacs-annalist =2D-=20 2.20.1 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6f/SZXb4DLdwy+VR9TDDtKKp8G0FAl6BQ6oACgkQ9TDDtKKp 8G1HbBAAmH7k+ENMMG/OzRxc3LPSdaf5De0A5RXkmopUbqmdJtda8tMDDLXx6OJL b6vuvTI85C3ceCNCLoCoD3oXx2Jx2y4YO+r7MFR0naOVOstKpiHJSphAR2H0rXgl dKa/i+SParS3crMcUpLPcOuKK0+ilcQ812Ne+5LGJiJmlFyKIYnzEqYfQ3dPYkS0 O3lzo5pq4ItsWW1YhsnASMhrONoZn2WYkbDgacFKP1oVHoD9iT8D5P2DkdJdc8BF qEs5Cqlwp9fv++pV4qCxMzpnwg3zGcK7WNtihS7cPDy4qGSRuY/Iu9MARvo9TZIJ 4QVXgH+W2ZF/Yqn1U2KPteOaYv60nqrqPBfyNjj4XyygZ7zTT/AV88L6C2BL0ZA2 z4NSd19vFX6VfNgaTMbocqAlCHHs972d0hlKlxJHsiq70V7/aEMbBqtsiVqThqj7 5Jz5+aoeb69SBuhWabsDR8Ef3tjBx0B5s0LHT3GL63iIjKPQ/GtOvHlseheds62N PluOfp8dy4BJZikvJZXXPYhuhh0LRSwELfG86tJ+kltmhqdyUSefyEQYOD+IfWgS 0r7g0gobIQLmoaGHL/G2dVbZ6YDbbkD8/ycAFvMuNEbGmeNloAaC7LGwEfH5GoqV jKOMPipbFcj72tgudI1DGXxQ/Buq7hYQgdnfTrW/Xs/j5MIC8QY= =L9L9 -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 30 06:12:47 2020 Received: (at submit) by debbugs.gnu.org; 30 Mar 2020 10:12:47 +0000 Received: from localhost ([127.0.0.1]:60955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jIrPS-0002S6-Ps for submit@debbugs.gnu.org; Mon, 30 Mar 2020 06:12:47 -0400 Received: from lists.gnu.org ([209.51.188.17]:37028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jIrPR-0002Rz-Kb for submit@debbugs.gnu.org; Mon, 30 Mar 2020 06:12:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46213) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIrPQ-0002NK-Kg for guix-patches@gnu.org; Mon, 30 Mar 2020 06:12:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jIrPP-00025p-Cg for guix-patches@gnu.org; Mon, 30 Mar 2020 06:12:44 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:58027) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jIrPP-00023y-6k for guix-patches@gnu.org; Mon, 30 Mar 2020 06:12:43 -0400 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 2ACB6240010; Mon, 30 Mar 2020 10:12:38 +0000 (UTC) From: Nicolas Goaziou To: Tobias Geerinckx-Rice via Guix-patches via Subject: Re: [bug#40284] [PATCH] gnu: emacs-arduino-mode: Change to a maintained fork. References: <87k13220st.fsf@gmail.com> <87sghqaf1w.fsf@nicolasgoaziou.fr> <874ku6lllf.fsf@nckx> Date: Mon, 30 Mar 2020 12:12:37 +0200 In-Reply-To: <874ku6lllf.fsf@nckx> (Tobias Geerinckx-Rice via Guix-patches via's message of "Mon, 30 Mar 2020 02:42:20 +0200") Message-ID: <87ftdq9mne.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 217.70.178.230 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit Cc: Tobias Geerinckx-Rice , Evan Straw , 40284@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Tobias Geerinckx-Rice via Guix-patches via writes: > Nicolas Goaziou =E5=86=99=E9=81=93=EF=BC=9A >> The phase must end with a #f > > Typo of course, but: #t! :-) Duh! Here's what happens when I answer mails at 3 am. Thanks, Regards, --=20 Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 30 08:02:01 2020 Received: (at 40284-done) by debbugs.gnu.org; 30 Mar 2020 12:02:01 +0000 Received: from localhost ([127.0.0.1]:32827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jIt7B-0007WW-58 for submit@debbugs.gnu.org; Mon, 30 Mar 2020 08:02:01 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:16857) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jIt79-0007WD-Ly for 40284-done@debbugs.gnu.org; Mon, 30 Mar 2020 08:02:00 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 3F1A0240011; Mon, 30 Mar 2020 12:01:51 +0000 (UTC) From: Nicolas Goaziou To: Evan Straw Subject: Re: [bug#40284] [PATCH v2] gnu: emacs-arduino-mode: Change to a maintained fork. References: <87k13220st.fsf@gmail.com> <87sghqaf1w.fsf@nicolasgoaziou.fr> <877dz21x05.fsf_-_@gmail.com> Date: Mon, 30 Mar 2020 14:01:51 +0200 In-Reply-To: <877dz21x05.fsf_-_@gmail.com> (Evan Straw's message of "Sun, 29 Mar 2020 17:56:10 -0700") Message-ID: <87a73y9hlc.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40284-done Cc: Tobias Geerinckx-Rice , 40284-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Evan Straw writes: > Subject: [PATCH] gnu: emacs-arduino-mode: Change to a maintained fork. > > * gnu/packages/emacs-xyz.scm (emacs-arduino-mode): Change to a maintained > fork. Applied as 6957e4c13d0c01b50b616832360ee510dac58e66. I expounded a bit the commit message. Thank you! Regards, -- Nicolas Goaziou From unknown Thu Aug 21 23:00:42 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 28 Apr 2020 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator