Subject: Re: [bug#40281] [PATCH v2] gnu: Add mtpaint.

From: R Veera Kumar <[email-masked]>
Date: Fri, 3 Apr 2020 10:12:51 +0530

On Fri, Apr 03, 2020 at 06:15:57AM +0200, Ricardo Wurmus wrote:
> 
> R Veera Kumar <[email-masked]> writes:
> 
> > * gnu/packages/image.scm (mtpaint): New variable.
> 
> Thank you for the patch!
> 
> > +
> > +(define-public mtpaint
> > +  (let ((commit "03b1b0938067b88d86d9f1b1088730f1934d411e")
> > +        (revision "1"))
> 
> Why is this particular commit needed?  Can’t we use the latest release?
>

The author does not make release tarballs or even make git release tags.
He only puts package version in git commit title.
 
> > +    (package
> > +      (name "mtpaint")
> > +      (version (git-version "3.49.25" revision commit))
> > +      (source
> > +       (origin
> > +         (method git-fetch)
> > +         (uri (git-reference
> > +               (url "https://github.com/wjaguar/mtPaint/")
> > +               (commit commit)))
> > +         (file-name (git-file-name name version))
> > +         (sha256
> > +          (base32 "0izm2wvj26566fd8mqvypr7bmv7jnq8qhp4760m7z2wrc4y8pjn1"))))
> > +      (build-system gnu-build-system)
> > +      (native-inputs
> > +       `(("gettext" ,gettext-minimal)
> > +         ("pkg-config" ,pkg-config)
> > +         ("pkg-config" ,pkg-config)
> 
> You have this line twice.
> 

Will correct this.

> > +         ("which" ,which)))
> > +      (inputs
> > +       `(("imlib2" ,imlib2)
> > +         ("libtiff" ,libtiff)
> > +         ("libpng" ,libpng)
> > +         ("libungif", libungif)
> > +         ("libjpeg", libjpeg)
> > +         ("libwebp" ,libwebp)
> > +         ("openjpeg" ,openjpeg)
> > +         ("lcms" ,lcms)
> > +         ("zlib", zlib)
> > +         ("glib" ,glib)
> > +         ("gtk+" ,gtk+-2)))
> 
> Could you please build with gtk+ (i.e. version 3).  You probably need to
> add “gtk3” to the configure flags.
> 

Currently gtk2 support is stable. gtk3 is testing stage.

> > +      (arguments
> > +       `(#:configure-flags
> > +         (list
> > +          "intl") ;; internationalized support
> 
> Please remove the line break.
> For margin comments (at the end of a line) use just one semicolon please.
> 

Will correct.

> > +         ;; no check target
> > +         #:tests? #f))
> > +      (home-page "http://mtpaint.sourceforge.net/")
> > +      (synopsis "Create pixel art and manipulate digital images")
> > +      (description
> > +       "Mtpaint is a graphic editing program which uses the GTK+ toolkit.
> > +It can create and edit indexed pallete or 24bit RGB images, offers
> > basic
> 
> “pallete” –> “palette”
> 

Will correct.

> > +painting and palette manipulation tools.
> 
> Same here.
> 

Will correct.

R Veera Kumar

> --
> Ricardo