From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 29 13:15:39 2020 Received: (at submit) by debbugs.gnu.org; 29 Mar 2020 17:15:39 +0000 Received: from localhost ([127.0.0.1]:59656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jIbX9-0007oe-6g for submit@debbugs.gnu.org; Sun, 29 Mar 2020 13:15:39 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:50643) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jIbX6-0007oP-W6 for submit@debbugs.gnu.org; Sun, 29 Mar 2020 13:15:37 -0400 Received: by mail-wm1-f67.google.com with SMTP id d198so17193947wmd.0 for ; Sun, 29 Mar 2020 10:15:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dme-org.20150623.gappssmtp.com; s=20150623; h=to:subject:from:date:message-id:user-agent:mime-version; bh=2TkMCmKEJZSdwSVPTDZdEY3rDszkok7LlZKQOwi+ThA=; b=AjNv0USYFCtWYvTnYcFeXB3E4BozYyUhNmwCkths4RpTTYF3ayVatlH/z5E6BryXhL GfT+X27VKIjdv0ibnakCUtyzYNV/BnI+T/BeNMVjLRbRSbLdNo7ZET5RkV9z6MxsRE4I qzEV/VA/JSgBVPRxUN7M49MGPZaEVLlMTCVhYmPCSaHwtS9kZb+ucXadtchE81lenXBc MedhMIeOYCIovbuhy06IccEqfmT68gr1JYYgGOIr+1C4N9tu8hCQTgWmjswX5za9E1S9 3xPPxl1zKxhXVtd8Xfafv8YdrmsXMGV1P2Echoid8G7Xr7vko8NTZzoT17wv3RSrlbMV e+bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:subject:from:date:message-id:user-agent :mime-version; bh=2TkMCmKEJZSdwSVPTDZdEY3rDszkok7LlZKQOwi+ThA=; b=tVZNosUuK5CuaD9keYdDE6dTxCzlRVcFkOa7TJQpojzxm+idHPiHVlcNRHRcv6n7T8 KbPqXrcVndI7SWDzG2ZpUA2BCnrNfIgwV/Q5/at1eG0qDo+qep+gVGbmC6KX7TpLMEy2 p9DN1CxOT6bIgWCeZfbfW2tGE+/o+t5OCptC7FB7ijxCUgZ1CtvmsQzBsAHfcnId5gAY nUz590SHLfRgOsFwHDuapw/nGVUqVvNizmJHT2J5CPq5Q9rzt6xEN1JcR4t1f0BEy2ps NYhYbwHBLS3hzxFBe0puIKwnCEorrZ1Kl/IutevzTZW0gMBXW1UPLwZMUNfFDAyvKFrV UFEA== X-Gm-Message-State: ANhLgQ1DqwUnd+imvlIAEJJlVGcjvc9OcvLe4vwokLWleDNuTsAJhq70 hywIgYLxzkGzmNxJyRo6V13rrw== X-Google-Smtp-Source: ADFU+vsgpMjIC9hvRbMko/ceK6w+blYZ2sCLb81PN3r0ramckKjl4rS4y99+qE0SeEeh5CtDBI1bcA== X-Received: by 2002:a7b:c004:: with SMTP id c4mr8963030wmb.108.1585502130795; Sun, 29 Mar 2020 10:15:30 -0700 (PDT) Received: from disaster-area.hh.sledj.net (disaster-area.hh.sledj.net. [2001:8b0:bb71:7140:64::1]) by smtp.gmail.com with ESMTPSA id d7sm3743164wrr.77.2020.03.29.10.15.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Mar 2020 10:15:29 -0700 (PDT) Received: from localhost (disaster-area.hh.sledj.net [local]) by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id 0455d20a; Sun, 29 Mar 2020 17:15:28 +0000 (UTC) To: submit@debbugs.gnu.org (The Gnus Bugfixing Girls + Boys) Subject: gnus-cloud doesn't do anything useful X-Debbugs-Version: 5.13 X-Debbugs-Package: emacs,gnus X-HGTTG: vroomfondel From: David Edmondson Date: Sun, 29 Mar 2020 18:15:28 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) --=-=-= Content-Type: text/plain After some time away, I'm playing with Gnus again. In this instance, gnus-cloud isn't working for me. Specifically, I can add a gnus-cloud storage server (on nnimap) and register another server (nntp) with it. ~u causes messages to be added to Emacs-Cloud and they appear to have the right kind of content. ~d on another machine never does anything useful (e.g. mark some articles as read) because this test: (if (and newer (not force-older)) (gnus-message 3 "Skipping outdated cloud info for group %s, the info is from %s (now is %s)" group date now) always returns true. Looking at how `newer' is calculated, it compares the group timestamp from the gnus-cloud message with the current time. It's not clear to me how that test is ever going to return `nil', unless I have a version of emacs running somewhere in the future that updates gnus-cloud. In general I would have expected to replay any changes with a higher sequence number, irrespective of the date of the changes. That they happened in the past is somewhat the point, isn't it? :-) Another problem is that after a set of Emacs-Cloud messages have been used to replay, the emacs instance doing that replay doesn't persist the last seen sequence value as `gnus-cloud-sequence', so the next time it attempts to replay it will unnecessarily replay the same sequence numbered messages again. Attached is a suggested patch. This makes things work for me in some limited testing. Gnus v5.13 GNU Emacs 26.1 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.11) of 2019-09-09, modified by Debian 200 news.gmane.io InterNetNews NNRP server INN 2.6.3 ready (posting ok) 100 Legal commands ARTICLE [message-ID|number] AUTHINFO USER name|PASS password|SASL mechanism [initial-response]|GENERIC program [argument ...] BODY [message-ID|number] CAPABILITIES [keyword] COMPRESS DEFLATE DATE GROUP newsgroup HDR header [message-ID|range] HEAD [message-ID|number] HELP IHAVE message-ID LAST LIST [ACTIVE [wildmat]|ACTIVE.TIMES [wildmat]|COUNTS [wildmat]|DISTRIB.PATS|DISTRIBUTIONS|HEADERS [MSGID|RANGE]|MODERATORS|MOTD|NEWSGROUPS [wildmat]|OVERVIEW.FMT|SUBSCRIPTIONS [wildmat]] LISTGROUP [newsgroup [range]] MODE READER NEWGROUPS [yy]yymmdd hhmmss [GMT] NEWNEWS wildmat [yy]yymmdd hhmmss [GMT] NEXT OVER [range] POST QUIT STARTTLS STAT [message-ID|number] XGTITLE [wildmat] XHDR header [message-ID|range] XOVER [range] XPAT header message-ID|range pattern [pattern ...] Report problems to . . 382 Begin TLS negotiation now 100 Legal commands ARTICLE [message-ID|number] AUTHINFO USER name|PASS password|SASL mechanism [initial-response]|GENERIC program [argument ...] BODY [message-ID|number] CAPABILITIES [keyword] COMPRESS DEFLATE DATE GROUP newsgroup HDR header [message-ID|range] HEAD [message-ID|number] HELP IHAVE message-ID LAST LIST [ACTIVE [wildmat]|ACTIVE.TIMES [wildmat]|COUNTS [wildmat]|DISTRIB.PATS|DISTRIBUTIONS|HEADERS [MSGID|RANGE]|MODERATORS|MOTD|NEWSGROUPS [wildmat]|OVERVIEW.FMT|SUBSCRIPTIONS [wildmat]] LISTGROUP [newsgroup [range]] MODE READER NEWGROUPS [yy]yymmdd hhmmss [GMT] NEWNEWS wildmat [yy]yymmdd hhmmss [GMT] NEXT OVER [range] POST QUIT STARTTLS STAT [message-ID|number] XGTITLE [wildmat] XHDR header [message-ID|range] XOVER [range] XPAT header message-ID|range pattern [pattern ...] Report problems to . . --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-gnus-cloud-Improve-cloud-sync.patch >From a3bdd2219855a72e2ee90de1b6f823c9678a470c Mon Sep 17 00:00:00 2001 From: David Edmondson Date: Sat, 28 Mar 2020 19:03:58 +0000 Subject: [PATCH] gnus-cloud: Improve cloud sync After replaying a set of actions downloaded by gnus-cloud, persist the highest sequence number seen as the local `gnus-cloud-sequence' number, in order that a future download will not unnecessarily replay previously seen actions and any future uploads from this emacs instance use a higher sequence number than that downloaded. Remove the test on whether individual newsrc entries are older than the current time, as that is always going to be the case. --- lisp/gnus/gnus-cloud.el | 54 ++++++++++++++++++++--------------------- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/lisp/gnus/gnus-cloud.el b/lisp/gnus/gnus-cloud.el index da6231d73300..7ea691e7220c 100644 --- a/lisp/gnus/gnus-cloud.el +++ b/lisp/gnus/gnus-cloud.el @@ -223,13 +223,10 @@ easy interactive way to set this from the Server buffer." (t (gnus-message 1 "Unknown type %s; ignoring" type)))))) -(defun gnus-cloud-update-newsrc-data (group elem &optional force-older) - "Update the newsrc data for GROUP from ELEM. -Use old data if FORCE-OLDER is not nil." +(defun gnus-cloud-update-newsrc-data (group elem) + "Update the newsrc data for GROUP from ELEM." (let* ((contents (plist-get elem :contents)) (date (or (plist-get elem :timestamp) "0")) - (now (gnus-cloud-timestamp nil)) - (newer (string-lessp date now)) (group-info (gnus-get-info group))) (if (and contents (stringp (nth 0 contents)) @@ -238,15 +235,13 @@ Use old data if FORCE-OLDER is not nil." (if (equal (format "%S" group-info) (format "%S" contents)) (gnus-message 3 "Skipping cloud update of group %s, the info is the same" group) - (if (and newer (not force-older)) - (gnus-message 3 "Skipping outdated cloud info for group %s, the info is from %s (now is %s)" group date now) - (when (or (not gnus-cloud-interactive) - (gnus-y-or-n-p - (format "%s has older different info in the cloud as of %s, update it here? " - group date))) - (gnus-message 2 "Installing cloud update of group %s" group) - (gnus-set-info group contents) - (gnus-group-update-group group)))) + (when (or (not gnus-cloud-interactive) + (gnus-y-or-n-p + (format "%s has different info in the cloud from %s, update it here? " + group date))) + (gnus-message 2 "Installing cloud update of group %s" group) + (gnus-set-info group contents) + (gnus-group-update-group group))) (gnus-error 1 "Sorry, group %s is not subscribed" group)) (gnus-error 1 "Sorry, could not update newsrc for group %s (invalid data %S)" group elem)))) @@ -380,8 +375,9 @@ When FULL is t, upload everything, not just a difference from the last full." (gnus-cloud-files-to-upload full) (gnus-cloud-collect-full-newsrc))) (group (gnus-group-full-name gnus-cloud-group-name gnus-cloud-method))) + (setq gnus-cloud-sequence (1+ (or gnus-cloud-sequence 0))) (insert (format "Subject: (sequence: %s type: %s storage-method: %s)\n" - (or gnus-cloud-sequence "UNKNOWN") + gnus-cloud-sequence (if full :full :partial) gnus-cloud-storage-method)) (insert "From: nobody@gnus.cloud.invalid\n") @@ -390,7 +386,6 @@ When FULL is t, upload everything, not just a difference from the last full." (if (gnus-request-accept-article gnus-cloud-group-name gnus-cloud-method t t) (progn - (setq gnus-cloud-sequence (1+ (or gnus-cloud-sequence 0))) (gnus-cloud-add-timestamps elems) (gnus-message 3 "Uploaded Gnus Cloud data successfully to %s" group) (gnus-group-refresh-group group)) @@ -459,18 +454,21 @@ instead of `gnus-cloud-sequence'. When UPDATE is t, returns the result of calling `gnus-cloud-update-all'. Otherwise, returns the Gnus Cloud data chunks." (let ((articles nil) + (highest-sequence-seen gnus-cloud-sequence) chunks) (dolist (header (gnus-cloud-available-chunks)) - (when (> (gnus-cloud-chunk-sequence (mail-header-subject header)) - (or sequence-override gnus-cloud-sequence -1)) - - (if (string-match (format "storage-method: %s" gnus-cloud-storage-method) - (mail-header-subject header)) - (push (mail-header-number header) articles) - (gnus-message 1 "Skipping article %s because it didn't match the Gnus Cloud method %s: %s" - (mail-header-number header) - gnus-cloud-storage-method - (mail-header-subject header))))) + (let ((this-sequence (gnus-cloud-chunk-sequence (mail-header-subject header)))) + (when (> this-sequence (or sequence-override gnus-cloud-sequence -1)) + + (if (string-match (format "storage-method: %s" gnus-cloud-storage-method) + (mail-header-subject header)) + (progn + (push (mail-header-number header) articles) + (setq highest-sequence-seen (max highest-sequence-seen this-sequence))) + (gnus-message 1 "Skipping article %s because it didn't match the Gnus Cloud method %s: %s" + (mail-header-number header) + gnus-cloud-storage-method + (mail-header-subject header)))))) (when articles (nnimap-request-articles (nreverse articles) gnus-cloud-group-name) (with-current-buffer nntp-server-buffer @@ -480,7 +478,9 @@ Otherwise, returns the Gnus Cloud data chunks." (push (gnus-cloud-parse-chunk) chunks) (forward-line 1)))) (if update - (mapcar #'gnus-cloud-update-all chunks) + (progn + (mapcar #'gnus-cloud-update-all chunks) + (setq gnus-cloud-sequence highest-sequence-seen)) chunks))) (defun gnus-cloud-server-p (server) -- 2.25.1 --=-=-= Content-Type: text/plain dme. -- And the sign said: long haired freaky people need not apply. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed May 13 06:21:51 2020 Received: (at 40280) by debbugs.gnu.org; 13 May 2020 10:21:51 +0000 Received: from localhost ([127.0.0.1]:57450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYoWN-0008GI-K8 for submit@debbugs.gnu.org; Wed, 13 May 2020 06:21:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYoWL-0008G6-B2 for 40280@debbugs.gnu.org; Wed, 13 May 2020 06:21:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33650) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYoWG-0001zM-2K; Wed, 13 May 2020 06:21:44 -0400 Received: from [2a01:cb18:832e:5f00:7499:6e2e:99e3:10a4] (port=47592 helo=meru) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jYoWF-0002ZB-FC; Wed, 13 May 2020 06:21:43 -0400 From: Mathieu Othacehe To: David Edmondson Subject: Re: bug#40280: gnus-cloud doesn't do anything useful References: Date: Wed, 13 May 2020 12:21:42 +0200 In-Reply-To: (David Edmondson's message of "Sun, 29 Mar 2020 18:15:28 +0100") Message-ID: <87sgg4qgnd.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 40280 Cc: 40280@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, > Looking at how `newer' is calculated, it compares the group timestamp > from the gnus-cloud message with the current time. It's not clear to me > how that test is ever going to return `nil', unless I have a version of > emacs running somewhere in the future that updates gnus-cloud. I share the same conclusions on 26.3, the downloaded message is always older than current time, and nothing happens. The patch you are proposing fixes gnus cloud update for me. Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 09 12:41:39 2020 Received: (at 40280) by debbugs.gnu.org; 9 Jun 2020 16:41:39 +0000 Received: from localhost ([127.0.0.1]:60820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jihJj-0005oE-Hj for submit@debbugs.gnu.org; Tue, 09 Jun 2020 12:41:39 -0400 Received: from mail-qt1-f173.google.com ([209.85.160.173]:36994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jihJh-0005nw-Fo for 40280@debbugs.gnu.org; Tue, 09 Jun 2020 12:41:38 -0400 Received: by mail-qt1-f173.google.com with SMTP id d27so18132536qtg.4 for <40280@debbugs.gnu.org>; Tue, 09 Jun 2020 09:41:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to:date :in-reply-to:message-id:user-agent:mime-version; bh=gO/T2KNFfYtk4mWRwsfcAVAJoUExQXs4SUnzCFv0I8E=; b=LRz3Wj6yrcnjPOzaFuwPEcB9dFLWyRFOB+o4rrtVVqkqhehW/HTO7u+FdbLgqRrq/I Xr/8myhRx+KDVstmTHk0sbYHynq88KZtQ2UYYcz3yzlTW3HELtUSkhFqP5WNWIGTQZhg 8qZKB3EO+jm8IjG8akg83EZIDAt0yrL2akG0w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:date:in-reply-to:message-id:user-agent:mime-version; bh=gO/T2KNFfYtk4mWRwsfcAVAJoUExQXs4SUnzCFv0I8E=; b=oT/etQStIIvnQMRQYHsVc4Wfct5eWbgcqul0CT27nSUbfYeREcwtctfDmVYFtkvmLj Ot+2QJukty+NdVeR2krJQlc3QambIE+ZONWJnebn2VDNWlqsqPUg5MSo1nyL+Ew7IloU px3pGdO76a0hzNfLrWu+Rvh/oolIYXAJjevR9hdk2EuS+5dEgsZ4FF9ie33lUfgVT06w XVWw/iNpJi2Qo0F2jyI1+hRKdqTJyhPbiuVcYu1RilF9J61J9vljDkT3ruqVqLvcPQYR mB0kUG4SxtJOD7tfUlBbJI72friLcARa4Y0tuL9s1kcV2vMuH7+pD3GsejWxz7tQOxjY g7fA== X-Gm-Message-State: AOAM532nxF5531OtX/6j2Tv8tkubLBDGxXtPBbNSLBvbR1en7z/ywdpp iqYxgGr8TyfLRRjDGWGdfom98fa7VaM7wA== X-Google-Smtp-Source: ABdhPJykEOCT1JUKbbK0tPXnjosq/zEHW5XQdNX6sox3BTRlRHbKzFQO8szCSvwySY1XGj4p7JaZhQ== X-Received: by 2002:ac8:7303:: with SMTP id x3mr11514908qto.44.1591720891394; Tue, 09 Jun 2020 09:41:31 -0700 (PDT) Received: from flea (c-76-28-41-155.hsd1.ma.comcast.net. [76.28.41.155]) by smtp.gmail.com with ESMTPSA id h8sm10275156qto.0.2020.06.09.09.41.29 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Jun 2020 09:41:30 -0700 (PDT) From: Ted Zlatanov To: Mathieu Othacehe Subject: Re: bug#40280: gnus-cloud doesn't do anything useful Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: <87sgg4qgnd.fsf@gnu.org> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Date: Tue, 09 Jun 2020 16:41:29 +0000 In-Reply-To: <87sgg4qgnd.fsf@gnu.org> (Mathieu Othacehe's message of "Wed, 13 May 2020 12:21:42 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40280 Cc: 40280@debbugs.gnu.org, David Edmondson X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed, 13 May 2020 12:21:42 +0200 Mathieu Othacehe wrote: >> Looking at how `newer' is calculated, it compares the group timestamp >> from the gnus-cloud message with the current time. It's not clear to me >> how that test is ever going to return `nil', unless I have a version of >> emacs running somewhere in the future that updates gnus-cloud. MO> I share the same conclusions on 26.3, the downloaded message is always MO> older than current time, and nothing happens. MO> The patch you are proposing fixes gnus cloud update for me. I agree this is a problem and agree with David's patch. I've pushed the patch to branch scratch/tzz/dme/bug-40280-gnus-cloud-newest I'll merge it into master and adjust any docs needed if I can get a second review please :) David, thank you very much for contributing the fix. Ted From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 14:14:34 2020 Received: (at 40280) by debbugs.gnu.org; 16 Jun 2020 18:14:34 +0000 Received: from localhost ([127.0.0.1]:49573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlG6U-0007qA-9q for submit@debbugs.gnu.org; Tue, 16 Jun 2020 14:14:34 -0400 Received: from mail-qt1-f182.google.com ([209.85.160.182]:37709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlG6Q-0007ps-7T for 40280@debbugs.gnu.org; Tue, 16 Jun 2020 14:14:33 -0400 Received: by mail-qt1-f182.google.com with SMTP id d27so16281182qtg.4 for <40280@debbugs.gnu.org>; Tue, 16 Jun 2020 11:14:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to:date :in-reply-to:message-id:user-agent:mime-version; bh=yBuHc23MT3z5Nf9XfXnF+hxyQkcSPoBr7aQwNXl8/7w=; b=b9hBX4VIe+PD0Pf6nV3+2mN61fEb3FSQnh+dTO0AkVHbWuqV9s+5dFYDYI6/lmywoY 4lS8OFjdhJvn8K3lQ/0RJbrLXxSw97RU6AdZ3WeyJdD8n5LfAyvgVmr4MpojTzGb0DHZ Jrd0RSBuMsUZw5uer1XmMSGSVBDIV69wM8mFY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:date:in-reply-to:message-id:user-agent:mime-version; bh=yBuHc23MT3z5Nf9XfXnF+hxyQkcSPoBr7aQwNXl8/7w=; b=DMF2/tK4MKvzQx4voSZoy9CFnMJJr+xsZD77UcvW6hNDtNoQ4bLgFXdcLjuCpPqFi3 PezRFtY1T4r6pflrp8k9Ia3XVkMxnulWmWLx1BnIvsTIcyMopEtdf/aBSq4L2UQQjF/9 sn9eoMvlT4Z/ZztZ2JqQ6LpGOKOKG3/YelUaIFwJu8fFKZh9G7Dj0Xpct/eZmiu6d9Iw NWPWUQ9Y7EVtGzSIW4LsKuy1mTCOIOV03eQYGgShjTfU7YWWRW1Q7fbBq+RnA2UX5sNY g+1eQ1n0HvNYk3ruazGGY2ojhOVWYdOPAkAKeboceaBk2OC21wSexw7KAFFIc5O9Go5k Y7iA== X-Gm-Message-State: AOAM532kmr5RaebIjBA4FaiPGHbVF0clCFAZi+npK3G5mpUCZUp33SOl 3nBdD9zTXi0E0y8ZWysSzk3Row== X-Google-Smtp-Source: ABdhPJxAZ97pGHJbwJPV8oXuJoHCxb4vgNIGTDTcEaV+mfXKZAzUQBWoccghv+FYv58FnGUVfMrb6A== X-Received: by 2002:ac8:768b:: with SMTP id g11mr23522009qtr.249.1592331264698; Tue, 16 Jun 2020 11:14:24 -0700 (PDT) Received: from flea (c-76-28-41-155.hsd1.ma.comcast.net. [76.28.41.155]) by smtp.gmail.com with ESMTPSA id h5sm14950277qkk.108.2020.06.16.11.14.21 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Jun 2020 11:14:21 -0700 (PDT) From: Ted Zlatanov To: Mathieu Othacehe Subject: Re: bug#40280: gnus-cloud doesn't do anything useful Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: <87sgg4qgnd.fsf@gnu.org> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Date: Tue, 16 Jun 2020 18:14:20 +0000 In-Reply-To: (Ted Zlatanov's message of "Tue, 09 Jun 2020 16:41:29 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40280 Cc: 40280@debbugs.gnu.org, David Edmondson X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, 09 Jun 2020 16:41:29 +0000 Ted Zlatanov wrote: TZ> On Wed, 13 May 2020 12:21:42 +0200 Mathieu Othacehe wrote: >>> Looking at how `newer' is calculated, it compares the group timestamp >>> from the gnus-cloud message with the current time. It's not clear to me >>> how that test is ever going to return `nil', unless I have a version of >>> emacs running somewhere in the future that updates gnus-cloud. MO> I share the same conclusions on 26.3, the downloaded message is always MO> older than current time, and nothing happens. MO> The patch you are proposing fixes gnus cloud update for me. TZ> I agree this is a problem and agree with David's patch. TZ> I've pushed the patch to branch scratch/tzz/dme/bug-40280-gnus-cloud-newest TZ> I'll merge it into master and adjust any docs needed if I can get a TZ> second review please :) David, Mathieu: The patch and commit message looked good so I've pushed this. Please confirm the fix works well for you and I'll close the bug. Thanks Ted From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 16 14:56:16 2020 Received: (at 40280) by debbugs.gnu.org; 16 Jun 2020 18:56:16 +0000 Received: from localhost ([127.0.0.1]:49604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlGkq-0000SD-AI for submit@debbugs.gnu.org; Tue, 16 Jun 2020 14:56:16 -0400 Received: from mail-wm1-f41.google.com ([209.85.128.41]:55288) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlGkn-0000Ry-Dj for 40280@debbugs.gnu.org; Tue, 16 Jun 2020 14:56:14 -0400 Received: by mail-wm1-f41.google.com with SMTP id g10so3861463wmh.4 for <40280@debbugs.gnu.org>; Tue, 16 Jun 2020 11:56:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=8ixq+uMs3TyNRTBacYGniq/Si2Ocb+UYS+/oVu67TXk=; b=GYmre+QaszESNzGyvmF9Y/Wcu+ykGBC1FzyHM5BSQKcjy+l2qGQXDx6BRXWr98239n fEJZGVq3BCit8b/e1VBvzwhbv7ljOLbpuxUZMFgHiLhw70c3vrEyXKwMawmU/tlBYX6v vCkb48MVXZVZ3kJgvEnIaoXhiH1LEnzY1jIxWz/+99dNQVMqVFc5iGcBv8cEPnaDKJ0R PvF4EiMkg5sHfVyWWhsB097RCNQJilnWNhgr5pBDxRi0ACl7kpPZRa68TKjyQI9ODQCe SH6XXhB4BsVRx+RPwXNqn8SEhcvdNUxSHFmxI0SptlkKkDKL0ntQ4M9b4Hf94pJ+q69b OYRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=8ixq+uMs3TyNRTBacYGniq/Si2Ocb+UYS+/oVu67TXk=; b=s9lvB3x3ee4OTyvmqJuoCQ5hJy7GZUyjmbhn0o8lMtv3q7+TZp48dtHnyL9UCkGRee 9AeekRXoLhWD+FA3zXNqwZQfhvFH3Pc9C3QNnjRn20e6ajL+QvFQQUAnTkV7MWvr2akr qd5TL3n3ofaEOFae1FGpLw37tMdfjErCohrqGRGRw51IlYycfOR21G9ZLLASkyk3iglJ 57Ki+jYcY9PAgT9QHJyC9XRkXzVTIuo9fzOpeoJI+C+3ja4x7G5toPF22/5VCOIslh1D pEs9u4h3ZHXkZAHyzYMuo2SZhSE+/YWmSaVY+UKBDUXnth5AnTtc/SD2nhZCI0JO4XWa MahQ== X-Gm-Message-State: AOAM532YaA2JTH5HtlE9c597/OkU7fe+yoQ3XjW6JjMrPlBbte1D/ZEh lbFzRZhE2Q7eVVTHn038zctNtQ== X-Google-Smtp-Source: ABdhPJzSymnp0YcWW5pOa+/yfnrPAgHmHUPt5EsLcrt8mpl2WSb0krF/zSAcAwj6Z5WieGJPsdPikg== X-Received: by 2002:a1c:49c1:: with SMTP id w184mr4522390wma.46.1592333767502; Tue, 16 Jun 2020 11:56:07 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id n189sm5138706wmb.43.2020.06.16.11.56.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2020 11:56:06 -0700 (PDT) From: "Basil L. Contovounesios" To: David Edmondson Subject: Re: bug#40280: gnus-cloud doesn't do anything useful References: Date: Tue, 16 Jun 2020 19:56:05 +0100 In-Reply-To: (David Edmondson's message of "Sun, 29 Mar 2020 18:15:28 +0100") Message-ID: <87y2omq1q2.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40280 Cc: 40280@debbugs.gnu.org, Ted Zlatanov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From a3bdd2219855a72e2ee90de1b6f823c9678a470c Mon Sep 17 00:00:00 2001 > From: David Edmondson > Date: Sat, 28 Mar 2020 19:03:58 +0000 > Subject: [PATCH] gnus-cloud: Improve cloud sync > > After replaying a set of actions downloaded by gnus-cloud, persist the > highest sequence number seen as the local `gnus-cloud-sequence' > number, in order that a future download will not unnecessarily replay > previously seen actions and any future uploads from this emacs > instance use a higher sequence number than that downloaded. > > Remove the test on whether individual newsrc entries are older than > the current time, as that is always going to be the case. In the future please follow the formatting guidelines for change log messages described in the file CONTRIBUTE. [...] > --- a/lisp/gnus/gnus-cloud.el > +++ b/lisp/gnus/gnus-cloud.el > @@ -480,7 +478,9 @@ Otherwise, returns the Gnus Cloud data chunks." > (push (gnus-cloud-parse-chunk) chunks) > (forward-line 1)))) > (if update > - (mapcar #'gnus-cloud-update-all chunks) > + (progn > + (mapcar #'gnus-cloud-update-all chunks) > + (setq gnus-cloud-sequence highest-sequence-seen)) > chunks))) This change means the result of the mapcar is no longer used or returned, giving rise to the following warning: In gnus-cloud-download-data: gnus/gnus-cloud.el:482:12: Warning: =E2=80=98mapcar=E2=80=99 called for e= ffect; use =E2=80=98mapc=E2=80=99 or =E2=80=98dolist=E2=80=99 instead It also makes highest-sequence-seen the return value of gnus-cloud-download-data. Is this intended? Thanks, --=20 Basil From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 17 04:13:43 2020 Received: (at 40280) by debbugs.gnu.org; 17 Jun 2020 08:13:43 +0000 Received: from localhost ([127.0.0.1]:50298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlTCY-00041M-Jj for submit@debbugs.gnu.org; Wed, 17 Jun 2020 04:13:42 -0400 Received: from mail-wr1-f53.google.com ([209.85.221.53]:37425) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlTCU-000413-K9 for 40280@debbugs.gnu.org; Wed, 17 Jun 2020 04:13:41 -0400 Received: by mail-wr1-f53.google.com with SMTP id x13so1303414wrv.4 for <40280@debbugs.gnu.org>; Wed, 17 Jun 2020 01:13:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dme-org.20150623.gappssmtp.com; s=20150623; h=to:cc:subject:in-reply-to:references:from:date:message-id :mime-version:content-transfer-encoding; bh=SXS2lA+CIlXzabjN31CYaluaiCMXRNrwCpIcuSMjgMA=; b=sZSOGzl3Pno0NMWlSYFzaPChrw5Vx1fvLW3zA8uNmAPoD72jxMq98rrmfDZJewGI40 UtzddRtVZ+QrfT/eEjju/XL38AupPqP1Hk/Ax/pUno99SyVFE38bONl8WDqEs83JCkZq mjKv2GHUqUKq+OxXiDJwG1SZ3akO7tvD268CNuvd4IKqtmfss60d4eTMaQxtMgT57YDp XwhK8XoVAqBtk2DlSDHpFdzyeRbp73ByKiof1ZQSS/O2dLIVjLP08gjGr38KdQXt3Ye+ WSCMbM7JgquKt42/mv4O3cIohWZAmS1QR2QtBXLXBoxGQIC6+WhUJL3FsLxFbIu0GDWg /4KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:subject:in-reply-to:references:from:date :message-id:mime-version:content-transfer-encoding; bh=SXS2lA+CIlXzabjN31CYaluaiCMXRNrwCpIcuSMjgMA=; b=G6rf2SZ7OUL2WTMiXQ/Y2bBQZtv6jhbCbMesVQwk6wiyE08XTNjOg9jHNSmJa/W3CC jdFswZdXPIa+a49fcSSs/geW/M2VgIlpxcICsLYL/UMnNxVjcE3eQLngiJ+QrM7SqQ1o hcRAjeK61rtRzxtdqb/uwbWEkZ9k6Wmj9qZP0aW8SNiCnmqX8NUWNfHxwhaFDzGgnsJt 9XsipNdC5vrxcPXDnQsWNMrSgePJicQ0J6zPdiIj+4U/ZQ6rtLcejCcwDP4eVfLVgEac P9RrVfCaYRukfFSU4xIr3KyhhrKzHWMVBX5i/vZPsRL5moYcgSRXW3kAR/Ri0y6gmrGE KfPg== X-Gm-Message-State: AOAM531VQUJjFuKDlFSvKtiEcNdzDFPlFRiAywmN4eYFpBKdzd/li972 8mCO4KRhAUwtXNglXLSc0zOBKpC/ssd/uA== X-Google-Smtp-Source: ABdhPJxqDqdv49rbHxwGproOZDz4hgLS5HvOellxofivgu2hss6ImbUBskJ+/H5Jedc+XWZ5wIabMQ== X-Received: by 2002:adf:df03:: with SMTP id y3mr6843530wrl.376.1592381612119; Wed, 17 Jun 2020 01:13:32 -0700 (PDT) Received: from disaster-area.hh.sledj.net (8.a.e.d.0.0.0.0.0.0.0.0.4.6.0.0.0.4.1.7.1.7.b.b.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:bb71:7140:64::dea8]) by smtp.gmail.com with ESMTPSA id n1sm32105337wrp.10.2020.06.17.01.13.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2020 01:13:31 -0700 (PDT) Received: from localhost (disaster-area.hh.sledj.net [local]) by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id 6c750dfd; Wed, 17 Jun 2020 08:13:30 +0000 (UTC) To: "Basil L. Contovounesios" Subject: Re: bug#40280: gnus-cloud doesn't do anything useful In-Reply-To: <87y2omq1q2.fsf@tcd.ie> References: <87y2omq1q2.fsf@tcd.ie> X-HGTTG: heart-of-gold From: David Edmondson Date: Wed, 17 Jun 2020 09:13:29 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 40280 Cc: 40280@debbugs.gnu.org, Ted Zlatanov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) On Tuesday, 2020-06-16 at 19:56:05 +01, Basil L. Contovounesios wrote: >> From a3bdd2219855a72e2ee90de1b6f823c9678a470c Mon Sep 17 00:00:00 2001 >> From: David Edmondson >> Date: Sat, 28 Mar 2020 19:03:58 +0000 >> Subject: [PATCH] gnus-cloud: Improve cloud sync >> >> After replaying a set of actions downloaded by gnus-cloud, persist the >> highest sequence number seen as the local `gnus-cloud-sequence' >> number, in order that a future download will not unnecessarily replay >> previously seen actions and any future uploads from this emacs >> instance use a higher sequence number than that downloaded. >> >> Remove the test on whether individual newsrc entries are older than >> the current time, as that is always going to be the case. > > In the future please follow the formatting guidelines for change log > messages described in the file CONTRIBUTE. Understood. > [...] > >> --- a/lisp/gnus/gnus-cloud.el >> +++ b/lisp/gnus/gnus-cloud.el >> @@ -480,7 +478,9 @@ Otherwise, returns the Gnus Cloud data chunks." >> (push (gnus-cloud-parse-chunk) chunks) >> (forward-line 1)))) >> (if update >> - (mapcar #'gnus-cloud-update-all chunks) >> + (progn >> + (mapcar #'gnus-cloud-update-all chunks) >> + (setq gnus-cloud-sequence highest-sequence-seen)) >> chunks))) > > This change means the result of the mapcar is no longer used or > returned, giving rise to the following warning: > > In gnus-cloud-download-data: > gnus/gnus-cloud.el:482:12: Warning: =E2=80=98mapcar=E2=80=99 called for= effect; use =E2=80=98mapc=E2=80=99 or > =E2=80=98dolist=E2=80=99 instead > > It also makes highest-sequence-seen the return value of > gnus-cloud-download-data. Is this intended? No, it's not an intended change and is not desirable. Presumably replacing `progn' with `prog1' would properly restore the previous behaviour. Should I submit a further patch? dme. --=20 J'aurais toujours faim de toi. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 17 10:11:08 2020 Received: (at 40280) by debbugs.gnu.org; 17 Jun 2020 14:11:08 +0000 Received: from localhost ([127.0.0.1]:51938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlYmS-0005Aq-2P for submit@debbugs.gnu.org; Wed, 17 Jun 2020 10:11:08 -0400 Received: from mail-qk1-f173.google.com ([209.85.222.173]:42247) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlYmP-0005AL-8F for 40280@debbugs.gnu.org; Wed, 17 Jun 2020 10:11:06 -0400 Received: by mail-qk1-f173.google.com with SMTP id l17so2078277qki.9 for <40280@debbugs.gnu.org>; Wed, 17 Jun 2020 07:11:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=ywDFqwpfAoz4gR2pLAcr3XtyvQRL2FbhghWKobf+9mA=; b=ehzY3dMBZvdHYjRrul/gFsNuh9wlShHzvL10pnr3clZrRz7w3CgogGIz0q3VskQN5e vNacCsPPS9GGUWhpQ5+dobmgkrmFUfqebLBw7ycOtAnJrRAKRZH4KP8FV4PBTKNhTnyU yjjaSwLJ2ZsdQRF9q8+CBbIjirgB0XcGgX9Sg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:date:in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=ywDFqwpfAoz4gR2pLAcr3XtyvQRL2FbhghWKobf+9mA=; b=P/I35/p48L8Qu6iEotb7tGP//8gt+fXMzmOQINHPagvCbuccS3376WUra+kUrM0cHu 8hhab1kllqSuc+iSfR+d0IcqiWimuS6zG5mk+nKLfb1Q8oT+d0RtqbT3EPxOC4THSRSz /l1yW7sV4G5XsCx9MtbsiIUmPlJpDbJoEpIu+WljTTgmGl3Hnrk5KgFWCcuhrPVMFhNe bXKaEfI6njaz/+6Sgv4ZFF4yQbP6Wf8PYw5bVyTv0aEsAYWKLFkiwBldCa32CNNgrvH5 Y0vz1iqpSK/YYx+TfKUbuptpV0zEoaRFvVFCMqFfXc2PezC7ibiBIG+DNS+AQZwJ8M/x BDiA== X-Gm-Message-State: AOAM531I2O1x1JP/C3dNRPkzlC8awYU2Tkk3PX29VoqY7MMDcncHaRZg o6pp1OUGcWr7hKK2SJsEIPQWj90ia9kzzw== X-Google-Smtp-Source: ABdhPJyV4kBoqw//3oZadM6ffTw006QquyCqJsVgRnFUYj3HS/SVaVpQHjW4K9+NNRQoltXl9h1nRw== X-Received: by 2002:a05:620a:ecf:: with SMTP id x15mr24656942qkm.465.1592403059248; Wed, 17 Jun 2020 07:10:59 -0700 (PDT) Received: from flea (c-76-28-41-155.hsd1.ma.comcast.net. [76.28.41.155]) by smtp.gmail.com with ESMTPSA id 5sm18114qkr.9.2020.06.17.07.10.57 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 Jun 2020 07:10:58 -0700 (PDT) From: Ted Zlatanov To: David Edmondson Subject: Re: bug#40280: gnus-cloud doesn't do anything useful Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: <87y2omq1q2.fsf@tcd.ie> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Date: Wed, 17 Jun 2020 14:10:56 +0000 In-Reply-To: (David Edmondson's message of "Wed, 17 Jun 2020 09:13:29 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40280 Cc: "Basil L. Contovounesios" , 40280@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed, 17 Jun 2020 09:13:29 +0100 David Edmondson wrote:=20 DE> On Tuesday, 2020-06-16 at 19:56:05 +01, Basil L. Contovounesios wrote: >> This change means the result of the mapcar is no longer used or >> returned, giving rise to the following warning: >>=20 >> In gnus-cloud-download-data: >> gnus/gnus-cloud.el:482:12: Warning: =E2=80=98mapcar=E2=80=99 called for = effect; use =E2=80=98mapc=E2=80=99 or >> =E2=80=98dolist=E2=80=99 instead >>=20 >> It also makes highest-sequence-seen the return value of >> gnus-cloud-download-data. Is this intended? DE> No, it's not an intended change and is not desirable. Presumably DE> replacing `progn' with `prog1' would properly restore the previous DE> behaviour. DE> Should I submit a further patch? Please do. Thanks to you and Basil. Ted From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 23 07:53:03 2020 Received: (at 40280) by debbugs.gnu.org; 23 Jun 2020 11:53:03 +0000 Received: from localhost ([127.0.0.1]:35603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnhU7-0005QJ-Dl for submit@debbugs.gnu.org; Tue, 23 Jun 2020 07:53:03 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:39881) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnhU4-0005Pn-F6 for 40280@debbugs.gnu.org; Tue, 23 Jun 2020 07:53:02 -0400 Received: by mail-wm1-f44.google.com with SMTP id t194so2886922wmt.4 for <40280@debbugs.gnu.org>; Tue, 23 Jun 2020 04:53:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dme-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=U0b6J0BNXpn4E66XybnTkiZ24XzLZV9Cxk9lPCuyQAQ=; b=T8Vb+OaJ22jNmNgRvJRClEsMoC7g8U9vnY1ER2zik5LK4G9COMHgLQdFIO8BkEX8e9 72B/Xgy6VN4Vjd3uIQaYGLfeuRdYbHMj3uYW49URq14EuvLsHrmpUXfR8x0FwUeNMm0u +cjMLOC4fyI+r2BySUFv8n3IJbCp5B5sGP0nllVeJ33RGJ2er7GwJYTb1AIYO7gPj1Zx 0MW14VdG2stnXU1uTZsAbpzdKoOxmPeDDfx+BdOVABCnPHhfBQbsMNdyTMZizj2tHcjg /YyEVmXcEpW0061oWx1YQ6OaT3ndUXtY693TEcROw93FYyNt/DV7E/tT1q7DFbUl6yMy M5Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=U0b6J0BNXpn4E66XybnTkiZ24XzLZV9Cxk9lPCuyQAQ=; b=NGAzB5Y2qLp5OT28q+dXPaOSe1vkwV9vlVOCbDw7ot1Aax/D8tvkLsEfdjRHs/bEu9 SbJcJtrgFLnubbTG9yveq2oPVYAc6Di4YWkwvOpdCO5D/sHylD+xEuISQQHF/pWKmXRi siJ1rWUJNduWiWFeUQWyjm7+SIXIP8FZtAiXzCbh1wG3miQ+e2nEH1owjxoM8tlEQJmI J6pkqmVGbaf2vjGWCewJc0ubwDgbCBVzb46584K3GVWQiqEKL4D12bxHNJh+TNAKw0Nc Hlb1ZZyZo3Mo3DY/ZxqI71uwdb+m95gcOTF7CMSOjvUw3dgiRjCU909SLpl02Hy0cj/5 xB8Q== X-Gm-Message-State: AOAM531GbYnpXAnhOkBDBzWG7wNFZaMxgPoBfQOnKloTOQ7O9VawHdX7 Zc9kjnOIWm/d7Q8v+tfIP6sU7UYzCoySSQ== X-Google-Smtp-Source: ABdhPJwPZlp/yH7veqVaI7voZj/KE/RJ2KXOctu3engMPjJ9ygMca8ZkEphHdCkdIK/RxxMBh8QAGw== X-Received: by 2002:a7b:c441:: with SMTP id l1mr22531145wmi.7.1592913174003; Tue, 23 Jun 2020 04:52:54 -0700 (PDT) Received: from disaster-area.hh.sledj.net (8.a.e.d.0.0.0.0.0.0.0.0.4.6.0.0.0.4.1.7.1.7.b.b.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:bb71:7140:64::dea8]) by smtp.gmail.com with ESMTPSA id o7sm1358855wmb.9.2020.06.23.04.52.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2020 04:52:53 -0700 (PDT) Received: from localhost (disaster-area.hh.sledj.net [local]) by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id 59a4a9ae; Tue, 23 Jun 2020 11:52:52 +0000 (UTC) From: David Edmondson To: 40280@debbugs.gnu.org Subject: [PATCH] Fix gnus-cloud-download-all-data return value Date: Tue, 23 Jun 2020 12:52:34 +0100 Message-Id: <20200623115234.909041-1-dme@dme.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 40280 Cc: David Edmondson X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) * lisp/gnus/gnus-cloud.el (gnus-cloud-download-data): Return the result of calling `gnus-cloud-update-all' when UPDATE is t, as per the documented behaviour. --- lisp/gnus/gnus-cloud.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/gnus/gnus-cloud.el b/lisp/gnus/gnus-cloud.el index 5028da5e8d..f730518241 100644 --- a/lisp/gnus/gnus-cloud.el +++ b/lisp/gnus/gnus-cloud.el @@ -478,8 +478,8 @@ Otherwise, returns the Gnus Cloud data chunks." (push (gnus-cloud-parse-chunk) chunks) (forward-line 1)))) (if update - (progn - (mapc #'gnus-cloud-update-all chunks) + (prog1 + (mapcar #'gnus-cloud-update-all chunks) (setq gnus-cloud-sequence highest-sequence-seen)) chunks))) -- 2.27.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 23 09:14:54 2020 Received: (at 40280) by debbugs.gnu.org; 23 Jun 2020 13:14:54 +0000 Received: from localhost ([127.0.0.1]:35730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnilK-0007MQ-6t for submit@debbugs.gnu.org; Tue, 23 Jun 2020 09:14:54 -0400 Received: from mail-qk1-f182.google.com ([209.85.222.182]:32906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnilI-0007MC-22 for 40280@debbugs.gnu.org; Tue, 23 Jun 2020 09:14:53 -0400 Received: by mail-qk1-f182.google.com with SMTP id j80so7384579qke.0 for <40280@debbugs.gnu.org>; Tue, 23 Jun 2020 06:14:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to:date :in-reply-to:message-id:user-agent:mime-version; bh=rK5oc6iPoCemj8bUHB/4ctw4DQ+08WCzESOnQjPHB4Y=; b=Ct+yIcGTdOEBdre/RLMOqZ6IGmto9P0qHM5+31p6WPLWR2m8d61i14u0TOyTlV/X1l iWYpsX66dqGdvjr9gktKmN4QwzVlGfSBVkdZEuVjTNFJLGBXgWTu8wkihaYpvohkHMYK bDw+rZ02VDsAS26r0lmshWsO8mDSx3iRIWut4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:date:in-reply-to:message-id:user-agent:mime-version; bh=rK5oc6iPoCemj8bUHB/4ctw4DQ+08WCzESOnQjPHB4Y=; b=gtbotSxLc/3Tan1xtsOydntN4g0YLwg7kfAcvEmtEao50aLuq6AO0J7lb9ydix0ZaS 0iwphR15YkbtonLiyT3aGTWmrrunBm0SmiowJKUOPsKDvFQYjHa7ycMAwj7doEDW58yV 5tfLNl3USO45ceVonmfomKhggYZNnECFWMGmzQc0/KujhKZSeQdKT6Pv/GOIfVVvqRsH sJvy0bjJWK+8K1vmddQ4bjoQxD8lHYjLyJaffWikc6Q0pfn3ovPjAuj2GMhmKODnPYS8 gBkd3/XnMu4s9Rw1xQ9RWbeGk2fZ4c7lfZ+yBYt4ew4vIhdtIqUAYNsslMWLlr4rzsMj Tt3g== X-Gm-Message-State: AOAM530/BNU0VCMH8UTlv6YWBFmt7LZbs+VIV4KNvOsnh1clI+nE2NZI vEOMCB/WcTXJlDUPc5MDtNY9GO+BcyvVlw== X-Google-Smtp-Source: ABdhPJzEqBusflmYg70kN8WBAWDrVlsLYs0EBMv2M5J4P+62Sm7ChRsxsO8eCfE2SrKi7vrV476RkQ== X-Received: by 2002:a37:4b17:: with SMTP id y23mr19880708qka.73.1592918086151; Tue, 23 Jun 2020 06:14:46 -0700 (PDT) Received: from flea (c-76-28-41-155.hsd1.ma.comcast.net. [76.28.41.155]) by smtp.gmail.com with ESMTPSA id j4sm520551qtv.68.2020.06.23.06.14.44 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Jun 2020 06:14:44 -0700 (PDT) From: Ted Zlatanov To: David Edmondson Subject: Re: bug#40280: [PATCH] Fix gnus-cloud-download-all-data return value Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: <20200623115234.909041-1-dme@dme.org> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Date: Tue, 23 Jun 2020 13:14:43 +0000 In-Reply-To: <20200623115234.909041-1-dme@dme.org> (David Edmondson's message of "Tue, 23 Jun 2020 12:52:34 +0100") Message-ID: <366lncu4.fsf@lifelogs.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40280 Cc: 40280@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, 23 Jun 2020 12:52:34 +0100 David Edmondson wrote: DE> * lisp/gnus/gnus-cloud.el (gnus-cloud-download-data): Return the DE> result of calling `gnus-cloud-update-all' when UPDATE is t, as per the DE> documented behaviour. Thanks David. Applied with slightly adjusted commit message. Ted From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 18 22:39:34 2020 Received: (at 40280) by debbugs.gnu.org; 19 Jul 2020 02:39:34 +0000 Received: from localhost ([127.0.0.1]:59770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwzEk-0000qQ-J9 for submit@debbugs.gnu.org; Sat, 18 Jul 2020 22:39:34 -0400 Received: from quimby.gnus.org ([95.216.78.240]:56718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwzEj-0000qC-AP for 40280@debbugs.gnu.org; Sat, 18 Jul 2020 22:39:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=c4Tcoem862YlNjrDGVUQfJfRy2U9tZM3+r2qBCHht/0=; b=uIpEA9EtyvI86VlLu+EHCpJv2X uhQ2pYplWLgQlV7uhynrbCJ0LhuyJQIV9vt2aK3eyjEKip9ZV2BFYK/8yLO1WBT1ujVndwIj1Eyuc md1SWng4H2rrOTTaUYihPr65AbkkjNsBhj6rwPYtxQa8M6aplcR+GKUZ9iGuzUqGWxqM=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jwzEU-0008JD-Bz; Sun, 19 Jul 2020 04:39:27 +0200 From: Lars Ingebrigtsen To: David Edmondson Subject: Re: bug#40280: [PATCH] Fix gnus-cloud-download-all-data return value References: <20200623115234.909041-1-dme@dme.org> <366lncu4.fsf@lifelogs.com> Date: Sun, 19 Jul 2020 04:39:17 +0200 In-Reply-To: <366lncu4.fsf@lifelogs.com> (Ted Zlatanov's message of "Tue, 23 Jun 2020 13:14:43 +0000") Message-ID: <87tuy4tei2.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Ted Zlatanov writes: > On Tue, 23 Jun 2020 12:52:34 +0100 David Edmondson wrote: > > DE> * lisp/gnus/gnus-cloud.el (gnus-cloud-download-data): Return the > DE> result of calling `gnus-cloud-update-all' when [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40280 Cc: 40280@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ted Zlatanov writes: > On Tue, 23 Jun 2020 12:52:34 +0100 David Edmondson wrote: > > DE> * lisp/gnus/gnus-cloud.el (gnus-cloud-download-data): Return the > DE> result of calling `gnus-cloud-update-all' when UPDATE is t, as per the > DE> documented behaviour. > > Thanks David. Applied with slightly adjusted commit message. If I understand correctly, the matters in this bug reports were all fixed, and I'm now closing this bug report. Please reopen if that isn't the case. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 18 22:39:42 2020 Received: (at control) by debbugs.gnu.org; 19 Jul 2020 02:39:42 +0000 Received: from localhost ([127.0.0.1]:59773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwzEr-0000qk-QF for submit@debbugs.gnu.org; Sat, 18 Jul 2020 22:39:42 -0400 Received: from quimby.gnus.org ([95.216.78.240]:56732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwzEq-0000qX-Gu for control@debbugs.gnu.org; Sat, 18 Jul 2020 22:39:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=K7cXNS9nZu/AR9H728GZXuW/gxTZEU5+P2DGS/9uCVQ=; b=ujGZYOaNqR2wseDvlhdayx/2WC fvkz0k0K4DXMvgy9N7Ua2Pn2QUgCsrkKwJYZTrgJx4uEoeOzbyFXsvVUTu4g7NH58iSkLbWYz5FRR 7QUZsblHBovSUYl3rQC2aYGn8J5iVeIzJ0C3YS1qjpFr0RI1E4Wll8/D96BCDUvSySuM=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jwzEi-0008JO-Q4 for control@debbugs.gnu.org; Sun, 19 Jul 2020 04:39:34 +0200 Date: Sun, 19 Jul 2020 04:39:31 +0200 Message-Id: <87sgdoteho.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #40280 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 40280 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 40280 quit From unknown Sat Aug 16 18:43:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 16 Aug 2020 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator