Subject: Re: [bug#40246] [PATCH] gnu: Add cramfs-tools.

From: Ludovic Courtès <[email-masked]>
Date: Wed, 01 Apr 2020 23:22:46 +0200

Hi Vincent,

Vincent Legoll <[email-masked]> skribis:

> From ff79a4b2d798bba222ac502a7aa1f7ef0a97e249 Mon Sep 17 00:00:00 2001
> From: Vincent Legoll <[email-masked]>
> Date: Thu, 26 Mar 2020 23:12:53 +0100
> Subject: [PATCH] gnu: Add cramfs-tools.
>
> * gnu/packages/linux.scm (cramfs-tools): New variable.

[...]

> +    (name "cramfs-tools")
> +    (version "2.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/npitre/cramfs-tools/archive/v"

As reported by ‘guix lint’, please don’t refer to a generated tarball.

Instead you can use a hosted “hand-crafted” tarball if there’s one or,
more likely, ‘git-fetch’.

> +    (synopsis "Tools to manage Cramfs filesystems")
> +    (description "Cramfs is a Linux filesystem designed to be simple, small,
> +and to compress things well.  It is used on a number of embedded systems and
> +small devices.  This version has additional features such as uncompressed
> +blocks and random block placement.")

Could you write “file systems” (two words)?  This is by convention in
GNU and Guix.

Thanks in advance!

Ludo’.