Subject: 26.1; browse-url, needs to % hex hex encode the hash char

From: larice <[email-masked]>
Date: Thu, 26 Mar 2020 11:16:05 +0100

Dear Maintainers,

  I couldn't open a link in org mode, which happened
    to contain a hash char #.
  A search for the culprit revealed usage of this
    (setq url (browse-url-encode-url url))
  in several functions,
  for example in browse-url-firefox in file browse-url.el

  This function looks like:

  (defun browse-url-encode-url (url)
  "Escape annoying characters in URL.
The annoying characters are those that can mislead a web browser
regarding its parameter treatment."
  ;; FIXME: Is there an actual example of a web browser getting
  ;; confused?  (This used to encode commas, but at least Firefox
  ;; handles commas correctly and doesn't accept encoded commas.)
  (browse-url-url-encode-chars url "[\")$] "))

  I suggest to add the char '#' to the second argument of the
    browse-url-url-encode-chars invocation to fix the nuisance.

Best Regards,
  Robert Larice