From unknown Mon Aug 18 09:05:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40211] [PATCH 0/2] Enable udev support in SDL2 and bump version Resent-From: Timotej Lazar Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 24 Mar 2020 14:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 40211 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 40211@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.158505873818789 (code B ref -1); Tue, 24 Mar 2020 14:06:01 +0000 Received: (at submit) by debbugs.gnu.org; 24 Mar 2020 14:05:38 +0000 Received: from localhost ([127.0.0.1]:55390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGkBU-0004su-Ad for submit@debbugs.gnu.org; Tue, 24 Mar 2020 10:05:38 -0400 Received: from lists.gnu.org ([209.51.188.17]:52126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGkBQ-0004sa-9u for submit@debbugs.gnu.org; Tue, 24 Mar 2020 10:05:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54578) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGkBO-0006Cu-Hq for guix-patches@gnu.org; Tue, 24 Mar 2020 10:05:32 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGkBK-0001tN-Pr for guix-patches@gnu.org; Tue, 24 Mar 2020 10:05:30 -0400 Received: from araneo.si ([2001:15c0:2110:3400::2]:37666) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jGkBK-0001jr-9o for guix-patches@gnu.org; Tue, 24 Mar 2020 10:05:26 -0400 Received: from araneo.si (localhost.lan [127.0.0.1]) by araneo.si (OpenSMTPD) with ESMTP id 47f14c66 for ; Tue, 24 Mar 2020 14:05:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=araneo.si; h=from:to :subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=20180623; bh=WGs2ZnSHTbhaNPh1Mzjoc a3jrHQ=; b=snBQlDKLroPCNGVp58EC7GqcmB9Nd+ULTwAmWmoNa/wN495hx2gFg rBj4MWIQG51SDxWSd/Fi4+axDHChC040OZRQTu3Xv5urSm0LLxRrsC9hCFqSaTVy SK7NeT+HagKA7c3jocDW9wi/vYe7PYqEyxu1wt6K4OLl3I/wZArvwlJ9Wqq+BaCo vEX/EtIy9e0xnop8iASRs6o0J7p285db8EIxNF44MxempaHPcpuDGX3H0gXkIlbJ VmxBF3HjISx9ayGrLoaMNMf8A2fL45AXsBStjOkl2whk1bw5PdVmeSfHidcs+NkC j3juSISSPWaQek0W4o35Q6OwjuOUZCx9g== Received: by araneo.si (OpenSMTPD) with ESMTPSA id 3c4be8ef (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Tue, 24 Mar 2020 14:05:20 +0000 (UTC) From: Timotej Lazar Date: Tue, 24 Mar 2020 15:05:19 +0100 Message-ID: <87tv2dc0gw.fsf@araneo.si> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:15c0:2110:3400::2 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi, these patches update sdl2 to the latest release and enable udev support. Without udev I experienced freezes every few seconds in certain games (for instance hedgewars and supertux) as SDL searched through /dev/input for joysticks. Since libudev is dlopened, I add it to rpath in make-flags. During build this overrides LDFLAGS from the base package=E2=80=99s configure-flags, whi= ch add mesa to rpath. AFAICT this is OK as sdl2 already includes mesa by linking libgbm. (Perhaps we could move LDFLAGS to make-flags in the base package, and make the override explicit in the derived package? Or have sdl2 find and modify the LDFLAGS entry from the base configure-flags, but that seems more trouble than it=E2=80=99s worth.) I was able to rebuild all dependent packages with no (new) failures. I ran several games and everything appears OK, but I don=E2=80=99t have a joy= stick or gamepad to try. There have been some issues in the past with SDL not finding (correct) libraries=C2=B9, so it would be good to test this on a foreign Guix install. As for the version bump, the changelog=C2=B2 doesn=E2=80=99t mention any si= gnificant changes except for hidapi support, which is disabled by default. Thanks! Timotej =C2=B9 https://lists.gnu.org/archive/html/guix-devel/2015-03/msg00585.html =C2=B2 https://hg.libsdl.org/SDL/file/355a4f94a782/WhatsNew.txt Timotej Lazar (2): gnu: sdl2: Use udev to discover input devices. gnu: sdl2: Update to 2.0.12. gnu/local.mk | 1 - gnu/packages/patches/sdl2-mesa-compat.patch | 21 ---------------- gnu/packages/sdl.scm | 27 ++++++++++++--------- 3 files changed, 16 insertions(+), 33 deletions(-) delete mode 100644 gnu/packages/patches/sdl2-mesa-compat.patch --=20 2.25.1 From unknown Mon Aug 18 09:05:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40211] [PATCH 1/2] gnu: sdl2: Use udev to discover input devices. Resent-From: Timotej Lazar Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 24 Mar 2020 14:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40211 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 40211@debbugs.gnu.org Cc: Timotej Lazar Received: via spool by 40211-submit@debbugs.gnu.org id=B40211.158505909019393 (code B ref 40211); Tue, 24 Mar 2020 14:12:02 +0000 Received: (at 40211) by debbugs.gnu.org; 24 Mar 2020 14:11:30 +0000 Received: from localhost ([127.0.0.1]:55400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGkHC-00052j-9E for submit@debbugs.gnu.org; Tue, 24 Mar 2020 10:11:30 -0400 Received: from araneo.si ([90.157.193.204]:34728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGkHA-00052a-NN for 40211@debbugs.gnu.org; Tue, 24 Mar 2020 10:11:29 -0400 Received: from araneo.si (localhost.lan [127.0.0.1]) by araneo.si (OpenSMTPD) with ESMTP id 0e742cca for <40211@debbugs.gnu.org>; Tue, 24 Mar 2020 14:11:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=araneo.si; h=from:to:cc :subject:date:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=20180623; bh=Bv5A1Z/c DLZgX+cbfskXvhM5+Hc=; b=nEW3leW0scvJlS0nbzm6qffbSZfpPE1NaClQ33ed oMRh3hK5x2fPndahwjrl1le/wLFdT1BY/lSsk4WQkx0n4/3HRWL5LZUES2W7PZFm RYEwO5jbdqieHfhnxnAQW/q6vHnppBIqvC6DYs0x3QsOCncxPmqs7ziS8cpmAD4D eyZahe/Ex/iLAj7pIpvQ7PIec7L4X2v25yO4Wi833Cwhy8ZuvhSyAtwz3NKnFxy0 fM6bTWfhD3KJE0TqpMoT6Zo4jSwEgUIx8FPbpMX8nt+uOjzQ07rmhDJNW63VXw1k wci0BwOoT3oBA8j+Gd14tcDl6ccCXdTxjBwvAPNKp7MvOg== Received: by araneo.si (OpenSMTPD) with ESMTPSA id b78c5aa1 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 24 Mar 2020 14:11:26 +0000 (UTC) From: Timotej Lazar Date: Tue, 24 Mar 2020 15:10:36 +0100 Message-Id: <20200324141037.28250-1-timotej.lazar@araneo.si> X-Mailer: git-send-email 2.25.1 In-Reply-To: <87tv2dc0gw.fsf@araneo.si> References: <87tv2dc0gw.fsf@araneo.si> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Without udev SDL falls back on custom detection code, which blocks every three seconds while checking for new devices. * gnu/packages/sdl.scm (sdl2)[inputs]: Add eudev. [arguments]<#:make-flags>: Add LDFLAGS to include eudev in rpath so that dlopen can find it. --- gnu/packages/sdl.scm | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/gnu/packages/sdl.scm b/gnu/packages/sdl.scm index 25b0bdba2b..8b21f813c9 100644 --- a/gnu/packages/sdl.scm +++ b/gnu/packages/sdl.scm @@ -132,20 +132,26 @@ joystick, and graphics hardware.") "--disable-kmsdrm-shared") ,flags)) ((#:make-flags flags ''()) - ;; Add the Fcitx header files to GCCs "system header" search path - ;; in order to suppress compiler warnings induced by those: - ;; .../include/fcitx-utils/utarray.h:178:9: error: ISO C90 forbids - ;; mixed declarations and code [-Werror=declaration-after-statement] - `(append (list (string-append "C_INCLUDE_PATH=" - (assoc-ref %build-inputs "fcitx") - "/include")) - ,flags)))) + `(cons* + ;; Add the Fcitx header files to GCCs "system header" search path + ;; in order to suppress compiler warnings induced by those: + ;; .../include/fcitx-utils/utarray.h:178:9: error: ISO C90 forbids + ;; mixed declarations and code [-Werror=declaration-after-statement] + (string-append "C_INCLUDE_PATH=" + (assoc-ref %build-inputs "fcitx") "/include") + ;; SDL dlopens libudev, so make sure it is in rpath. This overrides + ;; the LDFLAG set in sdl’s configure-flags, which isn’t necessary + ;; as sdl2 includes Mesa by default. + (string-append "LDFLAGS=-Wl,-rpath," + (assoc-ref %build-inputs "eudev") "/lib") + ,flags)))) (inputs ;; SDL2 needs to be built with ibus support otherwise some systems ;; experience a bug where input events are doubled. ;; ;; For more information, see: https://dev.solus-project.com/T1721 (append `(("dbus" ,dbus) + ("eudev" ,eudev) ; for discovering input devices ("fcitx" ,fcitx) ; helps with CJK input ("glib" ,glib) ("ibus" ,ibus) -- 2.25.1 From unknown Mon Aug 18 09:05:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40211] [PATCH 2/2] gnu: sdl2: Update to 2.0.12. Resent-From: Timotej Lazar Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 24 Mar 2020 14:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40211 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 40211@debbugs.gnu.org Cc: Timotej Lazar Received: via spool by 40211-submit@debbugs.gnu.org id=B40211.158505909919414 (code B ref 40211); Tue, 24 Mar 2020 14:12:02 +0000 Received: (at 40211) by debbugs.gnu.org; 24 Mar 2020 14:11:39 +0000 Received: from localhost ([127.0.0.1]:55404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGkHL-000534-HG for submit@debbugs.gnu.org; Tue, 24 Mar 2020 10:11:39 -0400 Received: from araneo.si ([90.157.193.204]:34728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGkHI-00052a-9f for 40211@debbugs.gnu.org; Tue, 24 Mar 2020 10:11:38 -0400 Received: from araneo.si (localhost.lan [127.0.0.1]) by araneo.si (OpenSMTPD) with ESMTP id 8fab5eeb for <40211@debbugs.gnu.org>; Tue, 24 Mar 2020 14:11:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=araneo.si; h=from:to:cc :subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; s=20180623; bh=aiWdb8BB0DJAC8nmvQA6f L+D5mk=; b=tvUb69qakbA3YdDNAPiACBMlSKXDrRKAOmztb8+DHnrAQN5RfPwL8 Hdl6sSm48PMn79RduxyZkdz/5VICfHxnXBbOokY+0QAsICmX7blBgOhxbSoWXzg8 QhdzqDsAiZ4PsZ4GNMzw54xT6vTuiAhhHAI8TyV8v3qrWMQeeMYaDXjoQrTle9IU +1mfPe/eKU8rIcUjKw4K3M1oIMkzFFC7gTE7vX2HjVBnZoS11qi1tlKfyDWP16yd g5BOSx0zbsqi2j6paXG8jGw8VJH8QpcRl66Xk95aOOeQNviyc3+MiaqzxqqHMfnk Hef8JFlwPlmZvmkzGI8DkMGHYTNEPmwVg== Received: by araneo.si (OpenSMTPD) with ESMTPSA id 0575bd6a (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 24 Mar 2020 14:11:34 +0000 (UTC) From: Timotej Lazar Date: Tue, 24 Mar 2020 15:10:37 +0100 Message-Id: <20200324141037.28250-2-timotej.lazar@araneo.si> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200324141037.28250-1-timotej.lazar@araneo.si> References: <87tv2dc0gw.fsf@araneo.si> <20200324141037.28250-1-timotej.lazar@araneo.si> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/patches/sdl2-mesa-compat.patch: Delete file. * gnu/packages/sdl.scm (sdl2): Update to 2.0.12. [source]: Drop patch that was included in this release. --- gnu/local.mk | 1 - gnu/packages/patches/sdl2-mesa-compat.patch | 21 --------------------- gnu/packages/sdl.scm | 5 ++--- 3 files changed, 2 insertions(+), 25 deletions(-) delete mode 100644 gnu/packages/patches/sdl2-mesa-compat.patch diff --git a/gnu/local.mk b/gnu/local.mk index 7cce60b7c0..ef11ac4a04 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1411,7 +1411,6 @@ dist_patch_DATA = \ %D%/packages/patches/scotch-build-parallelism.patch \ %D%/packages/patches/scotch-integer-declarations.patch \ %D%/packages/patches/sdl-libx11-1.6.patch \ - %D%/packages/patches/sdl2-mesa-compat.patch \ %D%/packages/patches/seahorse-gkr-use-0-on-empty-flags.patch \ %D%/packages/patches/seq24-rename-mutex.patch \ %D%/packages/patches/sharutils-CVE-2018-1000097.patch \ diff --git a/gnu/packages/patches/sdl2-mesa-compat.patch b/gnu/packages/patches/sdl2-mesa-compat.patch deleted file mode 100644 index 8182e582e7..0000000000 --- a/gnu/packages/patches/sdl2-mesa-compat.patch +++ /dev/null @@ -1,21 +0,0 @@ -Do not include GLES header when OpenGL headers are already included. - -Taken from upstream: -https://hg.libsdl.org/SDL/rev/369b01006eb2 - -diff -r 4cbaffd0083b -r 369b01006eb2 src/video/SDL_video.c ---- a/src/video/SDL_video.c Fri Oct 11 06:18:24 2019 +0200 -+++ b/src/video/SDL_video.c Sat Oct 12 18:47:56 2019 +0200 -@@ -37,9 +37,9 @@ - #include "SDL_opengl.h" - #endif /* SDL_VIDEO_OPENGL */ - --#if SDL_VIDEO_OPENGL_ES -+#if SDL_VIDEO_OPENGL_ES && !SDL_VIDEO_OPENGL - #include "SDL_opengles.h" --#endif /* SDL_VIDEO_OPENGL_ES */ -+#endif /* SDL_VIDEO_OPENGL_ES && !SDL_VIDEO_OPENGL */ - - /* GL and GLES2 headers conflict on Linux 32 bits */ - #if SDL_VIDEO_OPENGL_ES2 && !SDL_VIDEO_OPENGL - diff --git a/gnu/packages/sdl.scm b/gnu/packages/sdl.scm index 8b21f813c9..7b36d5509c 100644 --- a/gnu/packages/sdl.scm +++ b/gnu/packages/sdl.scm @@ -115,16 +115,15 @@ joystick, and graphics hardware.") (define-public sdl2 (package (inherit sdl) (name "sdl2") - (version "2.0.10") + (version "2.0.12") (source (origin (method url-fetch) (uri (string-append "https://libsdl.org/release/SDL2-" version ".tar.gz")) - (patches (search-patches "sdl2-mesa-compat.patch")) (sha256 (base32 - "0mqxp6w5jhbq6y1j690g9r3gpzwjxh4czaglw8x05l7hl49nqrdl")))) + "0qy8wbqvfkb5ps8kxgaaf2zzpkjqbsw712hlp74znbn0jpv6i4il")))) (arguments (substitute-keyword-arguments (package-arguments sdl) ((#:configure-flags flags) -- 2.25.1 From unknown Mon Aug 18 09:05:34 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Timotej Lazar Subject: bug#40211: closed (Re: [bug#40211] [PATCH 0/2] Enable udev support in SDL2 and bump version) Message-ID: References: <878sjdsvil.fsf@devup.no> <87tv2dc0gw.fsf@araneo.si> X-Gnu-PR-Message: they-closed 40211 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 40211@debbugs.gnu.org Date: Thu, 02 Apr 2020 16:28:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1585844882-30349-1" This is a multi-part message in MIME format... ------------=_1585844882-30349-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #40211: [PATCH 0/2] Enable udev support in SDL2 and bump version which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 40211@debbugs.gnu.org. --=20 40211: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D40211 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1585844882-30349-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 40211-done) by debbugs.gnu.org; 2 Apr 2020 16:27:40 +0000 Received: from localhost ([127.0.0.1]:40580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jK2gt-0007ry-MZ for submit@debbugs.gnu.org; Thu, 02 Apr 2020 12:27:39 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:35765) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jK2gs-0007rM-LK for 40211-done@debbugs.gnu.org; Thu, 02 Apr 2020 12:27:39 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 52BA85C020D; Thu, 2 Apr 2020 12:27:33 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 02 Apr 2020 12:27:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=3bNdVQ0ZZc2raLn4CI9wEer7Ne lNTYUzzIuqvwVurNU=; b=snvcyL+i0/NA6/j1GD2r+C7uVQZ7U9JOpKiKtm12Lw 5yxG87ICJVFMrwGj9Z0VK874mHyNvXEbOtZDynRvacguUMvv4DF983wgbLUztj9t BI18N8lncRyiUH+y6c/V/f8HeR1YRrBTH4FGRfFC7Ft8gDd7Ks7ksZUSbMJSsRJd NxC7NVX3p3VmLTfDzh24J8M5VZRlKesBT/7uNSTU+Pev0e32fPVNJ+FyqV0xfHkh UTlispDsfc6g+vwfNk4LR7Oj9u/ty35O4CKCpSX93FzrXejndbCq6owDysn1Pph0 tevj6yigvsGt9nrl0PHKe/dpv5rou0ZNP+Dpu///XvPA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=3bNdVQ 0ZZc2raLn4CI9wEer7NelNTYUzzIuqvwVurNU=; b=LZB0WAcU32qe07Y5SX+HqX 9BZnw9I/ZM0fYH1sDR8blfygHUQVgWr/2vg5ng1XIkzoRY5fEreoSdDCyKxeGXG1 kGQzG2Ae9NKJm4oWzVNOAi1JE5tSrCLKD2tB2RgoY3kmRxrOJr8GmIrTsjO3x5kk wWDXD3ZTeLPkN4qjga6H10pckYfEnynnh79oleGYuuSkgu6YDyvTIbIyu/s4s8J0 TrxRH66QoUWjcTWNJCPjFWOimydoz1u2SIAeCeS9662+GilEGA/URi9BMkthUGry 7EDp2MWccTI6/S/Siie8witKEhy35iuuSbXqkyClB8fqNa4gH6LWiY7ZldwW/zoQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrtdeggdelhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujghffgffkfggtgesghdtreertderjeenucfhrhhomhepofgrrhhiuhhs uceurghkkhgvuceomhgsrghkkhgvsehfrghsthhmrghilhdrtghomheqnecukfhppeekge drvddtvddrieekrdejheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgr ihhlfhhrohhmpehmsggrkhhkvgesfhgrshhtmhgrihhlrdgtohhm X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id 69855306CE18; Thu, 2 Apr 2020 12:27:32 -0400 (EDT) From: Marius Bakke To: Timotej Lazar , 40211-done@debbugs.gnu.org Subject: Re: [bug#40211] [PATCH 0/2] Enable udev support in SDL2 and bump version In-Reply-To: <87tv2dc0gw.fsf@araneo.si> References: <87tv2dc0gw.fsf@araneo.si> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Thu, 02 Apr 2020 18:27:30 +0200 Message-ID: <878sjdsvil.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40211-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Timotej, Timotej Lazar writes: > Hi, > > these patches update sdl2 to the latest release and enable udev support. > Without udev I experienced freezes every few seconds in certain games > (for instance hedgewars and supertux) as SDL searched through /dev/input > for joysticks. > > Since libudev is dlopened, I add it to rpath in make-flags. During build > this overrides LDFLAGS from the base package=E2=80=99s configure-flags, w= hich > add mesa to rpath. AFAICT this is OK as sdl2 already includes mesa by > linking libgbm. > > (Perhaps we could move LDFLAGS to make-flags in the base package, and > make the override explicit in the derived package? Or have sdl2 find and > modify the LDFLAGS entry from the base configure-flags, but that seems > more trouble than it=E2=80=99s worth.) > > I was able to rebuild all dependent packages with no (new) failures. I > ran several games and everything appears OK, but I don=E2=80=99t have a j= oystick > or gamepad to try. > > There have been some issues in the past with SDL not finding (correct) > libraries=C2=B9, so it would be good to test this on a foreign Guix insta= ll. > As for the version bump, the changelog=C2=B2 doesn=E2=80=99t mention any = significant > changes except for hidapi support, which is disabled by default. Thank you for the excellent research, bugfix, and patches. I have applied both and hope that it will fix a longstanding problem with SuperTuxKart and multiple gamepads that I will try out hopefully this weekend. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl6GEnIACgkQoqBt8qM6 VPpRIAgAwY6EM2qc0BYXTftuMViG0e0RTQ4oQCODnNdyjuaxDRuMte68s8i+oXm4 Pu9hAQftK8g9bPFvqGVxxRQj/X6Em+lDSdY29MDoZ4AP8vaO1VPJS3FkQuRGrjbF PiEktTHpZH+iQNHq53X8BPj0XbazShjwxc4e904l5QE0nUYOg3Q4i++ZH6/Zif8C YvFHXtYb3fvyQ21hq0Nb0kiNzBNu/fUACO2c4eDn5nh89k17rrnZDBPIPtM9tqlY 7pjtOHcrOnILzj0H3irvOlAq/8Up4Q2sUXWFa7IvQdkVoNY3GG3VcyiTcRPZzngD VfZHQhOtwFeoQh+D2aSM1a5k0uzndQ== =PEqQ -----END PGP SIGNATURE----- --=-=-=-- ------------=_1585844882-30349-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 24 Mar 2020 14:05:38 +0000 Received: from localhost ([127.0.0.1]:55390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGkBU-0004su-Ad for submit@debbugs.gnu.org; Tue, 24 Mar 2020 10:05:38 -0400 Received: from lists.gnu.org ([209.51.188.17]:52126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGkBQ-0004sa-9u for submit@debbugs.gnu.org; Tue, 24 Mar 2020 10:05:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54578) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGkBO-0006Cu-Hq for guix-patches@gnu.org; Tue, 24 Mar 2020 10:05:32 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGkBK-0001tN-Pr for guix-patches@gnu.org; Tue, 24 Mar 2020 10:05:30 -0400 Received: from araneo.si ([2001:15c0:2110:3400::2]:37666) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jGkBK-0001jr-9o for guix-patches@gnu.org; Tue, 24 Mar 2020 10:05:26 -0400 Received: from araneo.si (localhost.lan [127.0.0.1]) by araneo.si (OpenSMTPD) with ESMTP id 47f14c66 for ; Tue, 24 Mar 2020 14:05:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=araneo.si; h=from:to :subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=20180623; bh=WGs2ZnSHTbhaNPh1Mzjoc a3jrHQ=; b=snBQlDKLroPCNGVp58EC7GqcmB9Nd+ULTwAmWmoNa/wN495hx2gFg rBj4MWIQG51SDxWSd/Fi4+axDHChC040OZRQTu3Xv5urSm0LLxRrsC9hCFqSaTVy SK7NeT+HagKA7c3jocDW9wi/vYe7PYqEyxu1wt6K4OLl3I/wZArvwlJ9Wqq+BaCo vEX/EtIy9e0xnop8iASRs6o0J7p285db8EIxNF44MxempaHPcpuDGX3H0gXkIlbJ VmxBF3HjISx9ayGrLoaMNMf8A2fL45AXsBStjOkl2whk1bw5PdVmeSfHidcs+NkC j3juSISSPWaQek0W4o35Q6OwjuOUZCx9g== Received: by araneo.si (OpenSMTPD) with ESMTPSA id 3c4be8ef (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Tue, 24 Mar 2020 14:05:20 +0000 (UTC) From: Timotej Lazar To: guix-patches@gnu.org Subject: [PATCH 0/2] Enable udev support in SDL2 and bump version Date: Tue, 24 Mar 2020 15:05:19 +0100 Message-ID: <87tv2dc0gw.fsf@araneo.si> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:15c0:2110:3400::2 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi, these patches update sdl2 to the latest release and enable udev support. Without udev I experienced freezes every few seconds in certain games (for instance hedgewars and supertux) as SDL searched through /dev/input for joysticks. Since libudev is dlopened, I add it to rpath in make-flags. During build this overrides LDFLAGS from the base package=E2=80=99s configure-flags, whi= ch add mesa to rpath. AFAICT this is OK as sdl2 already includes mesa by linking libgbm. (Perhaps we could move LDFLAGS to make-flags in the base package, and make the override explicit in the derived package? Or have sdl2 find and modify the LDFLAGS entry from the base configure-flags, but that seems more trouble than it=E2=80=99s worth.) I was able to rebuild all dependent packages with no (new) failures. I ran several games and everything appears OK, but I don=E2=80=99t have a joy= stick or gamepad to try. There have been some issues in the past with SDL not finding (correct) libraries=C2=B9, so it would be good to test this on a foreign Guix install. As for the version bump, the changelog=C2=B2 doesn=E2=80=99t mention any si= gnificant changes except for hidapi support, which is disabled by default. Thanks! Timotej =C2=B9 https://lists.gnu.org/archive/html/guix-devel/2015-03/msg00585.html =C2=B2 https://hg.libsdl.org/SDL/file/355a4f94a782/WhatsNew.txt Timotej Lazar (2): gnu: sdl2: Use udev to discover input devices. gnu: sdl2: Update to 2.0.12. gnu/local.mk | 1 - gnu/packages/patches/sdl2-mesa-compat.patch | 21 ---------------- gnu/packages/sdl.scm | 27 ++++++++++++--------- 3 files changed, 16 insertions(+), 33 deletions(-) delete mode 100644 gnu/packages/patches/sdl2-mesa-compat.patch --=20 2.25.1 ------------=_1585844882-30349-1--