From unknown Sat Aug 16 20:57:01 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#40209 <40209@debbugs.gnu.org> To: bug#40209 <40209@debbugs.gnu.org> Subject: Status: [PATCH] gnu: qiv: Add qiv image viewer for X Reply-To: bug#40209 <40209@debbugs.gnu.org> Date: Sun, 17 Aug 2025 03:57:01 +0000 retitle 40209 [PATCH] gnu: qiv: Add qiv image viewer for X reassign 40209 guix-patches submitter 40209 R Veera Kumar severity 40209 normal tag 40209 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 24 06:21:14 2020 Received: (at submit) by debbugs.gnu.org; 24 Mar 2020 10:21:14 +0000 Received: from localhost ([127.0.0.1]:53921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGggL-0002qN-EO for submit@debbugs.gnu.org; Tue, 24 Mar 2020 06:21:14 -0400 Received: from lists.gnu.org ([209.51.188.17]:60589) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGfzD-0001eQ-8G for submit@debbugs.gnu.org; Tue, 24 Mar 2020 05:36:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46115) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGfzC-0006QD-2M for guix-patches@gnu.org; Tue, 24 Mar 2020 05:36:39 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGfzB-0008Cm-1T for guix-patches@gnu.org; Tue, 24 Mar 2020 05:36:37 -0400 Received: from vkten.in ([104.244.73.96]:39868) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jGfzA-0008Bg-Rm for guix-patches@gnu.org; Tue, 24 Mar 2020 05:36:36 -0400 Received: (qmail 1625 invoked from network); 24 Mar 2020 09:36:35 -0000 Received: from unknown (HELO tulip) (vkor@vkten.in@117.202.224.5) de/crypted with TLSv1.3: TLS_AES_256_GCM_SHA384 [256/256] DN=none by vkten with ESMTPSA; 24 Mar 2020 09:36:35 -0000 Date: Tue, 24 Mar 2020 15:06:27 +0530 From: R Veera Kumar To: guix-patches@gnu.org Subject: [PATCH] gnu: qiv: Add qiv image viewer for X Message-ID: <20200324093627.GB3208@tulip> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 104.244.73.96 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 24 Mar 2020 06:21:12 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Hi, Add Quick Image Viewer (qiv) for X. A new pkg submission. Website: http://spiegl.de/qiv/ Regards, R Veera Kumar [Outreachy Contrib] India From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 24 06:33:40 2020 Received: (at 40209) by debbugs.gnu.org; 24 Mar 2020 10:33:40 +0000 Received: from localhost ([127.0.0.1]:53937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGgsO-0003HA-Ic for submit@debbugs.gnu.org; Tue, 24 Mar 2020 06:33:40 -0400 Received: from vkten.in ([104.244.73.96]:56662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGgsM-0003Gt-PA for 40209@debbugs.gnu.org; Tue, 24 Mar 2020 06:33:39 -0400 Received: (qmail 3053 invoked from network); 24 Mar 2020 10:33:26 -0000 Received: from unknown (HELO tulip) (vkor@vkten.in@117.202.224.5) de/crypted with TLSv1.3: TLS_AES_256_GCM_SHA384 [256/256] DN=none by vkten with ESMTPSA; 24 Mar 2020 10:33:26 -0000 Date: Tue, 24 Mar 2020 16:03:16 +0530 From: R Veera Kumar To: 40209@debbugs.gnu.org Subject: [PATCH] gnu: qiv: Add new pkg qiv an image viewer for X Message-ID: <20200324103316.GA3324@tulip> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 40209 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Add qiv an image viewer for X. Signed-off-by: R Veera Kumar --- gnu/packages/qiv.scm | 53 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 53 insertions(+) create mode 100644 gnu/packages/qiv.scm diff --git a/gnu/packages/qiv.scm b/gnu/packages/qiv.scm new file mode 100644 index 0000000000..76b3c5702c --- /dev/null +++ b/gnu/packages/qiv.scm @@ -0,0 +1,53 @@ +(define-module (gnu packages qiv) + #:use-module ((guix licenses) #:prefix license:) + #:use-module (guix packages) + #:use-module (guix download) + #:use-module (guix build-system gnu) + #:use-module (gnu packages) + #:use-module (gnu packages image) + #:use-module (gnu packages glib) + #:use-module (gnu packages gtk) + #:use-module (gnu packages photo) + #:use-module (gnu packages pkg-config)) + + +(define-public qiv + (package + (name "qiv") + (version "2.3.1") + (source + (origin + (method url-fetch) + (uri (string-append "http://spiegl.de/qiv/download/qiv-" + version ".tgz")) + (sha256 + (base32 "1rlf5h67vhj7n1y7jqkm9k115nfnzpwngj3kzqsi2lg676srclv7")))) + (build-system gnu-build-system) + (native-inputs + `(("pkg-config" ,pkg-config))) + (inputs + `(("imlib2" ,imlib2) + ("glib" ,glib) + ("gtk+" ,gtk+-2) + ("libtiff" ,libtiff) + ("libexif" ,libexif) + ("libpng" ,libpng))) + (arguments + `(#:phases + (modify-phases %standard-phases + (delete `configure)) + #:tests? #f + #:make-flags + (list + "CC=gcc" + "LCMS=" + (string-append "PREFIX=" (assoc-ref %outputs "out"))))) + (home-page "http://spiegl.de/qiv/") + (synopsis "Graphical image viewer for X") + (description + "Quick Image Viewer is a very small and fast GDK/Imlib image viewer. +Features include zoom, maxpect, scale down, fullscreen, brightness/contrast/ +gamma correction, slideshow, pan with keyboard and mouse, rotate left/right, +flip, delete, jump/forward/backward images, filename filter and use it to +set X desktop background.") + (license license:gpl2))) -- 2.25.1 From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 24 08:04:42 2020 Received: (at 40209) by debbugs.gnu.org; 24 Mar 2020 12:04:42 +0000 Received: from localhost ([127.0.0.1]:54017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGiIU-0001M5-6e for submit@debbugs.gnu.org; Tue, 24 Mar 2020 08:04:42 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:60508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGiIP-0001Lt-RL for 40209@debbugs.gnu.org; Tue, 24 Mar 2020 08:04:41 -0400 Received: from localhost (unknown [185.17.13.127]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 6AF653365225; Tue, 24 Mar 2020 13:04:36 +0100 (CET) Date: Tue, 24 Mar 2020 13:04:35 +0100 From: Danny Milosavljevic To: R Veera Kumar Subject: Re: [bug#40209] [PATCH] gnu: qiv: Add new pkg qiv an image viewer for X Message-ID: <20200324130435.53b67995@scratchpost.org> In-Reply-To: <20200324103316.GA3324@tulip> References: <20200324093627.GB3208@tulip> <20200324103316.GA3324@tulip> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/B.J0=2qU3OKi.B3vmeZwVlT"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40209 Cc: 40209@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/B.J0=2qU3OKi.B3vmeZwVlT Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Veera, in order to make this actually work in a Guix release, please refer to the = new file in gnu/local.mk in GNU_SYSTEM_MODULES . Or better yet, in this case I would prefer if you just added qiv to the exi= sting file gnu/packages/image-viewers.scm . >+ #:tests? #f Why? Please add a comment. It seems that the changelog mentions that the tests are now in "make instal= l". Did the tests work? >+ #:make-flags >+ (list >+ "CC=3Dgcc" >+ "LCMS=3D" >+ (string-append "PREFIX=3D" (assoc-ref %outputs "out"))))) Indentation is off. Otherwise it looks good. Could you send a v2 of your patch with these points addressed? --Sig_/B.J0=2qU3OKi.B3vmeZwVlT Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl5591MACgkQ5xo1VCww uqVaPwf/YfAuHNKvU6/mY9AoPHXINg61Azd+1I5nBEtusKBTJUb5ezoa2jzN0uX7 3YTZ6JT7UOzYfO/HdYsn5osGZLlZyBUpvTJ/S4GzvpAiXMHmpK92SiuIOHsgbbjZ JQS8n/e8jsTJldY/7DMrveiZSGsClhzMr6osSKqf/3YSsoyqJlrnudQqJ/efOoZB 8oWmCEGvTZ82kJOO/geZRxLcCyUmE1RMF50EarXEvhfAflO3uOuI81Om1WzlK8f5 MeS8vBcMxLY+wnsQ1gRv0O89VEakawgWt1jcoOPruj19Yv6sM6LaViJ0fUzGuMSn QnhXqcDWbh9mhybnQzagg+stm4b0HA== =zV0D -----END PGP SIGNATURE----- --Sig_/B.J0=2qU3OKi.B3vmeZwVlT-- From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 25 04:09:17 2020 Received: (at 40209) by debbugs.gnu.org; 25 Mar 2020 08:09:17 +0000 Received: from localhost ([127.0.0.1]:56187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jH16D-0008H5-EC for submit@debbugs.gnu.org; Wed, 25 Mar 2020 04:09:17 -0400 Received: from vkten.in ([104.244.73.96]:56670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jH16A-0008Gk-D0 for 40209@debbugs.gnu.org; Wed, 25 Mar 2020 04:09:15 -0400 Received: (qmail 24106 invoked from network); 25 Mar 2020 08:09:06 -0000 Received: from unknown (HELO tulip) (vkor@vkten.in@117.202.255.94) de/crypted with TLSv1.3: TLS_AES_256_GCM_SHA384 [256/256] DN=none by vkten with ESMTPSA; 25 Mar 2020 08:09:06 -0000 Date: Wed, 25 Mar 2020 13:38:58 +0530 From: R Veera Kumar To: 40209@debbugs.gnu.org Subject: [PATCH v2] gnu: image-viewers: Add new pkg qiv an image viewer for X Message-ID: <20200325080858.GA1742@tulip> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 40209 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Add qiv (Quick Image Viewer) is a very small and fast GDK/Imlib2 image viewer for X. Signed-off-by: R Veera Kumar --- Changes in v2: - Add into image-viewers instead of separate - Add reason for no make check as comments - Correct indentation using indent-code.el - remove libpng from inputs --- gnu/packages/image-viewers.scm | 42 ++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm index 8f3f61c4b1..133df4f741 100644 --- a/gnu/packages/image-viewers.scm +++ b/gnu/packages/image-viewers.scm @@ -596,3 +596,45 @@ with tiling window managers. Features include: @end itemize\n") (home-page "https://github.com/eXeC64/imv") (license license:expat))) + +(define-public qiv + (package + (name "qiv") + (version "2.3.1") + (source + (origin + (method url-fetch) + (uri (string-append "http://spiegl.de/qiv/download/qiv-" + version ".tgz")) + (sha256 + (base32 "1rlf5h67vhj7n1y7jqkm9k115nfnzpwngj3kzqsi2lg676srclv7")))) + (build-system gnu-build-system) + (native-inputs + `(("pkg-config" ,pkg-config))) + (inputs + `(("imlib2" ,imlib2) + ("glib" ,glib) + ("gtk+" ,gtk+-2) + ("libtiff" ,libtiff) + ("libexif" ,libexif))) + (arguments + `(#:phases + (modify-phases %standard-phases + (delete `configure)) ;; no configure script + #:tests? #f ;; there is no check target + ;; make install runs the built qiv binary + ;; which fails as no X in build env + #:make-flags + (list + "CC=gcc" + "LCMS=" ;; requires lcms2 + (string-append "PREFIX=" (assoc-ref %outputs "out"))))) + (home-page "http://spiegl.de/qiv/") + (synopsis "Graphical image viewer for X") + (description + "Quick Image Viewer is a very small and fast GDK/Imlib2 image viewer. +Features include zoom, maxpect, scale down, fullscreen, brightness/contrast/ +gamma correction, slideshow, pan with keyboard and mouse, rotate left/right, +flip, delete, jump/forward/backward images, filename filter and use it to +set X desktop background.") + (license license:gpl2))) -- 2.25.1 From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 31 07:04:17 2020 Received: (at 40209) by debbugs.gnu.org; 31 Mar 2020 11:04:17 +0000 Received: from localhost ([127.0.0.1]:35607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJEgq-0004XL-Tc for submit@debbugs.gnu.org; Tue, 31 Mar 2020 07:04:17 -0400 Received: from vkten.in ([104.244.73.96]:56748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJEgm-0004X4-1A for 40209@debbugs.gnu.org; Tue, 31 Mar 2020 07:04:15 -0400 Received: (qmail 2905 invoked from network); 31 Mar 2020 11:04:01 -0000 Received: from unknown (HELO tulip) (vkor@vkten.in@117.249.171.68) de/crypted with TLSv1.3: TLS_AES_256_GCM_SHA384 [256/256] DN=none by vkten with ESMTPSA; 31 Mar 2020 11:04:01 -0000 Date: Tue, 31 Mar 2020 16:33:55 +0530 From: R Veera Kumar To: 40209@debbugs.gnu.org Subject: [PATCH v3] gnu: Add qiv. Message-ID: <20200331110355.GA11085@tulip> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 40209 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/image-viewers.scm (qiv): New variable. Signed-off-by: R Veera Kumar --- Changes in v3: - Commit msg as per changelog format. - Change quasi quote to normal in modify phases 'configure - Add lcms2 and jpeg support Changes in v2: - Add into image-viewers instead of separate - Add reason for no make check as comments - Correct indentation using indent-code.el --- gnu/packages/image-viewers.scm | 45 ++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm index 8f3f61c4b1..bc2ad69473 100644 --- a/gnu/packages/image-viewers.scm +++ b/gnu/packages/image-viewers.scm @@ -13,6 +13,7 @@ ;;; Copyright © 2019 Guy Fleury Iteriteka ;;; Copyright © 2019 Pierre Langlois ;;; Copyright © 2020 Peng Mei Yu +;;; Copyright © 2020 R Veera Kumar ;;; ;;; This file is part of GNU Guix. ;;; @@ -596,3 +597,47 @@ with tiling window managers. Features include: @end itemize\n") (home-page "https://github.com/eXeC64/imv") (license license:expat))) + +(define-public qiv + (package + (name "qiv") + (version "2.3.1") + (source + (origin + (method url-fetch) + (uri (string-append "http://spiegl.de/qiv/download/qiv-" + version ".tgz")) + (sha256 + (base32 "1rlf5h67vhj7n1y7jqkm9k115nfnzpwngj3kzqsi2lg676srclv7")))) + (build-system gnu-build-system) + (native-inputs + `(("pkg-config" ,pkg-config))) + (inputs + `(("imlib2" ,imlib2) + ("glib" ,glib) + ("gtk+" ,gtk+-2) + ("lcms" ,lcms) + ("libjpeg" ,libjpeg) + ("libtiff" ,libtiff) + ("libexif" ,libexif) + ("libx11" ,libx11) + ("libxext" ,libxext))) + (arguments + `(#:phases + (modify-phases %standard-phases + (delete 'configure)) ;; no configure script + #:tests? #f ;; there is no check target + ;; make install runs the built qiv binary + ;; which fails as no X in build env + #:make-flags + (list + (string-append "PREFIX=" (assoc-ref %outputs "out"))))) + (home-page "http://spiegl.de/qiv/") + (synopsis "Graphical image viewer for X") + (description + "Quick Image Viewer is a small and fast GDK/Imlib2 image viewer. +Features include zoom, maxpect, scale down, fullscreen, slideshow, delete, +brightness/contrast/gamma correction, pan with keyboard and mouse, flip, +rotate left/right, jump/forward/backward images, filename filter and use it +to set X desktop background.") + (license license:gpl2))) -- 2.26.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 31 07:17:21 2020 Received: (at 40209) by debbugs.gnu.org; 31 Mar 2020 11:17:21 +0000 Received: from localhost ([127.0.0.1]:35632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJEtV-0004ws-BH for submit@debbugs.gnu.org; Tue, 31 Mar 2020 07:17:21 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:43834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJEtT-0004wh-1T for 40209@debbugs.gnu.org; Tue, 31 Mar 2020 07:17:19 -0400 Received: from localhost (80-110-126-163.cgn.dynamic.surfer.at [80.110.126.163]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 6C75F3365366; Tue, 31 Mar 2020 13:17:17 +0200 (CEST) Date: Tue, 31 Mar 2020 13:17:12 +0200 From: Danny Milosavljevic To: R Veera Kumar Subject: Re: [bug#40209] [PATCH v3] gnu: Add qiv. Message-ID: <20200331131712.5b0c7414@scratchpost.org> In-Reply-To: <20200331110355.GA11085@tulip> References: <20200324093627.GB3208@tulip> <20200331110355.GA11085@tulip> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/Lm9f9iZOEPSpAAV3jd48Swf"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40209 Cc: 40209@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/Lm9f9iZOEPSpAAV3jd48Swf Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Veera, thanks! > + ;; make install runs the built qiv binary > + ;; which fails as no X in build env But that should mean that this package should fail to install. Doesn't it? Also, you can just start an X server. (search for the text "Xvfb" in gnu/pa= ckages) Everything else it fine. --Sig_/Lm9f9iZOEPSpAAV3jd48Swf Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl6DJrgACgkQ5xo1VCww uqWv1gf+OsaZbLbLavjpy/BIu+UWxdZ7ycDFp9woC/Q5fV7I8lAIN7bMa+kb+YRi +9AglPC9c0BaBOsXg5CeC8HlWBrXIsPa+KECNULZN0JgLuyv6fF1thWodYYgRfry LWzCIK6I2zgkG3ne0qzGtj0JQnHRaraP5RMPwAvmXEEpjGOo8RoGOaT2ocj/ckc1 E4wCm+S5Bdi5hLtEY5+3PzKq3iIC1Iy2kmFUegphBv2rOpiFjxaGj7HRnrcFO8lv gxSc6HMzx+WrYY/0WLVoJ1WY5nzjuJ24GbSWyOt24XL7IYxc6nw+RU9nER5pgs/1 dIhAqX9e1rcKEOHuQOOfdm/WLlHcBQ== =pEdj -----END PGP SIGNATURE----- --Sig_/Lm9f9iZOEPSpAAV3jd48Swf-- From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 31 07:54:15 2020 Received: (at 40209) by debbugs.gnu.org; 31 Mar 2020 11:54:15 +0000 Received: from localhost ([127.0.0.1]:35660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJFTC-0007zn-MN for submit@debbugs.gnu.org; Tue, 31 Mar 2020 07:54:15 -0400 Received: from vkten.in ([104.244.73.96]:56750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJFTB-0007za-LW for 40209@debbugs.gnu.org; Tue, 31 Mar 2020 07:54:14 -0400 Received: (qmail 3458 invoked from network); 31 Mar 2020 11:54:05 -0000 Received: from unknown (HELO tulip) (vkor@vkten.in@117.249.171.68) de/crypted with TLSv1.3: TLS_AES_256_GCM_SHA384 [256/256] DN=none by vkten with ESMTPSA; 31 Mar 2020 11:54:05 -0000 Date: Tue, 31 Mar 2020 17:23:46 +0530 From: R Veera Kumar To: Danny Milosavljevic Subject: Re: [bug#40209] [PATCH v3] gnu: Add qiv. Message-ID: <20200331115346.GA11075@tulip> References: <20200324093627.GB3208@tulip> <20200331110355.GA11085@tulip> <20200331131712.5b0c7414@scratchpost.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200331131712.5b0c7414@scratchpost.org> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 40209 Cc: 40209@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, Mar 31, 2020 at 01:17:12PM +0200, Danny Milosavljevic wrote: > Hi Veera, > > thanks! > > > + ;; make install runs the built qiv binary > > + ;; which fails as no X in build env > > But that should mean that this package should fail to install. > > Doesn't it? > I am running the build in X environment (Mate DM). Package builds fine. And installs fine. And works fine. The Makefile has this: @if ./qiv -f ./intro.jpg ; \ then echo "-- Test Passed --" ; \ else echo "-- Test Failed --" ; \ fi It justs echos this in build log which I saw. > Also, you can just start an X server. (search for the text "Xvfb" in gnu/packages) > Is it neccessary? Am finding about it. > Everything else it fine. Thanks, R Veera Kumar From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 31 09:38:25 2020 Received: (at 40209) by debbugs.gnu.org; 31 Mar 2020 13:38:25 +0000 Received: from localhost ([127.0.0.1]:35778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJH61-0003oM-Js for submit@debbugs.gnu.org; Tue, 31 Mar 2020 09:38:25 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:57066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJH60-0003oE-Hz for 40209@debbugs.gnu.org; Tue, 31 Mar 2020 09:38:24 -0400 Received: from localhost (80-110-126-163.cgn.dynamic.surfer.at [80.110.126.163]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 952D23365333; Tue, 31 Mar 2020 15:38:22 +0200 (CEST) Date: Tue, 31 Mar 2020 15:38:15 +0200 From: Danny Milosavljevic To: R Veera Kumar Subject: Re: [PATCH v2] gnu: image-viewers: Add new pkg qiv an image viewer for X Message-ID: <20200331153815.37a77f5b@scratchpost.org> In-Reply-To: <20200325080858.GA1742@tulip> References: <20200325080858.GA1742@tulip> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_//qYNxABq_FxKTdFKqBAqlaS"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40209 Cc: 40209@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_//qYNxABq_FxKTdFKqBAqlaS Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable There are different kinds of comments we use (by convention): ;; These comments are for sentences describing the next thing. (foo...) ;;; ;;; These comments are for describing entire sections. ;;; (foo...) ; these just for short trailing note --Sig_//qYNxABq_FxKTdFKqBAqlaS Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl6DR8cACgkQ5xo1VCww uqWrLQf/U76MZva008puN3hpRznGNjcnAWrtFB73uHoKS9cP4XnhClU/zNRZOgl3 EjJrhIpDPfizuT1m6f1eFW1Kh8XTkeavTkXmp8CfQIfi0a67gMiQyDIw+4SqoyHG 5uIMvTK+eMXUPAYgOEDVOR3BO6mSHEX7/iWWMnKpbrV0apOp1hq3g4sI+TlVugjU s2pxwEC7wJXnJU0sP++WgjII/j0By1YhjUYVv7r52hKgvYpX8iZ2ihukTjSDnjvC VSMQJOqs68IJaDKZZ1L1jEezwOe7vFHNMfNWENZo4Uw2MT+LIE/VzvxPUvA5ngNj /h2IigpW0hl0sCrJ16W0yzmMtmzsSQ== =nK72 -----END PGP SIGNATURE----- --Sig_//qYNxABq_FxKTdFKqBAqlaS-- From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 31 21:07:24 2020 Received: (at 40209) by debbugs.gnu.org; 1 Apr 2020 01:07:24 +0000 Received: from localhost ([127.0.0.1]:37265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJRql-0007H1-La for submit@debbugs.gnu.org; Tue, 31 Mar 2020 21:07:23 -0400 Received: from vkten.in ([104.244.73.96]:56756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJRqj-0007Gl-IE for 40209@debbugs.gnu.org; Tue, 31 Mar 2020 21:07:22 -0400 Received: (qmail 16000 invoked from network); 1 Apr 2020 01:07:13 -0000 Received: from unknown (HELO tulip) (vkor@vkten.in@117.209.255.152) de/crypted with TLSv1.3: TLS_AES_256_GCM_SHA384 [256/256] DN=none by vkten with ESMTPSA; 1 Apr 2020 01:07:13 -0000 Date: Wed, 1 Apr 2020 06:37:03 +0530 From: R Veera Kumar To: 40209@debbugs.gnu.org Subject: [PATCH v4] gnu: Add qiv. Message-ID: <20200401010703.GA3180@tulip> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 40209 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/image-viewers.scm (qiv): New variable. Signed-off-by: R Veera Kumar --- Changes in v4: - Make install check pass by setting up Xvfb for test - Patch Makefile so that qiv runs and exits by itself during test - Make proper guile comments Changes in v3: - Commit msg as per changelog format. - Change quasi quote to normal in modify phases 'configure - Add lcms2 and jpeg support Changes in v2: - Add into image-viewers instead of separate - Add reason for no make check as comments - Correct indentation using indent-code.el --- gnu/packages/image-viewers.scm | 55 ++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+) diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm index 8f3f61c4b1..6bbbf2a3b0 100644 --- a/gnu/packages/image-viewers.scm +++ b/gnu/packages/image-viewers.scm @@ -13,6 +13,7 @@ ;;; Copyright © 2019 Guy Fleury Iteriteka ;;; Copyright © 2019 Pierre Langlois ;;; Copyright © 2020 Peng Mei Yu +;;; Copyright © 2020 R Veera Kumar ;;; ;;; This file is part of GNU Guix. ;;; @@ -596,3 +597,57 @@ with tiling window managers. Features include: @end itemize\n") (home-page "https://github.com/eXeC64/imv") (license license:expat))) + +(define-public qiv + (package + (name "qiv") + (version "2.3.1") + (source + (origin + (method url-fetch) + (uri (string-append "http://spiegl.de/qiv/download/qiv-" + version ".tgz")) + (sha256 + (base32 "1rlf5h67vhj7n1y7jqkm9k115nfnzpwngj3kzqsi2lg676srclv7")))) + (build-system gnu-build-system) + (native-inputs + `(("pkg-config" ,pkg-config) + ;; for testing + ("xorg-server" ,xorg-server-for-tests))) + (inputs + `(("imlib2" ,imlib2) + ("glib" ,glib) + ("gtk+" ,gtk+-2) + ("lcms" ,lcms) + ("libjpeg" ,libjpeg) + ("libtiff" ,libtiff) + ("libexif" ,libexif) + ("libx11" ,libx11) + ("libxext" ,libxext))) + (arguments + `(#:phases + (modify-phases %standard-phases + (delete 'configure) ; no configure script + (add-before 'install 'patch-file-start-xserver + (lambda* (#:key inputs #:allow-other-keys) + ;; patch the file so that qiv runs and exits by itself + (substitute* "Makefile" + (("./qiv -f ./intro.jpg") "./qiv -f -C -s ./intro.jpg")) + (let ((xorg-server (assoc-ref inputs "xorg-server"))) + ;; There must be a running X server and make install doesn't start one. + ;; Therefore we must do it. + (system (format #f "~a/bin/Xvfb :1 &" xorg-server)) + (setenv "DISPLAY" ":1") ) #t))) + #:tests? #f ; there is no check target + #:make-flags + (list + (string-append "PREFIX=" (assoc-ref %outputs "out"))))) + (home-page "http://spiegl.de/qiv/") + (synopsis "Graphical image viewer for X") + (description + "Quick Image Viewer is a small and fast GDK/Imlib2 image viewer. +Features include zoom, maxpect, scale down, fullscreen, slideshow, delete, +brightness/contrast/gamma correction, pan with keyboard and mouse, flip, +rotate left/right, jump/forward/backward images, filename filter and use it +to set X desktop background.") + (license license:gpl2))) -- 2.26.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 01 06:20:26 2020 Received: (at 40209-done) by debbugs.gnu.org; 1 Apr 2020 10:20:26 +0000 Received: from localhost ([127.0.0.1]:37471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJaTy-0005Qg-3O for submit@debbugs.gnu.org; Wed, 01 Apr 2020 06:20:26 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:47080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJaTw-0005QT-4i for 40209-done@debbugs.gnu.org; Wed, 01 Apr 2020 06:20:24 -0400 Received: from localhost (80-110-126-163.cgn.dynamic.surfer.at [80.110.126.163]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 49E673361569; Wed, 1 Apr 2020 12:20:22 +0200 (CEST) Date: Wed, 1 Apr 2020 12:20:21 +0200 From: Danny Milosavljevic To: R Veera Kumar Subject: Re: [bug#40209] [PATCH v4] gnu: Add qiv. Message-ID: <20200401122021.28d87758@scratchpost.org> In-Reply-To: <20200401010703.GA3180@tulip> References: <20200324093627.GB3208@tulip> <20200401010703.GA3180@tulip> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/=5kbZsFmuFq3KnG_na/PTJF"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40209-done Cc: 40209-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/=5kbZsFmuFq3KnG_na/PTJF Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Veera, Thanks for the patch! pushed to guix master as commit e2bd0af373d3abfba645647e6ec674670f2bd1e4 wi= th tiny changes. --Sig_/=5kbZsFmuFq3KnG_na/PTJF Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl6EauUACgkQ5xo1VCww uqVYBQf/Z9jJeRQqBUX3MHyVrB2EVl5P0bVqBe5j+WuvzBnEMmH4fFDZxpQIeVRH DvvaO5g1kEIo6fZ/xab0i3vzgLSPq/Jt5L3UR5cwGhsAnK2Os4knEZTPI4f4ExpJ I9aewM8HJQsGQEXkILYbHhf2YRnvHHDmJ6K11sYM2xd5Nfl4couPBt/howxJ9PqI 2HS3UBqVjfUmkw8/WJS75DTYXX2tTVxgTEM+UYwrButbi5nKv3Xw2WCOnQh8L7Ty a8U1oQGaMzK5W8oWF84g/B7GMwl4gitlLGaboRiBMCCJGo3QfsBH0ExJyArqrJBq BWM4XBt271Gyy1caAH27kDYa4nKQRg== =G1g9 -----END PGP SIGNATURE----- --Sig_/=5kbZsFmuFq3KnG_na/PTJF-- From unknown Sat Aug 16 20:57:01 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 29 Apr 2020 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator