GNU bug report logs - #40204
[PATCH] gnu: xkbcomp: update to 1.4.3

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40204 in the body.
You can then email your comments to 40204 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: xkbcomp: update to 1.4.3
Date: Tue, 24 Mar 2020 03:18:07 +0100

[Message part 1 (text/plain, inline)]

* gnu/packages/xorg.scm (xkbcomp): update to 1.4.3

[0001-gnu-packages-xorg.scm-xkbcomp-update-to-1.4.3.patch (text/x-patch, inline)]

From 2976e6de897232296d1e16a3a799cd3ab20ea1db Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike <at> rohleder.de>
Date: Tue, 24 Mar 2020 03:13:33 +0100
Subject: [PATCH] * gnu/packages/xorg.scm (xkbcomp): update to 1.4.3

---
 gnu/packages/xorg.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
index f4c7329e06..cde699bb51 100644
--- a/gnu/packages/xorg.scm
+++ b/gnu/packages/xorg.scm
@@ -22,6 +22,7 @@
 ;;; Copyright © 2019 Yoshinori Arai <kumagusu08 <at> gmail.com>
 ;;; Copyright © 2020 Leo Prikler <leo.prikler <at> student.tugraz.at>
 ;;; Copyright © 2020 Florian Pelz <pelzflorian <at> pelzflorian.de>
+;;; Copyright © 2020 Michael Rohleder <mike <at> rohleder.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -3825,7 +3826,7 @@ alternative implementations like XRandR or TwinView.")
 (define xkbcomp-intermediate ; used as input for xkeyboard-config
   (package
     (name "xkbcomp-intermediate")
-    (version "1.4.2")
+    (version "1.4.3")
     (source
       (origin
         (method url-fetch)
@@ -3835,7 +3836,7 @@ alternative implementations like XRandR or TwinView.")
                ".tar.bz2"))
         (sha256
          (base32
-          "0944rrkkf0dxp07vhh9yr4prslxhqyw63qmbjirbv1bypswvrn3d"))))
+          "0dflr250nlj6rrnv658f6dm8qx37sj0xfimc3ihay761kwb2q906"))))
     (build-system gnu-build-system)
     (inputs
       `(("xorgproto" ,xorgproto)
-- 
2.26.0

[Message part 3 (text/plain, inline)]

-- 
GNU Emacs is a LISP operating system disguised as a word processor.
    --Doug Mohney, in comp.arch

[signature.asc (application/pgp-signature, inline)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: 40204 <at> debbugs.gnu.org
Subject: Re: [bug#40204] [PATCH] gnu: xkbcomp: update to 1.4.3
Date: Tue, 24 Mar 2020 11:47:34 +0100

Hello Michael,

While your patch LGTM, running:

--8<---------------cut here---------------start------------->8---
guix refresh -l xkbcomp
--8<---------------cut here---------------end--------------->8---

you'll see that it triggers too much rebuilds to be pushed on
master. Could you rebase it on core-updates and see if it works?

Thanks,

Mathieu

Message #14 received at 40204 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 40204 <at> debbugs.gnu.org
Subject: Re: [bug#40204] [PATCH] gnu: xkbcomp: update to 1.4.3
Date: Tue, 24 Mar 2020 15:43:50 -0400

On Tue, Mar 24, 2020 at 11:47:34AM +0100, Mathieu Othacehe wrote:
> you'll see that it triggers too much rebuilds to be pushed on
> master. Could you rebase it on core-updates and see if it works?

To clarify, the guidelines about how many rebuilds are okay for which
branch are in item 8 of the manual section Submitting Patches [0]:

------
300 dependent packages or less

    master branch (non-disruptive changes).
between 300 and 1,200 dependent packages

    staging branch (non-disruptive changes). This branch is intended to be merged in master every 3 weeks or so. Topical changes (e.g., an update of the GNOME stack) can instead go to a specific branch (say, gnome-updates).
more than 1,200 dependent packages

    core-updates branch (may include major and potentially disruptive changes). This branch is intended to be merged in master every 2.5 months or so. 
------

These are rough heuristics that help us manage big changes effectively.

[0]
https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html

Message #17 received at 40204 <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: 40204 <at> debbugs.gnu.org
Subject: Re: [bug#40204] [PATCH] gnu: xkbcomp: update to 1.4.3
Date: Thu, 26 Mar 2020 22:04:30 +0100

[Message part 1 (text/plain, inline)]

here is the update against core-updates.

I tested building only some of the dependencies and it seems to work in
a "./pre-inst-env guix environment --pure bash --ad-hoc xkbcomp" on
branch core-updates.

[0001-gnu-packages-xorg.scm-xkbcomp-update-to-1.4.3.patch (text/x-patch, inline)]

From 11cc3b00ed62608a8a56edab4d1306d3a5e5b477 Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike <at> rohleder.de>
Date: Thu, 26 Mar 2020 21:23:43 +0100
Subject: [PATCH] * gnu/packages/xorg.scm (xkbcomp): update to 1.4.3

---
 gnu/packages/xorg.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
index 2ec151fd01..5db27fbff0 100644
--- a/gnu/packages/xorg.scm
+++ b/gnu/packages/xorg.scm
@@ -22,6 +22,7 @@
 ;;; Copyright © 2019 Yoshinori Arai <kumagusu08 <at> gmail.com>
 ;;; Copyright © 2019 Mathieu Othacehe <m.othacehe <at> gmail.com>
 ;;; Copyright © 2020 Leo Prikler <leo.prikler <at> student.tugraz.at>
+;;; Copyright © 2020 Michael Rohleder <mike <at> rohleder.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -3746,7 +3747,7 @@ alternative implementations like XRandR or TwinView.")
 (define xkbcomp-intermediate ; used as input for xkeyboard-config
   (package
     (name "xkbcomp-intermediate")
-    (version "1.4.2")
+    (version "1.4.3")
     (source
       (origin
         (method url-fetch)
@@ -3756,7 +3757,7 @@ alternative implementations like XRandR or TwinView.")
                ".tar.bz2"))
         (sha256
          (base32
-          "0944rrkkf0dxp07vhh9yr4prslxhqyw63qmbjirbv1bypswvrn3d"))))
+          "0dflr250nlj6rrnv658f6dm8qx37sj0xfimc3ihay761kwb2q906"))))
     (build-system gnu-build-system)
     (inputs
       `(("xorgproto" ,xorgproto)
-- 
2.26.0

[Message part 3 (text/plain, inline)]

-- 
win-nt from the people who invented edlin

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 40204-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Michael Rohleder <mike <at> rohleder.de>, 40204-done <at> debbugs.gnu.org
Subject: Re: [bug#40204] [PATCH] gnu: xkbcomp: update to 1.4.3
Date: Thu, 26 Mar 2020 22:40:59 +0100

[Message part 1 (text/plain, inline)]

Michael Rohleder <mike <at> rohleder.de> writes:

> * gnu/packages/xorg.scm (xkbcomp): update to 1.4.3

Thanks!  Pushed to the 'core-updates' branch as
b12acffbd03c025b1e849f7a93d5edd47682a8ce.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.