GNU bug report logs - #40195
Add Docusign python API module as a package

Previous Next

To reply to this bug, email your comments to 40195 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Josh Marshall <Josh.Marshall <at> jax.org>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: Add Docusign python API module as a package
Date: Mon, 23 Mar 2020 14:26:10 +0000

[Message part 1 (text/plain, inline)]

Add Docusign python API module as a package
---

The information in this email, including attachments, may be confidential and is intended solely for the addressee(s). If you believe you received this email by mistake, please notify the sender by return email as soon as possible.

[0001-Adding-Docusign-python-API-module-as-a-package.patch (application/octet-stream, attachment)]

Message #8 received at 40195 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Josh Marshall <Josh.Marshall <at> jax.org>
Cc: 40195 <at> debbugs.gnu.org
Subject: Re: [bug#40195] Add Docusign python API module as a package
Date: Mon, 23 Mar 2020 15:39:06 -0400

On Mon, Mar 23, 2020 at 02:26:10PM +0000, Josh Marshall wrote:
> Add Docusign python API module as a package

Thanks! I have a few changes...

The tarballs that GitHub automatically generates per-tag (named like
'v3.0.0.tar.gz') do sometimes change, which breaks our packaging. So we
should package this either from the Git tag or from PyPI:

https://pypi.org/project/docusign-esign/

I think we should take the PyPi name as canonical, so as a Python
library, this Guix package should be called 'python-docusign-esign'.

Why are the tests skipped? Can you add a code comment? Even just "No
test suite" if that is the case.

Make sure to lint the package. You may need to do it in a Guix
development environment; something like this should work:

`guix environment guix -- ./pre-inst-env guix lint python-docusign`.

Can you send a revised patch? Also, does this integrate with any Guix
packages?

Message #11 received at 40195 <at> debbugs.gnu.org (full text, mbox):

From: Josh Marshall <Josh.Marshall <at> jax.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: "40195 <at> debbugs.gnu.org" <40195 <at> debbugs.gnu.org>
Subject: Re: [EXTERNAL]Re: [bug#40195] Add Docusign python API module as a
 package
Date: Tue, 24 Mar 2020 17:46:43 +0000

[Message part 1 (text/plain, inline)]

The tarballs that GitHub automatically generates per-tag (named like
'v3.0.0.tar.gz') do sometimes change, which breaks our packaging. So we
should package this either from the Git tag or from PyPI:
> Done

I think we should take the PyPi name as canonical, so as a Python
library, this Guix package should be called 'python-docusign-esign'.
> Done

Why are the tests skipped? Can you add a code comment? Even just "No
test suite" if that is the case.
> Done

Make sure to lint the package. You may need to do it in a Guix
development environment; something like this should work:
> I couldn't figure the command -- thanks.  Also done

Can you send a revised patch? 
> See attached

Also, does this integrate with any Guix packages?
> No?
---

The information in this email, including attachments, may be confidential and is intended solely for the addressee(s). If you believe you received this email by mistake, please notify the sender by return email as soon as possible.

[0001-Adding-Docusign-python-API-module-as-a-package.patch (application/octet-stream, attachment)]

[0002-Making-reccomended-changes.patch (application/octet-stream, attachment)]

Message #14 received at 40195 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Josh Marshall <Josh.Marshall <at> jax.org>
Cc: "40195-done <at> debbugs.gnu.org" <40195 <at> debbugs.gnu.org>
Subject: Re: [EXTERNAL]Re: [bug#40195] Add Docusign python API module as a
 package
Date: Tue, 24 Mar 2020 15:39:42 -0400

Thanks for the revisions! I pushed as
b14c234c0d32216f8c2f6e6d1935c469a6b947c9 with a few more changes:

I made it fetch from PyPi instead of Git since they didn't actually tag
a 3.1.0 release. We'd rather take the thing that upstream definitely
says is "the release" in cases like that.

I made the variable name and package name consistent.

And I simplified the synopsis to hopefully improve searchability.

Message #17 received at 40195 <at> debbugs.gnu.org (full text, mbox):

From: Josh Marshall <Josh.Marshall <at> jax.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: "40195-done <at> debbugs.gnu.org" <40195 <at> debbugs.gnu.org>
Subject: Re: [EXTERNAL]Re: [bug#40195] Add Docusign python API module as a
 package
Date: Tue, 24 Mar 2020 21:06:58 +0000

Thanks!  I'll try to do better on the next one I submit.

________________________________________
From: Leo Famulari <leo <at> famulari.name>
Sent: Tuesday, March 24, 2020 3:39 PM
To: Josh Marshall
Cc: 40195-done <at> debbugs.gnu.org
Subject: Re: [EXTERNAL]Re: [bug#40195] Add Docusign python API module as a package

Thanks for the revisions! I pushed as
b14c234c0d32216f8c2f6e6d1935c469a6b947c9 with a few more changes:

I made it fetch from PyPi instead of Git since they didn't actually tag
a 3.1.0 release. We'd rather take the thing that upstream definitely
says is "the release" in cases like that.

I made the variable name and package name consistent.

And I simplified the synopsis to hopefully improve searchability.
---

The information in this email, including attachments, may be confidential and is intended solely for the addressee(s). If you believe you received this email by mistake, please notify the sender by return email as soon as possible.

Message #20 received at 40195 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Josh Marshall <Josh.Marshall <at> jax.org>
Cc: "40195-done <at> debbugs.gnu.org" <40195 <at> debbugs.gnu.org>
Subject: Re: [EXTERNAL]Re: [bug#40195] Add Docusign python API module as a
 package
Date: Tue, 24 Mar 2020 17:20:54 -0400

On Tue, Mar 24, 2020 at 09:06:58PM +0000, Josh Marshall wrote:
> Thanks!  I'll try to do better on the next one I submit.

Okay! The important thing is to get the patch in the queue :)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.