GNU bug report logs - #40168
[PATCH]

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Damien Cassou <damien <at> cassou.me>
Subject: bug#40168: closed (Re: [bug#40168] [PATCH])
Date: Sat, 21 Mar 2020 22:40:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#40168: [PATCH] 

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 40168 <at> debbugs.gnu.org.

-- 
40168: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40168
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Damien Cassou <damien <at> cassou.me>
Cc: 40168-done <at> debbugs.gnu.org
Subject: Re: [bug#40168] [PATCH]
Date: Sat, 21 Mar 2020 23:39:12 +0100

[Message part 3 (text/plain, inline)]

Hi Damien,

Damien Cassou <damien <at> cassou.me> skribis:

> Damien Cassou (3):
>   * gnu/packages/xdisorg.scm (clipmenu): Re-indent
>   * gnu/packages/xdisorg.scm (clipnotify): Add a comment
>   gnu: clipmenu: Improve the package definition

Applied!

I added a subject line to the commit logs.  For the last patch I
adjusted the shebang substitute:

[Message part 4 (text/x-patch, inline)]

diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index f7c4668bf8..facd63ab53 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -2204,8 +2204,8 @@ tools to complement clipnotify.")
                  #t)))
            (add-after 'install 'wrap-script
              (lambda* (#:key inputs outputs #:allow-other-keys)
-               (let* ((out (assoc-ref outputs "out"))
-                      (clipnotify (assoc-ref inputs "clipnotify"))
+               (let* ((out               (assoc-ref outputs "out"))
+                      (clipnotify        (assoc-ref inputs "clipnotify"))
                       (coreutils-minimal (assoc-ref inputs "coreutils-minimal"))
                       (gawk              (assoc-ref inputs "gawk"))
                       (util-linux        (assoc-ref inputs "util-linux"))
@@ -2227,7 +2227,7 @@ tools to complement clipnotify.")
                ;; file writes this string to a temporary file):
                (substitute* "tests/test-clipmenu"
                  (("#!/usr/bin/env bash")
-                  (which "bash")))
+                  (string-append "#!" (which "bash"))))
                (invoke "tests/test-clipmenu")
                #t)))))
       (inputs

[Message part 5 (text/plain, inline)]

Thanks!

Ludo’.

[Message part 6 (message/rfc822, inline)]

From: Damien Cassou <damien <at> cassou.me>
To: guix-patches <at> gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>
Subject: [PATCH] 
Date: Sat, 21 Mar 2020 18:02:57 +0100

[Message part 7 (text/plain, inline)]

Hi,

I've improved the packaging for clipmenu in
gnu/packages/xdisorg.scm. Please give feedback.

I found that my usage of wrap-script is very verbose. Is there a simpler
way?

Thank you

Damien Cassou (3):
  * gnu/packages/xdisorg.scm (clipmenu): Re-indent
  * gnu/packages/xdisorg.scm (clipnotify): Add a comment
  gnu: clipmenu: Improve the package definition

 gnu/packages/xdisorg.scm | 125 ++++++++++++++++++++++-----------------
 1 file changed, 72 insertions(+), 53 deletions(-)

-- 
Damien Cassou

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

[0001-gnu-packages-xdisorg.scm-clipmenu-Re-indent.patch (text/x-patch, attachment)]

[0002-gnu-packages-xdisorg.scm-clipnotify-Add-a-comment.patch (text/x-patch, attachment)]

[0003-gnu-clipmenu-Improve-the-package-definition.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.