GNU bug report logs - #40157
[PATCH] hydra: Display the IRC logs in reverse chronological order.

Previous Next

Package: guix-patches;

Reported by: Leo Famulari <leo <at> famulari.name>

Date: Fri, 20 Mar 2020 21:45:01 UTC

Severity: normal

Tags: patch

Done: Leo Famulari <leo <at> famulari.name>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Leo Famulari <leo <at> famulari.name>
Subject: bug#40157: closed (Re: [PATCH] hydra: Display the IRC logs in
 reverse chronological order.)
Date: Sun, 22 Mar 2020 17:42:01 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#40157: [PATCH] hydra: Display the IRC logs in reverse chronological order.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 40157 <at> debbugs.gnu.org.

-- 
40157: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40157
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Leo Famulari <leo <at> famulari.name>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 40157-done <at> debbugs.gnu.org
Subject: Re: [PATCH] hydra: Display the IRC logs in reverse chronological
 order.
Date: Sun, 22 Mar 2020 13:41:30 -0400
On Sun, Mar 22, 2020 at 12:43:43PM +0100, Ricardo Wurmus wrote:
> > I think that people usually want to read the latest logs, which
> > currently requires a lot of scrolling.
> >
> > * hydra/goggles.scm (index): Reverse the list of log files.
> 
> Looks good, thank you.  I’ve applied it.  We’ll have to wait for the
> next reconfiguration to see the effects on logs.guix.gnu.org.

Thanks!

[Message part 3 (message/rfc822, inline)]
From: Leo Famulari <leo <at> famulari.name>
To: guix-patches <at> gnu.org
Cc: rekado <at> elephly.net
Subject: [PATCH] hydra: Display the IRC logs in reverse chronological order.
Date: Fri, 20 Mar 2020 17:43:49 -0400
I think that people usually want to read the latest logs, which
currently requires a lot of scrolling.

* hydra/goggles.scm (index): Reverse the list of log files.
---
 hydra/goggles.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/hydra/goggles.scm b/hydra/goggles.scm
index 169b3c3..884c8df 100644
--- a/hydra/goggles.scm
+++ b/hydra/goggles.scm
@@ -181,9 +181,9 @@ freenode." channel))
      (ul
       ,@(map (lambda (file)
                `(li (a (@ (href ,(string-append "/" channel "/" file))) ,file)))
-             (or (scandir (string-append %log-root "/#" channel "/")
-                          (lambda (name)
-                           (not (member name '("." ".." "index.html")))))
+             (or (reverse (scandir (string-append %log-root "/#" channel "/")
+                                   (lambda (name)
+                                    (not (member name '("." ".." "index.html"))))))
                  '()))))))
 
 (define %controller
-- 
2.25.1




This bug report was last modified 5 years and 139 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.