GNU bug report logs - #40151
28.0.50; Remove Date header from message-draft-headers

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40151 in the body.
You can then email your comments to 40151 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; Remove Date header from message-draft-headers
Date: Fri, 20 Mar 2020 10:11:14 -0700

[Message part 1 (text/plain, inline)]

It was noted on gnus.general that it's weird to have the Date header as
part of the default value of `message-draft-headers'. Having it in there
means that a Date header is generated (and fixed) when a message is
first saved or delayed, not when it is sent. In the case of delayed
messages, in particular, it's weird that the eventually-sent message can
have a Date header days or weeks in the past.

Is there any interest in changing the default value?

Eric

[message-draft-headers.diff (text/x-patch, attachment)]

Message #8 received at 40151 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 40151 <at> debbugs.gnu.org
Subject: Re: bug#40151: 28.0.50; Remove Date header from message-draft-headers
Date: Fri, 20 Mar 2020 18:23:50 +0100

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> It was noted on gnus.general that it's weird to have the Date header as
> part of the default value of `message-draft-headers'. Having it in there
> means that a Date header is generated (and fixed) when a message is
> first saved or delayed, not when it is sent. In the case of delayed
> messages, in particular, it's weird that the eventually-sent message can
> have a Date header days or weeks in the past.
>
> Is there any interest in changing the default value?

Sure; makes sense to me.

Perhaps it should be documented in the "postpone" command(s), too.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 40151 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 40151 <at> debbugs.gnu.org
Subject: Re: bug#40151: 28.0.50; Remove Date header from message-draft-headers
Date: Fri, 20 Mar 2020 10:31:19 -0700

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> It was noted on gnus.general that it's weird to have the Date header as
>> part of the default value of `message-draft-headers'. Having it in there
>> means that a Date header is generated (and fixed) when a message is
>> first saved or delayed, not when it is sent. In the case of delayed
>> messages, in particular, it's weird that the eventually-sent message can
>> have a Date header days or weeks in the past.
>>
>> Is there any interest in changing the default value?
>
> Sure; makes sense to me.
>
> Perhaps it should be documented in the "postpone" command(s), too.

You mean in the `gnus-delay-article' docstring? I didn't see anything
apropos of "postpone".

Message #14 received at 40151 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 40151 <at> debbugs.gnu.org
Subject: Re: bug#40151: 28.0.50; Remove Date header from message-draft-headers
Date: Fri, 20 Mar 2020 18:44:49 +0100

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> You mean in the `gnus-delay-article' docstring? I didn't see anything
> apropos of "postpone".

No, but it should perhaps say something.  Or at least point to
message-draft-headers...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #17 received at 40151 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 40151 <at> debbugs.gnu.org
Subject: Re: bug#40151: 28.0.50; Remove Date header from message-draft-headers
Date: Fri, 20 Mar 2020 10:55:28 -0700

[Message part 1 (text/plain, inline)]

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> You mean in the `gnus-delay-article' docstring? I didn't see anything
>> apropos of "postpone".
>
> No, but it should perhaps say something.  Or at least point to
> message-draft-headers...

How's this look?

[0001-Remove-the-Date-header-from-message-draft-headers.patch (text/x-patch, attachment)]

Message #20 received at 40151 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 40151 <at> debbugs.gnu.org
Subject: Re: bug#40151: 28.0.50; Remove Date header from message-draft-headers
Date: Fri, 20 Mar 2020 19:20:03 +0100

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> How's this look?

[...]

> +The value of `message-draft-headers' determines which headers are
> +generate when the article is delayed.  Remaining headers are
           ^d

> +generate when the article is sent."
           ^d

Otherwise -- looks good to me.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #25 received at 40151-done <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 40151-done <at> debbugs.gnu.org
Subject: Re: bug#40151: 28.0.50; Remove Date header from message-draft-headers
Date: Fri, 20 Mar 2020 11:41:11 -0700

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> How's this look?
>
> [...]
>
>> +The value of `message-draft-headers' determines which headers are
>> +generate when the article is delayed.  Remaining headers are
>            ^d
>
>> +generate when the article is sent."
>            ^d

A weird typo to make twice...

> Otherwise -- looks good to me.

Done, thanks.

Message #28 received at 40151 <at> debbugs.gnu.org (full text, mbox):

From: James Cloos <cloos <at> jhcloos.com>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 40151 <at> debbugs.gnu.org
Subject: Re: bug#40151: 28.0.50; Remove Date header from message-draft-headers
Date: Fri, 20 Mar 2020 15:40:44 -0400

there should be an easy way to avoid this change.  on a per message basis.

-JimC
-- 
James Cloos <cloos <at> jhcloos.com>         OpenPGP: 0x997A9F17ED7DAEA6

Message #31 received at 40151 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: James Cloos <cloos <at> jhcloos.com>
Cc: 40151 <at> debbugs.gnu.org
Subject: Re: bug#40151: 28.0.50; Remove Date header from message-draft-headers
Date: Fri, 20 Mar 2020 13:57:05 -0700

James Cloos <cloos <at> jhcloos.com> writes:

> there should be an easy way to avoid this change.  on a per message basis.

Providing some per-message mechanism is beyond the scope of this change,
and I think would have to be tackled separately, but if you think this
change is bad and should be reverted, I'd be happy to hear why, and
discuss it. I probably should have left the report up for a while before
pushing it.

Message #34 received at 40151 <at> debbugs.gnu.org (full text, mbox):

From: Peter Münster <pmlists <at> free.fr>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 40151 <at> debbugs.gnu.org, Lars Ingebrigtsen <larsi <at> gnus.org>
Subject: Re: bug#40151: 28.0.50; Remove Date header from message-draft-headers
Date: Mon, 23 Mar 2020 09:09:00 +0100

[Message part 1 (text/plain, inline)]

On Fri, Mar 20 2020, Eric Abrahamsen wrote:

> -  :version "22.1"
> +  :version "28.1"

Why waiting for 28.1?
27.1 is not yet released.

-- 
           Peter

[signature.asc (application/pgp-signature, inline)]

Message #37 received at 40151 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Peter Münster <pmlists <at> free.fr>
Cc: Eric Abrahamsen <eric <at> ericabrahamsen.net>, 40151 <at> debbugs.gnu.org,
 Lars Ingebrigtsen <larsi <at> gnus.org>
Subject: Re: bug#40151: 28.0.50; Remove Date header from message-draft-headers
Date: Mon, 23 Mar 2020 09:35:33 +0100

>>>>> On Mon, 23 Mar 2020 09:09:00 +0100, Peter Münster <pmlists <at> free.fr> said:

    Peter> On Fri, Mar 20 2020, Eric Abrahamsen wrote:
    >> -  :version "22.1"
    >> +  :version "28.1"

    Peter> Why waiting for 28.1?
    Peter> 27.1 is not yet released.

27.1 is in pre-release, which means no new features, bugfixes and doc
fixes only. I realise itʼs a small change, but who here hasn't
released software with 'just one last change' and gotten burnt?

Robert

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.