GNU bug report logs - #40143
[PATCH] gnu: git: Return #t in install-man-pages phase.

Previous Next

Package: guix-patches;

Reported by: Brice Waegeneire <brice <at> waegenei.re>

Date: Fri, 20 Mar 2020 09:21:01 UTC

Severity: normal

Tags: patch

Done: Mathieu Othacehe <m.othacehe <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Brice Waegeneire <brice <at> waegenei.re>
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 40143-close <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, Guix-patches <guix-patches-bounces+brice+lists=waegenei.re <at> gnu.org>
Subject: [bug#40143] [PATCH] gnu: git: Return #t in install-man-pages phase.
Date: Sat, 21 Mar 2020 14:43:56 +0000

On 2020-03-21 14:29, Mathieu Othacehe wrote:
> Hello Brice,
> 
>> Danny Milosavljevic <dannym <at> scratchpost.org> writes:
>> 
>>> invoke already returns #t, so there's no technical bug.
>>> 
>>> That said, maybe for clarity?  Not sure...
> 
> I agree with Danny and Maxim here, we already return a boolean, or
> raise an exception in case of error, so I think we are fine :)
> 
> Closing this bug,
> 
> Thanks,
> 
> Mathieu

Looks like a forgot to reply to all, I replied to Danny that it
should be closed. I missed the RTFM sign... I didn't knew about
Maxim's link and would like to know where are we in transitioning
away from getting rid of boolean return code in phases.
This bug report was last modified 5 years and 146 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.