GNU bug report logs - #40143
[PATCH] gnu: git: Return #t in install-man-pages phase.

Previous Next

Package: guix-patches;

Reported by: Brice Waegeneire <brice <at> waegenei.re>

Date: Fri, 20 Mar 2020 09:21:01 UTC

Severity: normal

Tags: patch

Done: Mathieu Othacehe <m.othacehe <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #16 received at 40143-close <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 40143-close <at> debbugs.gnu.org,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: [bug#40143] [PATCH] gnu: git: Return #t in install-man-pages
 phase.
Date: Sat, 21 Mar 2020 15:29:52 +0100

Hello Brice,

> Danny Milosavljevic <dannym <at> scratchpost.org> writes:
>
>> invoke already returns #t, so there's no technical bug.
>>
>> That said, maybe for clarity?  Not sure...

I agree with Danny and Maxim here, we already return a boolean, or
raise an exception in case of error, so I think we are fine :)

Closing this bug,

Thanks,

Mathieu
This bug report was last modified 5 years and 146 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.