GNU bug report logs - #40143
[PATCH] gnu: git: Return #t in install-man-pages phase.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#40143: closed ([PATCH] gnu: git: Return #t in install-man-pages
 phase.)
Date: Sat, 21 Mar 2020 14:30:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 21 Mar 2020 15:29:52 +0100
with message-id <877dzdkcgv.fsf <at> gmail.com>
and subject line Re: [bug#40143] [PATCH] gnu: git: Return #t in install-man-pages phase.
has caused the debbugs.gnu.org bug report #40143,
regarding [PATCH] gnu: git: Return #t in install-man-pages phase.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
40143: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40143
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Brice Waegeneire <brice <at> waegenei.re>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: git: Return #t in install-man-pages phase.
Date: Fri, 20 Mar 2020 10:20:05 +0100

* gnu/packages/version-control.scm (git)[arguments]: Return #t in
install-man-pages phase.
---
 gnu/packages/version-control.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index d25df4c63d..7eb85cc749 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -441,7 +441,8 @@ as well as the classic centralized workflow.")
                    (manpages (assoc-ref inputs "git-manpages")))
               (mkdir-p man)
               (with-directory-excursion man
-                (invoke "tar" "xvf" manpages))))))))
+                (invoke "tar" "xvf" manpages)))
+            #t)))))
 
    (native-search-paths
     ;; For HTTPS access, Git needs a single-file certificate bundle, specified

base-commit: 837644b48a5107a28acbdb6d172aff0040a8247d
prerequisite-patch-id: b9e1cb7e09e15cac4d607e985e2a3b5e301828e5
prerequisite-patch-id: e22ea3f99fc3d9f3e11ddfa31ba60212f2ed4d62
-- 
2.25.1

[Message part 3 (message/rfc822, inline)]

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 40143-close <at> debbugs.gnu.org,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: [bug#40143] [PATCH] gnu: git: Return #t in install-man-pages
 phase.
Date: Sat, 21 Mar 2020 15:29:52 +0100

Hello Brice,

> Danny Milosavljevic <dannym <at> scratchpost.org> writes:
>
>> invoke already returns #t, so there's no technical bug.
>>
>> That said, maybe for clarity?  Not sure...

I agree with Danny and Maxim here, we already return a boolean, or
raise an exception in case of error, so I think we are fine :)

Closing this bug,

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.