From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 20 05:20:18 2020 Received: (at submit) by debbugs.gnu.org; 20 Mar 2020 09:20:18 +0000 Received: from localhost ([127.0.0.1]:43973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFDpC-0005lk-Ky for submit@debbugs.gnu.org; Fri, 20 Mar 2020 05:20:18 -0400 Received: from lists.gnu.org ([209.51.188.17]:51412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFDpA-0005la-PY for submit@debbugs.gnu.org; Fri, 20 Mar 2020 05:20:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51574) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFDp9-0002bz-Pb for guix-patches@gnu.org; Fri, 20 Mar 2020 05:20:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_20,RCVD_IN_DNSWL_LOW autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jFDp8-0002vg-Me for guix-patches@gnu.org; Fri, 20 Mar 2020 05:20:15 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:34313) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jFDp8-0002oL-GU for guix-patches@gnu.org; Fri, 20 Mar 2020 05:20:14 -0400 Received: from localhost (luy13-1-78-237-113-178.fbx.proxad.net [78.237.113.178]) (Authenticated sender: brice@waegenei.re) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 6DD00100009 for ; Fri, 20 Mar 2020 09:20:09 +0000 (UTC) From: Brice Waegeneire To: guix-patches@gnu.org Subject: [PATCH] gnu: git: Return #t in install-man-pages phase. Date: Fri, 20 Mar 2020 10:20:05 +0100 Message-Id: <20200320092005.22388-1-brice@waegenei.re> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 217.70.178.231 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/version-control.scm (git)[arguments]: Return #t in install-man-pages phase. --- gnu/packages/version-control.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm index d25df4c63d..7eb85cc749 100644 --- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -441,7 +441,8 @@ as well as the classic centralized workflow.") (manpages (assoc-ref inputs "git-manpages"))) (mkdir-p man) (with-directory-excursion man - (invoke "tar" "xvf" manpages)))))))) + (invoke "tar" "xvf" manpages))) + #t))))) (native-search-paths ;; For HTTPS access, Git needs a single-file certificate bundle, specified base-commit: 837644b48a5107a28acbdb6d172aff0040a8247d prerequisite-patch-id: b9e1cb7e09e15cac4d607e985e2a3b5e301828e5 prerequisite-patch-id: e22ea3f99fc3d9f3e11ddfa31ba60212f2ed4d62 -- 2.25.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 20 05:54:14 2020 Received: (at 40143) by debbugs.gnu.org; 20 Mar 2020 09:54:14 +0000 Received: from localhost ([127.0.0.1]:43985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFEM1-0006eV-Ql for submit@debbugs.gnu.org; Fri, 20 Mar 2020 05:54:14 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:48522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFELz-0006eL-Bh for 40143@debbugs.gnu.org; Fri, 20 Mar 2020 05:54:11 -0400 Received: from localhost (80-110-126-163.cgn.dynamic.surfer.at [80.110.126.163]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 4FE5233679F7; Fri, 20 Mar 2020 10:54:09 +0100 (CET) Date: Fri, 20 Mar 2020 10:54:06 +0100 From: Danny Milosavljevic To: Brice Waegeneire Subject: Re: [bug#40143] [PATCH] gnu: git: Return #t in install-man-pages phase. Message-ID: <20200320105406.42ba348b@scratchpost.org> In-Reply-To: <20200320092005.22388-1-brice@waegenei.re> References: <20200320092005.22388-1-brice@waegenei.re> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/Y_tS6kssurWnS1wc+ZrwscK"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40143 Cc: 40143@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/Y_tS6kssurWnS1wc+ZrwscK Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable invoke already returns #t, so there's no technical bug. That said, maybe for clarity? Not sure... --Sig_/Y_tS6kssurWnS1wc+ZrwscK Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl50kr4ACgkQ5xo1VCww uqUA6Af/V72+dk8p9/pwjv2aWdMjQFwg8SLeIio5wCxTp4JTNtl+DK+nyD57ZRZz c2I8flvOkmG5vijkiNL97e15fyHjTfD+aagTQClOM4oOIBkRrLciTnVk6LyJ4+ZC eokiQRcU0tWLf5ZYQ6ZdEkdtmOxHFmC1MeTShivNoCnnrCV/pv2Wk0aSMAAkwDh3 vqNeqHwYJTgzbtcsw+CpmmDpAbRiUWMCRRH2oekbHaZlI9m7veN7Cj4x1JDov3EK aczuoiJ+IqHbGGv9yS5SmlgPmD7EoiLdNinLSV6p2EyvAaNdivuCHcpkTRMKoKaH uz+vaAvMZbnVND4TFwygwLT6+xTlEg== =OkXj -----END PGP SIGNATURE----- --Sig_/Y_tS6kssurWnS1wc+ZrwscK-- From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 20 10:21:26 2020 Received: (at 40143) by debbugs.gnu.org; 20 Mar 2020 14:21:26 +0000 Received: from localhost ([127.0.0.1]:45336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFIWb-0007jM-Os for submit@debbugs.gnu.org; Fri, 20 Mar 2020 10:21:25 -0400 Received: from mail-qv1-f66.google.com ([209.85.219.66]:40967) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFIWZ-0007j9-MK for 40143@debbugs.gnu.org; Fri, 20 Mar 2020 10:21:24 -0400 Received: by mail-qv1-f66.google.com with SMTP id o7so537953qvq.8 for <40143@debbugs.gnu.org>; Fri, 20 Mar 2020 07:21:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=YdwdJVFgrhF8TJMMK/sjkoSsPjE2/RjfxH43j3BOHZE=; b=lsZQRABgpRlMIl2dLHo0Xmy2l0HeGVOXJBxnJA5aR6lDrZVv/WmuOj8BS34xgr0ICk N08G7UjM2d2Vb7D0wHRbB+bDSPNKr/cos3ue/A098mXzL8F7cnoawT3O6nAi1ukzR1RI 03uAiPt24tgfkVf5Re3jvfw61svibAs70azgxsFlOaKeS2rqa2lwNa5fGAD43ZC1e6tm m42slQVfkQXo1aBipoenS4bEF2PLZNdZN+lcXDsSEPBMWDGIsH+YsPjRdRnhOE85d34c /BUDm2xUopflHU5D3sbmZC1AzcmPTgt4EgHx5y06/AfA1lHby3Yb/e4zXiA3Y0vAuVNm wpzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=YdwdJVFgrhF8TJMMK/sjkoSsPjE2/RjfxH43j3BOHZE=; b=Ag1z71vlDBcsrLZZTSiHsPsuVwIUsQCu//6MeOX+9sF+6Zc9KxesCm6n166TIbUPIn fMDVplMKJjJ6hdWQJCBV1gxPwnp/73hePSjQjjOQUFA18tB32n9mT4O1MC8xneunDb7k unhQMmZvlH0aDM9gEH4zy1Iyb2jqYLmqhShUpW9aa7ykztTqtjxzgf3vE+FY+ZkPsgH4 R2ye+GUetbk6BPtomzR59f2dGq4iyZPdZG3hfCdqix9PTi6hnX6+7oTmj6yLKhC/KfUz WzNonK7GwGmZySEPwdnJy/z5xuhsjz5J/vdeg2kstZ3P4XhV8GxYD38bhtDf5zSb/WJW o2Qw== X-Gm-Message-State: ANhLgQ0G+EHSoJUt8ntvgFBBax2GVdQoMCyubLcnTDUIVum+iOW3YI2X NaIX+3HMvLHIMqf2eFfaP40TsdvbkE8= X-Google-Smtp-Source: ADFU+vupFP8lZvDedW1pQJW5iY/6/t2aQvgr7j7tdHHOat4CJVDwI52qpCKdouqntAlcYIOTB9IxiQ== X-Received: by 2002:a0c:f788:: with SMTP id s8mr8478549qvn.236.1584714075733; Fri, 20 Mar 2020 07:21:15 -0700 (PDT) Received: from raisin ([2607:fad8:4:6:235e:8579:8464:aacc]) by smtp.gmail.com with ESMTPSA id 31sm4655631qta.56.2020.03.20.07.21.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2020 07:21:14 -0700 (PDT) From: Maxim Cournoyer To: Danny Milosavljevic Subject: Re: [bug#40143] [PATCH] gnu: git: Return #t in install-man-pages phase. References: <20200320092005.22388-1-brice@waegenei.re> <20200320105406.42ba348b@scratchpost.org> Date: Fri, 20 Mar 2020 10:21:14 -0400 In-Reply-To: <20200320105406.42ba348b@scratchpost.org> (Danny Milosavljevic's message of "Fri, 20 Mar 2020 10:54:06 +0100") Message-ID: <87blor3y5h.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40143 Cc: Brice Waegeneire , 40143@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Danny Milosavljevic writes: > invoke already returns #t, so there's no technical bug. > > That said, maybe for clarity? Not sure... I don't see any technical nor clarity issue here. The vision laid out by Mark more than two years ago (!) was to get rid of all the boolean return codes and move to an exception based system entirely, which I find much more elegant. The transition plan was outlined in this message: https://lists.gnu.org/archive/html/guix-devel/2017-12/msg00278.html. I think we should go back to work on finishing the missing bits :-). Maxim From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 21 10:30:01 2020 Received: (at 40143-close) by debbugs.gnu.org; 21 Mar 2020 14:30:01 +0000 Received: from localhost ([127.0.0.1]:47776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFf8T-0000pQ-6p for submit@debbugs.gnu.org; Sat, 21 Mar 2020 10:30:01 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:39504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFf8R-0000p6-LH for 40143-close@debbugs.gnu.org; Sat, 21 Mar 2020 10:30:00 -0400 Received: by mail-wr1-f67.google.com with SMTP id h6so10948540wrs.6 for <40143-close@debbugs.gnu.org>; Sat, 21 Mar 2020 07:29:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=pnfsfgqMV2Wu/GNtp7YeHTlz6hwaZsEG1Ur0O4BJAxI=; b=DJaya+E3tr9m70ABuUCAo6mRuMVxxlhA6J+kraxMyevzZK9DrEKwh9I3m8yquyWwl7 tn/45oOofUWryTPe+567edtD3CE3tsL36wbZmhJwC00TUQy4sn/p+umTZxkQUvP/JX/+ oj/GowiKlrD9Haq4E/+LOuKl962bSboXa6wOOETu6d0WHsF/rLtJOg0MyMk57c4mZl4M Hyqh6f+ASb52qTXoUCWEZtghJ30gwDmfod6+5mkm8bjy9/NIzGe71WS4ioYTYJonVC3s ZY0OdW6geTI3Ruea8qYAy+DWGGF5UkNUJR1P4edEqv20ukNmEkV1x7t3cZ/HGkgHeQ1k DxTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=pnfsfgqMV2Wu/GNtp7YeHTlz6hwaZsEG1Ur0O4BJAxI=; b=lpXIy+pNS65ZcfrekcaQxWSonnvPtqGhnFe1mF2b1OyU1oNCmssdGI74gLWCM9jTAv P0YN0K2XTJKi7Ey1f7wXczLQG8K9Kst+kXn/oqg2btplAn/G0HzlNqrbK4bUTsZmNiW+ udTsjc1/9CxegP0Huew1VnauvhMVPw+c7env0iBBh4svV0fFu4DBFNbTBFxa0+tDv/Ac nRIksXw/v2vDn1TiIZJjPTxbULA4qoqkyeFKh/nfFNSHVn45IBhzfyMjfGc5CH8Ir9Wq FtDeXzZEYcKtR5z4Rin6+TxDmWQu/c+t+lgldAg2n/fz/nC2UkzgqY+PwI71YSml6S+I 5EMA== X-Gm-Message-State: ANhLgQ2V9+ZAP+g+xmYwQpjcRgzXgtXQ9HdxVhvsPwaW8mU6KUtVvNgN SVIMNMeTEVwctxzz7B9S03+IYmfsAhM= X-Google-Smtp-Source: ADFU+vuQGu1tuT1NPiEHxj/Ts5fJAd9qSgdo49ZvFJ14Nac9s2tvRzXhRqGWMi6aca4EsX5bqi1rDw== X-Received: by 2002:a5d:5106:: with SMTP id s6mr16816318wrt.24.1584800993632; Sat, 21 Mar 2020 07:29:53 -0700 (PDT) Received: from meru ([2a01:cb18:832e:5f00:acf7:2f15:39af:8258]) by smtp.gmail.com with ESMTPSA id b11sm2034563wrq.26.2020.03.21.07.29.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2020 07:29:53 -0700 (PDT) References: <20200320092005.22388-1-brice@waegenei.re> <20200320105406.42ba348b@scratchpost.org> <87blor3y5h.fsf@gmail.com> User-agent: mu4e 1.2.0; emacs 26.3 From: Mathieu Othacehe To: Brice Waegeneire Subject: Re: [bug#40143] [PATCH] gnu: git: Return #t in install-man-pages phase. In-reply-to: <87blor3y5h.fsf@gmail.com> Date: Sat, 21 Mar 2020 15:29:52 +0100 Message-ID: <877dzdkcgv.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40143-close Cc: Danny Milosavljevic , 40143-close@debbugs.gnu.org, Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Brice, > Danny Milosavljevic writes: > >> invoke already returns #t, so there's no technical bug. >> >> That said, maybe for clarity? Not sure... I agree with Danny and Maxim here, we already return a boolean, or raise an exception in case of error, so I think we are fine :) Closing this bug, Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 21 10:44:07 2020 Received: (at 40143-close) by debbugs.gnu.org; 21 Mar 2020 14:44:07 +0000 Received: from localhost ([127.0.0.1]:47814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFfM6-0001Kp-Mi for submit@debbugs.gnu.org; Sat, 21 Mar 2020 10:44:06 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:50549) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFfM4-0001Jp-1r for 40143-close@debbugs.gnu.org; Sat, 21 Mar 2020 10:44:04 -0400 Received: from webmail.gandi.net (webmail18.sd4.0x35.net [10.200.201.18]) (Authenticated sender: brice@waegenei.re) by relay3-d.mail.gandi.net (Postfix) with ESMTPA id 038E160007; Sat, 21 Mar 2020 14:43:56 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 21 Mar 2020 14:43:56 +0000 From: Brice Waegeneire To: Brice Waegeneire Subject: Re: bug#40143: [PATCH] gnu: git: Return #t in install-man-pages phase. In-Reply-To: <877dzdkcgv.fsf@gmail.com> References: <20200320092005.22388-1-brice@waegenei.re> <20200320105406.42ba348b@scratchpost.org> <87blor3y5h.fsf@gmail.com> <877dzdkcgv.fsf@gmail.com> Message-ID: <97f43fbba8a1b83caa53373c459a7639@waegenei.re> X-Sender: brice@waegenei.re User-Agent: Roundcube Webmail/1.3.8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40143-close Cc: Danny Milosavljevic , 40143-close@debbugs.gnu.org, Maxim Cournoyer , Guix-patches X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2020-03-21 14:29, Mathieu Othacehe wrote: > Hello Brice, > >> Danny Milosavljevic writes: >> >>> invoke already returns #t, so there's no technical bug. >>> >>> That said, maybe for clarity? Not sure... > > I agree with Danny and Maxim here, we already return a boolean, or > raise an exception in case of error, so I think we are fine :) > > Closing this bug, > > Thanks, > > Mathieu Looks like a forgot to reply to all, I replied to Danny that it should be closed. I missed the RTFM sign... I didn't knew about Maxim's link and would like to know where are we in transitioning away from getting rid of boolean return code in phases. From unknown Thu Sep 11 15:11:04 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 19 Apr 2020 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator