GNU bug report logs - #40130
[PATCH 0/8] Add 'with-build-handler' and use it to improve UI feedback

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Subject: bug#40130: closed (Re: [bug#40130] [PATCH 0/8] Add
 'with-build-handler' and use it to improve UI feedback)
Date: Sun, 22 Mar 2020 11:45:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#40130: [PATCH 0/8] Add 'with-build-handler' and use it to improve UI feedback

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 40130 <at> debbugs.gnu.org.

-- 
40130: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40130
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: 40130-done <at> debbugs.gnu.org
Subject: Re: [bug#40130] [PATCH 0/8] Add 'with-build-handler' and use it to
 improve UI feedback
Date: Sun, 22 Mar 2020 12:44:43 +0100

Ludovic Courtès <ludo <at> gnu.org> skribis:

> This patch series is to always display upfront what’s going to
> happen, even in the presence of “dynamic dependencies” (grafts),
> as was reported at:
>
>   https://issues.guix.gnu.org/issue/28310
>
> With this patch, any time ‘build-things’ is called, we have an
> opportunity to display what’s going to happen and to choose
> whether or not to actually build things (dry runs).

Pushed with a0f480d623f71b7f0d93de192b86038317dc625b along with related
changes.

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>
Subject: [PATCH 0/8] Add 'with-build-handler' and use it to improve UI feedback
Date: Thu, 19 Mar 2020 11:56:42 +0100

Hello Guix!

This patch series is to always display upfront what’s going to
happen, even in the presence of “dynamic dependencies” (grafts),
as was reported at:

  https://issues.guix.gnu.org/issue/28310

With this patch, any time ‘build-things’ is called, we have an
opportunity to display what’s going to happen and to choose
whether or not to actually build things (dry runs).

I’m wondering whether/how this mechanism could be extended to
address:

  https://issues.guix.gnu.org/issue/22990

We’ll see!

Ludo’.

Ludovic Courtès (8):
  syscalls: 'with-file-lock' re-grabs lock when reentering its dynamic
    extent.
  store: Add 'with-build-handler'.
  ui: Add a notification build handler.
  guix build: Use 'with-build-handler'.
  deploy: Use 'with-build-handler'.
  pack: Use 'with-build-handler'.
  guix package, pull: Use 'with-build-handler'.
  guix system: Use 'with-build-handler'.

 .dir-locals.el           |   1 +
 guix/build/syscalls.scm  |  64 ++++++-------
 guix/scripts/build.scm   | 114 +++++++++++------------
 guix/scripts/deploy.scm  |  34 +++----
 guix/scripts/pack.scm    | 196 +++++++++++++++++++--------------------
 guix/scripts/package.scm |  29 +++---
 guix/scripts/pull.scm    | 118 ++++++++++++-----------
 guix/scripts/system.scm  |  80 ++++++++--------
 guix/store.scm           |  75 ++++++++++++---
 guix/ui.scm              |  38 ++++++++
 tests/store.scm          |  34 ++++++-
 11 files changed, 447 insertions(+), 336 deletions(-)

-- 
2.25.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.