GNU bug report logs - #40121
27.0.90; ERC incorrectly reuses single buffer for channels of same name on multiple networks

Previous Next

Full log

Message #24 received at 40121 <at> debbugs.gnu.org (full text, mbox):

From: Kevin Brubeck Unhammer <unhammer <at> fsfe.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 40121 <at> debbugs.gnu.org
Subject: Re: bug#40121: 27.0.90; ERC incorrectly reuses single buffer for
 channels of same name on multiple networks
Date: Wed, 05 Aug 2020 12:37:12 +0200

[Message part 1 (text/plain, inline)]

Lars Ingebrigtsen <larsi <at> gnus.org> čálii:

> Kevin Brubeck Unhammer <unhammer <at> fsfe.org> writes:
>
>> There's still a bug when there's two networks on the same server:port.
>>
>> But the fix is simple, just an `(and target …)` around the "Channel
>> buffer" case, like
>>
>>                    ;; Channel buffer; check that it's from the right server.
>>                    (and target
>>                         (with-current-buffer (get-buffer candidate)
>>                           (and (string= erc-session-server server)
>>                                (erc-port-equal erc-session-port port))))
>>
>> I connect to several networks on the same server:port (my weechat
>> instance). Without the `and target` check it'll reuse the server buffer
>> from network1 when connecting to network2.
>
> Ah, I see.  I didn't even know that was possible.  :-)
>
> I've now applied your fix to Emacs 28.

Thanks! :)

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.