From unknown Mon Jun 23 18:33:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40121: 27.0.90; ERC incorrectly reuses single buffer for channels of same name on multiple networks Resent-From: Corwin Brust Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Mar 2020 16:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 40121 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 40121@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.158454775722475 (code B ref -1); Wed, 18 Mar 2020 16:10:02 +0000 Received: (at submit) by debbugs.gnu.org; 18 Mar 2020 16:09:17 +0000 Received: from localhost ([127.0.0.1]:41074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEbFs-0005qQ-P4 for submit@debbugs.gnu.org; Wed, 18 Mar 2020 12:09:17 -0400 Received: from lists.gnu.org ([209.51.188.17]:36477) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEbFr-0005qJ-Bh for submit@debbugs.gnu.org; Wed, 18 Mar 2020 12:09:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52708) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEbFp-0007LO-Nk for bug-gnu-emacs@gnu.org; Wed, 18 Mar 2020 12:09:15 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jEbFn-0007rH-6N for bug-gnu-emacs@gnu.org; Wed, 18 Mar 2020 12:09:13 -0400 Received: from mail-qv1-f54.google.com ([209.85.219.54]:42817) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jEbFn-0007oR-1T for bug-gnu-emacs@gnu.org; Wed, 18 Mar 2020 12:09:11 -0400 Received: by mail-qv1-f54.google.com with SMTP id ca9so13178539qvb.9 for ; Wed, 18 Mar 2020 09:09:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to :content-transfer-encoding; bh=Gxi/jG3yoXGJnTuERp4Dj2qYB4OE3R0o+mk1FH+mpAc=; b=NpI4Vk7R5UMj7XMhNrDoyOgbB6XVTGReFiXqcLRPxeOrCLtToxENESVZ4aibXfpEPg YcRe13VhJZEfP5yGqWli8vB1ZbyDybE2Q/+u8mEYVlA2qnfE7+MkWJl0B8MR4Ha3WjAo Dl6mlAABdtBbsY6YZra3wzL/D8Mhn+vpXOtOMq95ZJNPRr49yOKRIB+ua2IadwIoUrel 4C4tKRWkk43uefUAHXUXNZ8/iDzw3/atLAOmAkom6QLTbWro7iR1iy/8+eWI5Eib9eJC 9yB88gKLjpWpyNc+eNsp/z6QarEiJQHBcDbfVUJBBGlZOXY1CuapU3jf11Z2euoiWIKY Vv5Q== X-Gm-Message-State: ANhLgQ1wvLuQiQPju/ZtQU1mfcIBaT9gAa0aMerbD9Q/j67DdQHlPs7A Q116pswVx2QAuHWZsiaoaaSR7DwhM1xtDqex56YPwWfu X-Google-Smtp-Source: ADFU+vvXTAeN65evFqKs45zSLp2ZogIhbecwl9OGS5Xp8/U5gKx0v8WiUELpiKcGGUTtN/9nTglf5NbcG5imBXEoIMY= X-Received: by 2002:a05:6214:1703:: with SMTP id db3mr5187068qvb.28.1584547749644; Wed, 18 Mar 2020 09:09:09 -0700 (PDT) MIME-Version: 1.0 From: Corwin Brust Date: Wed, 18 Mar 2020 11:08:59 -0500 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.219.54 X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) I'm able to get two channels of the same name sharing a single buffer. I was hunting for this feature once upon a time but I *swear* I didn't do *anything* :) 1. emacs -Q On windows, so I used: D:\projects>c:\emacs-27.0.90\x86_64\bin\runemacs.e= xe -Q 2. M-x erc RET Connect to an IRC network such as freenode. Expect: Connection occurs succcessfully; server buffer opens) 3. /join #mytestchannel RET Do this in the server buffer after connecting. Expect: Channel joined successfully, channel buffer opens. Actual: OK 4. M-x erc RET Connect to a second IRC network such as efnet Expect: Connection occurs succcessfully; server buffer opens) Actual: OK 3. /join #mytestchannel RET Do this in the new/second server buffer after both network connections are successful. Expect: Channel joined successfully, new channel buffer opens. Actual: NOT OK When I join a second channel of the same name on a different network, rather than create a new buffer and switch to it, ERC is reusing the buffer created for the channel on the first network. I see a consolidated feed of messages sent from either network's channel and the mode line for this "shared" buffer changes to reflect whichever network last sent traffic to it. Before confirming I can reproduce in -Q and creating this report I left my client running and connected to both channels for a couple of days. ERC was stable this time. In fact, if I had some way to select which network's channel I was sending too (and if I had any control over it happening) this might be a cool feature. As it is messages are sent to whichever network last wrote to the buffer. Using the following expression in M-: with the "shared" buffer selected I can see that the erc-session-server (which I think of as "IRC network server") does change as incoming traffic causes each respective network to "take over" the buffer. ;; list erc buffers and their network (mapconcat (lambda(b) (with-current-buffer b (format "%s =3D> %s\n" b erc-session-server))) (erc-all-buffer-names) " ") I had some additional issues with nickname autocomplete that may be related but I've not troubled to research these at all yet. I'll share additional detail or a patch when/if I develop any. Thank you! In GNU Emacs 27.0.90 (build 1, x86_64-w64-mingw32) of 2020-03-01 built on CIRROCUMULUS Repository revision: c5f255d68156926923232b1edadf50faac527861 Repository branch: HEAD Windowing system distributor 'Microsoft Corp.', version 10.0.18363 System Description: Microsoft Windows 10 Home (v10.0.1909.18363.720) Recent messages: Logging in as `mplsCorwin'... Logging in as =E2=80=98mplsCorwin=E2=80=99... done Connecting to irc.perl.org:6667... Logging in as `corwin'... Logging in without password Logging in as =E2=80=98corwin=E2=80=99... done Making completion list... Commands: d, s, x, u; f, o, 1, 2, m, v; ~, %; q to quit; ? for help. Mark set Making completion list... Configured using: 'configure --without-dbus --host=3Dx86_64-w64-mingw32 --without-compress-install 'CFLAGS=3D-O2 -static'' Configured features: XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY W32NOTIFY ACL GNUTLS LIBXML2 HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS MODULES THREADS PDUMPER LCMS2 GMP Important settings: value of $LANG: ENU locale-coding-system: cp1252 Major mode: Buffer Menu Minor modes in effect: erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-networks-mode: t erc-pcomplete-mode: t erc-track-mode: t erc-track-minor-mode: t erc-match-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-netsplit-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs text-property-search mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils erc-list erc-menu easymenu erc-join erc-ring erc-networks erc-pcomplete time-date pcomplete comint ansi-color ring erc-track erc-match erc-button browse-url wid-edit erc-fill erc-stamp erc-netsplit erc-goodies erc erc-backend erc-compat format-spec auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs cl-loaddefs cl-lib password-cache json subr-x map seq byte-opt gv bytecomp byte-compile cconv thingatpt pp erc-loaddefs tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads w32notify w32 lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 87033 18275) (symbols 48 9967 1) (strings 32 28608 1896) (string-bytes 1 880312) (vectors 16 15638) (vector-slots 8 185817 12702) (floats 8 42 320) (intervals 56 876 280) (buffers 1000 16)) From unknown Mon Jun 23 18:33:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40121: 27.0.90; ERC incorrectly reuses single buffer for channels of same name on multiple networks Resent-From: Kevin Brubeck Unhammer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Jun 2020 13:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40121 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Corwin Brust Cc: 40121@debbugs.gnu.org Received: via spool by 40121-submit@debbugs.gnu.org id=B40121.159283285329148 (code B ref 40121); Mon, 22 Jun 2020 13:35:02 +0000 Received: (at 40121) by debbugs.gnu.org; 22 Jun 2020 13:34:13 +0000 Received: from localhost ([127.0.0.1]:33490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnMaS-0007a4-MH for submit@debbugs.gnu.org; Mon, 22 Jun 2020 09:34:12 -0400 Received: from wforward1-smtp.messagingengine.com ([64.147.123.30]:51303) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnMaQ-0007Zr-9L for 40121@debbugs.gnu.org; Mon, 22 Jun 2020 09:34:11 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailforward.west.internal (Postfix) with ESMTP id 3141111E9; Mon, 22 Jun 2020 09:34:04 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 22 Jun 2020 09:34:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=KkCPuV vq++u+EA52A1F26fXQPzmFezFde+X7U05LoXg=; b=c3XoZ0/+zx+qL5mv/EY/w1 FgJ9WjE94aVAcHs085P9SkRhaHZ4twtNbGqRa6rjECekEzgxpX17c7FeRWGtbWj0 Ny5yo6vy2sJPLxcjCFl0tiAXQCbXOmy7c0MPwzCKNSeWaiqshnUVWVykgWxp+YYN 1X8g/1gm4Saygh/T1RRynoOCsje4JAuXZWNN7RCNsEjbw8ipoypTWcU64p4f02Sa cVhJS8y1zl0NZpiFqKE4pf34rksXd/VuypDIPZQL/Tz1B+hKmSBVIxZvyjKVsJAL 7oxB1E1eUyTtN8hrAo3kw0BkuhC0ryArU/eo1k3HtLIJx9+mQ1IORtcYuz3deBfg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudekvddgieejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufhfffgjkfggtgesthdtredttddttdenucfhrhhomhepmfgvvhhinhcu uehruhgsvggtkhcufghnhhgrmhhmvghruceouhhnhhgrmhhmvghrsehfshhfvgdrohhrgh eqnecuggftrfgrthhtvghrnhepfeeigedvteeuhfdtveeftdetleehudehfffhjeetffet ueekudelleekhfekgfelnecuffhomhgrihhnpehgnhhurdhorhhgnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepuhhnhhgrmhhmvghrsehfshhf vgdrohhrgh X-ME-Proxy: From: Kevin Brubeck Unhammer References: Date: Mon, 22 Jun 2020 15:33:59 +0200 In-Reply-To: (Corwin Brust's message of "Wed, 18 Mar 2020 11:08:59 -0500") Message-ID: <874kr39qd4.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) I have bisected. The regression seems to have been introduced in commit cdefc045893a7fed57856ac385ab41c71f61c09f "Fix problem with erc buffer renames after reconnect" which was supposed to solve https://debbugs.gnu.org/cgi/bugreport.cgi?bug=30639 Reverting that commit fixes it for me. From unknown Mon Jun 23 18:33:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40121: 27.0.90; ERC incorrectly reuses single buffer for channels of same name on multiple networks Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Aug 2020 07:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40121 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Kevin Brubeck Unhammer Cc: 40121@debbugs.gnu.org, Corwin Brust Received: via spool by 40121-submit@debbugs.gnu.org id=B40121.159635426320176 (code B ref 40121); Sun, 02 Aug 2020 07:45:02 +0000 Received: (at 40121) by debbugs.gnu.org; 2 Aug 2020 07:44:23 +0000 Received: from localhost ([127.0.0.1]:41605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k28fO-0005FM-Jr for submit@debbugs.gnu.org; Sun, 02 Aug 2020 03:44:22 -0400 Received: from quimby.gnus.org ([95.216.78.240]:58800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k28fM-0005F5-Bg for 40121@debbugs.gnu.org; Sun, 02 Aug 2020 03:44:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=htarKveDVgGiCzuanzCqtq4HWwqHBpDceviwxEYjHtU=; b=Hk/lTgHUjfJ+zSPfO00Ov3mCvU XHtsRTwyfsjy+kLFUKTge5URS5Js8vL9OeLmoLWc+MPn1J6NqMHSGfjwiL42G+aFvpBgKj/CHSaqH rIixjmcU77TVh4Jv5S1kQqQJCkWJxl0MfJo32RmxPREixqnP43jbtIhisIHPS5ceTcrQ=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k28f5-0006d3-Ng; Sun, 02 Aug 2020 09:44:13 +0200 From: Lars Ingebrigtsen References: <874kr39qd4.fsf@fsfe.org> Date: Sun, 02 Aug 2020 09:44:02 +0200 In-Reply-To: <874kr39qd4.fsf@fsfe.org> (Kevin Brubeck Unhammer's message of "Mon, 22 Jun 2020 15:33:59 +0200") Message-ID: <87ft95mr0d.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Kevin Brubeck Unhammer writes: > I have bisected. The regression seems to have been introduced in commit > cdefc045893a7fed57856ac385ab41c71f61c09f > "Fix problem with erc buffer renames after reconnect" > which was supposed to sol [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Kevin Brubeck Unhammer writes: > I have bisected. The regression seems to have been introduced in commit > cdefc045893a7fed57856ac385ab41c71f61c09f > "Fix problem with erc buffer renames after reconnect" > which was supposed to solve > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=30639 This should now be fixed in Emacs 28.1. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 02 03:44:29 2020 Received: (at control) by debbugs.gnu.org; 2 Aug 2020 07:44:29 +0000 Received: from localhost ([127.0.0.1]:41608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k28fU-0005Fd-U7 for submit@debbugs.gnu.org; Sun, 02 Aug 2020 03:44:29 -0400 Received: from quimby.gnus.org ([95.216.78.240]:58816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k28fT-0005FK-Cy for control@debbugs.gnu.org; Sun, 02 Aug 2020 03:44:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YhQBQG+xRUfpSspO3DQaERcr+EQSqn1klfPVJqWXcJo=; b=dsl8tGA9Lb3Z/QJXmsXmXKVu2x KOGf8CkPXPCWrHnVU90GlV1q9Z8ftLdGIC9By2Rhi9GyMjMi5XVfYmvMJfW8/JiC7gM1wBRqcBe90 /T/axjI7iGFYgReP69zNwXfB/WaBCNbVHL+0LMdiuVZRMKbvNcD/qw5uXuNuFOFh4nu0=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k28fL-0006dD-MG for control@debbugs.gnu.org; Sun, 02 Aug 2020 09:44:21 +0200 Date: Sun, 02 Aug 2020 09:44:18 +0200 Message-Id: <87eeopmqzx.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #40121 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 40121 fixed close 40121 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 40121 fixed close 40121 28.1 quit From unknown Mon Jun 23 18:33:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40121: 27.0.90; ERC incorrectly reuses single buffer for channels of same name on multiple networks Resent-From: Kevin Brubeck Unhammer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Aug 2020 09:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40121 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Lars Ingebrigtsen Cc: 40121@debbugs.gnu.org, Corwin Brust Received: via spool by 40121-submit@debbugs.gnu.org id=B40121.159661803816661 (code B ref 40121); Wed, 05 Aug 2020 09:01:01 +0000 Received: (at 40121) by debbugs.gnu.org; 5 Aug 2020 09:00:38 +0000 Received: from localhost ([127.0.0.1]:49719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3FHq-0004Ke-5x for submit@debbugs.gnu.org; Wed, 05 Aug 2020 05:00:38 -0400 Received: from forward3-smtp.messagingengine.com ([66.111.4.237]:41739) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3FHo-0004KS-8B for 40121@debbugs.gnu.org; Wed, 05 Aug 2020 05:00:36 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailforward.nyi.internal (Postfix) with ESMTP id D5231194149B; Wed, 5 Aug 2020 05:00:30 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 05 Aug 2020 05:00:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=k61Reg Yfmehqo0lP5vtZ6w76QLyK2uBZEGGbTWs4Rhk=; b=FrZjNLw0hToqd0UXw/R7iH w4b8WlM9DSSK5dHYooBV4EYSLJflXvEl1XAsZYiwMqjLxD2D/Dy1uL/2peflcXF+ E9XOp85kB49GGqKWEOfIblZ9Ml/QM72023OSpDYIkewdQm0VAQCeG4RIgQPfX4hD KvY7wQ/BmM0++8/Kz4dPA7CkPuBxIRdqWegMrQxsWB/VlP+XahnzzxzMJY9XPfY/ r4cKe3TNp7IbKh+h0Gws6zA8CG5c0K5cIMAYl/LdkOZZuGv3cTf6TU8un9emRg40 Ulnu4f4NrwzYdIv2zLCE568VfGN2ybWxwbWFMjXjXeF1BVU/igSsDw9WCod6Nnng == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrjeekgdduvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufhffjgfkgggtsehgtderredttdejnecuhfhrohhmpefmvghvihhnuceu rhhusggvtghkucgfnhhhrghmmhgvrhcuoehunhhhrghmmhgvrhesfhhsfhgvrdhorhhgqe enucggtffrrghtthgvrhhnpefhfeekvefhgffgleevtdehgfefueehkedtteegteeileeg hfdttdethefhfeeigfenucffohhmrghinhepghhnuhdrohhrghenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehunhhhrghmmhgvrhesfhhsfhgv rdhorhhg X-ME-Proxy: From: Kevin Brubeck Unhammer References: <874kr39qd4.fsf@fsfe.org> <87ft95mr0d.fsf@gnus.org> Date: Wed, 05 Aug 2020 11:00:25 +0200 In-Reply-To: <87ft95mr0d.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 02 Aug 2020 09:44:02 +0200") Message-ID: <87ft91zcuu.fsf@mm.st> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Lars Ingebrigtsen =C4=8D=C3=A1lii: > Kevin Brubeck Unhammer writes: > >> I have bisected. The regression seems to have been introduced in commit >> cdefc045893a7fed57856ac385ab41c71f61c09f >> "Fix problem with erc buffer renames after reconnect" >> which was supposed to solve >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D30639 > > This should now be fixed in Emacs 28.1. There's still a bug when there's two networks on the same server:port. But the fix is simple, just an `(and target =E2=80=A6)` around the "Channel buffer" case, like ;; Channel buffer; check that it's from the right server. (and target (with-current-buffer (get-buffer candidate) (and (string=3D erc-session-server server) (erc-port-equal erc-session-port port)))) I connect to several networks on the same server:port (my weechat instance). Without the `and target` check it'll reuse the server buffer from network1 when connecting to network2. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEq9A0PxCu5rIo7lbX/DwefQCTFmcFAl8qdSoACgkQ/DwefQCT FmfH+w//RspeDTx53q65c4RZs9Yz/OOHw6+y2NjxZmPuHWmLdFkKMooa5RsQNY9K PUtwOKW8t+La4qS74y+0lFJqQV5H4MUGkDiOu/YP0dxpaI/b+4WqJUG+II4R2Gkw JABAqLor3mtrE+cax++3frcabCfbs9pzN/uArMTyqFFtFd9wB0Bevj7bM61Nd5ul MNUsCNjGDZXkXh5U1W09rOw6rETzDA4pcjirSTWCl0xEC/y+ysPwZxlUPc0rjwYb B3xADOQEG+5bRkW8L5MTaKAPEsZv7czvDDamLKpcEgt1zg1EUnDkeMsjfSLz0gUB pHPwUJLPNvnIPmyLCGCkganGQgiKjRmQYWSHzgjSR7m4HOXLTYlS5itOkxXxhm6c onNFCPOHfnsZhNRNki6UvlPFEcivNoXPLJ7YTFH8e8Ej0o/5MzqpSgEQe3cLtEBb b0OJD7IOaPHHFuz96ofHfGNu0j3Gr3poTPhAlWxyZg62itjfWzpiU1i7eDLJsLu2 pK7ekmdAH71bE6HA8MQAAS1PQ58GUWPFgnnvknrHAtPCmNd2dBU8bBfOXK8rzb7W LKn30uJ9GPpn8h9RKeWohKWaoBlRmjRuY0fzyRf+xa5GyNWlW/V1wOO2dFqt7E41 zRQP8q+ARBbo6yqX3+tD/q14YDKXtep0miP1qd3/QXOpNlvE8B4= =44W3 -----END PGP SIGNATURE----- --=-=-=-- From unknown Mon Jun 23 18:33:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40121: 27.0.90; ERC incorrectly reuses single buffer for channels of same name on multiple networks Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Aug 2020 09:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40121 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Kevin Brubeck Unhammer Cc: 40121@debbugs.gnu.org, Corwin Brust Received: via spool by 40121-submit@debbugs.gnu.org id=B40121.159661887117955 (code B ref 40121); Wed, 05 Aug 2020 09:15:02 +0000 Received: (at 40121) by debbugs.gnu.org; 5 Aug 2020 09:14:31 +0000 Received: from localhost ([127.0.0.1]:49772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3FVH-0004fX-GH for submit@debbugs.gnu.org; Wed, 05 Aug 2020 05:14:31 -0400 Received: from quimby.gnus.org ([95.216.78.240]:38020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3FVF-0004fF-E4 for 40121@debbugs.gnu.org; Wed, 05 Aug 2020 05:14:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=+qAO5eXcmDvCjYj5OHplGVGVX6HZR3znuvE6nxrpl1s=; b=bxOlD6AatbXZYI5xjuU3YzCn4S DDjHvnEFPyOqtblYXE/DLrMsuHfQRc5ANFFByo8HKoOfzCRy3mZoh8VDd+o2ggHPWD2H1dMvHPoy5 hdaXjJwCn8cfP0te5VNc8pbxZLYibs2nGZekQVVg9QaA9PaG/HzU86p2q/NyPUrmasHo=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k3FV6-0002u4-4L; Wed, 05 Aug 2020 11:14:22 +0200 From: Lars Ingebrigtsen References: <874kr39qd4.fsf@fsfe.org> <87ft95mr0d.fsf@gnus.org> <87ft91zcuu.fsf@mm.st> Date: Wed, 05 Aug 2020 11:14:18 +0200 In-Reply-To: <87ft91zcuu.fsf@mm.st> (Kevin Brubeck Unhammer's message of "Wed, 05 Aug 2020 11:00:25 +0200") Message-ID: <87r1sle9p1.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Kevin Brubeck Unhammer writes: > There's still a bug when there's two networks on the same server:port. > > But the fix is simple, just an `(and target =?UTF-8?Q?=E2=80=A6?=)` around the "Channel > buffer" case, like > > ;; Channel buffer; check tha [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Kevin Brubeck Unhammer writes: > There's still a bug when there's two networks on the same server:port. > > But the fix is simple, just an `(and target =E2=80=A6)` around the "Chann= el > buffer" case, like > > ;; Channel buffer; check that it's from the right serv= er. > (and target > (with-current-buffer (get-buffer candidate) > (and (string=3D erc-session-server server) > (erc-port-equal erc-session-port port)))) > > I connect to several networks on the same server:port (my weechat > instance). Without the `and target` check it'll reuse the server buffer > from network1 when connecting to network2. Ah, I see. I didn't even know that was possible. :-) I've now applied your fix to Emacs 28. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Mon Jun 23 18:33:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40121: 27.0.90; ERC incorrectly reuses single buffer for channels of same name on multiple networks Resent-From: Kevin Brubeck Unhammer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Aug 2020 10:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40121 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Lars Ingebrigtsen Cc: 40121@debbugs.gnu.org Received: via spool by 40121-submit@debbugs.gnu.org id=B40121.159662384510818 (code B ref 40121); Wed, 05 Aug 2020 10:38:02 +0000 Received: (at 40121) by debbugs.gnu.org; 5 Aug 2020 10:37:25 +0000 Received: from localhost ([127.0.0.1]:49953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3GnV-0002oQ-Iy for submit@debbugs.gnu.org; Wed, 05 Aug 2020 06:37:25 -0400 Received: from forward3-smtp.messagingengine.com ([66.111.4.237]:50159) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3GnT-0002oB-44 for 40121@debbugs.gnu.org; Wed, 05 Aug 2020 06:37:24 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailforward.nyi.internal (Postfix) with ESMTP id EE7FF1941255; Wed, 5 Aug 2020 06:37:16 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 05 Aug 2020 06:37:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=109Ahc j7Xu/qOUR41qj8dACRmS8okXQ4ww36Ug34DQo=; b=ZtJxkssg7UfsJfknX47NZa Fn14C9emLl2RIB5jWPL5N1OIyNaVcjotNg5Awgs3NHtWiT7eb+S9dPxNcqs02Lfm 8kPUg5eFBf+3hIHmccEjtCyT5/hI8p/1iOrtspKXJZ5iY6mYlUv++3goXDsChcYl +0dsfyX7/LePX2TKjpj2OesyCKEhtqeuMY4HV+5juxq3gly6xxq67RGuYI30fVEC NCl40JyTZV8v2czMKbP2SWUPwTnMsdsIPR5qbBcuo/7ADBqlnE/02vkNzfJhdID7 W+0RfZJNF+wfMWKhz1wQ5o/d0UxYQJdafbtgCzplTUSnypAVYRzLH4QQLknt8sWA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrjeekgdefvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufhffjgfkgggtsehgtderredttdejnecuhfhrohhmpefmvghvihhnuceu rhhusggvtghkucgfnhhhrghmmhgvrhcuoehunhhhrghmmhgvrhesfhhsfhgvrdhorhhgqe enucggtffrrghtthgvrhhnpeekvefhkeejtedvkedtgeefleekffevudevveegteeffedt teeuhedvieeffeevvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehunhhhrghmmhgvrhesfhhsfhgvrdhorhhg X-ME-Proxy: From: Kevin Brubeck Unhammer References: <874kr39qd4.fsf@fsfe.org> <87ft95mr0d.fsf@gnus.org> <87ft91zcuu.fsf@mm.st> <87r1sle9p1.fsf@gnus.org> Date: Wed, 05 Aug 2020 12:37:12 +0200 In-Reply-To: <87r1sle9p1.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 05 Aug 2020 11:14:18 +0200") Message-ID: <87bljpz8dj.fsf@mm.st> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Lars Ingebrigtsen =C4=8D=C3=A1lii: > Kevin Brubeck Unhammer writes: > >> There's still a bug when there's two networks on the same server:port. >> >> But the fix is simple, just an `(and target =E2=80=A6)` around the "Chan= nel >> buffer" case, like >> >> ;; Channel buffer; check that it's from the right ser= ver. >> (and target >> (with-current-buffer (get-buffer candidate) >> (and (string=3D erc-session-server server) >> (erc-port-equal erc-session-port port)))) >> >> I connect to several networks on the same server:port (my weechat >> instance). Without the `and target` check it'll reuse the server buffer >> from network1 when connecting to network2. > > Ah, I see. I didn't even know that was possible. :-) > > I've now applied your fix to Emacs 28. Thanks! :) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEq9A0PxCu5rIo7lbX/DwefQCTFmcFAl8qi9gACgkQ/DwefQCT FmdqYQ//YHn3ewLiQzKwXLvAz0vmgz+5m6YafY6/UqqLSG8sDQt0KesE7Ovt5WCg 8zuCNGhwmDiWInjsxx36KAxjE6GrTL5BMf2wbbEjFWmFQjhUGJP8c3VQux2D+4c4 hyAMTYrggdOSGi2o/2eYdj49WjSDcy/HYVHS8NP49IKeCABU4GggOo0CTWJHmmyy ioAeTG1MDzvfNCEOkp9+Mu5g3xOp6mOTz8qAEnwdd7ixkgBfbucsng1FuiFikHtv LDO88hsg/Nf9yf/aP0YcFp5NmUa/HQVibxP3spV1JbvtHSCoGHMzHRWWGp6u600h HEgq4/PDYo9YlVlygei2wkxA9uhzhIQOtYZMT0yXomyxs9KZyETGaTdvnyGzNvEo H4JshlUPV9w8drR9jO6AE0wISpfD8BwPXkmYgTUQ9fvo17AoKj39jbP/sUe7GHZO hg5jkYrsaV2PE7Tq7MpFPPA1IXPPg9L4iwvJ4ZJUeBelTIIZ3S8Iuh06VyRwRP1n n8xErLo60JP/tPFwFylXFR+bG4t2MZf91leVCAEsHZ6SCXuYt5UG7kD5OaPs8vWL fF3qoUaVgccms3OlyTlLNmtrlDaPA36wgomrYzBH35ldM1aRiWQPGtHNdZzxUKoY PtLW3W4tSTaV8xGDiWRxqdQJIdU7tsJZZJPq/fj+bvHtWTqHXrs= =io3M -----END PGP SIGNATURE----- --=-=-=-- From unknown Mon Jun 23 18:33:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40121: 27.0.90; ERC incorrectly reuses single buffer for channels of same name on multiple networks References: In-Reply-To: Resent-From: "Mingde (Matthew) Zeng" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Aug 2020 12:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40121 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: 40121@debbugs.gnu.org Received: via spool by 40121-submit@debbugs.gnu.org id=B40121.15966318859715 (code B ref 40121); Wed, 05 Aug 2020 12:52:02 +0000 Received: (at 40121) by debbugs.gnu.org; 5 Aug 2020 12:51:25 +0000 Received: from localhost ([127.0.0.1]:50342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3ItA-0002Wa-3a for submit@debbugs.gnu.org; Wed, 05 Aug 2020 08:51:25 -0400 Received: from mail-qt1-f181.google.com ([209.85.160.181]:36604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k39GF-0007cN-R0 for 40121@debbugs.gnu.org; Tue, 04 Aug 2020 22:34:36 -0400 Received: by mail-qt1-f181.google.com with SMTP id t23so29504724qto.3 for <40121@debbugs.gnu.org>; Tue, 04 Aug 2020 19:34:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version; bh=sk+4QFiXA4UPOkOyHvnxqROWiNW/Ipj+x8SLidfVQY4=; b=lv+eLsBxhsodg6993chzOXxOyneUOMvkpQGOzLnrnJuS8j3AR6qbQ7QnTaY7ETkNoV idCmMfoA0Ya5ZTp3XIZBu6TZuEO2MIf/JIFLFLbNf+hehgX4d6UvHdjdjmFTll8ceGUe H62goz8h6boJzCJDM9qj5VxwdOcPy/covssKCVz91906r9t4GzmSYeNuZChmq4JxBMhX nJQzS2aBxdA5M/8SJdrWDyguEkjGxzdBf5bMeIM9qeceqL53c3MvFSQYlvCCx009zc/f TIiTGS24iLSG/Cz+sqR9zCd8sU6a6UCUjP6jD5vdXx9VjQy1tvFSBx5SiaPU6WZUxoC+ hYbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=sk+4QFiXA4UPOkOyHvnxqROWiNW/Ipj+x8SLidfVQY4=; b=VGtzklOK1Lpt8ongJ+3sopRLgrztc0RsUxrBLxOwWsQm1FwmbjS22lu6ZpcOYePu+i s0bUCofFUEU7ynC54e79/y3NXMXWYp/1l7moq50wYfvp6IgNUHOqjbdpxFaotwdd7zVd 4XL2KIiIOkcIG3DH5c1KmzTPIeEU9pTksBlow5/2taO9vlywLl6lI8F3/CPz+ok+oCmc HZ7FidZnPicd6xmaQOnUDBTOYMm+jziJmIGS7soIabL8K2OwublTkH7ApNO6/QmdokqY g2Ga5aYVMAr/98LWQj3yinLZNefgrzpd6CVnQcElBdPlCc92fqYMb43pselCjKDKhkUq h3WQ== X-Gm-Message-State: AOAM532g+wv3Wabb/gd8nUpYQ1Gy0hKyrSSd5C64o8On0rZEkQqKMfNo 6SVrlAaaJ9M99qDG3NyFK4el8z0+fEM= X-Google-Smtp-Source: ABdhPJz07TeowDoZAo9HiLI0+hmUlw639q+Dlc7aZdkwhFlsTma0lddUCoayysubE7oEqHaMHWlkBQ== X-Received: by 2002:aed:3023:: with SMTP id 32mr1127596qte.37.1596594869888; Tue, 04 Aug 2020 19:34:29 -0700 (PDT) Received: from mt-manjaro (216-58-109-18.cpe.distributel.net. [216.58.109.18]) by smtp.gmail.com with ESMTPSA id m30sm877903qtm.46.2020.08.04.19.34.27 for <40121@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2020 19:34:29 -0700 (PDT) User-agent: mu4e 1.4.12; emacs 27.0.91 From: "Mingde (Matthew) Zeng" Date: Tue, 04 Aug 2020 22:34:24 -0400 Message-ID: <87imdxes7j.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Mailman-Approved-At: Wed, 05 Aug 2020 08:51:23 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I submitted a patch that should fix this problem completely. -- Mingde (Matthew) Zeng From unknown Mon Jun 23 18:33:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40121: 27.0.90; ERC incorrectly reuses single buffer for channels of same name on multiple networks Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Aug 2020 12:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40121 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: "Mingde (Matthew) Zeng" Cc: 40121@debbugs.gnu.org Received: via spool by 40121-submit@debbugs.gnu.org id=B40121.15966320059983 (code B ref 40121); Wed, 05 Aug 2020 12:54:01 +0000 Received: (at 40121) by debbugs.gnu.org; 5 Aug 2020 12:53:25 +0000 Received: from localhost ([127.0.0.1]:50360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3Iv6-0002ax-Nz for submit@debbugs.gnu.org; Wed, 05 Aug 2020 08:53:24 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3Iv5-0002ai-1R for 40121@debbugs.gnu.org; Wed, 05 Aug 2020 08:53:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vWkivt9TFLlz+TktowT2yg4LeO8ZdIkTG1Juwf/bTFE=; b=Lf+KGrdcFXL485dW1xUsIlQMZA 1Gp4uP0vpbieI3PCaDlycp5ZAQzhkU4YNnSd9i5AB+IyKM80/N5qgckGvnBjYNnEWxp7OegX6Av1T Kv85y+Mck1CDYlTeUc93A7Qk7QssdrPVvHfSwLH5jmO2HHFIdbFX2nDHFS77eWaHDvFU=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k3Iuw-0004n3-H4; Wed, 05 Aug 2020 14:53:17 +0200 From: Lars Ingebrigtsen References: <87imdxes7j.fsf@gmail.com> Date: Wed, 05 Aug 2020 14:53:13 +0200 In-Reply-To: <87imdxes7j.fsf@gmail.com> (Mingde Zeng's message of "Tue, 04 Aug 2020 22:34:24 -0400") Message-ID: <87v9hx6ypy.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: "Mingde (Matthew) Zeng" writes: > I submitted a patch that should fix this problem completely. Did you send it to 40121@debbugs.gnu.org? It's nice to have the patches in the bug tracker. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Mingde (Matthew) Zeng" writes: > I submitted a patch that should fix this problem completely. Did you send it to 40121@debbugs.gnu.org? It's nice to have the patches in the bug tracker. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Mon Jun 23 18:33:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40121: 27.0.90; ERC incorrectly reuses single buffer for channels of same name on multiple networks Resent-From: Corwin Brust Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Aug 2020 13:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40121 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Lars Ingebrigtsen Cc: "Mingde \(Matthew\) Zeng" , 40121@debbugs.gnu.org Received: via spool by 40121-submit@debbugs.gnu.org id=B40121.159663296319860 (code B ref 40121); Wed, 05 Aug 2020 13:10:01 +0000 Received: (at 40121) by debbugs.gnu.org; 5 Aug 2020 13:09:23 +0000 Received: from localhost ([127.0.0.1]:50375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3JAZ-0005AG-Dk for submit@debbugs.gnu.org; Wed, 05 Aug 2020 09:09:23 -0400 Received: from mail-qk1-f181.google.com ([209.85.222.181]:39338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3JAX-0005A3-Uv for 40121@debbugs.gnu.org; Wed, 05 Aug 2020 09:09:22 -0400 Received: by mail-qk1-f181.google.com with SMTP id l6so41524023qkc.6 for <40121@debbugs.gnu.org>; Wed, 05 Aug 2020 06:09:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3iGEzNQEl8tfQi0w06m1MmF9ae/owUvCu85hx/VyCe8=; b=QKKzqIYk+blWJhFQreEU+jWYGSOeRtVXfiKuPbKXVJDMptCYy8bhvG/8nMDGI6LiuC CeFjrR3S5AeiAbyc9kyTR2yzwEAqc5Ki78rhkylnfzzZ8aDlVLYv5MT00NgBQPWn179s Ibbpsi5sRJvDdm6ycKI+v3hrBC0b9JMJlMw7yOwaIV1xUlCdu7TI0Ix5kkZBp9zSy9JE BFXbvD/0XFOGcuMMWEzs5JO6NqJx3dwOcj9/j2dPkvbzW/hhlwd7icFFqykpcEVGfC+O eTnXLhIkibmlJMW6ebAzqIYgOJf42O7U90ArffzwxOeVh1YPtmbXs0AG53rfODQ8x94k QC/w== X-Gm-Message-State: AOAM533n8CfLb0uQ8pFDWKRiGs7dCuoGPnSyxQJTy5meSjsP0ynwTSV9 bN7MleQtT0QQrQKIdQ+Ah37P3rHgDlPYoI/qzS8= X-Google-Smtp-Source: ABdhPJz8AOBUkW9PxZ/HAQ9XcUaBeB2A3aZ8anD6nmpwp/wmHJ1UQDo4Ri0g2kymfVmIgDnAbzYQQkYUqEhP5vLsDP4= X-Received: by 2002:a37:a454:: with SMTP id n81mr3277627qke.11.1596632955802; Wed, 05 Aug 2020 06:09:15 -0700 (PDT) MIME-Version: 1.0 References: <87imdxes7j.fsf@gmail.com> <87v9hx6ypy.fsf@gnus.org> In-Reply-To: <87v9hx6ypy.fsf@gnus.org> From: Corwin Brust Date: Wed, 5 Aug 2020 08:09:03 -0500 Message-ID: Content-Type: multipart/alternative; boundary="0000000000002b812f05ac2114ff" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000002b812f05ac2114ff Content-Type: text/plain; charset="UTF-8" Hi! On Wed, Aug 5, 2020, 7:54 AM Lars Ingebrigtsen wrote: > "Mingde (Matthew) Zeng" writes: > > > I submitted a patch that should fix this problem completely. > > Did you send it to 40121@debbugs.gnu.org? It's nice to have the patches > in the bug tracker. > I really appreciate everyone's work on this; I will look and help confirm next week when I am home from vacation. > --0000000000002b812f05ac2114ff Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi!

On Wed, Aug 5, 2020, 7:54 AM Lars Ingebrigtsen <= larsi@gnus.org> wrote:
"Mingde (Matthew) Zeng" <matth= ewzmd@gmail.com> writes:

> I submitted a patch that should fix this problem completely.

Did you send it to 40121@debbugs.gnu.org?=C2=A0 It's nice to hav= e the patches
in the bug tracker.

I really appreciate everyone's work on this; I will = look and help confirm next week when I am home from vacation.
--0000000000002b812f05ac2114ff-- From unknown Mon Jun 23 18:33:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40121: 27.0.90; ERC incorrectly reuses single buffer for channels of same name on multiple networks Resent-From: Amin Bandali Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Aug 2020 13:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40121 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Lars Ingebrigtsen Cc: "Mingde \(Matthew\) Zeng" , 40121@debbugs.gnu.org Received: via spool by 40121-submit@debbugs.gnu.org id=B40121.159663321920222 (code B ref 40121); Wed, 05 Aug 2020 13:14:01 +0000 Received: (at 40121) by debbugs.gnu.org; 5 Aug 2020 13:13:39 +0000 Received: from localhost ([127.0.0.1]:50380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3JEg-0005G6-UU for submit@debbugs.gnu.org; Wed, 05 Aug 2020 09:13:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3JEe-0005Fs-86 for 40121@debbugs.gnu.org; Wed, 05 Aug 2020 09:13:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56579) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k3JEY-0000u0-UQ; Wed, 05 Aug 2020 09:13:30 -0400 Received: from [2607:fea8:3fdf:f688::2] (port=56814 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k3JEY-0002W7-5Y; Wed, 05 Aug 2020 09:13:30 -0400 From: Amin Bandali References: <87imdxes7j.fsf@gmail.com> <87v9hx6ypy.fsf@gnus.org> Date: Wed, 05 Aug 2020 09:13:28 -0400 In-Reply-To: <87v9hx6ypy.fsf@gnus.org> Message-ID: <87a6z99qx3.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Lars Ingebrigtsen writes: > "Mingde (Matthew) Zeng" writes: > >> I submitted a patch that should fix this problem completely. > > Did you send it to 40121@debbugs.gnu.org? It's nice to have the patches > in the bug tracker. He'd sent it to emacs-devel, after some bit of feedback me and others had given him about his previous patches, also on emacs-devel. https://lists.gnu.org/archive/html/emacs-devel/2020-08/msg00084.html I'll let the two of you coordinate with each other since you are both working on the same issue. For future cases, let us try to keep an eye both on the tracker and on the emacs-devel list before sending a patch or pushing a change, to help make sure we don't do duplicate work or make simultaneous conflicting changes where one contributor tries to chase a moving target. :-) Thanks. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJEBAEBCAAuFiEEObM8jZRIDS3cwqSYi0Sgzce5VvIFAl8qsHgQHGJhbmRhbGlA Z251Lm9yZwAKCRCLRKDNx7lW8m+gD/0aRoFgJoOi5eENB66OV9Quy+juX1UYzucC IUMgnd+nBLhNIRuVpqrsBZkCHQiii3S2S6N7AECLJr9+w1UlpJWayVoMCWOPQZoM wvbbr+dT4YBQwOGvgsd4fWmyeed0g56xPxUE7gyhsVtDgDjMtA/MFRMrbd/KidOX YCPgoA5dw9Qhj4CyIo99EAhY4ydsGO8mXeSvvkBEzmQwjFsIsIuSqAVIZ9+mB+98 4HSRy/Z8LMjMSOOhjQLg/q5krhlHANcFQYuC/NP5X0ZKm9j6HhYgSmAhflPCTZBg L5dyuPOM7/dpol/mb2qhmJuyMFxiJC2aZfMwtcCKF3zvqSbGsvL/9dm6KVA0d5se uFNhT4/RWnzktG518bTsp8i6zYc+zBNy9LaHlr/y5B+XA+4IcjtVDD8szuWovmWR oEdowGYPLOA265LH4XTrr0d7betiLL/QYbsyKI91r7ul5hXeOOLR8Thu0MPjzcJu PIWIL0TtIY5yAB6m3NzLb05Ex9xojVw8WuCULq3AHNvmGFh3CZJ0m/5p07VC5fYB YKIPOONl9uSVITqAqb3Y/trtWVKBXlFn4jubjca32Ya/7mK7veqRi8PiVrJjykmU pDqvu/QC9HPwMEk9IXDoWuxLy471RUAyvAjOsmERw5Adx+/JzNo+M9NkI6FieIA/ 7z2mes+8UA== =SNLQ -----END PGP SIGNATURE----- --=-=-=-- From unknown Mon Jun 23 18:33:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40121: 27.0.90; ERC incorrectly reuses single buffer for channels of same name on multiple networks Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Aug 2020 13:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40121 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Amin Bandali Cc: "Mingde \(Matthew\) Zeng" , 40121@debbugs.gnu.org Received: via spool by 40121-submit@debbugs.gnu.org id=B40121.159663402121397 (code B ref 40121); Wed, 05 Aug 2020 13:27:02 +0000 Received: (at 40121) by debbugs.gnu.org; 5 Aug 2020 13:27:01 +0000 Received: from localhost ([127.0.0.1]:50384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3JRd-0005Z3-6O for submit@debbugs.gnu.org; Wed, 05 Aug 2020 09:27:01 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3JRa-0005Yn-Q3 for 40121@debbugs.gnu.org; Wed, 05 Aug 2020 09:27:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=12U8pzpH19YwG/1x58l3EBiVZbkxHa5ScdxVpA1Uit8=; b=L3g9EsBAJqPbZk8YCKW2lhsP3V XffC1mt2edq9KjWrIlDm2YmtBsIz4MVUbp4Vc7qdYlt1+rHWvOFWU/WnxkO3H5afP4hF8DCoaOO/s HzOZv4JeUt+R9AeCd1xeWlFhVCO3ZOjqlFqEKaWeWYKFWM62gyCptkd3WI3OL1gU6Wgo=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k3JRL-00055t-A5; Wed, 05 Aug 2020 15:26:52 +0200 From: Lars Ingebrigtsen References: <87imdxes7j.fsf@gmail.com> <87v9hx6ypy.fsf@gnus.org> <87a6z99qx3.fsf@gnu.org> Date: Wed, 05 Aug 2020 15:26:41 +0200 In-Reply-To: <87a6z99qx3.fsf@gnu.org> (Amin Bandali's message of "Wed, 05 Aug 2020 09:13:28 -0400") Message-ID: <87h7th6x66.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Amin Bandali writes: > I'll let the two of you coordinate with each other since you are both > working on the same issue. For future cases, let us try to keep an eye > both on the tracker and on the emacs-devel list befor [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Amin Bandali writes: > I'll let the two of you coordinate with each other since you are both > working on the same issue. For future cases, let us try to keep an eye > both on the tracker and on the emacs-devel list before sending a patch > or pushing a change, to help make sure we don't do duplicate work or > make simultaneous conflicting changes where one contributor tries to > chase a moving target. :-) Yeah, sorry about that. And there was another patch applied to the function earlier today. :-/ -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Mon Jun 23 18:33:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40121: [PATCHv2] erc: fix erc-reuse-buffers behavior References: In-Reply-To: Resent-From: "Mingde (Matthew) Zeng" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Aug 2020 18:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40121 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: 40121@debbugs.gnu.org, emacs-devel@gnu.org Cc: larsi@gnus.org Received: via spool by 40121-submit@debbugs.gnu.org id=B40121.159717203917264 (code B ref 40121); Tue, 11 Aug 2020 18:54:01 +0000 Received: (at 40121) by debbugs.gnu.org; 11 Aug 2020 18:53:59 +0000 Received: from localhost ([127.0.0.1]:41688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5ZPL-0004UO-02 for submit@debbugs.gnu.org; Tue, 11 Aug 2020 14:53:59 -0400 Received: from mail-qt1-f179.google.com ([209.85.160.179]:35966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5ZPH-0004U9-Ku for 40121@debbugs.gnu.org; Tue, 11 Aug 2020 14:53:57 -0400 Received: by mail-qt1-f179.google.com with SMTP id t23so10244748qto.3 for <40121@debbugs.gnu.org>; Tue, 11 Aug 2020 11:53:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:cc:subject:date:message-id:mime-version; bh=/ly3QfAE+0qIbTJtGFSyLj+uQ35wufQG1Qi3LfrDbus=; b=eCBzjVPcSjQAHLPyp5obF/SSzkhQW1xpSkSHDVfnu68gpXMuqd9+OA28CO3GvtvKn2 YajoT06Espn2oF1PIKN2zLOqotgzPUj73+tyGqND0Fbsz9nR6EDDH7YgKUxgPBtE8GT7 /cDMbPvS49cNf5UO3kAuaO22A07srhw2U4Xd2E7dkTSqjDVc4iudsqNzAuH+wYrNAv1L u7BRKkQN/fxBhOO5mQcViJIsvd1wBvmNMmO8RSSVo09vhZi+ms4zXQfSKhadKh+AzJg1 4pI9seicn5GHmHi3lJugDbu0TmauHaI4LWwe61NUiLYPSNFcWA6crjUOAF9chlxBP+SN Kv7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:cc:subject:date:message-id :mime-version; bh=/ly3QfAE+0qIbTJtGFSyLj+uQ35wufQG1Qi3LfrDbus=; b=ZcVsWzkNCieKECMEcFVmDDMDk17+XOtWWOp6aKYCGFryKzZSrZVC6uepU9JFZfpIhq 0jlDf9DcpuSknplW1sKG+GRQ6tBkfOud863ZromtYNZsSDqlsSi4I5TlzgroEq0Gyw0J aUij2Q8HCJ15rmru8t9z2DcNHvHPA5ryrb3ynEfemTNgbmZgVbXtJaUzF0rL6Pxd6vRm nWyhS1kLj7fSWREMjaGYXgb27lN4B387wmov0U/au75Rxf1sNLR/l6f4gbxYvPhM6Y8d zgKSwfh/k2n23nQisl+ID6S7PeAb3qbve7G0772U0GFgDl38cJtOaoxPXoDpSOCUAryY ME3A== X-Gm-Message-State: AOAM533mez8W5fPspoaVI0qJ77/yGsneJk8f0ge10tuiVIwYu+IzWZmS yTonYlAcDLSFt4g31RtWg9o= X-Google-Smtp-Source: ABdhPJyk7heNm0lI8RtW8dacnshnyhhmjQ0egKT2Q9RJggwxs7uZQVft3+VFUbbNnjjH0SBCPQVx+w== X-Received: by 2002:aed:3387:: with SMTP id v7mr2526045qtd.318.1597172029753; Tue, 11 Aug 2020 11:53:49 -0700 (PDT) Received: from mt-manjaro (216-58-109-18.cpe.distributel.net. [216.58.109.18]) by smtp.gmail.com with ESMTPSA id q126sm17660656qkb.75.2020.08.11.11.53.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2020 11:53:49 -0700 (PDT) User-agent: mu4e 1.4.13; emacs 27.0.91 From: "Mingde (Matthew) Zeng" Date: Tue, 11 Aug 2020 14:53:48 -0400 Message-ID: <87h7t9ovyb.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) By the definition of erc-reuse-buffers, if non-nil it should create a new buffer when joining channels with same names on different servers. The current behavior of erc-reuse-buffers is: 1. when non-nil, it will always reuse the same channel buffer, resulting in server A's channel gets reconnected to the channel with the same name of server B. 2. when nil, the buffer-name of the joined channel is '#channel/server'. However if one tries to '/join #channel' from the server buffer, it creates a new empty buffer with buffer-name '#channel', instead of opening the already-joined channel buffer. This bug is partly documented in bug#40121. * lisp/erc/erc.el (erc-generate-new-buffer-name): fixes behavior 1, also determines if the '#channel/server' buffer already exists and will reuse that buffer when joining on the same server. Additionally when creating a new buffer with '#channel/serverB', the existing buffer '#channel' on 'severA' will be renamed to '#channel/serverA' for the sake of consistency. (erc-cmd-JOIN): with some refactoring, it ensures the joined channel buffer is selected and thereby fixes the second behavior. * lisp/erc/erc-join.el (erc-autojoin-channels): the logic is simplified ensuring that when autojoining channels specified in erc-autojoin-channels-alist, if there exists an erc buffer with the same channel name but a different server, it will create a new buffer to join the channel. The current logic is very weak that will skip joining same channel on different servers altogether. --- lisp/erc/erc-join.el | 22 ++++++------ lisp/erc/erc.el | 85 +++++++++++++++++++++++++------------------- 2 files changed, 61 insertions(+), 46 deletions(-) diff --git a/lisp/erc/erc-join.el b/lisp/erc/erc-join.el index e4faf6bd79..79c111082f 100644 --- a/lisp/erc/erc-join.el +++ b/lisp/erc/erc-join.el @@ -153,18 +153,20 @@ This function is run from `erc-nickserv-identified-hook'." 'erc-autojoin-channels-delayed server nick (current-buffer)))) ;; `erc-autojoin-timing' is `connect': - (dolist (l erc-autojoin-channels-alist) - (when (string-match (car l) server) - (let ((server (or erc-session-server erc-server-announced-name))) + (let ((server (or erc-session-server erc-server-announced-name))) + (dolist (l erc-autojoin-channels-alist) + (when (string-match-p (car l) server) (dolist (chan (cdr l)) - (let ((buffer (erc-get-buffer chan))) - ;; Only auto-join the channels that we aren't already in - ;; using a different nick. + (let ((buffer + (car (erc-buffer-filter + (lambda () + (let ((current (erc-default-target))) + (and (stringp current) + (string-match-p (car l) + (or erc-session-server erc-server-announced-name)) + (string-equal (erc-downcase chan) + (erc-downcase current))))))))) (when (or (not buffer) - ;; If the same channel is joined on another - ;; server the best-effort is to just join - (not (string-match (car l) - (process-name erc-server-process))) (not (with-current-buffer buffer (erc-server-process-alive)))) (erc-server-join-channel server chan)))))))) diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el index 404a4c0997..41d7516fbb 100644 --- a/lisp/erc/erc.el +++ b/lisp/erc/erc.el @@ -1608,36 +1608,47 @@ symbol, it may have these values: (defun erc-generate-new-buffer-name (server port target) "Create a new buffer name based on the arguments." (when (numberp port) (setq port (number-to-string port))) - (let ((buf-name (or target - (or (let ((name (concat server ":" port))) - (when (> (length name) 1) - name)) - ;; This fallback should in fact never happen - "*erc-server-buffer*"))) - buffer-name) + (let* ((buf-name (or target + (let ((name (concat server ":" port))) + (when (> (length name) 1) + name)) + ;; This fallback should in fact never happen. + "*erc-server-buffer*")) + (full-buf-name (concat buf-name "/" server)) + (dup-buf-name (buffer-name (car (erc-channel-list nil)))) + buffer-name) ;; Reuse existing buffers, but not if the buffer is a connected server ;; buffer and not if its associated with a different server than the ;; current ERC buffer. - ;; if buf-name is taken by a different connection (or by something !erc) - ;; then see if "buf-name/server" meets the same criteria - (dolist (candidate (list buf-name (concat buf-name "/" server))) - (if (and (not buffer-name) - erc-reuse-buffers - (or (not (get-buffer candidate)) - ;; Looking for a server buffer, so there's no target. - (and (not target) - (with-current-buffer (get-buffer candidate) - (and (erc-server-buffer-p) - (not (erc-server-process-alive))))) - ;; Channel buffer; check that it's from the right server. - (and target - (with-current-buffer (get-buffer candidate) - (and (string= erc-session-server server) - (erc-port-equal erc-session-port port)))))) - (setq buffer-name candidate))) - ;; if buffer-name is unset, neither candidate worked out for us, + ;; If buf-name is taken by a different connection (or by something !erc) + ;; then see if "buf-name/server" meets the same criteria. + (if (and dup-buf-name (string-match-p (concat buf-name "/") dup-buf-name)) + (setq buffer-name full-buf-name) ; ERC buffer with full name already exists. + (dolist (candidate (list buf-name full-buf-name)) + (if (and (not buffer-name) + erc-reuse-buffers + (or (not (get-buffer candidate)) + ;; Looking for a server buffer, so there's no target. + (and (not target) + (with-current-buffer (get-buffer candidate) + (and (erc-server-buffer-p) + (not (erc-server-process-alive))))) + ;; Channel buffer; check that it's from the right server. + (and target + (with-current-buffer (get-buffer candidate) + (and (string= erc-session-server server) + (erc-port-equal erc-session-port port)))))) + (setq buffer-name candidate) + (when (and (not buffer-name) (get-buffer buf-name) erc-reuse-buffers) + ;; A new buffer will be created with the name buf-name/server, rename + ;; the existing name-duplicated buffer with the same format as well. + (with-current-buffer (get-buffer buf-name) + (when (derived-mode-p 'erc-mode) ; ensure it's an erc buffer + (rename-buffer + (concat buf-name "/" (or erc-session-server erc-server-announced-name))))))))) + ;; If buffer-name is unset, neither candidate worked out for us, ;; fallback to the old uniquification method: - (or buffer-name (generate-new-buffer-name (concat buf-name "/" server))))) + (or buffer-name (generate-new-buffer-name full-buf-name)))) (defun erc-get-buffer-create (server port target) "Create a new buffer based on the arguments." @@ -3153,16 +3164,18 @@ were most recently invited. See also `invitation'." (setq chnl (erc-ensure-channel-name channel))) (when chnl ;; Prevent double joining of same channel on same server. - (let ((joined-channels - (mapcar #'(lambda (chanbuf) - (with-current-buffer chanbuf (erc-default-target))) - (erc-channel-list erc-server-process)))) - (if (erc-member-ignore-case chnl joined-channels) - (switch-to-buffer (car (erc-member-ignore-case chnl - joined-channels))) - (let ((server (with-current-buffer (process-buffer erc-server-process) - (or erc-session-server erc-server-announced-name)))) - (erc-server-join-channel server chnl key)))))) + (let* ((joined-channels + (mapcar #'(lambda (chanbuf) + (with-current-buffer chanbuf (erc-default-target))) + (erc-channel-list erc-server-process))) + (server (with-current-buffer (process-buffer erc-server-process) + (or erc-session-server erc-server-announced-name))) + (chnl-name (car (erc-member-ignore-case chnl joined-channels)))) + (if chnl-name + (switch-to-buffer (if (get-buffer chnl-name) + chnl-name + (concat chnl-name "/" server))) + (erc-server-join-channel server chnl key))))) t) (defalias 'erc-cmd-CHANNEL 'erc-cmd-JOIN) -- 2.27.0 From unknown Mon Jun 23 18:33:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40121: [PATCHv2] erc: fix erc-reuse-buffers behavior Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Aug 2020 11:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40121 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: "Mingde (Matthew) Zeng" Cc: 40121@debbugs.gnu.org Received: via spool by 40121-submit@debbugs.gnu.org id=B40121.159723061519841 (code B ref 40121); Wed, 12 Aug 2020 11:11:01 +0000 Received: (at 40121) by debbugs.gnu.org; 12 Aug 2020 11:10:15 +0000 Received: from localhost ([127.0.0.1]:43057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5oe7-00059w-Ex for submit@debbugs.gnu.org; Wed, 12 Aug 2020 07:10:15 -0400 Received: from quimby.gnus.org ([95.216.78.240]:43790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5oe4-00059h-Ne for 40121@debbugs.gnu.org; Wed, 12 Aug 2020 07:10:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=lYRQ6oq5uAfofWcbg4gjCM8wA/fYFUHdSrmNNhFBD2U=; b=tLPCYu4vOZ2A089cGc7Ww5k5D2 6ePOVi2bf/uc/XxldGbTNJotaFMvzER1/AiA3e0IFqetrpaj92M7ObGh+byRx5uR0qoP3h0p1HFv4 wTXcilxwdvYUD+Pb2MP77A4p2bofGq3X2d2ZCc5fa0yAvblNiTwbQlUToFDCOSPqoFfk=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5odv-0008MD-QO; Wed, 12 Aug 2020 13:10:06 +0200 From: Lars Ingebrigtsen References: <87h7t9ovyb.fsf@gmail.com> Date: Wed, 12 Aug 2020 13:10:01 +0200 In-Reply-To: <87h7t9ovyb.fsf@gmail.com> (Mingde Zeng's message of "Tue, 11 Aug 2020 14:53:48 -0400") Message-ID: <875z9op1bq.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: "Mingde (Matthew) Zeng" writes: > By the definition of erc-reuse-buffers, if non-nil it should create a > new buffer when joining channels with same names on different > servers. The current behavior of erc-reuse-buffers is: > 1. wh [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Mingde (Matthew) Zeng" writes: > By the definition of erc-reuse-buffers, if non-nil it should create a > new buffer when joining channels with same names on different > servers. The current behavior of erc-reuse-buffers is: > 1. when non-nil, it will always reuse the same channel buffer, > resulting in server A's channel gets reconnected to the channel with > the same name of server B. > 2. when nil, the buffer-name of the joined channel is > '#channel/server'. However if one tries to '/join #channel' from the > server buffer, it creates a new empty buffer with buffer-name > '#channel', instead of opening the already-joined channel buffer. Thanks; applied to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 12 07:10:31 2020 Received: (at control) by debbugs.gnu.org; 12 Aug 2020 11:10:31 +0000 Received: from localhost ([127.0.0.1]:43060 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5oeM-0005AT-Li for submit@debbugs.gnu.org; Wed, 12 Aug 2020 07:10:31 -0400 Received: from quimby.gnus.org ([95.216.78.240]:43804) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5oeL-0005AH-FO for control@debbugs.gnu.org; Wed, 12 Aug 2020 07:10:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=je6laQasGXU6LuqCbTPKSmNTx1BoZrcqb/BzhM8SR9s=; b=dS+WUg9EGdCNuaJd75ffiS3S+/ 88pjOTgiee0r74teKJ0/btZ18h6aYCihJ/fRz2D5zYhRRJhs3HacGClXyq/UOT+X168iZcDXejwyS 52JooMCluB1vghg3Vqlmb3aHMnXJeK5ULHkrcGjwcerJch3gPW9hBb2bXnp9gUnPrt5U=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5oeD-0008MM-RA for control@debbugs.gnu.org; Wed, 12 Aug 2020 13:10:23 +0200 Date: Wed, 12 Aug 2020 13:10:20 +0200 Message-Id: <871rkcp1b7.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #40121 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 40121 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 40121 28.1 quit