GNU bug report logs - #40120
[PATCH] doc: guix.texi: Add console-font-service-type to Base Services.

Previous Next

Full log

Message #8 received at 40120 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: John Soo <jsoo1 <at> asu.edu>
Cc: 40120 <at> debbugs.gnu.org
Subject: Re: [bug#40120] [PATCH] doc: guix.texi: Add console-font-service-type
 to Base Services.
Date: Sat, 21 Mar 2020 23:42:54 +0100

Hi John,

Thanks for improving the manual!  Some comments:

John Soo <jsoo1 <at> asu.edu> skribis:

> From 6a7204a6396781c1bbc1db1defee362c0a8142f9 Mon Sep 17 00:00:00 2001
> From: John Soo <jsoo1 <at> asu.edu>
> Date: Wed, 18 Mar 2020 08:33:59 -0700
> Subject: [PATCH] doc: guix.texi: Add console-font-service-type to Base
>  Services.
>
> * doc/guix.texi (console-font-service-type): Add it.
                  ^
This should be the name of the section this is added in.

> +@deffn {Scheme Procedure} console-font-service-type @var{tty-font-pairs}

This should be @defvr because it’s a variable, not a procedure (and thus
has no arguments).

Could you change that accordingly?  You can take inspiration from other
service types.

TIA!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.