GNU bug report logs - #40119
[PATCH] Make compilation-mode regexp matching case-sensitive

Previous Next

Full log

Message #8 received at 40119 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Mattias Engdegård <mattiase <at> acm.org>
Cc: 40119 <at> debbugs.gnu.org
Subject: Re: bug#40119: [PATCH] Make compilation-mode regexp matching
 case-sensitive
Date: Wed, 18 Mar 2020 20:05:07 +0200

> From: Mattias Engdegård <mattiase <at> acm.org>
> Date: Wed, 18 Mar 2020 16:31:49 +0100
> 
> +** Compilation mode
> +
> +*** Regexp matching of messages is now case-sensitive.
> +
>  
>  * New Modes and Packages in Emacs 28.1
>  
> diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
> index 455f181f50..aefaa1707a 100644
> --- a/lisp/progmodes/compile.el
> +++ b/lisp/progmodes/compile.el
> @@ -1435,7 +1435,8 @@ compilation-parse-errors
>      (if (symbolp item)
>          (setq item (cdr (assq item
>                                compilation-error-regexp-alist-alist))))
> -    (let ((file (nth 1 item))
> +    (let ((case-fold-search nil)
> +          (file (nth 1 item))
>            (line (nth 2 item))
>            (col (nth 3 item))
>            (type (nth 4 item))

What if we are wrong and some compiler needs case-insensitive
matching?  Your change makes it impossible to get back the old
behavior, not even optionally.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.