GNU bug report logs - #40104
[PATCH 1/1] gnu: Add emacs-org-static-blog.

Previous Next

Full log

Message #16 received at 40104 <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 40104 <at> debbugs.gnu.org,
 Guix-patches <guix-patches-bounces+brice+lists=waegenei.re <at> gnu.org>
Subject: Re: [bug#40104] [PATCH 1/1] gnu: Add emacs-org-static-blog.
Date: Wed, 18 Mar 2020 08:26:07 +0000

On 2020-03-17 15:07, Nicolas Goaziou wrote:
> Hello,
> 
> Brice Waegeneire <brice <at> waegenei.re> writes:
> 
>> * gnu/packages/emacs-xyz.scm (emacs-org-static-blog): New variable.
> 
> Thank you.
> 
>> +(define-public emacs-org-static-blog
>> +  (package
>> +   (name "emacs-org-static-blog")
>> +   (version "20200117.800")
> 
> Could you explain in a comment why using an unstable release is
> required?
> 
>> +   (source
>> +    (origin
>> +     (method url-fetch)
>> +     (uri (string-append
>> +           "https://melpa.org/packages/org-static-blog-"
>> +           version ".el"))
> 
> It seems upstream is at Github, not MELPA. Could you use Github 
> instead?
> 
>> +   (home-page
>> +    "https://github.com/bastibe/org-static-blog")
>> +   (synopsis
>> +    "Simple org-mode based static blog generator")
> 
> Nitpick: Simple Org mode based static blog generator
> 
>> +   (description
>> +    "Org-static-blog is one more static blog generator, it focuses on 
>> being
>> +simple.  All files are simple org-mode files in a directory.
> 
> Nitpick: All file are simple Org files in a directory.
> 
>> The only
>> +requirement is that every org file must have a #+TITLE and a #+DATE, 
>> and
>> +optionally, #+FILETAGS.")
> 
> Nitpick: every Org file must have a @samp{title} and a @samp{date}
> keywords, and optionally, a @samp{filetags} keyword.
> 
> Could you send an updated patch?
> 
> Regards,
V2 send with all your suggestions added. And I have requested a new 
release upstream: https://github.com/bastibe/org-static-blog/issues/50

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.