Subject: Re: [bug#40104] [PATCH 1/1] gnu: Add emacs-org-static-blog.

From: Nicolas Goaziou <[email-masked]>
Date: Tue, 17 Mar 2020 16:07:58 +0100

Hello,

Brice Waegeneire <[email-masked]> writes:

> * gnu/packages/emacs-xyz.scm (emacs-org-static-blog): New variable.

Thank you.

> +(define-public emacs-org-static-blog
> +  (package
> +   (name "emacs-org-static-blog")
> +   (version "20200117.800")

Could you explain in a comment why using an unstable release is
required?

> +   (source
> +    (origin
> +     (method url-fetch)
> +     (uri (string-append
> +           "https://melpa.org/packages/org-static-blog-"
> +           version ".el"))

It seems upstream is at Github, not MELPA. Could you use Github instead?

> +   (home-page
> +    "https://github.com/bastibe/org-static-blog")
> +   (synopsis
> +    "Simple org-mode based static blog generator")

Nitpick: Simple Org mode based static blog generator

> +   (description
> +    "Org-static-blog is one more static blog generator, it focuses on being
> +simple.  All files are simple org-mode files in a directory.  

Nitpick: All file are simple Org files in a directory.

> The only
> +requirement is that every org file must have a #+TITLE and a #+DATE, and
> +optionally, #+FILETAGS.")

Nitpick: every Org file must have a @samp{title} and a @samp{date}
keywords, and optionally, a @samp{filetags} keyword.

Could you send an updated patch?

Regards,

-- 
Nicolas Goaziou