GNU bug report logs - #40102
[PATCH] gnu packages gnome-xyz: Add topicons-redux

Previous Next

Full log

Message #22 received at 40102-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Ekaitz Zarraga <ekaitz <at> elenq.tech>
Cc: "40102\\@debbugs.gnu.org" <40102-done <at> debbugs.gnu.org>,
 Leo Prikler <leo.prikler <at> student.tugraz.at>
Subject: Re: [bug#40102] [PATCH] gnu packages gnome-xyz: Add topicons-redux
Date: Sat, 21 Mar 2020 20:23:20 +0100

[Message part 1 (text/plain, inline)]

Ekaitz Zarraga <ekaitz <at> elenq.tech> writes:

>> Indentation is off here. If you are not using Emacs there is a script
>> that can help with indentation, see "Formatting Code" in the Guix manual.
>
> I'm using Vim with Vim paredit and it's own Sheme filetype, but it doesn't
> work very well sometimes.

In that case, please run ./etc/indent-code.el before submitting
patches to lessen the burden on committers.  I've fixed the indentation
locally by running C-M-q in Emacs.

>>
>> Can you send an updated patch?
>>
>
> Here it comes:

Thanks!  Please add it as an attachment next time so the commit message
is preserved (or send the whole patch directly with 'git send-email').

Also, './pre-inst-env guix lint gnome-shell-extension-topicons-redux'
reported these issues:

gnu/packages/gnome-xyz.scm:155:5: gnome-shell-extension-topicons-redux <at> 6: the source file name should contain the package name
gnu/packages/gnome-xyz.scm:181:14: gnome-shell-extension-topicons-redux <at> 6: no period allowed at the end of the synopsis

I've fixed these locally too, sorry for missing them in the first
review.

Finally I edited the commit message so it follows our conventions.
Pushed in e7c7912573111d5e86f3e3012a6edab948f7b302.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.