GNU bug report logs - #40102
[PATCH] gnu packages gnome-xyz: Add topicons-redux

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#40102: closed ([PATCH] gnu packages gnome-xyz: Add
 topicons-redux)
Date: Sat, 21 Mar 2020 19:24:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 21 Mar 2020 20:23:20 +0100
with message-id <87y2rt5x7b.fsf <at> devup.no>
and subject line Re: [bug#40102] [PATCH] gnu packages gnome-xyz: Add topicons-redux
has caused the debbugs.gnu.org bug report #40102,
regarding [PATCH] gnu packages gnome-xyz: Add topicons-redux
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
40102: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40102
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu packages gnome-xyz: Add topicons-redux
Date: Tue, 17 Mar 2020 12:58:17 +0000

Hi,
Added TopiconsRedux because it's the only System Tray Icon
Manager I managed to work in our current GNOME version.

gnome-shell-extension-appindicator doesn't support clicks
or menus on the System Tray, TopiconsRedux does.

Best,
Ekaitz


From c0d51f07042aca537d4f550e2c5e9ed2fcbb6292 Mon Sep 17 00:00:00 2001
From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
Date: Tue, 17 Mar 2020 13:54:24 +0100
Subject: [PATCH] gnu packages gnome-xyz: Add topicons-redux

---
 gnu/packages/gnome-xyz.scm | 48 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)

diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
index b8cd32db08..3c8b1f667b 100644
--- a/gnu/packages/gnome-xyz.scm
+++ b/gnu/packages/gnome-xyz.scm
@@ -4,6 +4,7 @@
 ;;; Copyright © 2019 Giacomo Leidi <goodoldpaul <at> autistici.org>
 ;;; Copyright © 2020 Alex Griffin <a <at> ajgrf.com>
 ;;; Copyright © 2020 Jack Hill <jackhill <at> jackhill.us>
+;;; Copyright © 2020 Ekaitz Zarraga <ekaitz <at> elenq.tech>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -26,6 +27,7 @@
   #:use-module (guix build-system copy)
   #:use-module (guix build-system meson)
   #:use-module (guix git-download)
+  #:use-module (guix download)
   #:use-module (guix packages)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (gnu packages base)
@@ -146,6 +148,52 @@ GNOME Shell.")
     (home-page "https://github.com/ubuntu/gnome-shell-extension-appindicator/")
     (license license:gpl2+)))

+(define-public gnome-shell-extension-topicons-redux
+  (package
+    (name "gnome-shell-extension-topicons-redux")
+    (version "6")
+    (source
+      (origin
+        (method url-fetch)
+        (uri
+          (string-append
+            "https://gitlab.com/pop-planet/TopIcons-Redux/-/archive/"
+            version "/TopIcons-Redux-" version ".tar.gz"))
+        (sha256
+          (base32 "0diwb6l4wy4dwpwkls4cq8v0dbi99q194jfl39sv7f7mnbjjgi82"))))
+    (build-system gnu-build-system)
+    (native-inputs
+      `(("glib" ,glib "bin")))
+    (arguments
+      `(#:tests? #f
+        #:phases
+        (modify-phases
+          %standard-phases
+          (delete 'configure)
+          (delete 'build)
+          (replace 'install
+                   (lambda* (#:key outputs #:allow-other-keys)
+                            (let ((out (assoc-ref outputs "out")))
+                              (invoke "make"
+                                      "install"
+                                      (string-append
+                                        "INSTALL_PATH="
+                                        out
+                                        "/share/gnome-shell/extensions"))))))))
+
+    (home-page
+      "https://gitlab.com/pop-planet/TopIcons-Redux/-/tree/master")
+    (synopsis "Displays legacy tray icons in the GNOME Shell top panel.
+Rewritten fork of TopIcons Plus.")
+    (description "Many applications, such as chat clients, downloaders, and
+some media players, are meant to run long-term in the background even after you
+close their window. These applications remain accessible by adding an icon to
+the GNOME Shell Legacy Tray. However, the Legacy Tray was removed in GNOME
+3.26. TopIcons Redux brings those icons back into the top panel so that it's
+easier to keep track of apps running in the
+backround.")
+    (license license:gpl2)))
+
 (define-public gnome-shell-extension-dash-to-dock
   (package
     (name "gnome-shell-extension-dash-to-dock")
--
2.25.1

[Message part 3 (message/rfc822, inline)]

From: Marius Bakke <mbakke <at> fastmail.com>
To: Ekaitz Zarraga <ekaitz <at> elenq.tech>
Cc: "40102\\@debbugs.gnu.org" <40102-done <at> debbugs.gnu.org>,
 Leo Prikler <leo.prikler <at> student.tugraz.at>
Subject: Re: [bug#40102] [PATCH] gnu packages gnome-xyz: Add topicons-redux
Date: Sat, 21 Mar 2020 20:23:20 +0100

[Message part 4 (text/plain, inline)]

Ekaitz Zarraga <ekaitz <at> elenq.tech> writes:

>> Indentation is off here. If you are not using Emacs there is a script
>> that can help with indentation, see "Formatting Code" in the Guix manual.
>
> I'm using Vim with Vim paredit and it's own Sheme filetype, but it doesn't
> work very well sometimes.

In that case, please run ./etc/indent-code.el before submitting
patches to lessen the burden on committers.  I've fixed the indentation
locally by running C-M-q in Emacs.

>>
>> Can you send an updated patch?
>>
>
> Here it comes:

Thanks!  Please add it as an attachment next time so the commit message
is preserved (or send the whole patch directly with 'git send-email').

Also, './pre-inst-env guix lint gnome-shell-extension-topicons-redux'
reported these issues:

gnu/packages/gnome-xyz.scm:155:5: gnome-shell-extension-topicons-redux <at> 6: the source file name should contain the package name
gnu/packages/gnome-xyz.scm:181:14: gnome-shell-extension-topicons-redux <at> 6: no period allowed at the end of the synopsis

I've fixed these locally too, sorry for missing them in the first
review.

Finally I edited the commit message so it follows our conventions.
Pushed in e7c7912573111d5e86f3e3012a6edab948f7b302.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.