GNU bug report logs - #40102
[PATCH] gnu packages gnome-xyz: Add topicons-redux

Previous Next

Full log

View this message in rfc822 format

From: Marius Bakke <mbakke <at> fastmail.com>
To: Ekaitz Zarraga <ekaitz <at> elenq.tech>, Leo Prikler <leo.prikler <at> student.tugraz.at>
Cc: "40102 <at> debbugs.gnu.org" <40102 <at> debbugs.gnu.org>
Subject: [bug#40102] [PATCH] gnu packages gnome-xyz: Add topicons-redux
Date: Fri, 20 Mar 2020 18:53:46 +0100

[Message part 1 (text/plain, inline)]

Ekaitz Zarraga <ekaitz <at> elenq.tech> writes:

> From 4bbe7c5061a04d07ad9b85ff63d32379f34f8dc8 Mon Sep 17 00:00:00 2001
> From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
> Date: Tue, 17 Mar 2020 13:54:24 +0100
> Subject: [PATCH] gnu packages gnome-xyz: Add topicons-redux

[...]

> +(define-public gnome-shell-extension-topicons-redux
> +  (package
> +    (name "gnome-shell-extension-topicons-redux")
> +    (version "6")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri
> +          (string-append
> +            "https://gitlab.com/pop-planet/TopIcons-Redux/-/archive/"
> +            version "/TopIcons-Redux-" version ".tar.gz"))

Such "autogenerated" tarballs from GitLab and GitHub are prone to
getting re-created with different time stamps, breaking the checksum.
Can you adjust this package to use git-fetch instead of url-fetch?

[...]

> +    (arguments
> +      `(#:tests? #f

Why are tests disabled?  Please leave a comment.

> +        #:phases
> +        (modify-phases
> +          %standard-phases
> +          (delete 'configure)
> +          (delete 'build)
> +          (replace 'install
> +                   (lambda* (#:key outputs #:allow-other-keys)
> +                            (let ((out (assoc-ref outputs "out")))
> +                              (invoke "make"
> +                                      "install"
> +                                      (string-append
> +                                        "INSTALL_PATH="
> +                                        out
> +                                        "/share/gnome-shell/extensions"))))))))

Indentation is off here.  If you are not using Emacs there is a script
that can help with indentation, see "Formatting Code" in the Guix manual.

> +
> +    (home-page
> +      "https://gitlab.com/pop-planet/TopIcons-Redux/")

The line break here is not necessary.

> +    (synopsis "Displays legacy tray icons in the GNOME Shell top panel.
> +Rewritten fork of TopIcons Plus.")

Please keep synopsis to single sentences.  The second sentence can be
removed IMO.

> +    (description "Many applications, such as chat clients, downloaders, and
> +some media players, are meant to run long-term in the background even after you
> +close their window. These applications remain accessible by adding an icon to
> +the GNOME Shell Legacy Tray. However, the Legacy Tray was removed in GNOME
> +3.26. TopIcons Redux brings those icons back into the top panel so that it's
> +easier to keep track of apps running in the
> +backround.")

'guix lint gnome-shell-extension-topicons-redux' will warn that
sentences should be separated by two spaces.  Can you adjust accordingly?

> +    (license license:gpl2)))

Is the license really GPL2 only?  Unless the source code says explicitly
"GPL2 only", this should probably be "gpl2+", i.e. "GPL2 or any later
version".

Can you send an updated patch?

TIA!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.