From unknown Tue Jun 24 13:56:43 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40102] [PATCH] gnu packages gnome-xyz: Add topicons-redux Resent-From: Ekaitz Zarraga Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 17 Mar 2020 12:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 40102 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 40102@debbugs.gnu.org X-Debbugs-Original-To: "guix-patches@gnu.org" Reply-To: Ekaitz Zarraga Received: via spool by submit@debbugs.gnu.org id=B.158444991522210 (code B ref -1); Tue, 17 Mar 2020 12:59:02 +0000 Received: (at submit) by debbugs.gnu.org; 17 Mar 2020 12:58:35 +0000 Received: from localhost ([127.0.0.1]:38263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEBni-0005m5-Px for submit@debbugs.gnu.org; Tue, 17 Mar 2020 08:58:34 -0400 Received: from lists.gnu.org ([209.51.188.17]:41873) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEBnh-0005ly-4Q for submit@debbugs.gnu.org; Tue, 17 Mar 2020 08:58:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60476) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEBnf-0001wd-4Z for guix-patches@gnu.org; Tue, 17 Mar 2020 08:58:28 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jEBnd-0003H4-Dm for guix-patches@gnu.org; Tue, 17 Mar 2020 08:58:26 -0400 Received: from mail-40131.protonmail.ch ([185.70.40.131]:57436) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jEBnc-0002zP-T5 for guix-patches@gnu.org; Tue, 17 Mar 2020 08:58:25 -0400 Date: Tue, 17 Mar 2020 12:58:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=elenq.tech; s=protonmail; t=1584449902; bh=EDZfPvB+ZvGg2XkHjVYiFdH5up8MxKDCPfxOLg0Dd08=; h=Date:To:From:Reply-To:Subject:Feedback-ID:From; b=URlP/NPCN1iSlxERMA3HSL0iRcPmIw2a+t56G6S2HMEgBdTucCD3WD0hdBTTyf5KB KNUT321jRMn+zmNPWR2iuzay4Kgzlju3gtnjdVjNXZezGTDOHcbjjv74Wc8x/n48p2 FL4vkOLn/hhoOEptRZbXhpGhFqjMjesXa8ga1Mb4= From: Ekaitz Zarraga Message-ID: Feedback-ID: yrcNPDs6h_GmICDqa8wDN84Xewau0mXpBhN3eq2lvinS3lyxTuFMITDIGb7qalJ2C1nOhz7EVHHgQPysAd4y8g==:Ext:ProtonMail MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 185.70.40.131 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi, Added TopiconsRedux because it's the only System Tray Icon Manager I managed to work in our current GNOME version. gnome-shell-extension-appindicator doesn't support clicks or menus on the System Tray, TopiconsRedux does. Best, Ekaitz >From c0d51f07042aca537d4f550e2c5e9ed2fcbb6292 Mon Sep 17 00:00:00 2001 From: Ekaitz Zarraga Date: Tue, 17 Mar 2020 13:54:24 +0100 Subject: [PATCH] gnu packages gnome-xyz: Add topicons-redux --- gnu/packages/gnome-xyz.scm | 48 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm index b8cd32db08..3c8b1f667b 100644 --- a/gnu/packages/gnome-xyz.scm +++ b/gnu/packages/gnome-xyz.scm @@ -4,6 +4,7 @@ ;;; Copyright =C2=A9 2019 Giacomo Leidi ;;; Copyright =C2=A9 2020 Alex Griffin ;;; Copyright =C2=A9 2020 Jack Hill +;;; Copyright =C2=A9 2020 Ekaitz Zarraga ;;; ;;; This file is part of GNU Guix. ;;; @@ -26,6 +27,7 @@ #:use-module (guix build-system copy) #:use-module (guix build-system meson) #:use-module (guix git-download) + #:use-module (guix download) #:use-module (guix packages) #:use-module ((guix licenses) #:prefix license:) #:use-module (gnu packages base) @@ -146,6 +148,52 @@ GNOME Shell.") (home-page "https://github.com/ubuntu/gnome-shell-extension-appindicat= or/") (license license:gpl2+))) +(define-public gnome-shell-extension-topicons-redux + (package + (name "gnome-shell-extension-topicons-redux") + (version "6") + (source + (origin + (method url-fetch) + (uri + (string-append + "https://gitlab.com/pop-planet/TopIcons-Redux/-/archive/" + version "/TopIcons-Redux-" version ".tar.gz")) + (sha256 + (base32 "0diwb6l4wy4dwpwkls4cq8v0dbi99q194jfl39sv7f7mnbjjgi82"))= )) + (build-system gnu-build-system) + (native-inputs + `(("glib" ,glib "bin"))) + (arguments + `(#:tests? #f + #:phases + (modify-phases + %standard-phases + (delete 'configure) + (delete 'build) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (invoke "make" + "install" + (string-append + "INSTALL_PATH=3D" + out + "/share/gnome-shell/extensions")))= ))))) + + (home-page + "https://gitlab.com/pop-planet/TopIcons-Redux/-/tree/master") + (synopsis "Displays legacy tray icons in the GNOME Shell top panel. +Rewritten fork of TopIcons Plus.") + (description "Many applications, such as chat clients, downloaders, an= d +some media players, are meant to run long-term in the background even afte= r you +close their window. These applications remain accessible by adding an icon= to +the GNOME Shell Legacy Tray. However, the Legacy Tray was removed in GNOME +3.26. TopIcons Redux brings those icons back into the top panel so that it= 's +easier to keep track of apps running in the +backround.") + (license license:gpl2))) + (define-public gnome-shell-extension-dash-to-dock (package (name "gnome-shell-extension-dash-to-dock") -- 2.25.1 From unknown Tue Jun 24 13:56:43 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40102] [PATCH] gnu packages gnome-xyz: Add topicons-redux References: Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 17 Mar 2020 16:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40102 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: ekaitz@elenq.tech Cc: 40102@debbugs.gnu.org Received: via spool by 40102-submit@debbugs.gnu.org id=B40102.158446376730023 (code B ref 40102); Tue, 17 Mar 2020 16:50:02 +0000 Received: (at 40102) by debbugs.gnu.org; 17 Mar 2020 16:49:27 +0000 Received: from localhost ([127.0.0.1]:39494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEFPD-0007o9-4P for submit@debbugs.gnu.org; Tue, 17 Mar 2020 12:49:27 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:59332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEFPA-0007o0-NL for 40102@debbugs.gnu.org; Tue, 17 Mar 2020 12:49:25 -0400 Received: from nijino.local (193-83-20-222.hdsl.highway.telekom.at [193.83.20.222]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 48hfJw1z1Vz3wGr; Tue, 17 Mar 2020 17:49:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1584463760; bh=HPFkkNRXXPa36F9GE/jT5HjjsldDyT8y40l7PjdQGTg=; h=Subject:From:To:Cc:Date:In-Reply-To; b=dvLUDFov6SjshbtaRJLtmCiQN1ydim7Vyc29jnWjAaA+j20gpKagx68LFs/LsiJ7k IYrfipt28RtjkzRSCmvABeeReNCxAp1D3pXZHDZr6xD/gFsnmiCHp7JlfKXyxPoT7q 9JPotEECu2T7W62PH9q5htJ2fp255hBbWVdsU6E4= Message-ID: From: Leo Prikler Date: Tue, 17 Mar 2020 17:49:25 +0100 In-Reply-To: WNl-uAnWv9HyoL-xUnV0R1ZU3zoY1F-w-OPkdYIOeXx4ULUDqP2iK-X5iMMjX0MdSLBLqOr0GZEamO2wVoWmWzU0OaQzdH8DP7Xg9h1G-as=@elenq.tech Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.32.4 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Ekaitz, > + (home-page > + "https://gitlab.com/pop-planet/TopIcons-Redux/-/tree/master";) You should probably drop "-/tree/master" and uncomment the bracket. Otherwise LGTM. Regards, Leo From unknown Tue Jun 24 13:56:43 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40102] [PATCH] gnu packages gnome-xyz: Add topicons-redux Resent-From: Ekaitz Zarraga Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 17 Mar 2020 16:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40102 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Prikler Cc: "40102@debbugs.gnu.org" <40102@debbugs.gnu.org> Reply-To: Ekaitz Zarraga Received: via spool by 40102-submit@debbugs.gnu.org id=B40102.158446414430639 (code B ref 40102); Tue, 17 Mar 2020 16:56:02 +0000 Received: (at 40102) by debbugs.gnu.org; 17 Mar 2020 16:55:44 +0000 Received: from localhost ([127.0.0.1]:39498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEFVH-0007y7-Qk for submit@debbugs.gnu.org; Tue, 17 Mar 2020 12:55:44 -0400 Received: from mail2.protonmail.ch ([185.70.40.22]:44112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEFVE-0007xq-OL for 40102@debbugs.gnu.org; Tue, 17 Mar 2020 12:55:42 -0400 Date: Tue, 17 Mar 2020 16:55:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=elenq.tech; s=protonmail; t=1584464134; bh=W7nnicmpzJnGG/iy4KyVfH5aJ/pghxH1gZ2YWA++C9Y=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References: Feedback-ID:From; b=agS/MhqacfASzvcymkATaFVPGPDRjWJ0jnUYpCAUs1PwQ8UZyWxZKcJdhEiYI78CJ +kBHD3zJ7nABbBLQ3kwTL/mWNy053dNLTngN96NUDT6ivtt5GFi8oRc6O2+rmCvHp4 pEIZh16pmyKT0Wl0Vivaa/syFD3kOkZEE6MH9+nI= From: Ekaitz Zarraga Message-ID: In-Reply-To: References: Feedback-ID: yrcNPDs6h_GmICDqa8wDN84Xewau0mXpBhN3eq2lvinS3lyxTuFMITDIGb7qalJ2C1nOhz7EVHHgQPysAd4y8g==:Ext:ProtonMail MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Hi Ekaitz, > > > - (home-page > > - "https://gitlab.com/pop-planet/TopIcons-Redux/-/tree/master";) > > > > > > You should probably drop "-/tree/master" and uncomment the bracket. > Otherwise LGTM. > > Regards, > Leo The comment was accidentally introduced in the email. I don't really know h= ow tbh. Thanks for the comment, here's the updated patch: >From 4bbe7c5061a04d07ad9b85ff63d32379f34f8dc8 Mon Sep 17 00:00:00 2001 From: Ekaitz Zarraga Date: Tue, 17 Mar 2020 13:54:24 +0100 Subject: [PATCH] gnu packages gnome-xyz: Add topicons-redux --- gnu/packages/gnome-xyz.scm | 48 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm index b8cd32db08..abb8dab4f7 100644 --- a/gnu/packages/gnome-xyz.scm +++ b/gnu/packages/gnome-xyz.scm @@ -4,6 +4,7 @@ ;;; Copyright =C2=A9 2019 Giacomo Leidi ;;; Copyright =C2=A9 2020 Alex Griffin ;;; Copyright =C2=A9 2020 Jack Hill +;;; Copyright =C2=A9 2020 Ekaitz Zarraga ;;; ;;; This file is part of GNU Guix. ;;; @@ -26,6 +27,7 @@ #:use-module (guix build-system copy) #:use-module (guix build-system meson) #:use-module (guix git-download) + #:use-module (guix download) #:use-module (guix packages) #:use-module ((guix licenses) #:prefix license:) #:use-module (gnu packages base) @@ -146,6 +148,52 @@ GNOME Shell.") (home-page "https://github.com/ubuntu/gnome-shell-extension-appindicat= or/") (license license:gpl2+))) +(define-public gnome-shell-extension-topicons-redux + (package + (name "gnome-shell-extension-topicons-redux") + (version "6") + (source + (origin + (method url-fetch) + (uri + (string-append + "https://gitlab.com/pop-planet/TopIcons-Redux/-/archive/" + version "/TopIcons-Redux-" version ".tar.gz")) + (sha256 + (base32 "0diwb6l4wy4dwpwkls4cq8v0dbi99q194jfl39sv7f7mnbjjgi82"))= )) + (build-system gnu-build-system) + (native-inputs + `(("glib" ,glib "bin"))) + (arguments + `(#:tests? #f + #:phases + (modify-phases + %standard-phases + (delete 'configure) + (delete 'build) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (invoke "make" + "install" + (string-append + "INSTALL_PATH=3D" + out + "/share/gnome-shell/extensions")))= ))))) + + (home-page + "https://gitlab.com/pop-planet/TopIcons-Redux/") + (synopsis "Displays legacy tray icons in the GNOME Shell top panel. +Rewritten fork of TopIcons Plus.") + (description "Many applications, such as chat clients, downloaders, an= d +some media players, are meant to run long-term in the background even afte= r you +close their window. These applications remain accessible by adding an icon= to +the GNOME Shell Legacy Tray. However, the Legacy Tray was removed in GNOME +3.26. TopIcons Redux brings those icons back into the top panel so that it= 's +easier to keep track of apps running in the +backround.") + (license license:gpl2))) + (define-public gnome-shell-extension-dash-to-dock (package (name "gnome-shell-extension-dash-to-dock") -- 2.25.1 From unknown Tue Jun 24 13:56:43 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40102] [PATCH] gnu packages gnome-xyz: Add topicons-redux Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 20 Mar 2020 17:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40102 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ekaitz Zarraga , Leo Prikler Cc: "40102@debbugs.gnu.org" <40102@debbugs.gnu.org> Received: via spool by 40102-submit@debbugs.gnu.org id=B40102.158472683810243 (code B ref 40102); Fri, 20 Mar 2020 17:54:01 +0000 Received: (at 40102) by debbugs.gnu.org; 20 Mar 2020 17:53:58 +0000 Received: from localhost ([127.0.0.1]:45533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFLqI-0002f7-BB for submit@debbugs.gnu.org; Fri, 20 Mar 2020 13:53:58 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:50255) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFLqG-0002el-7q for 40102@debbugs.gnu.org; Fri, 20 Mar 2020 13:53:56 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 1849D5C01A4; Fri, 20 Mar 2020 13:53:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 20 Mar 2020 13:53:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=tM4ugwc1OosIpDALtkw6mBa6KW e/ujF5oYiWd9TtJ9E=; b=rdlvlF0V81VFWm36L/My+DoQmSp8/icXHEtrtwRJms zbhyBHx61Hq+vwBPaiwHBlhSvsK003+wWNNinkAfWUwfjtAcDcjhBlxYcZBe9O29 uLT/ruswukEFqWvg/AFOHJxnMGC/fI7Xx++uVPwNb73e+5A7EVrRAjUXYYarmb98 MxhoA4sXJ6r9oBiiVRh9YaJa0rA/i6u0QoUOSdlQ17Q0zu5xAMX2+Uxt57d1ionM ewC+vyUern/w/pXvWcacxug8Y74oXhceXMmed5S2tkMH3vqR9nVuM+Xd1zLr2Uon Eol4coNp8gAWi/6jFmDuetOKCuHpGGIKV8TqfKPBGxMg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=tM4ugw c1OosIpDALtkw6mBa6KWe/ujF5oYiWd9TtJ9E=; b=0xYtn1kdkEcw/q5iUKFeeg n2TTWmSNAGay6LiUB9ms2KvV+bTLSLmejXJuU1Xgv7DMcYA2F31+lCEv/P/+1QKb Hc0dieXZRpocGf3ziG8HwKP0zLPwHMqY5DDHX5Hhst6pCeXkR1MUDssGR8pQPGJK YoBR6YFRTUNXVSEmK9LU7DYdjKI96cbHOtWcapBBIpLuqGr8YNbj10xOMIBkC788 wVM9CYmGp1YY6mGvuqwc08ROOgG01zEtW5lFrgtYbqnpRjNMg5XiObp08DWNlUEh BGNbGq65Z1KFX3aYoru8t9RfGP8txOY5hbs5WKfqtO4wpJK83HWto+bUOlx0vI/A == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudeguddguddtgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffujghffgffkfggtgesghdtreertdertdenucfhrhhomhepofgrrhhi uhhsuceurghkkhgvuceomhgsrghkkhgvsehfrghsthhmrghilhdrtghomheqnecuffhomh grihhnpehgihhtlhgrsgdrtghomhenucfkphepkeegrddvtddvrdeikedrjeehnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgsrghkkhgvse hfrghsthhmrghilhdrtghomh X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id 2E17530624E4; Fri, 20 Mar 2020 13:53:48 -0400 (EDT) From: Marius Bakke In-Reply-To: References: User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Fri, 20 Mar 2020 18:53:46 +0100 Message-ID: <87fte29al1.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Ekaitz Zarraga writes: > From 4bbe7c5061a04d07ad9b85ff63d32379f34f8dc8 Mon Sep 17 00:00:00 2001 > From: Ekaitz Zarraga > Date: Tue, 17 Mar 2020 13:54:24 +0100 > Subject: [PATCH] gnu packages gnome-xyz: Add topicons-redux [...] > +(define-public gnome-shell-extension-topicons-redux > + (package > + (name "gnome-shell-extension-topicons-redux") > + (version "6") > + (source > + (origin > + (method url-fetch) > + (uri > + (string-append > + "https://gitlab.com/pop-planet/TopIcons-Redux/-/archive/" > + version "/TopIcons-Redux-" version ".tar.gz")) Such "autogenerated" tarballs from GitLab and GitHub are prone to getting re-created with different time stamps, breaking the checksum. Can you adjust this package to use git-fetch instead of url-fetch? [...] > + (arguments > + `(#:tests? #f Why are tests disabled? Please leave a comment. > + #:phases > + (modify-phases > + %standard-phases > + (delete 'configure) > + (delete 'build) > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((out (assoc-ref outputs "out"))) > + (invoke "make" > + "install" > + (string-append > + "INSTALL_PATH=" > + out > + "/share/gnome-shell/extensions")))))))) Indentation is off here. If you are not using Emacs there is a script that can help with indentation, see "Formatting Code" in the Guix manual. > + > + (home-page > + "https://gitlab.com/pop-planet/TopIcons-Redux/") The line break here is not necessary. > + (synopsis "Displays legacy tray icons in the GNOME Shell top panel. > +Rewritten fork of TopIcons Plus.") Please keep synopsis to single sentences. The second sentence can be removed IMO. > + (description "Many applications, such as chat clients, downloaders, and > +some media players, are meant to run long-term in the background even after you > +close their window. These applications remain accessible by adding an icon to > +the GNOME Shell Legacy Tray. However, the Legacy Tray was removed in GNOME > +3.26. TopIcons Redux brings those icons back into the top panel so that it's > +easier to keep track of apps running in the > +backround.") 'guix lint gnome-shell-extension-topicons-redux' will warn that sentences should be separated by two spaces. Can you adjust accordingly? > + (license license:gpl2))) Is the license really GPL2 only? Unless the source code says explicitly "GPL2 only", this should probably be "gpl2+", i.e. "GPL2 or any later version". Can you send an updated patch? TIA! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl51AyoACgkQoqBt8qM6 VPoqlwgAjT5FYe67FuxcA5308hVSLv2kyN2G7wwIrhl/E6wxBQNlmcoGKUSR1Ydn 52mxp/Rt5iLXfZeHMM2uv+GbtaelV62Xww+2GKhaynqzOn1SA6WdrFMkIN4nV/84 dZHBxKfz4joGJENGttn8/QHzYSacEbcjLlqcp3u4ag6eiBlqVrIkWiPvFIDUFJP9 IE/SYTZbPjQrQ8acGZIN7LPVcnn5ETSSFE8PGawaqTyLaSqLCqSC1zO4WU7wxHKS VWhcx7CTAOitvutMJVMTdmgB4vzzddC5+znpS0fTcimawAH3Vrhiop4Q9ubrVtDe 0FqRQwmNQ+Fs3lSxV8U+asxo0887fA== =ap6b -----END PGP SIGNATURE----- --=-=-=-- From unknown Tue Jun 24 13:56:43 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40102] [PATCH] gnu packages gnome-xyz: Add topicons-redux Resent-From: Ekaitz Zarraga Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 20 Mar 2020 19:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40102 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke Cc: "40102\\@debbugs.gnu.org" <40102@debbugs.gnu.org>, Leo Prikler Reply-To: Ekaitz Zarraga Received: via spool by 40102-submit@debbugs.gnu.org id=B40102.158473291731095 (code B ref 40102); Fri, 20 Mar 2020 19:36:01 +0000 Received: (at 40102) by debbugs.gnu.org; 20 Mar 2020 19:35:17 +0000 Received: from localhost ([127.0.0.1]:45685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFNQG-00085P-Ns for submit@debbugs.gnu.org; Fri, 20 Mar 2020 15:35:17 -0400 Received: from mail1.protonmail.ch ([185.70.40.18]:15468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFNQE-000854-90 for 40102@debbugs.gnu.org; Fri, 20 Mar 2020 15:35:11 -0400 Date: Fri, 20 Mar 2020 19:34:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=elenq.tech; s=protonmail; t=1584732903; bh=mngl39b+oJXEsnPop6XC42QIahMHuWW9P8kV1yf4frs=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=k16P+08rIFcDpubRilktYycg8RCToAaW58nAuXZYZM29bynXGTsjpCK3JcSXLky5H Wym/LIBe+SRFsSotXF4mnYnbpvKIbid/p62uWUq9sBfDAjP+BkStOt+ujdI+lemQ6u OO1m3lSapG+Wi42maiscm6bdDfdvskk7UgNlUeV4= From: Ekaitz Zarraga Message-ID: In-Reply-To: <87fte29al1.fsf@devup.no> References: <87fte29al1.fsf@devup.no> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi all, Thanks Marius for the feedback. =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Friday, March 20, 2020 5:53 PM, Marius Bakke wrote= : > Such "autogenerated" tarballs from GitLab and GitHub are prone to > getting re-created with different time stamps, breaking the checksum. > Can you adjust this package to use git-fetch instead of url-fetch? I wasn't aware of that! Thank you very much. > Why are tests disabled? Please leave a comment. Project doesn't have any test. > Indentation is off here. If you are not using Emacs there is a script > that can help with indentation, see "Formatting Code" in the Guix manual. I'm using Vim with Vim paredit and it's own Sheme filetype, but it doesn't work very well sometimes. > > The line break here is not necessary. Solved > > - (synopsis "Displays legacy tray icons in the GNOME Shell top panel. > > +Rewritten fork of TopIcons Plus.") > > > > Please keep synopsis to single sentences. The second sentence can be > removed IMO. Done. > 'guix lint gnome-shell-extension-topicons-redux' will warn that > sentences should be separated by two spaces. Can you adjust accordingly? Done. > > - (license license:gpl2))) > > Is the license really GPL2 only? Unless the source code says explicitly > "GPL2 only", this should probably be "gpl2+", i.e. "GPL2 or any later > version". Done. > > Can you send an updated patch? > Here it comes: >From e62251601732587409c18dfe3af0cd56ecf39d5f Mon Sep 17 00:00:00 2001 From: Ekaitz Zarraga Date: Tue, 17 Mar 2020 13:54:24 +0100 Subject: [PATCH] gnu packages gnome-xyz: Add topicons-redux --- gnu/packages/gnome-xyz.scm | 43 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm index b8cd32db08..39579bbea4 100644 --- a/gnu/packages/gnome-xyz.scm +++ b/gnu/packages/gnome-xyz.scm @@ -4,6 +4,7 @@ ;;; Copyright =C2=A9 2019 Giacomo Leidi ;;; Copyright =C2=A9 2020 Alex Griffin ;;; Copyright =C2=A9 2020 Jack Hill +;;; Copyright =C2=A9 2020 Ekaitz Zarraga ;;; ;;; This file is part of GNU Guix. ;;; @@ -146,6 +147,48 @@ GNOME Shell.") (home-page "https://github.com/ubuntu/gnome-shell-extension-appindicat= or/") (license license:gpl2+))) +(define-public gnome-shell-extension-topicons-redux + (package + (name "gnome-shell-extension-topicons-redux") + (version "6") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://gitlab.com/pop-planet/TopIcons-Redux.git") + (commit version))) + (sha256 + (base32 "1dli9xb545n3xlj6q4wl0y5gzkm903zs47p8fiq71pdvbr6v38rj"))= )) + (build-system gnu-build-system) + (native-inputs + `(("glib" ,glib "bin"))) + (arguments + `(#:tests? #f ; No test defined in the project + #:phases + (modify-phases + %standard-phases + (delete 'configure) + (delete 'build) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (invoke "make" + "install" + (string-append + "INSTALL_PATH=3D" + out + "/share/gnome-shell/extensions")))))))) + + (home-page "https://gitlab.com/pop-planet/TopIcons-Redux/") + (synopsis "Displays legacy tray icons in the GNOME Shell top panel.") + (description "Many applications, such as chat clients, downloaders, an= d +some media players, are meant to run long-term in the background even afte= r you +close their window. These applications remain accessible by adding an ico= n to +the GNOME Shell Legacy Tray. However, the Legacy Tray was removed in GNOM= E +3.26. TopIcons Redux brings those icons back into the top panel so that i= t's +easier to keep track of apps running in the backround.") + (license license:gpl2+))) + (define-public gnome-shell-extension-dash-to-dock (package (name "gnome-shell-extension-dash-to-dock") -- 2.25.1 From unknown Tue Jun 24 13:56:43 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Ekaitz Zarraga Subject: bug#40102: closed (Re: [bug#40102] [PATCH] gnu packages gnome-xyz: Add topicons-redux) Message-ID: References: <87y2rt5x7b.fsf@devup.no> X-Gnu-PR-Message: they-closed 40102 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 40102@debbugs.gnu.org Date: Sat, 21 Mar 2020 19:24:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1584818642-3798-1" This is a multi-part message in MIME format... ------------=_1584818642-3798-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #40102: [PATCH] gnu packages gnome-xyz: Add topicons-redux which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 40102@debbugs.gnu.org. --=20 40102: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D40102 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1584818642-3798-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 40102-done) by debbugs.gnu.org; 21 Mar 2020 19:23:30 +0000 Received: from localhost ([127.0.0.1]:48052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFjiU-0000yJ-BK for submit@debbugs.gnu.org; Sat, 21 Mar 2020 15:23:30 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:34155) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFjiS-0000y2-NQ for 40102-done@debbugs.gnu.org; Sat, 21 Mar 2020 15:23:29 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 9EDD25C010D; Sat, 21 Mar 2020 15:23:23 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 21 Mar 2020 15:23:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=J8DefmE+FXrkg1gYaFmU4lF7CA yNhhfnZWZqlD9D/cg=; b=wOVRAzXjqOvwnmBea1st8fNZUs7Gys5Yn6q/sddwvc c4tbHetCg5Wk3fuD3PJ6JJu7D21IyOYhYY3akdaw9+CVrG7+HvizNKV8GHnzM4T9 r4WTmFyH5to0QBYjIUDLhYXOMByWbYHAuIOyw8vx48uF4On/QT31qv9De1WdDqvJ 3DjtbgF93aHDCi8Tm8USl7X66kQ2byCEs1sfPJaI9APg1FpyNnzCtKc/6xxpF4zs 8ca93iBOpEqr6Kk5+kv6psqvTmMniCneqGLKpFJuksuWFIZLUp5j0y70rlb/oQ9w cDxbREC3QUG8b8r01GLVjApCB4rr9qOGbEDCw4wRYC6A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=J8Defm E+FXrkg1gYaFmU4lF7CAyNhhfnZWZqlD9D/cg=; b=WT3tci6jxCF7dEPJ8IQ74F VLbfbYEqjtMVGKyAA1kUQOO/uNfmiRStdPm5Nn1+3vUcPZYqtFZcE8v5e0WRfRTW be3TxOYVNq+LbxypW0Af467ASKGB2x4RHPok9Xhh5ND4HJaCrJ471FvRs0rSfRHx O8pF/4u6a6n4obj382VYSKdqGfyJ5EywDUmLGGFDJCHHkjcHIbkyNINYvZYPmxQI gXQKtKsdmZRCnd8hYOQ5rJ0i1oNcQOUx8NX4spFbGz95yyIU4+EwrWuka/yZnXwj PgUY1EadbAX+dg9KY5PqhIKYX5njoiPwEC/OvuDbkcunxZ14/GLIYDDQTnBbaJcA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudegfedguddvhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffujghffgffkfggtgesghdtreertdertdenucfhrhhomhepofgrrhhi uhhsuceurghkkhgvuceomhgsrghkkhgvsehfrghsthhmrghilhdrtghomheqnecukfhppe ekgedrvddtvddrieekrdejheenucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhep mhgrihhlfhhrohhmpehmsggrkhhkvgesfhgrshhtmhgrihhlrdgtohhm X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id 7FE053062A92; Sat, 21 Mar 2020 15:23:22 -0400 (EDT) From: Marius Bakke To: Ekaitz Zarraga Subject: Re: [bug#40102] [PATCH] gnu packages gnome-xyz: Add topicons-redux In-Reply-To: References: <87fte29al1.fsf@devup.no> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Sat, 21 Mar 2020 20:23:20 +0100 Message-ID: <87y2rt5x7b.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40102-done Cc: "40102\\@debbugs.gnu.org" <40102-done@debbugs.gnu.org>, Leo Prikler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Ekaitz Zarraga writes: >> Indentation is off here. If you are not using Emacs there is a script >> that can help with indentation, see "Formatting Code" in the Guix manual. > > I'm using Vim with Vim paredit and it's own Sheme filetype, but it doesn't > work very well sometimes. In that case, please run ./etc/indent-code.el before submitting patches to lessen the burden on committers. I've fixed the indentation locally by running C-M-q in Emacs. >> >> Can you send an updated patch? >> > > Here it comes: Thanks! Please add it as an attachment next time so the commit message is preserved (or send the whole patch directly with 'git send-email'). Also, './pre-inst-env guix lint gnome-shell-extension-topicons-redux' reported these issues: gnu/packages/gnome-xyz.scm:155:5: gnome-shell-extension-topicons-redux@6: the source file name should contain the package name gnu/packages/gnome-xyz.scm:181:14: gnome-shell-extension-topicons-redux@6: no period allowed at the end of the synopsis I've fixed these locally too, sorry for missing them in the first review. Finally I edited the commit message so it follows our conventions. Pushed in e7c7912573111d5e86f3e3012a6edab948f7b302. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl52aakACgkQoqBt8qM6 VPrerAgArH0SVw+wCQOo+OUbieRcPuzcIXsHJlhcBZR1aPCVF4D9dB3kGJhYkq1Q m7SHr2syQo33UYUiP2LMmeDAenFK+WCITTkWdKihQ8xc9t+morT3IcM9NK1RSP7C e5sdzgZAkZ4Fasu7h9Ja6fCQG8bnOj2F4sjKtXWti0lj0s9LsnvDKvLSHUhbrY3F 9krw8VsNzCgQSzdoYjl8Suq0BTzJMAY9J+GEFeTjrU4fPgIJ2zURnJOZ02azCFgy ndM7GlSQ4/mSYmHWho4rGpaAcweuXH3NRj1M0rZdYC5NwPCgZf/MBO29rg/Gt3wv ocPe0cQvK28uiEiHmz/+bxD/j6Q4iQ== =VO69 -----END PGP SIGNATURE----- --=-=-=-- ------------=_1584818642-3798-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 17 Mar 2020 12:58:35 +0000 Received: from localhost ([127.0.0.1]:38263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEBni-0005m5-Px for submit@debbugs.gnu.org; Tue, 17 Mar 2020 08:58:34 -0400 Received: from lists.gnu.org ([209.51.188.17]:41873) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEBnh-0005ly-4Q for submit@debbugs.gnu.org; Tue, 17 Mar 2020 08:58:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60476) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEBnf-0001wd-4Z for guix-patches@gnu.org; Tue, 17 Mar 2020 08:58:28 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jEBnd-0003H4-Dm for guix-patches@gnu.org; Tue, 17 Mar 2020 08:58:26 -0400 Received: from mail-40131.protonmail.ch ([185.70.40.131]:57436) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jEBnc-0002zP-T5 for guix-patches@gnu.org; Tue, 17 Mar 2020 08:58:25 -0400 Date: Tue, 17 Mar 2020 12:58:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=elenq.tech; s=protonmail; t=1584449902; bh=EDZfPvB+ZvGg2XkHjVYiFdH5up8MxKDCPfxOLg0Dd08=; h=Date:To:From:Reply-To:Subject:Feedback-ID:From; b=URlP/NPCN1iSlxERMA3HSL0iRcPmIw2a+t56G6S2HMEgBdTucCD3WD0hdBTTyf5KB KNUT321jRMn+zmNPWR2iuzay4Kgzlju3gtnjdVjNXZezGTDOHcbjjv74Wc8x/n48p2 FL4vkOLn/hhoOEptRZbXhpGhFqjMjesXa8ga1Mb4= To: "guix-patches@gnu.org" From: Ekaitz Zarraga Subject: [PATCH] gnu packages gnome-xyz: Add topicons-redux Message-ID: Feedback-ID: yrcNPDs6h_GmICDqa8wDN84Xewau0mXpBhN3eq2lvinS3lyxTuFMITDIGb7qalJ2C1nOhz7EVHHgQPysAd4y8g==:Ext:ProtonMail MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 185.70.40.131 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Ekaitz Zarraga Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi, Added TopiconsRedux because it's the only System Tray Icon Manager I managed to work in our current GNOME version. gnome-shell-extension-appindicator doesn't support clicks or menus on the System Tray, TopiconsRedux does. Best, Ekaitz >From c0d51f07042aca537d4f550e2c5e9ed2fcbb6292 Mon Sep 17 00:00:00 2001 From: Ekaitz Zarraga Date: Tue, 17 Mar 2020 13:54:24 +0100 Subject: [PATCH] gnu packages gnome-xyz: Add topicons-redux --- gnu/packages/gnome-xyz.scm | 48 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm index b8cd32db08..3c8b1f667b 100644 --- a/gnu/packages/gnome-xyz.scm +++ b/gnu/packages/gnome-xyz.scm @@ -4,6 +4,7 @@ ;;; Copyright =C2=A9 2019 Giacomo Leidi ;;; Copyright =C2=A9 2020 Alex Griffin ;;; Copyright =C2=A9 2020 Jack Hill +;;; Copyright =C2=A9 2020 Ekaitz Zarraga ;;; ;;; This file is part of GNU Guix. ;;; @@ -26,6 +27,7 @@ #:use-module (guix build-system copy) #:use-module (guix build-system meson) #:use-module (guix git-download) + #:use-module (guix download) #:use-module (guix packages) #:use-module ((guix licenses) #:prefix license:) #:use-module (gnu packages base) @@ -146,6 +148,52 @@ GNOME Shell.") (home-page "https://github.com/ubuntu/gnome-shell-extension-appindicat= or/") (license license:gpl2+))) +(define-public gnome-shell-extension-topicons-redux + (package + (name "gnome-shell-extension-topicons-redux") + (version "6") + (source + (origin + (method url-fetch) + (uri + (string-append + "https://gitlab.com/pop-planet/TopIcons-Redux/-/archive/" + version "/TopIcons-Redux-" version ".tar.gz")) + (sha256 + (base32 "0diwb6l4wy4dwpwkls4cq8v0dbi99q194jfl39sv7f7mnbjjgi82"))= )) + (build-system gnu-build-system) + (native-inputs + `(("glib" ,glib "bin"))) + (arguments + `(#:tests? #f + #:phases + (modify-phases + %standard-phases + (delete 'configure) + (delete 'build) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (invoke "make" + "install" + (string-append + "INSTALL_PATH=3D" + out + "/share/gnome-shell/extensions")))= ))))) + + (home-page + "https://gitlab.com/pop-planet/TopIcons-Redux/-/tree/master") + (synopsis "Displays legacy tray icons in the GNOME Shell top panel. +Rewritten fork of TopIcons Plus.") + (description "Many applications, such as chat clients, downloaders, an= d +some media players, are meant to run long-term in the background even afte= r you +close their window. These applications remain accessible by adding an icon= to +the GNOME Shell Legacy Tray. However, the Legacy Tray was removed in GNOME +3.26. TopIcons Redux brings those icons back into the top panel so that it= 's +easier to keep track of apps running in the +backround.") + (license license:gpl2))) + (define-public gnome-shell-extension-dash-to-dock (package (name "gnome-shell-extension-dash-to-dock") -- 2.25.1 ------------=_1584818642-3798-1-- From unknown Tue Jun 24 13:56:43 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40102] [PATCH] gnu packages gnome-xyz: Add topicons-redux Resent-From: Ekaitz Zarraga Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 21 Mar 2020 19:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40102 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke Cc: "40102\\\\\\@debbugs.gnu.org" <40102-done@debbugs.gnu.org>, Leo Prikler Reply-To: Ekaitz Zarraga Received: via spool by 40102-done@debbugs.gnu.org id=D40102.15848192585037 (code D ref 40102); Sat, 21 Mar 2020 19:35:02 +0000 Received: (at 40102-done) by debbugs.gnu.org; 21 Mar 2020 19:34:18 +0000 Received: from localhost ([127.0.0.1]:48064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFjsv-0001JB-QT for submit@debbugs.gnu.org; Sat, 21 Mar 2020 15:34:17 -0400 Received: from mail2.protonmail.ch ([185.70.40.22]:21003) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFjst-0001Iy-EF for 40102-done@debbugs.gnu.org; Sat, 21 Mar 2020 15:34:16 -0400 Date: Sat, 21 Mar 2020 19:34:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=elenq.tech; s=protonmail; t=1584819249; bh=4UDBKCnockboyzt6OOBtWV9qhIks/CKQ7c4vaRZjQwM=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=SUj+JcoHK8Qv0MTF/X5bRYm6holYdaeOtkl2eIkirsU7J0n+t/WNhB/4XEKnwaxey yJTMnl49RjkqHmgj79Pn0u+cZmMMvcPFY5QdJQMwSMmNFv1CFJFZrhVm95UFnHThOZ SNDYjez1cyxMGVsgE1hHrpsSWxagk21QT/KnSL2o= From: Ekaitz Zarraga Message-ID: In-Reply-To: <87y2rt5x7b.fsf@devup.no> References: <87fte29al1.fsf@devup.no> <87y2rt5x7b.fsf@devup.no> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I've fixed these locally too, sorry for missing them in the first > review. > ... Sorry for all the work I gave you. I'll do it better next time. Promise! Thanks for your time. Best, Ekaitz From unknown Tue Jun 24 13:56:43 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40102] [PATCH] gnu packages gnome-xyz: Add topicons-redux Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 21 Mar 2020 19:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40102 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ekaitz Zarraga Cc: "40102\\\\\\@debbugs.gnu.org" <40102-done@debbugs.gnu.org>, Leo Prikler Received: via spool by 40102-done@debbugs.gnu.org id=D40102.15848195265528 (code D ref 40102); Sat, 21 Mar 2020 19:39:01 +0000 Received: (at 40102-done) by debbugs.gnu.org; 21 Mar 2020 19:38:46 +0000 Received: from localhost ([127.0.0.1]:48070 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFjxG-0001R5-9y for submit@debbugs.gnu.org; Sat, 21 Mar 2020 15:38:46 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:47445) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFjxF-0001Qo-Dk for 40102-done@debbugs.gnu.org; Sat, 21 Mar 2020 15:38:45 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 164BE5C012D; Sat, 21 Mar 2020 15:38:40 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 21 Mar 2020 15:38:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=w7KSh9R2bsplt1AW7GPDZeF5p0 vQCW9ELMQKxaSTQuI=; b=pF7Hq6TpdnlQ1jymo2EMcetHjxfNcQSBtbId1JAqYn vprQOPAcjWJWYInTup3Jht1gRPA7Ca5eScSlVkb82Xl73Kr/5LFjMlaIO+TnJQau YikFXdn2fCWPzWy8q6XEkcmGIr0Pns6JmNTkqOQdf3bLVajtHDYt+wo4p2XtksPm 7OstEBdUW9p2ZpXuZyp2lXkv6jBDE99MNoFOLsZ6Iz98eFcPEEtKi+AHQPU+JRDj 3lcRjJar61wFjrwceRnTzim7dpEVZvPK5EYrgwJrtyIAculsf0oL+fz+og+ta2It W5MY0LHhRUFRWMvpT2VUgcAZ38QH64jMFm0/XUKH5k6A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=w7KSh9 R2bsplt1AW7GPDZeF5p0vQCW9ELMQKxaSTQuI=; b=ouJNgkEL2mv1ksa3cIg0CG E/w68cVhwfJrSLYzh3rGMxrOYSez/squZNTLKrt3Bpg8QM5E1s/jpaolVPxzeY9E YAzha577YeCmNXA2a4CLIIDSYmnLpTO3bXTecL+H8wgm0qtZDcz9ZwtC4j3tBznB vGlgL/1sJHQXY0ggtixEKQLscpaypAsvef0g8OlJ6J9RP7ylWfNvo/VXAM75eYQG VRdzdtgGHwqdvISkM3y0S7uoEeYp9p99GfXHah7PoatNS+19AdlBv0lt4rH6tVU/ vdiYsSgf8G4wtgYRYOpS1EGHhlLATQJUAU2e392B9m6Sy9yXY/jD1FRTexUnjT/Q == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudegfedguddvkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffujghffgffkfggtgesghdtreertdertdenucfhrhhomhepofgrrhhi uhhsuceurghkkhgvuceomhgsrghkkhgvsehfrghsthhmrghilhdrtghomheqnecukfhppe ekgedrvddtvddrieekrdejheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep mhgrihhlfhhrohhmpehmsggrkhhkvgesfhgrshhtmhgrihhlrdgtohhm X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id 315943280060; Sat, 21 Mar 2020 15:38:39 -0400 (EDT) From: Marius Bakke In-Reply-To: References: <87fte29al1.fsf@devup.no> <87y2rt5x7b.fsf@devup.no> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Sat, 21 Mar 2020 20:38:37 +0100 Message-ID: <87v9mx5whu.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Ekaitz Zarraga writes: >> I've fixed these locally too, sorry for missing them in the first >> review. >> ... > > Sorry for all the work I gave you. > I'll do it better next time. Promise! No worries! It takes a while to get the hang of these things. :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl52bT0ACgkQoqBt8qM6 VPrPygf/Q3inc6Ci2cR1zfbLSN8sgDEo7w3/zOi2DWXWec81s0EF5GqzNzxdiamD rqj6jChWOkISrjlzV2nCpKbis7j2DEKZjPSLGwEmw4wNyf0LBCtS7fTJ9PLnY1+Q bGA9+6UdllHxaV7TRzFjux8qOLH9niaryOAeuKPxYBkQ6/Q+4ZJ0ubOeb3uk85/q 72J+UtAt07X1CTqbI8lD+a4mu+SZw55ojwkh70pM6ye3iO3zm/3ctzb4jWPMEUPU f/QC7dSi2ZvMx5ItwB/4wYPXkycuj8AQYPfoqtMpSju9q7E4u2fh2PIYWWoCNMXo 2v2lIjo2f79LrEwR2yGerTnUN15pJg== =wKGH -----END PGP SIGNATURE----- --=-=-=--