GNU bug report logs - #40097
28.0.50; Preferred font ignored for specific charset

Previous Next

Full log

Message #38 received at 40097 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: sorganov <at> gmail.com, 40097 <at> debbugs.gnu.org
Subject: Re: bug#40097: 28.0.50; Preferred font ignored for specific charset
Date: Wed, 18 Mar 2020 21:47:19 +0100

[Message part 1 (text/plain, inline)]

>>>>> On Wed, 18 Mar 2020 20:18:11 +0200, Eli Zaretskii <eliz <at> gnu.org> said:

    >> From: Robert Pluim <rpluim <at> gmail.com>
    >> Cc: sorganov <at> gmail.com,  handa <at> gnu.org,  40097 <at> debbugs.gnu.org
    >> Date: Wed, 18 Mar 2020 17:28:47 +0100
    >> 
    >> ftfont.c:
    >> 
    >> { "windows-1251", { 0x0401, 0x0490 }, "ru"},
    >> 
    >> Thread 1 "emacs" hit Breakpoint 3, ftfont_get_charset (registry=XIL(0x394540)) at ftfont.c:486
    >> 486	  for (i = j = 0; i < SBYTES (SYMBOL_NAME (registry)); i++, j++)
    >> (gdb) pp registry
    >> microsoft-cp1251
    >> (gdb) 
    >> 
    >> So correcting the name of the registry in ftfont.c fixes this.

    Eli> You mean, fixing that makes DejaVu Sans Mono be used in this case?

Yes.

    Eli> That's great, let's fix this in emacs-27 then.

If you want me to be conservative, I could *add* a microsoft-cp1251
entry instead of replacing windows-1251, but as far as I know
windows-1251 is not a valid registry name.

[0001-Use-correct-registry-name-for-windows-1251-charset.patch (text/x-patch, inline)]

From c0001bb3cd097809f152fe9ca985aa319a957678 Mon Sep 17 00:00:00 2001
From: Robert Pluim <rpluim <at> gmail.com>
Date: Wed, 18 Mar 2020 21:37:55 +0100
Subject: [PATCH] Use correct registry name for windows-1251 charset
To: emacs-devel <at> gnu.org

* src/ftfont.c (fc_charset_table): The registry to use to lookup
windows-1251 charset is microsoft-cp1251, not windows-1251.
(Bug#40097)
---
 src/ftfont.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ftfont.c b/src/ftfont.c
index 2b442ead4b..6b549c3ddf 100644
--- a/src/ftfont.c
+++ b/src/ftfont.c
@@ -119,7 +119,7 @@ #define SYMBOL_FcChar8(SYM) (FcChar8 *) SDATA (SYMBOL_NAME (SYM))
     { "jisx0213.2004-1", { 0x20B9F }},
     { "viscii1.1-1", { 0x1EA0, 0x1EAE, 0x1ED2 }, "vi"},
     { "tis620.2529-1", { 0x0E01 }, "th"},
-    { "windows-1251", { 0x0401, 0x0490 }, "ru"},
+    { "microsoft-cp1251", { 0x0401, 0x0490 }, "ru"},
     { "koi8-r", { 0x0401, 0x2219 }, "ru"},
     { "mulelao-1", { 0x0E81 }, "lo"},
     { "unicode-sip", { 0x20000 }},
-- 
2.19.1.816.gcd69ec8cde

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.