GNU bug report logs - #40083
[PATCH] gnu: Add blktrace.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Vincent Legoll <vincent.legoll <at> gmail.com>
Subject: bug#40083: closed (Re: [bug#40083] [PATCH] gnu: Add blktrace.)
Date: Fri, 20 Mar 2020 17:36:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#40083: [PATCH] gnu: Add blktrace.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 40083 <at> debbugs.gnu.org.

-- 
40083: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40083
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Marius Bakke <mbakke <at> fastmail.com>
To: Vincent Legoll <vincent.legoll <at> gmail.com>
Cc: 40083-done <at> debbugs.gnu.org, Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [bug#40083] [PATCH] gnu: Add blktrace.
Date: Fri, 20 Mar 2020 18:35:50 +0100

[Message part 3 (text/plain, inline)]

Vincent Legoll <vincent.legoll <at> gmail.com> writes:

> Is that better ?

LGTM.

> I intend to submit the rmtree patch (along a bunch of other cleanups)
> to upstream, will update guix packaging when that will happen...

Great!

[...]
  
> +(define-public blktrace
> +  (let ((commit "f4f8ef7cdea138cfaa2f3ca0ee31fa23d3bcf1cc")
> +        (revision "0"))

I added a comment about why we take this commit instead of the latest
tagged version.

[...]

> +           (add-after 'unpack 'fix-gnuplot-path
> +             (lambda* (#:key inputs #:allow-other-keys)
> +               (let ((gnuplot (assoc-ref inputs "gnuplot")))
> +                 (substitute* "btt/bno_plot.py"
> +                   (("gnuplot %s")
> +                    (string-append gnuplot "/bin/gnuplot %s")))))))))

...and ended this phase on a #t.

Applied!

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add blktrace.
Date: Sun, 15 Mar 2020 21:52:18 +0100

[Message part 6 (text/plain, inline)]

Lightly tested on qemu VM, seems working OK

-- 
Vincent Legoll

[0001-gnu-Add-blktrace.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.