GNU bug report logs - #40083
[PATCH] gnu: Add blktrace.

Previous Next

Full log

Message #14 received at 40083 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Vincent Legoll <vincent.legoll <at> gmail.com>
Cc: 40083 <at> debbugs.gnu.org
Subject: Re: [bug#40083] [PATCH] gnu: Add blktrace.
Date: Thu, 19 Mar 2020 15:04:59 +0100

[Message part 1 (text/plain, inline)]

Hi!

Vincent Legoll <vincent.legoll <at> gmail.com> skribis:

> Dunno what to do about the packaged .py scripts, Should I patch the
> shebang ? ("#! /usr/bin/env python") after adding python to inputs ?

Just do something like this:

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index d19c20d056..0822748968 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4036,7 +4036,8 @@ applications.")
          #:phases
          (modify-phases %standard-phases (delete 'configure)))) ; no configure script
       (inputs
-       `(("libaio" ,libaio)))
+       `(("libaio" ,libaio)
+         ("python" ,python-wrapper)))             ;for 'bno_plot.py'
       (synopsis "Block layer IO tracing mechanism")
       (description "Blktrace is a block layer IO tracing mechanism which provides
 detailed information about request queue operations to user space.  It extracts

[Message part 3 (text/plain, inline)]

and the .py files will be automatically patched.

However, ‘bno_plot.py’ refers to /bin/rm and gnuplot, and these
references should probably be replaced with absolute file names.

Could you take a look and send an updated patch?

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.