From unknown Sun Jun 15 08:59:29 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40060] [PATCH 0/2] youtube-dl add ffmpeg, pycryptodome and zsh-completion Resent-From: Brice Waegeneire Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 14 Mar 2020 14:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 40060 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 40060@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15841964736338 (code B ref -1); Sat, 14 Mar 2020 14:35:01 +0000 Received: (at submit) by debbugs.gnu.org; 14 Mar 2020 14:34:33 +0000 Received: from localhost ([127.0.0.1]:33812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jD7s0-0001eA-Qn for submit@debbugs.gnu.org; Sat, 14 Mar 2020 10:34:33 -0400 Received: from lists.gnu.org ([209.51.188.17]:41926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jD7ry-0001e2-QG for submit@debbugs.gnu.org; Sat, 14 Mar 2020 10:34:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48692) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jD7rx-0005T9-Sx for guix-patches@gnu.org; Sat, 14 Mar 2020 10:34:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_05,RCVD_IN_DNSWL_LOW autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jD7rw-00027A-Ja for guix-patches@gnu.org; Sat, 14 Mar 2020 10:34:29 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:38073) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jD7rw-00025V-E5 for guix-patches@gnu.org; Sat, 14 Mar 2020 10:34:28 -0400 X-Originating-IP: 78.237.113.178 Received: from localhost (luy13-1-78-237-113-178.fbx.proxad.net [78.237.113.178]) (Authenticated sender: brice@waegenei.re) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 70BDAE0005 for ; Sat, 14 Mar 2020 14:34:23 +0000 (UTC) From: Brice Waegeneire Date: Sat, 14 Mar 2020 15:34:18 +0100 Message-Id: <20200314143418.13963-1-brice@waegenei.re> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 217.70.183.196 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Brice Waegeneire (2): gnu: youtube-dl: Use ffmpeg and pycryptodome gnu: youtube-dl: Add zsh completion gnu/packages/video.scm | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) -- 2.25.0 From unknown Sun Jun 15 08:59:29 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40060] [PATCH 1/2] gnu: youtube-dl: Use ffmpeg and pycryptodome Resent-From: Brice Waegeneire Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 14 Mar 2020 14:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40060 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 40060@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15841969587029 (code B ref -1); Sat, 14 Mar 2020 14:43:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Mar 2020 14:42:38 +0000 Received: from localhost ([127.0.0.1]:33818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jD7zp-0001pD-LL for submit@debbugs.gnu.org; Sat, 14 Mar 2020 10:42:38 -0400 Received: from lists.gnu.org ([209.51.188.17]:51560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jD7zn-0001p4-PE for submit@debbugs.gnu.org; Sat, 14 Mar 2020 10:42:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52955) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jD7zm-0006Rw-Jk for guix-patches@gnu.org; Sat, 14 Mar 2020 10:42:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jD7zi-0006ai-Sc for guix-patches@gnu.org; Sat, 14 Mar 2020 10:42:32 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:52389) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jD7zh-0006PZ-Bc for guix-patches@gnu.org; Sat, 14 Mar 2020 10:42:29 -0400 X-Originating-IP: 78.237.113.178 Received: from localhost (luy13-1-78-237-113-178.fbx.proxad.net [78.237.113.178]) (Authenticated sender: brice@waegenei.re) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 41B101BF204 for ; Sat, 14 Mar 2020 14:42:25 +0000 (UTC) From: Brice Waegeneire Date: Sat, 14 Mar 2020 15:42:20 +0100 Message-Id: <20200314144221.17112-1-brice@waegenei.re> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200314143418.13963-1-brice@waegenei.re> References: <20200314143418.13963-1-brice@waegenei.re> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 217.70.183.201 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/video.scm (youtube-dl)[arguments]: Add phase wrap-executable. [inputs]: Add ffmpeg. [propagated-inputs]: Add python-pycryptodome. --- gnu/packages/video.scm | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 074a1235a3..4ca037532f 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -37,6 +37,7 @@ ;;; Copyright © 2019 Riku Viitanen ;;; Copyright © 2020 Oleg Pykhalov ;;; Copyright © 2020 Josh Holland +;;; Copyright © 2020 Brice Waegeneire ;;; ;;; This file is part of GNU Guix. ;;; @@ -1580,7 +1581,19 @@ To load this plugin, specify the following option when starting mpv: (string-append "'" prefix "/etc/")) (("'share/") (string-append "'" prefix "/share/"))) - #t)))))) + #t))) + (add-after 'install 'wrap-executable + (lambda* (#:key inputs outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out")) + (ffmpeg (assoc-ref inputs "ffmpeg"))) + (wrap-program (string-append out "/bin/youtube-dl") + `("PATH" ":" prefix + ,(list (string-append ffmpeg "/bin"))))) + #t))))) + (inputs + `(("ffmpeg" ,ffmpeg))) + (propagated-inputs + `(("python-pycryptodome" ,python-pycryptodome))) (synopsis "Download videos from YouTube.com and other sites") (description "Youtube-dl is a small command-line program to download videos from -- 2.25.0 From unknown Sun Jun 15 08:59:29 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40060] [PATCH 2/2] gnu: youtube-dl: Add zsh completion Resent-From: Brice Waegeneire Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 14 Mar 2020 14:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40060 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 40060@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15841969607037 (code B ref -1); Sat, 14 Mar 2020 14:43:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Mar 2020 14:42:40 +0000 Received: from localhost ([127.0.0.1]:33820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jD7zr-0001pR-PI for submit@debbugs.gnu.org; Sat, 14 Mar 2020 10:42:39 -0400 Received: from lists.gnu.org ([209.51.188.17]:49452) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jD7zp-0001pC-HG for submit@debbugs.gnu.org; Sat, 14 Mar 2020 10:42:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52972) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jD7zo-0006S0-85 for guix-patches@gnu.org; Sat, 14 Mar 2020 10:42:37 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_05,RCVD_IN_DNSWL_LOW autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jD7zm-0006jK-IU for guix-patches@gnu.org; Sat, 14 Mar 2020 10:42:35 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:42393) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jD7zj-0006aB-Gz for guix-patches@gnu.org; Sat, 14 Mar 2020 10:42:32 -0400 X-Originating-IP: 78.237.113.178 Received: from localhost (luy13-1-78-237-113-178.fbx.proxad.net [78.237.113.178]) (Authenticated sender: brice@waegenei.re) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 96EB540005 for ; Sat, 14 Mar 2020 14:42:29 +0000 (UTC) From: Brice Waegeneire Date: Sat, 14 Mar 2020 15:42:21 +0100 Message-Id: <20200314144221.17112-2-brice@waegenei.re> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200314143418.13963-1-brice@waegenei.re> References: <20200314143418.13963-1-brice@waegenei.re> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 217.70.183.194 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/video.scm (youtube-dl)[arguments]: Add phase install-completion. --- gnu/packages/video.scm | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 4ca037532f..38f376c7e4 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -1582,6 +1582,15 @@ To load this plugin, specify the following option when starting mpv: (("'share/") (string-append "'" prefix "/share/"))) #t))) + (add-after 'install 'install-completion + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (zsh (string-append out + "/share/zsh/site-functions"))) + (mkdir-p zsh) + (copy-file "youtube-dl.zsh" + (string-append zsh "/_youtube-dl")) + #t))) (add-after 'install 'wrap-executable (lambda* (#:key inputs outputs #:allow-other-keys) (let ((out (assoc-ref outputs "out")) -- 2.25.0 From unknown Sun Jun 15 08:59:29 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40060] [PATCH 1/2] gnu: youtube-dl: Use ffmpeg and pycryptodome Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 14 Mar 2020 17:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40060 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brice Waegeneire Cc: 40060@debbugs.gnu.org Received: via spool by 40060-submit@debbugs.gnu.org id=B40060.158420648528831 (code B ref 40060); Sat, 14 Mar 2020 17:22:02 +0000 Received: (at 40060) by debbugs.gnu.org; 14 Mar 2020 17:21:25 +0000 Received: from localhost ([127.0.0.1]:33901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDATV-0007Ux-4p for submit@debbugs.gnu.org; Sat, 14 Mar 2020 13:21:25 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:38147) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDATS-0007Ui-Hp for 40060@debbugs.gnu.org; Sat, 14 Mar 2020 13:21:23 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 9F2CBA6; Sat, 14 Mar 2020 13:21:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 14 Mar 2020 13:21:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=tbqPi6gs+8ACX3tiRcOODlnF 4LsNT/1KcG0ObxJVBds=; b=AyS4nnbb5bMm177EryF18a6Y0sja0HU7hUTX4u8f yJvbqmoQF1TsFwXGkIqeokdGR3qq7k2OJE1yw+9F/QWqefJ1DpZoakhUt2XhYMyq AQKhL8QPDVdqFux/m1EQ94guFqrnmBtH7Dh8kIZYsmgJNpexHt9Lyb/lb+y4tKGS hVQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=tbqPi6 gs+8ACX3tiRcOODlnF4LsNT/1KcG0ObxJVBds=; b=0fHr3myaU2mvpjIzHw+sr0 6p85EV4oqmOAuJUZB9MgyWhhqO3ALU1Y6nXZLC+7Z8lVIHAqLw3PeyIIjmmjOPGF Jck3PH97maLlMiOIOyutqQQrjljCYakJqmg2duTwzCZIku1eq/+d4r1rygraImRR p5dSTQRwGha0ROVj6K4MqmdyHYxXnUvECEwvnixZ+mMdi77S9OxjuILMkdTQ0hVc dxSVegA9s1h1fxF8042ukqDsgD9sTPnTbu1uBkd0BXKFBxuXZ6DEhT9lpnuMF3BG JWQ+fky4lrDutBIFAOViBamazn2/N/CHLRi+g+7YuSQ0EqpvJYYpfmnVjuZwq1MQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedruddvledguddtudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecukfhppeejie druddvgedrudefkedrieefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehm rghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (c-76-124-138-63.hsd1.pa.comcast.net [76.124.138.63]) by mail.messagingengine.com (Postfix) with ESMTPA id B9345328005A; Sat, 14 Mar 2020 13:21:15 -0400 (EDT) Date: Sat, 14 Mar 2020 13:21:14 -0400 From: Leo Famulari Message-ID: <20200314172114.GA23019@jasmine.lan> References: <20200314143418.13963-1-brice@waegenei.re> <20200314144221.17112-1-brice@waegenei.re> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200314144221.17112-1-brice@waegenei.re> X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sat, Mar 14, 2020 at 03:42:20PM +0100, Brice Waegeneire wrote: > * gnu/packages/video.scm (youtube-dl)[arguments]: Add phase > wrap-executable. > [inputs]: Add ffmpeg. > [propagated-inputs]: Add python-pycryptodome. What do these added dependencies do? From unknown Sun Jun 15 08:59:29 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40060] [PATCH 1/2] gnu: youtube-dl: Use ffmpeg and pycryptodome Resent-From: Brice Waegeneire Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 14 Mar 2020 17:40:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40060 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 40060@debbugs.gnu.org, Guix-patches Received: via spool by 40060-submit@debbugs.gnu.org id=B40060.158420760230583 (code B ref 40060); Sat, 14 Mar 2020 17:40:03 +0000 Received: (at 40060) by debbugs.gnu.org; 14 Mar 2020 17:40:02 +0000 Received: from localhost ([127.0.0.1]:33933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDAlV-0007xC-MJ for submit@debbugs.gnu.org; Sat, 14 Mar 2020 13:40:01 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:53025) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDAlT-0007ww-HI for 40060@debbugs.gnu.org; Sat, 14 Mar 2020 13:40:00 -0400 Received: from webmail.gandi.net (webmail18.sd4.0x35.net [10.200.201.18]) (Authenticated sender: brice@waegenei.re) by relay4-d.mail.gandi.net (Postfix) with ESMTPA id 97999E000C; Sat, 14 Mar 2020 17:39:50 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 14 Mar 2020 17:39:50 +0000 From: Brice Waegeneire In-Reply-To: <20200314172114.GA23019@jasmine.lan> References: <20200314143418.13963-1-brice@waegenei.re> <20200314144221.17112-1-brice@waegenei.re> <20200314172114.GA23019@jasmine.lan> Message-ID: X-Sender: brice@waegenei.re User-Agent: Roundcube Webmail/1.3.8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2020-03-14 17:21, Leo Famulari wrote: > On Sat, Mar 14, 2020 at 03:42:20PM +0100, Brice Waegeneire wrote: >> * gnu/packages/video.scm (youtube-dl)[arguments]: Add phase >> wrap-executable. >> [inputs]: Add ffmpeg. >> [propagated-inputs]: Add python-pycryptodome. > > What do these added dependencies do? I should have written this in the cover-letter, my bad. pycryptodome is needed for the hlsative downloader, ffmpeg adds the ability to merge video and audio files downloaded separately by youtube-dl and removes the following warning: WARNING: You have requested multiple formats but ffmpeg or avconv are not installed. The formats won't be merged. Have a look in the NixOS derivation for more information on dependencies: https://github.com/NixOS/nixpkgs/blob/86a085cd4690d497c487d5090fabb0bbf093e7a2/pkgs/tools/misc/youtube-dl/default.nix#L33 From unknown Sun Jun 15 08:59:29 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40060] [PATCH 1/2] gnu: youtube-dl: Use ffmpeg and pycryptodome Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 14 Mar 2020 17:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40060 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brice Waegeneire Cc: 40060@debbugs.gnu.org Received: via spool by 40060-submit@debbugs.gnu.org id=B40060.158420806731283 (code B ref 40060); Sat, 14 Mar 2020 17:48:02 +0000 Received: (at 40060) by debbugs.gnu.org; 14 Mar 2020 17:47:47 +0000 Received: from localhost ([127.0.0.1]:33939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDAt1-00088V-GU for submit@debbugs.gnu.org; Sat, 14 Mar 2020 13:47:47 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:40101) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDAsz-00088H-6Q for 40060@debbugs.gnu.org; Sat, 14 Mar 2020 13:47:45 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 61489565; Sat, 14 Mar 2020 13:47:39 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sat, 14 Mar 2020 13:47:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=HP2aqBXo+grDd8NwN/IKX33s QacHrQ3Strqvydbdbbw=; b=epudbTFDojXV1PGbsUmcDjFWWjWRkx9TOAJB6ksd 7E+7QCXC/ArI8lkiSEUDpzIpxJyxhdnqG+jHowPFTYwKVEm5R1JAJ/egvMxuYH/O 5xkIk40LUKXZRGChENJa5H1DO6E5THUlJLCP9S1Qx67q09S+Cujx+DjUwmvm4+We u/o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=HP2aqB Xo+grDd8NwN/IKX33sQacHrQ3Strqvydbdbbw=; b=Si6+iJLTtrjsmzCnIr/R8A RIg2yDxR3XJISACNAXLdCo1was+a7KOAInt91+yNr3Tz6py7rEBvm7EjleHpF+ng XfjuHM7i9/H9mZ1AmaQ2YPMLGECJxJ5YLq5Picsa8tf2955hyagkJQWLBDPqbofV fKuHdKKC3g9UbGtA42Ku2Z3mfdIRwooNVKKPxGsqHlFqe0X+Hzt1G/IRCpkcdS0N TGMFa0ABGL6UIquZRVSl4p0Uq/FEBtu/Hly8nrQMJcaLedqSFTL/qOX0BTmjLVOy sFVApsAJ0lgd73teO11mqJuGtp7zkp24C2vCABXNzacAwn+0o1PunFgynRiAaexQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedruddvledguddtjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecukfhppeejie druddvgedrudefkedrieefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehm rghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (c-76-124-138-63.hsd1.pa.comcast.net [76.124.138.63]) by mail.messagingengine.com (Postfix) with ESMTPA id 37A19306130A; Sat, 14 Mar 2020 13:47:38 -0400 (EDT) Date: Sat, 14 Mar 2020 13:47:37 -0400 From: Leo Famulari Message-ID: <20200314174737.GA24608@jasmine.lan> References: <20200314143418.13963-1-brice@waegenei.re> <20200314144221.17112-1-brice@waegenei.re> <20200314172114.GA23019@jasmine.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sat, Mar 14, 2020 at 05:39:50PM +0000, Brice Waegeneire wrote: > I should have written this in the cover-letter, my bad. > pycryptodome is needed for the hlsative downloader, ffmpeg adds the ability > to merge video and audio files downloaded separately by youtube-dl and > removes the following warning: > WARNING: You have requested multiple formats but ffmpeg or avconv are not > installed. The formats won't be merged. What is hlsative? I guess that for FFmpeg, it looks in $PATH? This has always worked for me. But I think it's a good idea to bind them together. From unknown Sun Jun 15 08:59:29 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40060] [PATCH 1/2] gnu: youtube-dl: Use ffmpeg and pycryptodome Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 14 Mar 2020 22:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40060 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari , 40060@debbugs.gnu.org Received: via spool by 40060-submit@debbugs.gnu.org id=B40060.158422423423043 (code B ref 40060); Sat, 14 Mar 2020 22:18:01 +0000 Received: (at 40060) by debbugs.gnu.org; 14 Mar 2020 22:17:14 +0000 Received: from localhost ([127.0.0.1]:34061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDF5m-0005zb-8G for submit@debbugs.gnu.org; Sat, 14 Mar 2020 18:17:14 -0400 Received: from tobias.gr ([80.241.217.52]:39338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDF5k-0005zS-A2 for 40060@debbugs.gnu.org; Sat, 14 Mar 2020 18:17:13 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id 7376010e; Sat, 14 Mar 2020 22:17:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to :subject:references:in-reply-to:date:message-id:mime-version :content-type; s=2018; i=me@tobias.gr; bh=6Vl/xkOXSDU689BvkqNDOM mxQc5jA2zImUUcMRVStXU=; b=ab9BSwAnSm6mgdgCiLdIpB9XU1opwJdekidNOV 7Eegxd2zYp4V5+WZ4ARC41/6xJZJq+D/UdHRZh3llKhtO0iU0PbcEokt8iczlXFY exBCIkQGAl78F4hkirWCU5uixPisg3pCxu++CKUFJpOwcYbuF9iXAXG7bmPg0Y4u BrdmYfv+eo+LjhnLBiDIGkbN8qf0FWuX9kuMCpykqbw/pRSV5d+GBzy3Hraw7QHx 5dR9CKBkiH316LN+ljHMnSqaxffI/r7g7A1xkG2zrL72ntvdcW8Z+QNprQYTGpHk Mc6YAmZkegsemVjswyKfoy4F5y33MPgIoZJLQfAKKZ06blkA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id a140c57b (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO); Sat, 14 Mar 2020 22:17:10 +0000 (UTC) From: Tobias Geerinckx-Rice References: <20200314143418.13963-1-brice@waegenei.re> <20200314144221.17112-1-brice@waegenei.re> <20200314172114.GA23019@jasmine.lan> In-reply-to: Date: Sat, 14 Mar 2020 23:17:42 +0100 Message-ID: <87y2s2lgxl.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Hullo Brice, Thanks for the patch! Brice Waegeneire =E5=86=99=E9=81=93=EF=BC=9A > I should have written this in the cover-letter, my bad. > pycryptodome is needed for the hlsative downloader, ffmpeg adds=20 > the > ability to merge video and audio files downloaded separately by > youtube-dl and removes the following warning: > WARNING: You have requested multiple formats but ffmpeg or=20 > avconv are > not installed. The formats won't be merged. This message is one of the best I've seen. It clearly explains to=20 the user what's (not) going to happen, and what they can do to=20 change that *if* they want to. Hence I think adding ffmpeg as a=20 hard dependency is incorrect. (I'd also oppose a youtube-dl-full variant, by the way. Packages=20 aren't the right place for this; profiles are.) Does youtube-dl print a similarly clear message when pycryptodome=20 is needed but missing? If not, that addition LGTM with a ("pycryptodome" ,pycryptodome) ; for the hlsnative downloader comment. Cover letters & commit messages age badly. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfo+u0AlEeO9y5k0W2Imw8BjFSTwFAl5tWAYACgkQ2Imw8BjF STwJEg/+KkvVaMzy7eZytF1F/2CzmrH/8BxsTOTrMihbTI3eMlfsLn6DCQeeBCjH uZ8Dm/JDzoaiQVqt3MS1dYmoDdWGSNb5+q/EEbYyD9PLRzfPPUe7QwVHvbC4NnLG D4UYOK0mX/fNKMPUPXEJWqpCeGUaf2feqDqpTU9JDAgBBbVdMPqeMFiq70YEA/rW sp6fPoazHTmGZs01Url4a1+xpmg8+z8oGiDX1nGAnlGkNHkM5N/7+NpjEgQ+7WLN Edb8ABDyXN+ukpJ877l7zYFgS2kkckNqwNICdiHrR8neBsKoQVq+ua/sVHZAcnHP 9E3nX4IgmoCdB043Y2h4EPBuq8hL6MBH3z1C56eC3S/pJqJuGzyhMf3lE7nT8ZTF 0yaFQXJXSz9N350qo3TmfjTjNpJFOtdZjtxLoDtyjIJuzEUf4efFA0SPdWldpN+w TEAwQvDX32ygjkazPGSWr5tO1ayxm31k7N1w6Q0CgjwBU6jycrg7Beu/8GxAqUKP GU1F9Nuky0z8DUhP0yl9hadVD9vLRm6bve3cdifrsAfiK4feYTeTWCbHy2F/J9eb UUn+q52qBoSSNUj0ZzQd9LiDMak4F3aPVj+ssUJK0z5xQifrm21akswHwDQWbE8J 2d2dB4KBTemA2bKJSKT8r8P+z4/4X2hsIa/ZNIwXD4MfcB8s1f0= =hivP -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Jun 15 08:59:29 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40060] [PATCH 1/2] gnu: youtube-dl: Use ffmpeg and pycryptodome Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 14 Mar 2020 22:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40060 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 40060@debbugs.gnu.org, Brice Waegeneire Received: via spool by 40060-submit@debbugs.gnu.org id=B40060.158422440423323 (code B ref 40060); Sat, 14 Mar 2020 22:21:02 +0000 Received: (at 40060) by debbugs.gnu.org; 14 Mar 2020 22:20:04 +0000 Received: from localhost ([127.0.0.1]:34065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDF8W-000647-M2 for submit@debbugs.gnu.org; Sat, 14 Mar 2020 18:20:04 -0400 Received: from tobias.gr ([80.241.217.52]:39414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDF8U-00063c-Ig for 40060@debbugs.gnu.org; Sat, 14 Mar 2020 18:20:02 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id d581cfa8; Sat, 14 Mar 2020 22:20:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc :subject:references:in-reply-to:date:message-id:mime-version :content-type; s=2018; i=me@tobias.gr; bh=bXm0QUVwvXZzKTjHGdpaa8 HJykDqVR9/cBedt/tKZeI=; b=XeLAubSGotT2qe3zuZ46EksPKbht2ziHX1Oha6 6zxy/vwZBy0dI4FYudN3pG+xm1wT0fFKw9VfCUgAAHntT80KoDzmtFRvIqUrmMVi T/TirsbGISSvONNLeKrPLztxArDAfmkwqQaAQDPCRBqUu79/OavjGqaGKtAKdwgC 0EDpcSBJBhtWRQ6a2xrtQQ1bQMoZo9zb2B4RoH+s59TUIofrBQ+EwqF18BNtIUj4 RM013QP6O+NPXQ/rHIYqj5uA/77bfBb3BRI8zXtQTDvvp1kvOiIpFaw8/PZhx+cD 0XkTb0SXxVi0jxCOHWy3J/P1/GRWhSzTzxUvniycmech6gtw== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id df680654 (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO); Sat, 14 Mar 2020 22:19:59 +0000 (UTC) From: Tobias Geerinckx-Rice References: <20200314143418.13963-1-brice@waegenei.re> <20200314144221.17112-1-brice@waegenei.re> <20200314172114.GA23019@jasmine.lan> <20200314174737.GA24608@jasmine.lan> In-reply-to: <20200314174737.GA24608@jasmine.lan> Date: Sat, 14 Mar 2020 23:20:32 +0100 Message-ID: <87wo7mlgsv.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Leo Famulari =E5=86=99=E9=81=93=EF=BC=9A > What is hlsative? hlsnative, it's a =E2=80=98limited [HLS] implementation that does not=20 require ffmpeg.=E2=80=99[0] Kind regards, T G-R [0]:=20 https://github.com/ytdl-org/youtube-dl/blob/master/youtube_dl/downloader/hl= s.py#L25 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfo+u0AlEeO9y5k0W2Imw8BjFSTwFAl5tWLAACgkQ2Imw8BjF STwOeg/9G75z+8UcgEsTWywjQ9A0KRWL0ngp+M1buXAgP1rBRtamsGGEI/SajryV VM80zr/RNH9Jnd+M+htI+ec5NIA/g579+fksWz8cDknIYUKVpK32V6l7yhT+xe7m 4iVr7jHPHCxWCNdiKWyUnFEc6bQwwFJo78zdUxccKwincsLWLmxsY/0adnkYXgjX jyItX1g7q26vqUFiqC0R8nJQhb3Cu+mhhMs3baUoZko4SVuUucczu3/Hoa0b8mgn 1J3n9h1CZDKLtDPZT5tW2mLZV0xbkB6mIg09Sr/jgQnDWTSbEDFHF9wXCqcQDDa8 O5VoTLNJ8xw6iHo1QiFmWeG37cbfdL45c9JsYeA0S/NEM0DghFn3fY2tWgMRAdY9 CIZHtvGwHiq3S9S/H+yauFOKYcZC4FDjX9uoAqEfgV0BcNt7bF0ersRFyRNr+m4j cdeVVJKS6iFnYrPQ9xBpphG4/u1zfhYwR9MfOeL3B8hRSMBucHwmMID9bUq6KAon oKdMN1Gx7x90HouSt7gc5SUpmTp+ELCUqqIoa12FODJI6JXUGMKa49JrwwIzTvm4 u1mKgOGrDzn/jMbM/kJLLK1ElMmB47t8iOdhQKjA+YIFFUpiGM4I4rGZ1osBbdL6 hzoCK0ObqanxNV6d3zgX32jlEkGCchnSaLlyLH2ySvuv8dl/04E= =ZXwt -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Jun 15 08:59:29 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40060] [PATCH 1/2] gnu: youtube-dl: Use ffmpeg and pycryptodome Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 15 Mar 2020 17:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40060 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tobias Geerinckx-Rice Cc: 40060@debbugs.gnu.org Received: via spool by 40060-submit@debbugs.gnu.org id=B40060.15842931229329 (code B ref 40060); Sun, 15 Mar 2020 17:26:02 +0000 Received: (at 40060) by debbugs.gnu.org; 15 Mar 2020 17:25:22 +0000 Received: from localhost ([127.0.0.1]:35440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDX0s-0002QP-4y for submit@debbugs.gnu.org; Sun, 15 Mar 2020 13:25:22 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:58951) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDX0q-0002QC-E2 for 40060@debbugs.gnu.org; Sun, 15 Mar 2020 13:25:20 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 594AA220B8; Sun, 15 Mar 2020 13:25:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 15 Mar 2020 13:25:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=mesmtp; bh=gKTDe3FGayFGAGousa6UJ4kEKtRUxpnBtAwehbeLZKE=; b=Y3VuthqCfpI/ p6jMO2ctXM5Q+O3EwnSozuN0fmlJPO7YvCKho1gdXMNeN35Ue4Keh6GfjdUwe1xE 40Z42KRW0D7QiXveTQ3w4Lk26023aptSI7corOHH/oMKGbaAHnmDFkWMm/69acgZ VLqHSHijrtCyFuCxqjRZyiKvI+ckp2Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=gKTDe3FGayFGAGousa6UJ4kEKtRUxpnBtAwehbeLZ KE=; b=k2WQsd5zKcVC2FYwcOq4PWPyyI1ACFuqqdvs3lG5HAhWcCk6GpzBEXOsO sGwB74ZiX6M2as7qUMJ6QZ6Lpz1ZBmcmA+zwXRdgxV+Tzu6xQAD0CHOxciaC2GHY mriZ8QUACOA+EuxHg50cnhIUlpimEVYMb+7Aaf3NcxaWbTHwuKR4KKwHc7p2oJRP UWCNeBsurIgriucAr6tSomsHNX8i6oMgGSxSEWxoA0avNvuHITX1G6FMyeFwFX0W x5TNbAw+pqrVTapkm3XPmvi+XFqlUdN0bpHapKPqzCVP4oEB6/tWK//4lfCXMogi qgIId5h0TM+Lwsu/InUC4sN7y68fw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudefuddgtdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggugfgjsehtqh ertddttdejnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhl rghrihdrnhgrmhgvqeenucfkphepjeeirdduvdegrddufeekrdeifeenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghr ihdrnhgrmhgv X-ME-Proxy: Received: from localhost (c-76-124-138-63.hsd1.pa.comcast.net [76.124.138.63]) by mail.messagingengine.com (Postfix) with ESMTPA id 93344328005E; Sun, 15 Mar 2020 13:25:14 -0400 (EDT) Date: Sun, 15 Mar 2020 13:25:13 -0400 From: Leo Famulari Message-ID: <20200315172513.GB26892@jasmine.lan> References: <20200314143418.13963-1-brice@waegenei.re> <20200314144221.17112-1-brice@waegenei.re> <20200314172114.GA23019@jasmine.lan> <87y2s2lgxl.fsf@nckx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <87y2s2lgxl.fsf@nckx> X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sat, Mar 14, 2020 at 11:17:42PM +0100, Tobias Geerinckx-Rice wrote: > Brice Waegeneire =E5=86=99=E9=81=93=EF=BC=9A > > I should have written this in the cover-letter, my bad. > > pycryptodome is needed for the hlsative downloader, ffmpeg adds the > > ability to merge video and audio files downloaded separately by > > youtube-dl and removes the following warning: > > WARNING: You have requested multiple formats but ffmpeg or avconv are > > not installed. The formats won't be merged. >=20 > This message is one of the best I've seen. It clearly explains to the us= er > what's (not) going to happen, and what they can do to change that *if* th= ey > want to. Hence I think adding ffmpeg as a hard dependency is incorrect. I see your point of view, and I also have FFmpeg installed manually because I use it frequently in my work. I guess it depends on how many people are experiencing the issue that Brice is having. From unknown Sun Jun 15 08:59:29 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40060] [PATCH 1/2] gnu: youtube-dl: Use ffmpeg and pycryptodome Resent-From: Brice Waegeneire Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 17 Mar 2020 09:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40060 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: me@tobias.gr, 40060@debbugs.gnu.org X-Debbugs-Original-To: Tobias Geerinckx-Rice , Tobias Geerinckx-Rice via Guix-patches Received: via spool by submit@debbugs.gnu.org id=B.158443602723185 (code B ref -1); Tue, 17 Mar 2020 09:08:01 +0000 Received: (at submit) by debbugs.gnu.org; 17 Mar 2020 09:07:07 +0000 Received: from localhost ([127.0.0.1]:38172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jE8Bm-00061t-Pp for submit@debbugs.gnu.org; Tue, 17 Mar 2020 05:07:07 -0400 Received: from lists.gnu.org ([209.51.188.17]:58161) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jE8Bl-00061l-5f for submit@debbugs.gnu.org; Tue, 17 Mar 2020 05:07:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42523) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jE8Bj-0007i5-PU for guix-patches@gnu.org; Tue, 17 Mar 2020 05:07:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jE8Bi-0006AX-7E for guix-patches@gnu.org; Tue, 17 Mar 2020 05:07:03 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:54415) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jE8Bi-0005bw-0l for guix-patches@gnu.org; Tue, 17 Mar 2020 05:07:02 -0400 Received: from webmail.gandi.net (webmail18.sd4.0x35.net [10.200.201.18]) (Authenticated sender: brice@waegenei.re) by relay5-d.mail.gandi.net (Postfix) with ESMTPA id D0BC11C0007; Tue, 17 Mar 2020 09:06:57 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Tue, 17 Mar 2020 09:06:57 +0000 From: Brice Waegeneire In-Reply-To: <87y2s2lgxl.fsf@nckx> References: <20200314143418.13963-1-brice@waegenei.re> <20200314144221.17112-1-brice@waegenei.re> <20200314172114.GA23019@jasmine.lan> <87y2s2lgxl.fsf@nckx> Message-ID: X-Sender: brice@waegenei.re User-Agent: Roundcube Webmail/1.3.8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 217.70.183.197 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2020-03-14 22:17, Tobias Geerinckx-Rice via Guix-patches via wrote: > Brice Waegeneire 写道: >> WARNING: You have requested multiple formats but ffmpeg or avconv are >> not installed. The formats won't be merged. NOTE: This message appear when using a format option like this ='bestvideo[height<=320]+bestaudio'=. > This message is one of the best I've seen. It clearly explains to the > user what's (not) going to happen, and what they can do to change that > *if* they want to. Hence I think adding ffmpeg as a hard dependency > is incorrect. What about this one? #+begin_src sh $ youtue-dl https://www.youtube.com/watch\?v\=dp8PhLsUcFE [youtube] dp8PhLsUcFE: Downloading webpage [youtube] dp8PhLsUcFE: Downloading m3u8 information [youtube] dp8PhLsUcFE: Downloading MPD manifest [download] Destination: Bloomberg Global Financial News-dp8PhLsUcFE.mp4 ERROR: m3u8 download detected but ffmpeg or avconv could not be found. Please install one. #+end_src When downloading a live stream from youtube.com (and proabably others), ~youtube-dl~ needs ffmpeg to download the HLS stream – I tried with just ~pycryptodome~ and it doesn't work. > (I'd also oppose a youtube-dl-full variant, by the way. Packages > aren't the right place for this; profiles are.) > > Does youtube-dl print a similarly clear message when pycryptodome is > needed but missing? If not, that addition LGTM with a > > ("pycryptodome" ,pycryptodome) ; for the hlsnative downloader #+begin_src sh $ youtube-dl http://www.ivi.ru/watch/146500 [ivi] 146500: Downloading video JSON ERROR: pycryptodomex not found. Please install it. #+end_src #+begin_src python self.report_error('pycrypto not found. Please install it.') #+end_src I digged a little deeper about this dependency, ~pycryptodome~ replace the deprecated ~pycrypto~ library with the same name space (=Crypto=) while ~pycryptodomex~ uses it's own name space (=Cryptodome=) to provide similar functionality. #+begin_src python self.report_warning( 'hlsnative has detected features it does not support, ' 'extraction will be delegated to ffmpeg') #+end_src So I'm not sure if adding ~pycryptodome(x)~ is that useful after all. Especially if it can't totally replace ~ffmpeg~ when donating HLS streams. > comment. Cover letters & commit messages age badly. Noted. I think ~ffmpeg~ should be an input of ~youtube-dl~ while ~pycrytodome(x)~ don't need to since most (except the ivi downloader it seems) functionality can be achieved with ~ffmpeg~. WDYT? From unknown Sun Jun 15 08:59:29 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40060] [PATCH v2 0/2] youtube-dl add ffmpeg and zsh-completion Resent-From: Brice Waegeneire Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 23 Mar 2020 17:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40060 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 40060@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15849837194658 (code B ref -1); Mon, 23 Mar 2020 17:16:01 +0000 Received: (at submit) by debbugs.gnu.org; 23 Mar 2020 17:15:19 +0000 Received: from localhost ([127.0.0.1]:53458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGQfW-0001D3-Jv for submit@debbugs.gnu.org; Mon, 23 Mar 2020 13:15:18 -0400 Received: from lists.gnu.org ([209.51.188.17]:58800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGQfU-0001Cj-Ex for submit@debbugs.gnu.org; Mon, 23 Mar 2020 13:15:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47456) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGQfS-0000gI-Ji for guix-patches@gnu.org; Mon, 23 Mar 2020 13:15:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGQfR-0007Q5-5L for guix-patches@gnu.org; Mon, 23 Mar 2020 13:15:14 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:41477) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jGQfQ-0007Jr-Ub for guix-patches@gnu.org; Mon, 23 Mar 2020 13:15:13 -0400 X-Originating-IP: 78.237.113.178 Received: from localhost (luy13-1-78-237-113-178.fbx.proxad.net [78.237.113.178]) (Authenticated sender: brice@waegenei.re) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id E110E1C0007 for ; Mon, 23 Mar 2020 17:15:09 +0000 (UTC) From: Brice Waegeneire Date: Mon, 23 Mar 2020 18:15:00 +0100 Message-Id: <20200323171502.3147-1-brice@waegenei.re> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200314143418.13963-1-brice@waegenei.re> References: <20200314143418.13963-1-brice@waegenei.re> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 217.70.183.197 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Remove pycryptodome since ffmpeg is enought for accessing HLS streams. Brice Waegeneire (2): gnu: youtube-dl: Add 'ffmpeg' as input. gnu: youtube-dl: Add zsh completion. gnu/packages/video.scm | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) base-commit: d3e7282ec35d87842e8143f0230e27fd5ec5e74d -- 2.25.1 From unknown Sun Jun 15 08:59:29 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40060] [PATCH v2 2/2] gnu: youtube-dl: Add zsh completion. Resent-From: Brice Waegeneire Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 23 Mar 2020 17:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40060 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 40060@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15849837194665 (code B ref -1); Mon, 23 Mar 2020 17:16:02 +0000 Received: (at submit) by debbugs.gnu.org; 23 Mar 2020 17:15:19 +0000 Received: from localhost ([127.0.0.1]:53460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGQfW-0001D5-TS for submit@debbugs.gnu.org; Mon, 23 Mar 2020 13:15:19 -0400 Received: from lists.gnu.org ([209.51.188.17]:39238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGQfU-0001Ck-FT for submit@debbugs.gnu.org; Mon, 23 Mar 2020 13:15:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47469) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGQfS-0000iZ-Rt for guix-patches@gnu.org; Mon, 23 Mar 2020 13:15:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGQfR-0007Rr-Ml for guix-patches@gnu.org; Mon, 23 Mar 2020 13:15:14 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:48963) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jGQfR-0007P6-GS for guix-patches@gnu.org; Mon, 23 Mar 2020 13:15:13 -0400 X-Originating-IP: 78.237.113.178 Received: from localhost (luy13-1-78-237-113-178.fbx.proxad.net [78.237.113.178]) (Authenticated sender: brice@waegenei.re) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 0BFB71C0003 for ; Mon, 23 Mar 2020 17:15:11 +0000 (UTC) From: Brice Waegeneire Date: Mon, 23 Mar 2020 18:15:02 +0100 Message-Id: <20200323171502.3147-3-brice@waegenei.re> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200323171502.3147-1-brice@waegenei.re> References: <20200314143418.13963-1-brice@waegenei.re> <20200323171502.3147-1-brice@waegenei.re> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 217.70.183.197 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/video.scm (youtube-dl)[arguments]: Add phase install-completion. --- gnu/packages/video.scm | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 3b64c435b7..cb575a7375 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -1673,6 +1673,15 @@ To load this plugin, specify the following option when starting mpv: (("'share/") (string-append "'" prefix "/share/"))) #t))) + (add-after 'install 'install-completion + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (zsh (string-append out + "/share/zsh/site-functions"))) + (mkdir-p zsh) + (copy-file "youtube-dl.zsh" + (string-append zsh "/_youtube-dl")) + #t))) (add-after 'install 'wrap-executable (lambda* (#:key inputs outputs #:allow-other-keys) (let ((out (assoc-ref outputs "out")) -- 2.25.1 From unknown Sun Jun 15 08:59:29 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40060] [PATCH v2 1/2] gnu: youtube-dl: Add 'ffmpeg' as input. Resent-From: Brice Waegeneire Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 23 Mar 2020 17:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40060 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 40060@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15849837194672 (code B ref -1); Mon, 23 Mar 2020 17:16:02 +0000 Received: (at submit) by debbugs.gnu.org; 23 Mar 2020 17:15:19 +0000 Received: from localhost ([127.0.0.1]:53462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGQfX-0001DC-6v for submit@debbugs.gnu.org; Mon, 23 Mar 2020 13:15:19 -0400 Received: from lists.gnu.org ([209.51.188.17]:51306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGQfV-0001Cv-8V for submit@debbugs.gnu.org; Mon, 23 Mar 2020 13:15:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47470) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGQfS-0000ia-SI for guix-patches@gnu.org; Mon, 23 Mar 2020 13:15:17 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGQfR-0007RR-Js for guix-patches@gnu.org; Mon, 23 Mar 2020 13:15:14 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:46159) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jGQfR-0007OI-DL for guix-patches@gnu.org; Mon, 23 Mar 2020 13:15:13 -0400 X-Originating-IP: 78.237.113.178 Received: from localhost (luy13-1-78-237-113-178.fbx.proxad.net [78.237.113.178]) (Authenticated sender: brice@waegenei.re) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 1D5151BF20E for ; Mon, 23 Mar 2020 17:15:10 +0000 (UTC) From: Brice Waegeneire Date: Mon, 23 Mar 2020 18:15:01 +0100 Message-Id: <20200323171502.3147-2-brice@waegenei.re> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200323171502.3147-1-brice@waegenei.re> References: <20200314143418.13963-1-brice@waegenei.re> <20200323171502.3147-1-brice@waegenei.re> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 217.70.183.201 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/video.scm (youtube-dl)[arguments]: Add phase wrap-executable. [inputs]: Add ffmpeg. --- gnu/packages/video.scm | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 38e9d36307..3b64c435b7 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -37,6 +37,7 @@ ;;; Copyright © 2019 Riku Viitanen ;;; Copyright © 2020 Oleg Pykhalov ;;; Copyright © 2020 Josh Holland +;;; Copyright © 2020 Brice Waegeneire ;;; ;;; This file is part of GNU Guix. ;;; @@ -1671,7 +1672,17 @@ To load this plugin, specify the following option when starting mpv: (string-append "'" prefix "/etc/")) (("'share/") (string-append "'" prefix "/share/"))) - #t)))))) + #t))) + (add-after 'install 'wrap-executable + (lambda* (#:key inputs outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out")) + (ffmpeg (assoc-ref inputs "ffmpeg"))) + (wrap-program (string-append out "/bin/youtube-dl") + `("PATH" ":" prefix + ,(list (string-append ffmpeg "/bin"))))) + #t))))) + (inputs + `(("ffmpeg" ,ffmpeg))) (synopsis "Download videos from YouTube.com and other sites") (description "Youtube-dl is a small command-line program to download videos from -- 2.25.1 From unknown Sun Jun 15 08:59:29 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40060] [PATCH v2 0/2] youtube-dl add ffmpeg and zsh-completion Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 23 Mar 2020 19:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40060 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 40060@debbugs.gnu.org Cc: 40060-done@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.158499170518147 (code B ref -1); Mon, 23 Mar 2020 19:29:02 +0000 Received: (at submit) by debbugs.gnu.org; 23 Mar 2020 19:28:25 +0000 Received: from localhost ([127.0.0.1]:53544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGSkK-0004id-Vp for submit@debbugs.gnu.org; Mon, 23 Mar 2020 15:28:25 -0400 Received: from lists.gnu.org ([209.51.188.17]:51419) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGSkG-0004iL-Lu for submit@debbugs.gnu.org; Mon, 23 Mar 2020 15:28:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45555) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGSkF-00008z-MT for guix-patches@gnu.org; Mon, 23 Mar 2020 15:28:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGSkD-0004Cc-Q1 for guix-patches@gnu.org; Mon, 23 Mar 2020 15:28:19 -0400 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:37221) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jGSkC-0004BZ-2o for guix-patches@gnu.org; Mon, 23 Mar 2020 15:28:17 -0400 Received: by mail-wm1-x344.google.com with SMTP id d1so853061wmb.2 for ; Mon, 23 Mar 2020 12:28:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=q3nSPYanauHJXktj5bM9EtxL57T68FEhI4u+eSqAcFk=; b=B7g02TyRLeevwYynw+RCRGk7zTnRT62Gxlt/2QOCCy/vw/9xE7dMK4ARdalpDR6XWo Maqs++mNO3Fwgp0xQ47Cd2LuvwILxAfC+m2fmkmmweV1UH3Z6WXtE3GOCiTOq8YewGgq bY+Y3cYlAJnhohLTC1HYUe1rBBRMczzHVUt08qRORuf8xONfJg+49BPUOoURTEuROHCy B27TvX+mVL0hVzZfRJ82d9qB16Gkd9Fi5kBTe0sXCKNx8uff2yTxtIytX16F0KIhHLlw QZ5lxs44S8O46+hINp3c4c3EABoodCxegmRU0ZBHcMhnoMQTvbu97lH9RQrecIP+ds46 xsfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=q3nSPYanauHJXktj5bM9EtxL57T68FEhI4u+eSqAcFk=; b=k2F4bGSJi+0n9nuA52UvPdKuTykn5Rw27o5/6ZPob+ktPQSMDPQlioycLIvl78hkuh FMw1InoS06jZt3co0igGy/uHTNieD2D1tw75CDfbPp+2z1Py9Ji5yerQP/YSF7qwTOBr zbb7eZcucFD4M04EHYvAwQDNDIj1zqLeLmzDBUbkr0AYFvlXjytQ2zeUQR/cC7WS+ibd yR4S841j8Dzyw9QOu0kpPx8QT6NPpkaTDQc3WKns03pwURZPwuNy4WWBZor1+hEVP/DW 0g+yMGGLaN3EgZaqQYfnRHo0qDVZn8AA5fWEwH48P107xRM3Fd0sRZ6I0VpGx7zdWnWN jeiw== X-Gm-Message-State: ANhLgQ31yeJHiGiP/CIznrNs3hqYP4XKYazWXyXT/Mb4EH5Lnxhu28DC uH8fWbTElAkF54VeZxQAiYL/E9Za X-Google-Smtp-Source: ADFU+vte6MDbGiGgw7cy1lmzYbDd7wcczLvJhkQHmyxxsUrOebrVbSQNxIV+r/4VCBL8lRnx4JsjoA== X-Received: by 2002:a1c:f00a:: with SMTP id a10mr1036144wmb.102.1584991693592; Mon, 23 Mar 2020 12:28:13 -0700 (PDT) Received: from cervin ([2a01:cb18:832e:5f00:a873:d253:d873:1441]) by smtp.gmail.com with ESMTPSA id u17sm26823239wra.63.2020.03.23.12.28.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2020 12:28:12 -0700 (PDT) References: <20200314143418.13963-1-brice@waegenei.re> <20200323171502.3147-1-brice@waegenei.re> User-agent: mu4e 1.2.0; emacs 26.3 From: Mathieu Othacehe In-reply-to: <20200323171502.3147-1-brice@waegenei.re> Date: Mon, 23 Mar 2020 20:28:11 +0100 Message-ID: <874kuezx9w.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::344 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hello Brice, > Remove pycryptodome since ffmpeg is enought for accessing > HLS streams. I could do not find any reference to pycryptodome, but pushed the serie as is LTGM. Thanks, Mathieu From unknown Sun Jun 15 08:59:29 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Brice Waegeneire Subject: bug#40060: closed (Re: [bug#40060] [PATCH v2 0/2] youtube-dl add ffmpeg and zsh-completion) Message-ID: References: <874kuezx9w.fsf@gmail.com> <20200314143418.13963-1-brice@waegenei.re> X-Gnu-PR-Message: they-closed 40060 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 40060@debbugs.gnu.org Date: Mon, 23 Mar 2020 19:29:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1584991742-18199-1" This is a multi-part message in MIME format... ------------=_1584991742-18199-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #40060: [PATCH 0/2] youtube-dl add ffmpeg, pycryptodome and zsh-completion which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 40060@debbugs.gnu.org. --=20 40060: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D40060 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1584991742-18199-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 40060-done) by debbugs.gnu.org; 23 Mar 2020 19:28:22 +0000 Received: from localhost ([127.0.0.1]:53542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGSkH-0004iS-Gl for submit@debbugs.gnu.org; Mon, 23 Mar 2020 15:28:21 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:33865) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGSkF-0004i9-Lw for 40060-done@debbugs.gnu.org; Mon, 23 Mar 2020 15:28:20 -0400 Received: by mail-wm1-f65.google.com with SMTP id 26so799284wmk.1 for <40060-done@debbugs.gnu.org>; Mon, 23 Mar 2020 12:28:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=q3nSPYanauHJXktj5bM9EtxL57T68FEhI4u+eSqAcFk=; b=B7g02TyRLeevwYynw+RCRGk7zTnRT62Gxlt/2QOCCy/vw/9xE7dMK4ARdalpDR6XWo Maqs++mNO3Fwgp0xQ47Cd2LuvwILxAfC+m2fmkmmweV1UH3Z6WXtE3GOCiTOq8YewGgq bY+Y3cYlAJnhohLTC1HYUe1rBBRMczzHVUt08qRORuf8xONfJg+49BPUOoURTEuROHCy B27TvX+mVL0hVzZfRJ82d9qB16Gkd9Fi5kBTe0sXCKNx8uff2yTxtIytX16F0KIhHLlw QZ5lxs44S8O46+hINp3c4c3EABoodCxegmRU0ZBHcMhnoMQTvbu97lH9RQrecIP+ds46 xsfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=q3nSPYanauHJXktj5bM9EtxL57T68FEhI4u+eSqAcFk=; b=DIQyD9Rc367k8ozLlJatgwo+kgaGmeS0VexpqE5Q7ciujUlumN+p/EQqXkaSkwtc4R ygygy4tp1boQV7kPAMaa6vrgZc8xigApKhmEWm84jgqA+v8IZzacAmj4RPcVAGIA3N+n MxspR2VgFpOdt1wOEXSeldq7VNDEFLRqgxWTyPCd0ra0x6BjDXnNxKT2ZPM5ie3BRi06 1eBBecrbehi0RJpEdArN8rx1rcp1S2nq+tJxkPdOuD/cH+XY3PgKtlibe8j0VMMF5rls ukYMa4nuYI+ZIvvBbayfFv5YijqA5GrKHwuKUiL1qRfZYpYsN5gwsiYC/4p/JY1GpLhY waRA== X-Gm-Message-State: ANhLgQ0nlX/LIcoG3b4/Usf9CaaWm3BZULBBP43jZi9CPmMO/itnbjov a+lNuXkpc/vzu5NTEXZ/VJZv0Jdh X-Google-Smtp-Source: ADFU+vte6MDbGiGgw7cy1lmzYbDd7wcczLvJhkQHmyxxsUrOebrVbSQNxIV+r/4VCBL8lRnx4JsjoA== X-Received: by 2002:a1c:f00a:: with SMTP id a10mr1036144wmb.102.1584991693592; Mon, 23 Mar 2020 12:28:13 -0700 (PDT) Received: from cervin ([2a01:cb18:832e:5f00:a873:d253:d873:1441]) by smtp.gmail.com with ESMTPSA id u17sm26823239wra.63.2020.03.23.12.28.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2020 12:28:12 -0700 (PDT) References: <20200314143418.13963-1-brice@waegenei.re> <20200323171502.3147-1-brice@waegenei.re> User-agent: mu4e 1.2.0; emacs 26.3 From: Mathieu Othacehe To: guix-patches@gnu.org Subject: Re: [bug#40060] [PATCH v2 0/2] youtube-dl add ffmpeg and zsh-completion In-reply-to: <20200323171502.3147-1-brice@waegenei.re> Date: Mon, 23 Mar 2020 20:28:11 +0100 Message-ID: <874kuezx9w.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40060-done Cc: 40060-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Brice, > Remove pycryptodome since ffmpeg is enought for accessing > HLS streams. I could do not find any reference to pycryptodome, but pushed the serie as is LTGM. Thanks, Mathieu ------------=_1584991742-18199-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Mar 2020 14:34:33 +0000 Received: from localhost ([127.0.0.1]:33812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jD7s0-0001eA-Qn for submit@debbugs.gnu.org; Sat, 14 Mar 2020 10:34:33 -0400 Received: from lists.gnu.org ([209.51.188.17]:41926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jD7ry-0001e2-QG for submit@debbugs.gnu.org; Sat, 14 Mar 2020 10:34:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48692) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jD7rx-0005T9-Sx for guix-patches@gnu.org; Sat, 14 Mar 2020 10:34:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_05,RCVD_IN_DNSWL_LOW autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jD7rw-00027A-Ja for guix-patches@gnu.org; Sat, 14 Mar 2020 10:34:29 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:38073) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jD7rw-00025V-E5 for guix-patches@gnu.org; Sat, 14 Mar 2020 10:34:28 -0400 X-Originating-IP: 78.237.113.178 Received: from localhost (luy13-1-78-237-113-178.fbx.proxad.net [78.237.113.178]) (Authenticated sender: brice@waegenei.re) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 70BDAE0005 for ; Sat, 14 Mar 2020 14:34:23 +0000 (UTC) From: Brice Waegeneire To: guix-patches@gnu.org Subject: [PATCH 0/2] youtube-dl add ffmpeg, pycryptodome and zsh-completion Date: Sat, 14 Mar 2020 15:34:18 +0100 Message-Id: <20200314143418.13963-1-brice@waegenei.re> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 217.70.183.196 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Brice Waegeneire (2): gnu: youtube-dl: Use ffmpeg and pycryptodome gnu: youtube-dl: Add zsh completion gnu/packages/video.scm | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) -- 2.25.0 ------------=_1584991742-18199-1-- From unknown Sun Jun 15 08:59:29 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40060] [PATCH v2 0/2] youtube-dl add ffmpeg and zsh-completion Resent-From: Brice Waegeneire Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 23 Mar 2020 20:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40060 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 40060@debbugs.gnu.org, me@tobias.gr, leo@famulari.name Received: via spool by 40060-submit@debbugs.gnu.org id=B40060.158499501823774 (code B ref 40060); Mon, 23 Mar 2020 20:24:02 +0000 Received: (at 40060) by debbugs.gnu.org; 23 Mar 2020 20:23:38 +0000 Received: from localhost ([127.0.0.1]:53595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGTbm-0006BM-7w for submit@debbugs.gnu.org; Mon, 23 Mar 2020 16:23:38 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:54291) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGTbj-0006B8-Np for 40060@debbugs.gnu.org; Mon, 23 Mar 2020 16:23:36 -0400 Received: from webmail.gandi.net (webmail18.sd4.0x35.net [10.200.201.18]) (Authenticated sender: brice@waegenei.re) by relay3-d.mail.gandi.net (Postfix) with ESMTPA id 1B44160009; Mon, 23 Mar 2020 20:23:27 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 23 Mar 2020 20:23:27 +0000 From: Brice Waegeneire In-Reply-To: <874kuezx9w.fsf@gmail.com> References: <20200314143418.13963-1-brice@waegenei.re> <20200323171502.3147-1-brice@waegenei.re> <874kuezx9w.fsf@gmail.com> Message-ID: <1097e237aa50c0383d571c24f92702e7@waegenei.re> X-Sender: brice@waegenei.re User-Agent: Roundcube Webmail/1.3.8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2020-03-23 19:28, Mathieu Othacehe wrote: >> Remove pycryptodome since ffmpeg is enought for accessing >> HLS streams. > > I could do not find any reference to pycryptodome, but pushed the serie > as is LTGM. The first revision of this patch added pycryptodome as input, this version doesn't. BTW Tobias and Leo were against adding ffmpeg to youtube-dl. From unknown Sun Jun 15 08:59:29 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40060] [PATCH v2 0/2] youtube-dl add ffmpeg and zsh-completion Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 23 Mar 2020 20:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40060 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brice Waegeneire Cc: 40060@debbugs.gnu.org, me@tobias.gr, leo@famulari.name Received: via spool by 40060-submit@debbugs.gnu.org id=B40060.158499623325839 (code B ref 40060); Mon, 23 Mar 2020 20:44:02 +0000 Received: (at 40060) by debbugs.gnu.org; 23 Mar 2020 20:43:53 +0000 Received: from localhost ([127.0.0.1]:53613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGTvM-0006ig-Nd for submit@debbugs.gnu.org; Mon, 23 Mar 2020 16:43:52 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:40297) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGTvL-0006iQ-2l for 40060@debbugs.gnu.org; Mon, 23 Mar 2020 16:43:51 -0400 Received: by mail-wr1-f66.google.com with SMTP id f3so18834695wrw.7 for <40060@debbugs.gnu.org>; Mon, 23 Mar 2020 13:43:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=PrNB8HfglNiGIaCZjK/Ir/iCq59/Db4oRA4ScG/kZYU=; b=co6Jy5TjABrU1cVN5GZMeMgDI8ivU1RKE38YrbG0hfmuMvLCS7BwRHcr9p8o1UZavX zNZ8rvyIIZ7ObjlO8+zOvTaFCDje0WAsDyfruW4UkTQzd4C2YkfVXl92CR53L9AcCYG8 X/CFKrmJ7pbj/3OgBaZ2dSAS9kBvbL0jQGFzHib8mwpYQXX7EGmrtg8hWGpULmuO7cNd L5TnHDNJ8MfPf2hfoRL6TrprhujzwrGYI4TWrmQFpTXO+wGcHZdhwFuBnDKBYpRHf6ku r/nQUwPWBZxHK0PxOsDdL1J4M4FdrCkt2ghVfoozWgLKUfu5wq+kJ617cF47Y2aJ7TiT 0bAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=PrNB8HfglNiGIaCZjK/Ir/iCq59/Db4oRA4ScG/kZYU=; b=Plwj6s/cm83rkaDb3ljJqdu4ntMFD0/86g29XHy3pnrpNCbvMzwQEvfZSFg5kyEuqL V6tvLypBeCZ2HkcIVhbLk/vgtENifx5Yhx9BgLPhs4mcHoJnJDZgqm3rgk5KczV2QPgP DLEV3TG4SLDvU2Mv2EY8lu8JMp6j4t/d0t7ayMyMYlRU+AC1iYzSDqTaQI58BmtRwtSu IPGPGciELEHXSupecp8e+2JVCHnTi6QEPoJhV+a3iNTKTN3NTOISa3wrVZbGBdTrtc9X qwq1FixJMU9GQDRb3dICNQXasulslyugCa+5mNhYveXqUkny/CoO/X7k0H4kZN5IbaKX f48Q== X-Gm-Message-State: ANhLgQ3qKc0z1DohP9/k6Klwu11zIRC7UbXfRm2fWQi13y0GQlQGN8L2 y+5TiqowHEP1pETrZ0OKzvo= X-Google-Smtp-Source: ADFU+vsOONFuABgJNSLzopLzPe+gtX0+YlCKUxdQVZjcPxb0DD41hqtV8HZgVWvKsa2rTdEfUQAl1Q== X-Received: by 2002:a5d:4c87:: with SMTP id z7mr34219081wrs.39.1584996225007; Mon, 23 Mar 2020 13:43:45 -0700 (PDT) Received: from cervin ([2a01:cb18:832e:5f00:a873:d253:d873:1441]) by smtp.gmail.com with ESMTPSA id q4sm1644672wmj.1.2020.03.23.13.43.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2020 13:43:44 -0700 (PDT) References: <20200314143418.13963-1-brice@waegenei.re> <20200323171502.3147-1-brice@waegenei.re> <874kuezx9w.fsf@gmail.com> <1097e237aa50c0383d571c24f92702e7@waegenei.re> User-agent: mu4e 1.2.0; emacs 26.3 From: Mathieu Othacehe In-reply-to: <1097e237aa50c0383d571c24f92702e7@waegenei.re> Date: Mon, 23 Mar 2020 21:43:43 +0100 Message-ID: <87lfnqssxs.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > The first revision of this patch added pycryptodome as input, this version > doesn't. BTW Tobias and Leo were against adding ffmpeg to youtube-dl. Oops didn't see the small "v2". Well I'll revert this one until this is clarified. Sorry about that, Mathieu From unknown Sun Jun 15 08:59:29 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40060] [PATCH v3] gnu: youtube-dl: Add 'ffmpeg' as input. Resent-From: Brice Waegeneire Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 01 Apr 2020 13:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40060 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 40060@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.158574612430326 (code B ref -1); Wed, 01 Apr 2020 13:03:01 +0000 Received: (at submit) by debbugs.gnu.org; 1 Apr 2020 13:02:04 +0000 Received: from localhost ([127.0.0.1]:37563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJd0O-0007t3-60 for submit@debbugs.gnu.org; Wed, 01 Apr 2020 09:02:04 -0400 Received: from lists.gnu.org ([209.51.188.17]:45398) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJd0M-0007sh-5R for submit@debbugs.gnu.org; Wed, 01 Apr 2020 09:02:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33212) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJd0K-00005b-Ve for guix-patches@gnu.org; Wed, 01 Apr 2020 09:02:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_40,RCVD_IN_DNSWL_LOW autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJd0J-00032J-H1 for guix-patches@gnu.org; Wed, 01 Apr 2020 09:02:00 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:38373) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jJd0J-00031W-AE for guix-patches@gnu.org; Wed, 01 Apr 2020 09:01:59 -0400 X-Originating-IP: 78.237.113.178 Received: from localhost (luy13-1-78-237-113-178.fbx.proxad.net [78.237.113.178]) (Authenticated sender: brice@waegenei.re) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 8E8C240010 for ; Wed, 1 Apr 2020 13:01:56 +0000 (UTC) From: Brice Waegeneire Date: Wed, 1 Apr 2020 15:01:52 +0200 Message-Id: <20200401130152.1871-1-brice@waegenei.re> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200314143418.13963-1-brice@waegenei.re> References: <20200314143418.13963-1-brice@waegenei.re> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 217.70.183.194 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/video.scm (youtube-dl)[arguments]: Add phase wrap-executable. [inputs]: Add ffmpeg. --- This version is rebased on top of master and the commit adding zsh completion has been removed from the patch set since it has already been merged. gnu/packages/video.scm | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 03796fd770..6ad46fb9fe 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -1680,7 +1680,17 @@ To load this plugin, specify the following option when starting mpv: (mkdir-p zsh) (copy-file "youtube-dl.zsh" (string-append zsh "/_youtube-dl")) - #t)))))) + #t))) + (add-after 'install 'wrap-executable + (lambda* (#:key inputs outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out")) + (ffmpeg (assoc-ref inputs "ffmpeg"))) + (wrap-program (string-append out "/bin/youtube-dl") + `("PATH" ":" prefix + ,(list (string-append ffmpeg "/bin"))))) + #t))))) + (inputs + `(("ffmpeg" ,ffmpeg))) (synopsis "Download videos from YouTube.com and other sites") (description "Youtube-dl is a small command-line program to download videos from -- 2.25.1 From unknown Sun Jun 15 08:59:29 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40060] [PATCH v3] gnu: youtube-dl: Add 'ffmpeg' as input. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 01 Apr 2020 13:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40060 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 40060@debbugs.gnu.org Received: via spool by 40060-submit@debbugs.gnu.org id=B40060.15857484436132 (code B ref 40060); Wed, 01 Apr 2020 13:41:01 +0000 Received: (at 40060) by debbugs.gnu.org; 1 Apr 2020 13:40:43 +0000 Received: from localhost ([127.0.0.1]:37616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJdbn-0001ao-2k for submit@debbugs.gnu.org; Wed, 01 Apr 2020 09:40:43 -0400 Received: from tobias.gr ([80.241.217.52]:55446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJdbk-0001aZ-Dt for 40060@debbugs.gnu.org; Wed, 01 Apr 2020 09:40:41 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id 0da3dc6c for <40060@debbugs.gnu.org>; Wed, 1 Apr 2020 13:40:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to :subject:references:in-reply-to:date:message-id:mime-version :content-type; s=2018; i=me@tobias.gr; bh=Q0F4okg2AUe09jyuXJ9A0j 71QMr82VVyUZ4RKayHM+Q=; b=YD2pdJon58qF6EVdZU92Rpy175beMUcIS0gvom 5QIKdQTCsjp3sW2Ktxr9Ja7Ebe9sLscB7YD0Ouwi/3VjtJhpqpzhf9bXEM8HFCr5 40rk8WaI032CEdrVhwAJTALvkJaDEODu6yBHdVg/LMxckCtF1BnORn0jdaP21lzx i+5gx2mUOEwvr+CmqcCw/9rRawIly7pG8WIZJiS1d2WNMOst/q6C/oOiUN0qr/P7 1U5ythMUqXwdImznBtNaF1jeEt0942O/B7YnHikO//4JwsTlR9EL/ej3H/DfiYq7 jqPpG+Hi6Ix0WuVS3pMvqhNx2xW4zfW9GfgFB00QewwLJKFw== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id c3303097 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO) for <40060@debbugs.gnu.org>; Wed, 1 Apr 2020 13:40:38 +0000 (UTC) From: Tobias Geerinckx-Rice References: <20200314143418.13963-1-brice@waegenei.re> <20200401130152.1871-1-brice@waegenei.re> In-reply-to: <20200401130152.1871-1-brice@waegenei.re> Date: Wed, 01 Apr 2020 15:40:37 +0200 Message-ID: <875zejjpd6.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Brice, Sorry for the delay! However, I don't really know what more to=20 say. I'm still against pulling in ffmpeg for everyone, for the reason=20 given in my last[0] mail. Keep in mind: $ guix size youtube-dl | tail -n1 total: 184.0 MiB $ guix size youtube-dl ffmpeg | tail -n1 total: 804.7 MiB If youtube-dl silently failed or produced worse video without=20 ffmpeg, things'd clearly be different. Same if it disabled=20 features at build time if ffmpeg is not found. I don't think it=20 does=E2=80=A6 One could argue that those who really don't need or want ffmpeg=20 can simply customise their youtube-dl package because Guix is=20 awesome. Both true! But it's the asymmetry between opt-in $ guix install youtube-dl $ youtube-dl https://hotvidz.gnu/10h-of-rms-dancing.oggv Note: you'll want to install ffmpeg to see more glorious detail $ guix install ffmpeg =E2=80=A6 and opt-out, where the user has to learn about=20 substitute-keyword-arguments & write a custom package just to=20 avoid pulling in ffmpeg, that bugs me. That's just me. If you convince enough people to merge this I=20 certainly won't mind! Kind regards, T G-R [0]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D40060#23 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfo+u0AlEeO9y5k0W2Imw8BjFSTwFAl6EmdUACgkQ2Imw8BjF STwYcQ/+KFcbYp5qJowA2PgRWPHYKERKtThYEE+dsbKQfnq9HsUsTBM9XncxFvNY cUQTwn+Ab6J9+SLprO+FB32/4z8IsSS/+rEH9Pyd1XgGGDL3//TReiWWVuOlwSq8 SzmJDqGRlxi4DWq5HzRD6t8P1GU/9cTMRfIEeWfO0GBIIbAOtpfqEqgo9jM5B/p4 T98qOYiDKCUZlovbAD/gFhgoWpscQWX8abY9G7Bx+Wb/5XXagurAwOVWS9ru9Vt8 205/T9na7owdmvVdedIbwszqSYhVoTMD7/gwmmM/hJcFXowc37dT/oj0U+amaRti PEol5oK0laPguXccdB/nsVtfXaxhNCnTtLS/O5qp79vzW6CJTTDmtJ9KixmJw7d3 ISNtqI7FE3fCoTjZ+8B/HJIjUL6i8sMIA5XyGD/JDwxWZs2g1/EqONjv5816OWWn 1NhBOAMTjMAdCZPG1S2OgAiTApdcBN/OsbvYoUSxXesorcEl/AKnqfibPpHY/G5l MjLJlm5W2iduxPnhlqZslPObAvjHq7+dfPV4ttCcfE5tT3EemJbd5MutoBiedTyQ MPzmpR8mdTx/hS5Nwhd6HP/wE/whtQJvAroWsY5gSczzVmhe5lLI9WrW5nGknLnd SxoWH/UX+xV1prQRVuUXOztkh1iR+75PPimAI8EfE61fPjmsJ4I= =O9NA -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 01 10:05:50 2020 Received: (at control) by debbugs.gnu.org; 1 Apr 2020 14:05:50 +0000 Received: from localhost ([127.0.0.1]:38515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJe06-0003Dj-8k for submit@debbugs.gnu.org; Wed, 01 Apr 2020 10:05:50 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:44637) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJe04-0003DU-JJ for control@debbugs.gnu.org; Wed, 01 Apr 2020 10:05:49 -0400 Received: from webmail.gandi.net (webmail18.sd4.0x35.net [10.200.201.18]) (Authenticated sender: brice@waegenei.re) by relay11.mail.gandi.net (Postfix) with ESMTPA id E65D910000C for ; Wed, 1 Apr 2020 14:05:40 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 01 Apr 2020 14:05:40 +0000 From: Brice Waegeneire To: control@debbugs.gnu.org Subject: close 40060 Message-ID: X-Sender: brice@waegenei.re User-Agent: Roundcube Webmail/1.3.8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) # Increasing the size of the package that much is not worth it. close 40060 quit