GNU bug report logs - #40040
Submission of Patch for Package Description for CRAN Package r-crochet

Previous Next

Full log

Message #16 received at 40040 <at> debbugs.gnu.org (full text, mbox):

From: Naga Malleswari <nagamalli <at> riseup.net>
To: 40040 <at> debbugs.gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: Re: Resubmission of patch for Package Description for CRAN Package
 r-crochet
Date: Thu, 19 Mar 2020 13:43:30 +0530

[Message part 1 (text/plain, inline)]

Hi

Resubmitting v3 of my patch. I really hope i did the changes right.

I am going through documentation and learning the things. For seeking 
clarification, Is there any other way i can communicate with you or the 
community. I have joined IRC channel as well #guix on freenode.

On 17/03/20 3:20 pm, Danny Milosavljevic wrote:
> Hi,
>
> there's a whitespace error at the bottom of the patch.  When I try to apply it
> using "git am" I immediately get a warning message.
>
> Also, the subject you used "gnu: r-crochet: New variable" would mean that
> you add a new variable inside r-chochet, which you don't.
>
> It should be: "gnu: Add r-crochet".
>
> and
>
> "* gnu/packages/cran.scm (r-crochet): New variable.".
>
> Please examine some other commit messages in guix master for a template.

I have done the changes and understood.

> I've invoked guix lint and I get:
>
> gnu/packages/cran.scm:20813:6: r-crochet <at> 2.2.0: use @code or similar ornament instead of quotes
> /home/dannym/src/guix-r/guix/gnu/packages/cran.scm:20814:0: r-crochet <at> 2.2.0: trailing white space on line 20814
> /home/dannym/src/guix-r/guix/gnu/packages/cran.scm:20815:0: r-crochet <at> 2.2.0: trailing white space on line 20815

I am a beginner at this stuff. I am understanding the standards. I have 
invoked lint and found no errors.


> Could you fix these problems and submit a new version (v3) of the patch
> (using git send-email --to=40040 <at> debbugs.gnu.org , for example)?

-- 
Regards
NagaMalli

[0001-gnu-Add-r-crochet.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.